[{"id":26787,"web_url":"https://patchwork.libcamera.org/comment/26787/","msgid":"<168002148691.765114.12881447051864470627@Monstersaurus>","date":"2023-03-28T16:38:06","subject":"Re: [libcamera-devel] [PATCH] doc: ipa: Clarify IPA acronym","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Gabby,\n\nWelcome to libcamera, and thank you for contributing.\n\nQuoting Gabby George via libcamera-devel (2023-03-28 16:36:14)\n> I suggest clarifying the IPA acronym as it is not defined in a easily-accessible place and not immediately clear what it refers to. This patch is a practice patch for the google summer of code warmup.\n\nThe $SUBJECT line is fine, but this commit message could use some extra\nconsideration.\n\nWhen writing a commit message, it should strive to explain the\nrationale behind the change.\n\nPlease read: https://cbea.ms/git-commit/\n\nI find it to be a very good description of how I would expect to see\ncommit messages.\n\nThis message will be embedded into the history of the libcamera project,\nand so comments such as \"This patch is a practice patch for GSOC\" isn't\nreally appropriate to go here. Please keep it factual and to the point\nof the content of the patch.\n\n\nAt this point in the patch, we require a 'Signed-off-by:' tag. When you\nmake a commit, please use the '-s' flag to add this with git.\n\n\n> ---\n\nPlease also notice these three '---' separator markers. Anything\nafter these markers, but before the diff are ignored when applying\npatches. That gives you a space to add free form comments, which is\nwhere a message such as \"I'm practicing for GSoC\" could be added.\n\n\n\n\n> src/ipa/libipa/module.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/ipa/libipa/module.cpp b/src/ipa/libipa/module.cpp\n> index 77352104..ee01f12a 100644\n> --- a/src/ipa/libipa/module.cpp\n> +++ b/src/ipa/libipa/module.cpp\n> @@ -17,7 +17,7 @@ namespace libcamera {\n> LOG_DEFINE_CATEGORY(IPAModuleAlgo)\n> \n> /**\n> - * \\brief The IPA namespace\n> + * \\brief The IPA (Image Processing Algorithm) namespace\n\nThis change itself is fine. I hope we've defined this as a more global\nglossary somewhere though, but I wouldn't object to merging this (with a\ncorrectly formed commit message)\n\nPlease submit a v2 - Remember to mark the patch as v2 accordingly before\nsubmitting, and try to phrase the commit message in a form that would be\nmore appropriate.\n\nLook through the commit history of the project for a good idea of the\nlevel of content we expect in commit messages.\n\nRegards\n--\nKieran\n\n\n> *\n> * The IPA namespace groups all types specific to IPA modules. It serves as the\n> * top-level namespace for the IPA library libipa, and also contains\n> -- \n> 2.34.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5CB6FBD160\n\tfor ;\n\tTue, 28 Mar 2023 16:38:12 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7CEAE62740;\n\tTue, 28 Mar 2023 18:38:11 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 12FB961ECD\n\tfor ;\n\tTue, 28 Mar 2023 18:38:10 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 83411DEE;\n\tTue, 28 Mar 2023 18:38:09 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1680021491;\n\tbh=vwG4OrQo418A+7fTiYwmWn/bPZ9Qk7lSxsADkUmJhKk=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=OhZxYiVnIBzCQBuEmW/yqb1wi51n0/MSwhAaax75xG0Nwkbi84EMd6u9Wx1yeEnsy\n\tzcJw5cVdQwt24gl99/O7RnlkzIY49KHcA3YY1zlMVP+DiC8+oID8nyHJOdgkbk4mHh\n\t6hAOYhXZsh1+dzgHxsykG7KUZAdmEllMiG0KscP/6m1iZhx+TKVYOPycFxJeU5P8WM\n\ti+5HvamlX22vUNH3pgpl/fxMWOZcQ23IMb4eeCk3UxzvjANPdUHE5sswlDrBid3Z5A\n\t5++CCCwYysBD1xoskGKAdp9KqpUXrI4cUrV2ex21oKT/3yM8Rf1SThffahDyLzSpaX\n\tZcsp8Z0ridPuw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1680021489;\n\tbh=vwG4OrQo418A+7fTiYwmWn/bPZ9Qk7lSxsADkUmJhKk=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=mztgiP2pE0+3uX0905TmZkkTsmD5iCjN6Zu0+jkf2j7ZOoG67ZocWJYkZoJRQtgUF\n\tPbHo2Rh0p3FqLRbpGJZjY6rkA+xIofnh6nRuri1CUUZoNfzWzugrxZYOURaFS3X6BD\n\tmNdefIw8j/QH9/FClfF0iC3GAe/iUfgMi71nDbrQ="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"mztgiP2p\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20230328153614.38027-1-gabbymg94@gmail.com>","References":"<20230328153614.38027-1-gabbymg94@gmail.com>","To":"Gabby George , libcamera-devel@lists.libcamera.org","Date":"Tue, 28 Mar 2023 17:38:06 +0100","Message-ID":"<168002148691.765114.12881447051864470627@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH] doc: ipa: Clarify IPA acronym","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]