[{"id":26784,"web_url":"https://patchwork.libcamera.org/comment/26784/","msgid":"<168000484336.765114.17799963276285856657@Monstersaurus>","date":"2023-03-28T12:00:43","subject":"Re: [libcamera-devel] [GIT PULL] Raspberry Pi: Senor limits","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Naushir Patuck (2023-03-28 12:52:39)\n> The following changes since commit d942bdc913c5a7f0895bfcb0180db3f279be246e:\n> \n> libcamera: v4l2_device: openat(2) with O_CLOEXEC to cleanup after\n> exec(3) (2023-03-26 11:48:18 +0300)\n> \n> are available in the Git repository at:\n> \n> https://github.com/naushir/libcamera.git\n> \n> for you to fetch changes up to 798a05610c07ba071b51acdedf35294709a9c23e:\n\nHi Naush,\n\nFAILED: src/ipa/raspberrypi/ipa_rpi.so.p/controller_rpi_agc.cpp.o \ng++-9 -Isrc/ipa/raspberrypi/ipa_rpi.so.p -Isrc/ipa/raspberrypi -I../../../src/libcamera/src/ipa/raspberrypi -Iinclude -I../../../src/libcamera/include -Isrc/ipa -I../../../src/libcamera/src/ipa -I../../../src/libcamera/src/ipa/raspberrypi/controller -Iinclude/libcamera/ipa -Iinclude/libcamera -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -Wextra -Werror -std=c++17 -g -Wshadow -include /home/kbingham/iob/libcamera/ci/integrator/builds/build-matrix/gcc-9/config.h -fPIC -DLIBCAMERA_BASE_PRIVATE -MD -MQ src/ipa/raspberrypi/ipa_rpi.so.p/controller_rpi_agc.cpp.o -MF src/ipa/raspberrypi/ipa_rpi.so.p/controller_rpi_agc.cpp.o.d -o src/ipa/raspberrypi/ipa_rpi.so.p/controller_rpi_agc.cpp.o -c ../../../src/libcamera/src/ipa/raspberrypi/controller/rpi/agc.cpp\n../../../src/libcamera/src/ipa/raspberrypi/controller/rpi/agc.cpp: In constructor ‘RPiController::Agc::Agc(RPiController::Controller*)’:\n../../../src/libcamera/src/ipa/raspberrypi/controller/rpi/agc.cpp:226:29: error: class ‘RPiController::Agc’ does not have any field named ‘lastSensitivity_’\n 226 | lastTargetExposure_(0s), lastSensitivity_(0.0),\n | ^~~~~~~~~~~~~~~~\n\nSorry - not a complete fix.\n\n--\nKieran\n\n\n> \n> ipa: raspberrypi: Fix default frame durations calculation\n> (2023-03-28 12:47:45 +0100)\n> \n> ----------------------------------------------------------------\n> Naushir Patuck (4):\n> ipa: raspberrypi: Add sensor mode limits to CameraMode\n> ipa: raspberrypi: Use the new sensor limits fields in CameraMode\n> ipa: raspberrypi: Ensure shutter speed and gain are clipped in the AGC\n> ipa: raspberrypi: Fix default frame durations calculation\n> \n> src/ipa/raspberrypi/controller/camera_mode.h | 10 +++++++++-\n> src/ipa/raspberrypi/controller/rpi/agc.cpp | 58\n> ++++++++++++++++++++++++++++++++++++++++++++--------------\n> src/ipa/raspberrypi/controller/rpi/agc.h | 5 +++--\n> src/ipa/raspberrypi/raspberrypi.cpp | 57\n> +++++++++++++++++++++++++++++----------------------------\n> 4 files changed, 85 insertions(+), 45 deletions(-)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4D1EDC0F2A\n\tfor ;\n\tTue, 28 Mar 2023 12:00:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9EF1762740;\n\tTue, 28 Mar 2023 14:00:48 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9ECD66273D\n\tfor ;\n\tTue, 28 Mar 2023 14:00:46 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 152E4AD5;\n\tTue, 28 Mar 2023 14:00:46 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1680004848;\n\tbh=z2j4fLvsCb9Q7x1BBiGF7sZn7izR+pPiPLQqYYFutRk=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=GKQmoE1qHcYYSNSn/3uhZCRRr/nrt6kYkUU1dWFkNSl33weptUKKx+nDjDDiixsWN\n\tx/fyUYZEreBtcADLF7QxO4RLaKFrHUTa1dfA90GnDSBjwWJjcel81bfJBpu9Qip/vx\n\tPFEEbOhpPDKD+VdRfFQE8DYy5AbKdra6KqYFpw3/zEaT8hhX2+GohVBQ/iX1wdpHI5\n\thEHj/k84Oi4oehdr1QCYgX7DgpLcVv7kc4KLymu0N2Fy8J+LEdnYcH+C99NN0+R1o2\n\tDNXazsL3AAzFghJX9NrQ/k39lihiqNvBpKe4/22SbFKuIgMbN2CHxMD0bfVVI7ZYEU\n\trCllIm4yKau8A==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1680004846;\n\tbh=z2j4fLvsCb9Q7x1BBiGF7sZn7izR+pPiPLQqYYFutRk=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=h7+JqRB4pHbaS/uFbM4bqfBORv68f74vN7dfM/PA1Ep7+5qjAsXW2vM4y6YKt0Clu\n\tFkDDNgPCo7F+9qH64lWXM6c9JRFXFhbnIX2Q9fPQhIqJR1A//Eps/ecCO7CzcDZN3g\n\t4kC+5CfHwsejAJVQky4emqHoxbT5A/apB+I8Ls9A="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"h7+JqRB4\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"","References":"","To":"Jacopo Mondi ,\n\tNaushir Patuck ,\n\tlibcamera devel ","Date":"Tue, 28 Mar 2023 13:00:43 +0100","Message-ID":"<168000484336.765114.17799963276285856657@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [GIT PULL] Raspberry Pi: Senor limits","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":26785,"web_url":"https://patchwork.libcamera.org/comment/26785/","msgid":"","date":"2023-03-28T12:01:57","subject":"Re: [libcamera-devel] [GIT PULL] Raspberry Pi: Senor limits","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"On Tue, 28 Mar 2023 at 13:00, Kieran Bingham\n wrote:\n>\n> Quoting Naushir Patuck (2023-03-28 12:52:39)\n> > The following changes since commit d942bdc913c5a7f0895bfcb0180db3f279be246e:\n> >\n> > libcamera: v4l2_device: openat(2) with O_CLOEXEC to cleanup after\n> > exec(3) (2023-03-26 11:48:18 +0300)\n> >\n> > are available in the Git repository at:\n> >\n> > https://github.com/naushir/libcamera.git\n> >\n> > for you to fetch changes up to 798a05610c07ba071b51acdedf35294709a9c23e:\n>\n> Hi Naush,\n>\n> FAILED: src/ipa/raspberrypi/ipa_rpi.so.p/controller_rpi_agc.cpp.o\n> g++-9 -Isrc/ipa/raspberrypi/ipa_rpi.so.p -Isrc/ipa/raspberrypi -I../../../src/libcamera/src/ipa/raspberrypi -Iinclude -I../../../src/libcamera/include -Isrc/ipa -I../../../src/libcamera/src/ipa -I../../../src/libcamera/src/ipa/raspberrypi/controller -Iinclude/libcamera/ipa -Iinclude/libcamera -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -Wextra -Werror -std=c++17 -g -Wshadow -include /home/kbingham/iob/libcamera/ci/integrator/builds/build-matrix/gcc-9/config.h -fPIC -DLIBCAMERA_BASE_PRIVATE -MD -MQ src/ipa/raspberrypi/ipa_rpi.so.p/controller_rpi_agc.cpp.o -MF src/ipa/raspberrypi/ipa_rpi.so.p/controller_rpi_agc.cpp.o.d -o src/ipa/raspberrypi/ipa_rpi.so.p/controller_rpi_agc.cpp.o -c ../../../src/libcamera/src/ipa/raspberrypi/controller/rpi/agc.cpp\n> ../../../src/libcamera/src/ipa/raspberrypi/controller/rpi/agc.cpp: In constructor ‘RPiController::Agc::Agc(RPiController::Controller*)’:\n> ../../../src/libcamera/src/ipa/raspberrypi/controller/rpi/agc.cpp:226:29: error: class ‘RPiController::Agc’ does not have any field named ‘lastSensitivity_’\n> 226 | lastTargetExposure_(0s), lastSensitivity_(0.0),\n> | ^~~~~~~~~~~~~~~~\n>\n> Sorry - not a complete fix.\n\nAnd again... :(\n\n>\n> --\n> Kieran\n>\n>\n> >\n> > ipa: raspberrypi: Fix default frame durations calculation\n> > (2023-03-28 12:47:45 +0100)\n> >\n> > ----------------------------------------------------------------\n> > Naushir Patuck (4):\n> > ipa: raspberrypi: Add sensor mode limits to CameraMode\n> > ipa: raspberrypi: Use the new sensor limits fields in CameraMode\n> > ipa: raspberrypi: Ensure shutter speed and gain are clipped in the AGC\n> > ipa: raspberrypi: Fix default frame durations calculation\n> >\n> > src/ipa/raspberrypi/controller/camera_mode.h | 10 +++++++++-\n> > src/ipa/raspberrypi/controller/rpi/agc.cpp | 58\n> > ++++++++++++++++++++++++++++++++++++++++++++--------------\n> > src/ipa/raspberrypi/controller/rpi/agc.h | 5 +++--\n> > src/ipa/raspberrypi/raspberrypi.cpp | 57\n> > +++++++++++++++++++++++++++++----------------------------\n> > 4 files changed, 85 insertions(+), 45 deletions(-)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6EEC8BD160\n\tfor ;\n\tTue, 28 Mar 2023 12:02:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3205962749;\n\tTue, 28 Mar 2023 14:02:05 +0200 (CEST)","from mail-yw1-x1134.google.com (mail-yw1-x1134.google.com\n\t[IPv6:2607:f8b0:4864:20::1134])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EB0056273D\n\tfor ;\n\tTue, 28 Mar 2023 14:02:03 +0200 (CEST)","by mail-yw1-x1134.google.com with SMTP id\n\t00721157ae682-544f7c176easo224618137b3.9\n\tfor ;\n\tTue, 28 Mar 2023 05:02:03 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1680004925;\n\tbh=MPglGmsoBFs/eSYU0e0/eu3UNeFv/ZBdcmMR66d7N18=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=gDYb8ryFEChVJN1cuo00D8WxUyaE/3Fec4buacCmJArSz0dMYw13+3DZjW7aFNzG1\n\tgbKlwoEENegkJg+sIFR+hBpBmYUuI4bU6lrBN99SE2qvvqEZO6di7KPOnD+9tvcLO9\n\tNLdke5SzMQWjhaD3XAq9YDuxs4/ZNkpTYBK2XirXSsHO5HVX325+jOLmygLEh8icTf\n\tMYA+dsplwDcWA9EnEefUn3+r1Z5y5yO40kArCsXlsIXlSIODsL/jcJwE/Mj+H97d/X\n\tnM5muH9nDqBMEVFH3t2fWIEKkC+3G6zmQi8jqXr6ZSKsXQZzsiHBkV6cjjB72jQBtw\n\tKVu50RJpW1Zwg==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1680004923;\n\th=content-transfer-encoding:cc:to:subject:message-id:date:from\n\t:in-reply-to:references:mime-version:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=7a19zQw1r6k9u4q5rc02shM/bRDRWOX6T04KY6BuuIo=;\n\tb=kJf8opGC8IaeEgptxJE9XH6A157Gg+bFwGQA72MO72Z13gwu1oReAm/msTOp2xrYWz\n\t3ji+EbVkUdpBncxbZ6qRWdeA2j7ipWF3DuUeci724VtJNoFyJ0SGuF/cM9KgqjkoYQGh\n\tBIKsZsM9Wk+dNt7K4w/zAayhYmsIKW6Tgv3jfi2yfUEG8jKJ3hYBN0S1eyzawWusk/GF\n\tDIyLC8pprJEggA8A7L7ojwgV3GG3G/p5/w6WYbG6YeG8wf7TCEYb1QGD/3tw04Jd/rxD\n\tZAuW1bgCpXW7o/K8n2WFKRdvgOF+Y5IG3hDk1AUSf5Atx4CYRVLKP3JbykhzaLm2Y01P\n\t0mQQ=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"kJf8opGC\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112; t=1680004923;\n\th=content-transfer-encoding:cc:to:subject:message-id:date:from\n\t:in-reply-to:references:mime-version:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=7a19zQw1r6k9u4q5rc02shM/bRDRWOX6T04KY6BuuIo=;\n\tb=yNZ92mR+pLKPKCXWbd4EPVsF8ak0eiKlhknAIZDA5BqVTwBQSGQoRiFApWozBem+b3\n\tWMFl5bnvIm0Jd13J1GfLx+kItP/RwfQI51uLo7yyRwujO0z3Ff17JiAStX8wNerqJ6m0\n\t46GUogY6iXul4P1HXRk4UMs0blXx8y6kvmbC8PrXqDrNga6mvelSiDQ/yoVWIRIWcv+q\n\tP4UvwrVM8Bc+i7ilwV0pe5GgJjBjVKpqZA9G8Po5MddfcgT+Wxah3dAXrvtiicFJzdC7\n\tD6jPWqoSsiQ8pCO5CvMipF5HKyFafCI0KJnaecjAktabKz72mhifLvGsGyvt5f/zAe/5\n\tyLEg==","X-Gm-Message-State":"AAQBX9cbRFwTbQOAVQ/wmg8DYWA8EInC+BaX4QF74MsAxCjsAy8FOuMY\n\t7MkSCwPCJTEOAIw2NGdTYs91tDV6MgqWrXQo1DyM7eZ3XZiP1RUNXm8=","X-Google-Smtp-Source":"AKy350bzN3GxH/LWLujZ2uPIaqCrQL+UMlMwkJ8hbaenHEYbDWvCRL0sQyIgnhQ6DzaUjyobMMjjSXLIF9++9nWJ6nk=","X-Received":"by 2002:a81:ac64:0:b0:544:b9b2:5c32 with SMTP id\n\tz36-20020a81ac64000000b00544b9b25c32mr6924764ywj.7.1680004922715;\n\tTue, 28 Mar 2023 05:02:02 -0700 (PDT)","MIME-Version":"1.0","References":"\n\t<168000484336.765114.17799963276285856657@Monstersaurus>","In-Reply-To":"<168000484336.765114.17799963276285856657@Monstersaurus>","Date":"Tue, 28 Mar 2023 13:01:57 +0100","Message-ID":"","To":"Kieran Bingham ","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","Subject":"Re: [libcamera-devel] [GIT PULL] Raspberry Pi: Senor limits","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Naushir Patuck via libcamera-devel\n\t","Reply-To":"Naushir Patuck ","Cc":"Jacopo Mondi ,\n\tlibcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]