[{"id":26782,"web_url":"https://patchwork.libcamera.org/comment/26782/","msgid":"<168000302826.765114.12427848835678114818@Monstersaurus>","date":"2023-03-28T11:30:28","subject":"Re: [libcamera-devel] [GIT PULL] Raspberry Pi: Senor limits","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Naush,\n\nQuoting Naushir Patuck (2023-03-28 08:41:45)\n> The following changes since commit d942bdc913c5a7f0895bfcb0180db3f279be246e:\n> \n>   libcamera: v4l2_device: openat(2) with O_CLOEXEC to cleanup after\n> exec(3) (2023-03-26 11:48:18 +0300)\n> \n> are available in the Git repository at:\n> \n>   https://github.com/naushir/libcamera.git\n> \n> for you to fetch changes up to 4ec84728accfdf4df2250cec153e0aa396758b12:\n\nI hit the following error in the build-matrix I'm afraid:\n\n[8/49] Compiling C++ object src/ipa/raspberrypi/ipa_rpi.so.p/controller_rpi_agc.cpp.o\nFAILED: src/ipa/raspberrypi/ipa_rpi.so.p/controller_rpi_agc.cpp.o\nclang++-11 -Isrc/ipa/raspberrypi/ipa_rpi.so.p -Isrc/ipa/raspberrypi -I../../../src/libcamera/src/ipa/raspberrypi -Iinclude -I../../../src/libcamera/include -Isrc/ipa -I../../../src/libcamera/src/ipa -I../../../src/libcamera/src/ipa/raspberrypi/controller -Iinclude/libcamera/ipa -Iinclude/libcamera -fcolor-diagnostics -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -Wextra -Werror -std=c++17 -O0 -g -Wextra-semi -Wthread-safety -Wshadow -include /home/kbingham/iob/libcamera/ci/integrator/builds/build-matrix/clang-11/config.h -Wno-c99-designator -fPIC -DLIBCAMERA_BASE_PRIVATE -MD -MQ src/ipa/raspberrypi/ipa_rpi.so.p/controller_rpi_agc.cpp.o -MF src/ipa/raspberrypi/ipa_rpi.so.p/controller_rpi_agc.cpp.o.d -o src/ipa/raspberrypi/ipa_rpi.so.p/controller_rpi_agc.cpp.o -c ../../../src/libcamera/src/ipa/raspberrypi/controller/rpi/agc.cpp\nIn file included from ../../../src/libcamera/src/ipa/raspberrypi/controller/rpi/agc.cpp:20:\n../../../src/libcamera/src/ipa/raspberrypi/controller/rpi/agc.h:129:9: error: private field 'lastSensitivity_' is not used [-Werror,-Wunused-private-field]\n        double lastSensitivity_; /* sensitivity of the previous camera mode */\n               ^\n1 error generated.\n\n\n> \n>   ipa: raspberrypi: Fix default frame durations calculation\n> (2023-03-28 08:38:05 +0100)\n> \n> ----------------------------------------------------------------\n> Naushir Patuck (4):\n>       ipa: raspberrypi: Add sensor mode limits to CameraMode\n>       ipa: raspberrypi: Use the new sensor limits fields in CameraMode\n>       ipa: raspberrypi: Ensure shutter speed and gain are clipped in the AGC\n>       ipa: raspberrypi: Fix default frame durations calculation\n> \n>  src/ipa/raspberrypi/controller/camera_mode.h | 10 +++++++++-\n>  src/ipa/raspberrypi/controller/rpi/agc.cpp   | 55\n> ++++++++++++++++++++++++++++++++++++++++++-------------\n>  src/ipa/raspberrypi/controller/rpi/agc.h     |  4 +++-\n>  src/ipa/raspberrypi/raspberrypi.cpp          | 57\n> +++++++++++++++++++++++++++++----------------------------\n>  4 files changed, 83 insertions(+), 43 deletions(-)","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 52090BD160\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 28 Mar 2023 11:30:33 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 857FB6271F;\n\tTue, 28 Mar 2023 13:30:32 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2568761ECD\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 28 Mar 2023 13:30:31 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AEE28720;\n\tTue, 28 Mar 2023 13:30:30 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1680003032;\n\tbh=TczXbo7rNeItGNE7IiDBTUD9ouo91w5CSDTUSgYdkxI=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=mfj1KVu/vEjXLqlyYZ/oBNYmKcBvBURiY9JaHGBGLy5mEP7/Nj1X33zk3rBDgFpbe\n\tbDDwBv8Tr/LFzt2OG65YjU5/nNSyYqoeR0QRSKIvGmn8uG2p3JW2Y3/q6kz+Mlpkj2\n\tQT4Yxw328xMmiP1PUvBpd+SHvMnOaPXJ/uS9Cvx9X+KVg7JFx7KjZ8KnUYxbXCtw7R\n\t2lXrBYGVOl87CzKpMo8lnuOcWCLAoGTqOG5v69yAOatQAhxqVF5yYxq+KuNfyeBBpE\n\trUnTk+/aZ8wRTsS84BLHQXVYBZaFwuFmP3ujeST4Hd/x1uD0LAlpnsYRZrFI0NS1yS\n\t4AQULY5Br2pcw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1680003030;\n\tbh=TczXbo7rNeItGNE7IiDBTUD9ouo91w5CSDTUSgYdkxI=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=E3jzIWxP+yUA5lo9XVqw3Hcm5BNMuYJ5oiD6Mh2aUSPE5y/QP46T6wnKqBJK8gkIU\n\tc0DWbOMEvGYfUiAiaVoz3ggXJ11r0mXQOJwo2B8A0URqiLKge0tccfk/AtdUWAZjTe\n\t0DYYZCRJnhG+zUL8NFmE0Vx16p2cdks525pocvbw="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"E3jzIWxP\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<CAEmqJPrssS6rWqzqU1ZXNYqQ_qFPvcV+_mNBh1nbv5=Z5yB+Fg@mail.gmail.com>","References":"<CAEmqJPrssS6rWqzqU1ZXNYqQ_qFPvcV+_mNBh1nbv5=Z5yB+Fg@mail.gmail.com>","To":"Naushir Patuck <naush@raspberrypi.com>,\n\tlibcamera devel <libcamera-devel@lists.libcamera.org>","Date":"Tue, 28 Mar 2023 12:30:28 +0100","Message-ID":"<168000302826.765114.12427848835678114818@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [GIT PULL] Raspberry Pi: Senor limits","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Kieran Bingham via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>","Reply-To":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Cc":"Jacopo Mondi <jacopo.mondi@ideasonboard.com>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":26783,"web_url":"https://patchwork.libcamera.org/comment/26783/","msgid":"<CAEmqJPoWHiODz3N55HpEn3SduKvkOvF8Aq3zaenbFMOKviH0Wg@mail.gmail.com>","date":"2023-03-28T11:48:52","subject":"Re: [libcamera-devel] [GIT PULL] Raspberry Pi: Senor limits","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"On Tue, 28 Mar 2023 at 12:30, Kieran Bingham\n<kieran.bingham@ideasonboard.com> wrote:\n>\n> Hi Naush,\n>\n> Quoting Naushir Patuck (2023-03-28 08:41:45)\n> > The following changes since commit d942bdc913c5a7f0895bfcb0180db3f279be246e:\n> >\n> >   libcamera: v4l2_device: openat(2) with O_CLOEXEC to cleanup after\n> > exec(3) (2023-03-26 11:48:18 +0300)\n> >\n> > are available in the Git repository at:\n> >\n> >   https://github.com/naushir/libcamera.git\n> >\n> > for you to fetch changes up to 4ec84728accfdf4df2250cec153e0aa396758b12:\n>\n> I hit the following error in the build-matrix I'm afraid:\n>\n> [8/49] Compiling C++ object src/ipa/raspberrypi/ipa_rpi.so.p/controller_rpi_agc.cpp.o\n> FAILED: src/ipa/raspberrypi/ipa_rpi.so.p/controller_rpi_agc.cpp.o\n> clang++-11 -Isrc/ipa/raspberrypi/ipa_rpi.so.p -Isrc/ipa/raspberrypi -I../../../src/libcamera/src/ipa/raspberrypi -Iinclude -I../../../src/libcamera/include -Isrc/ipa -I../../../src/libcamera/src/ipa -I../../../src/libcamera/src/ipa/raspberrypi/controller -Iinclude/libcamera/ipa -Iinclude/libcamera -fcolor-diagnostics -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -Wextra -Werror -std=c++17 -O0 -g -Wextra-semi -Wthread-safety -Wshadow -include /home/kbingham/iob/libcamera/ci/integrator/builds/build-matrix/clang-11/config.h -Wno-c99-designator -fPIC -DLIBCAMERA_BASE_PRIVATE -MD -MQ src/ipa/raspberrypi/ipa_rpi.so.p/controller_rpi_agc.cpp.o -MF src/ipa/raspberrypi/ipa_rpi.so.p/controller_rpi_agc.cpp.o.d -o src/ipa/raspberrypi/ipa_rpi.so.p/controller_rpi_agc.cpp.o -c ../../../src/libcamera/src/ipa/raspberrypi/controller/rpi/agc.cpp\n> In file included from ../../../src/libcamera/src/ipa/raspberrypi/controller/rpi/agc.cpp:20:\n> ../../../src/libcamera/src/ipa/raspberrypi/controller/rpi/agc.h:129:9: error: private field 'lastSensitivity_' is not used [-Werror,-Wunused-private-field]\n>         double lastSensitivity_; /* sensitivity of the previous camera mode */\n\nOops, sorry about that! David did point it out and I forgot to remove the field.\n\nI'll push an update and send another [GIT PULL] request.\n\nRegards,\nNaush\n\n\n>                ^\n> 1 error generated.\n>\n>\n> >\n> >   ipa: raspberrypi: Fix default frame durations calculation\n> > (2023-03-28 08:38:05 +0100)\n> >\n> > ----------------------------------------------------------------\n> > Naushir Patuck (4):\n> >       ipa: raspberrypi: Add sensor mode limits to CameraMode\n> >       ipa: raspberrypi: Use the new sensor limits fields in CameraMode\n> >       ipa: raspberrypi: Ensure shutter speed and gain are clipped in the AGC\n> >       ipa: raspberrypi: Fix default frame durations calculation\n> >\n> >  src/ipa/raspberrypi/controller/camera_mode.h | 10 +++++++++-\n> >  src/ipa/raspberrypi/controller/rpi/agc.cpp   | 55\n> > ++++++++++++++++++++++++++++++++++++++++++-------------\n> >  src/ipa/raspberrypi/controller/rpi/agc.h     |  4 +++-\n> >  src/ipa/raspberrypi/raspberrypi.cpp          | 57\n> > +++++++++++++++++++++++++++++----------------------------\n> >  4 files changed, 83 insertions(+), 43 deletions(-)","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1DE76C0F2A\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 28 Mar 2023 11:49:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6D01662740;\n\tTue, 28 Mar 2023 13:49:00 +0200 (CEST)","from mail-yb1-xb2d.google.com (mail-yb1-xb2d.google.com\n\t[IPv6:2607:f8b0:4864:20::b2d])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3424061ECD\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 28 Mar 2023 13:48:59 +0200 (CEST)","by mail-yb1-xb2d.google.com with SMTP id j7so14638711ybg.4\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 28 Mar 2023 04:48:59 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1680004140;\n\tbh=tCyHQA/eu0i3NotHeXqJNWmd7wPQVQZEEtABCovKb+8=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=14LNu+TBDbQHTekSuwp2hcPb/furJEHMjuzdGChoWHQEFAHqHK09y6HwOK+yGEarY\n\ted2r015UcXXjMFN7jPH+vhXXJhkJiyA+12JpEzPv5Ssk8Y8VCMarRjhsrPG9tovKCo\n\th2BBnClubLfYEN8krTsVmzRrvRCtIC2OjvAvcVl9bxSyFBYhKKHlg2gRsdcEAgsBgt\n\tp6VDRaqs2xAhO9ACM8ank2djvARKlAa3vhklBaUBrKUPhC3I/xHTsnaRkvjFRm0FzN\n\tV5DryBtlhx+OyBREZxJZeZJ9g5/vn7XNNFtzRkl19546//v+TYuxOR+L4jBRTs8Gui\n\two1Sh0hvygSvQ==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1680004138;\n\th=content-transfer-encoding:cc:to:subject:message-id:date:from\n\t:in-reply-to:references:mime-version:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=C6d1+yTm5gnxWnwbZbXtZXI0BbhS/20VMtIsVflQCzY=;\n\tb=b1TxOm4Nl+28XGAWG4V6kQbPsjjmrQU90cbgF2hp6WIPv9VyzdmyQDduoNXYGb/3aD\n\tJ70XvkrhO+ZLs5WUsfphknt5ZY8/ffD7Bt0At6SwfCF/bM/7kMWHJK+da9lW52h5IGN8\n\tjYvNWDogzwxLiT0hsRt71bcVyTl2ilA+I6YMN7e+A0P/enbZtPK6MuisKM873fe7fnKz\n\tvEITsksglrqsTVOcsv7QOWU3xKmthJ0+gD4J0T5IniFFt0/IW7m/XSuTg2mEyd0B7V84\n\tw+Mnth2HZyWFtG6R7iaK4SMOhCAGj41gc68bKInWkHwfLEXrJFYWNkAVrvG11hDPq27R\n\tItFw=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"b1TxOm4N\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112; t=1680004138;\n\th=content-transfer-encoding:cc:to:subject:message-id:date:from\n\t:in-reply-to:references:mime-version:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=C6d1+yTm5gnxWnwbZbXtZXI0BbhS/20VMtIsVflQCzY=;\n\tb=KnTQG1yMrsh6eoD7m9IwaNu4ABU12xGfLpt93Wn+dqMxs13UJKbK0v33wPjcyGeQIr\n\tbf6AKgk7RhNgrQfaUiIH1zu/UQUWP+vvF0DVemPzpvM77G8Ts+5Nmiphf/3vKPVOlHs1\n\tqZce4IcdvAiFTnQmtWOKOGCOtrs/aLHYg3k+n2fre/4H8skaMfam4vcipDNJAXsJg+yF\n\togPJsr5eu746NRLiyxzKfNOTIhG+nQW+deNpqTk0D85AFC0JOvZff5bPR+HJdJEnEWCg\n\twawJQGcagCiJkHrECaSpsjWAOnEFrY4NFsm3FRzw3+2XQZ1C/j7pSVyu/1lkHxG2+Sz9\n\t2NWg==","X-Gm-Message-State":"AAQBX9d2B0ASWLeDGX+ewBBJaiOkeNmd5pm5F7UmCdlVRMze57betwad\n\tEqfLxo9NmRizJVGMFKQyl+Z+RdYtNUfny9DH+zcYyw==","X-Google-Smtp-Source":"AKy350ZD1z5qTB2pwoEwwkxM2VaLv2lqRE1GC8dDShSDPyozrnnwBcGHceu1ltvWmq1HxgvQXKUs9jvUkp6EntucuDA=","X-Received":"by 2002:a05:6902:1201:b0:b6c:4d60:1bd6 with SMTP id\n\ts1-20020a056902120100b00b6c4d601bd6mr10166540ybu.9.1680004137932;\n\tTue, 28 Mar 2023 04:48:57 -0700 (PDT)","MIME-Version":"1.0","References":"<CAEmqJPrssS6rWqzqU1ZXNYqQ_qFPvcV+_mNBh1nbv5=Z5yB+Fg@mail.gmail.com>\n\t<168000302826.765114.12427848835678114818@Monstersaurus>","In-Reply-To":"<168000302826.765114.12427848835678114818@Monstersaurus>","Date":"Tue, 28 Mar 2023 12:48:52 +0100","Message-ID":"<CAEmqJPoWHiODz3N55HpEn3SduKvkOvF8Aq3zaenbFMOKviH0Wg@mail.gmail.com>","To":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","Subject":"Re: [libcamera-devel] [GIT PULL] Raspberry Pi: Senor limits","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Naushir Patuck via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>","Reply-To":"Naushir Patuck <naush@raspberrypi.com>","Cc":"Jacopo Mondi <jacopo.mondi@ideasonboard.com>,\n\tlibcamera devel <libcamera-devel@lists.libcamera.org>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]