[{"id":2478,"web_url":"https://patchwork.libcamera.org/comment/2478/","msgid":"<20190819091815.7vvif6bgnnlymuif@uno.localdomain>","date":"2019-08-19T09:18:15","subject":"Re: [libcamera-devel] [PATCH 11/14] android: camera_hal_manager:\n\tRemove unused close() method","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"On Sun, Aug 18, 2019 at 04:13:26AM +0300, Laurent Pinchart wrote:\n> The CameraHalManager::close() method isn't used, remove it.\n>\n\nIndeed a leftover now that the camera stack calls proxy->close()\ndirectly\n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> Signed-off-by: Laurent Pinchart \n> ---\n> src/android/camera_hal_manager.cpp | 10 +---------\n> src/android/camera_hal_manager.h | 1 -\n> 2 files changed, 1 insertion(+), 10 deletions(-)\n>\n> diff --git a/src/android/camera_hal_manager.cpp b/src/android/camera_hal_manager.cpp\n> index 063080a0746b..a1ffb3713d7e 100644\n> --- a/src/android/camera_hal_manager.cpp\n> +++ b/src/android/camera_hal_manager.cpp\n> @@ -25,7 +25,7 @@ LOG_DECLARE_CATEGORY(HAL);\n> * and spawns its own thread where libcamera related events are dispatched to.\n> * It wraps the libcamera CameraManager operations and provides helpers for the\n> * camera_module_t operations, to retrieve the number of cameras in the system,\n> - * their static information and to open and close camera devices.\n> + * their static information and to open camera devices.\n> */\n>\n> CameraHalManager::~CameraHalManager()\n> @@ -109,14 +109,6 @@ CameraProxy *CameraHalManager::open(unsigned int id,\n> \treturn proxy;\n> }\n>\n> -int CameraHalManager::close(CameraProxy *proxy)\n> -{\n> -\tproxy->close();\n> -\tLOG(HAL, Info) << \"Close camera '\" << proxy->id() << \"'\";\n> -\n> -\treturn 0;\n> -}\n> -\n> unsigned int CameraHalManager::numCameras() const\n> {\n> \treturn cameraManager_->cameras().size();\n> diff --git a/src/android/camera_hal_manager.h b/src/android/camera_hal_manager.h\n> index 502115cf056f..c23abd1c00af 100644\n> --- a/src/android/camera_hal_manager.h\n> +++ b/src/android/camera_hal_manager.h\n> @@ -29,7 +29,6 @@ public:\n> \tint init();\n>\n> \tCameraProxy *open(unsigned int id, const hw_module_t *module);\n> -\tint close(CameraProxy *proxy);\n>\n> \tunsigned int numCameras() const;\n> \tint getCameraInfo(unsigned int id, struct camera_info *info);\n> --\n> Regards,\n>\n> Laurent Pinchart\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net\n\t[217.70.183.198])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 144DD60E38\n\tfor ;\n\tMon, 19 Aug 2019 11:16:47 +0200 (CEST)","from uno.localdomain (unknown [87.18.63.98])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 66A3AC0006;\n\tMon, 19 Aug 2019 09:16:46 +0000 (UTC)"],"X-Originating-IP":"87.18.63.98","Date":"Mon, 19 Aug 2019 11:18:15 +0200","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190819091815.7vvif6bgnnlymuif@uno.localdomain>","References":"<20190818011329.14499-1-laurent.pinchart@ideasonboard.com>\n\t<20190818011329.14499-12-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"jnasrdzw5zdnmb6g\"","Content-Disposition":"inline","In-Reply-To":"<20190818011329.14499-12-laurent.pinchart@ideasonboard.com>","User-Agent":"NeoMutt/20180716","Subject":"Re: [libcamera-devel] [PATCH 11/14] android: camera_hal_manager:\n\tRemove unused close() method","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 19 Aug 2019 09:16:47 -0000"}}]