[{"id":26771,"web_url":"https://patchwork.libcamera.org/comment/26771/","msgid":"<1f3e86a624db2cf395ec0ceed7156f71ab8b03eb.camel@collabora.com>","date":"2023-03-27T13:42:36","subject":"Re: [libcamera-devel] [PATCH v2 2/3] doc: gstreamer: Add missing\n\tqueues","submitter":{"id":31,"url":"https://patchwork.libcamera.org/api/people/31/","name":"Nicolas Dufresne","email":"nicolas.dufresne@collabora.com"},"content":"Le vendredi 24 mars 2023 à 14:12 -0400, Nicolas Dufresne a écrit :\n> From: Nicolas Dufresne \n> \n> As libcamerasrc reports some latency, a queue is needed in order to store the\n> data in case the buffers has been produced slightly ahead of our reported\n> latency.\n\nIt could be nice to consider this patch independent from the rest. Currently,\nunless your camera has less then a frame of latency, the GStreamer pipeline emit\na warning, and you can also notice quite some jitter.\n\n> \n> Signed-off-by: Nicolas Dufresne \n> ---\n> README.rst | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/README.rst b/README.rst\n> index 34b6b49f..52cde91c 100644\n> --- a/README.rst\n> +++ b/README.rst\n> @@ -133,7 +133,7 @@ onto the OpenGL accelerated display element on your system.\n> \n> .. code::\n> \n> - gst-launch-1.0 libcamerasrc camera-name=\"Camera 1\" ! glimagesink\n> + gst-launch-1.0 libcamerasrc camera-name=\"Camera 1\" ! queue ! glimagesink\n> \n> To show the first camera found you can omit the camera-name property, or you\n> can list the cameras and their capabilities using:\n> @@ -164,7 +164,7 @@ the following example could be used as a starting point:\n> \n> gst-launch-1.0 libcamerasrc ! \\\n> video/x-raw,colorimetry=bt709,format=NV12,width=1280,height=720,framerate=30/1 ! \\\n> - jpegenc ! multipartmux ! \\\n> + queue ! jpegenc ! multipartmux ! \\\n> tcpserversink host=0.0.0.0 port=5000\n> \n> Which can be received on another device over the network with:","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 48F32C0F2A\n\tfor ;\n\tMon, 27 Mar 2023 13:42:47 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 01EF9626D7;\n\tMon, 27 Mar 2023 15:42:47 +0200 (CEST)","from madras.collabora.co.uk (madras.collabora.co.uk\n\t[IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B98D8626D7\n\tfor ;\n\tMon, 27 Mar 2023 15:42:45 +0200 (CEST)","from nicolas-tpx395.localdomain (192-222-136-102.qc.cable.ebox.net\n\t[192.222.136.102])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (4096 bits))\n\t(No client certificate requested) (Authenticated sender: nicolas)\n\tby madras.collabora.co.uk (Postfix) with ESMTPSA id 46C3066018CA\n\tfor ;\n\tMon, 27 Mar 2023 14:42:45 +0100 (BST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1679924567;\n\tbh=SRByFKr2tKjCr4cvCm7giyiIHKIPusEWv9BZCbOBfxM=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=xg6NEzWRniB85Abm637E8WQXBUIUPd8W9T0Ht2CyTnIQ7LK2RfbkAbJrHnwAaKzgJ\n\tH6I9UiQ3Evvgex5+oP5xjxisE1wQdK5MqoJ4JPDP/rOH53S/yCWJpxTBubksMuhUaK\n\tpCuYrRyQ9KRC7gp0gDkgAKOS18ZsEui4ve9nx05xuT4TfhwVVyovF5X0x4HRFxmgNG\n\tTXrJYPK+ecyw/3JUxRxQ7H/cbpszPv6G0tUZRjzVtGoG0Ky/ImVSVHYHC48HsZM5UT\n\t8hV/mqbe9SC3jQHAJjwz9zcT2nE1+yj2N5gY8ii3XVqHa8IkxKVWGkI99NuQEpwe/d\n\thdVxDNuXm4leA==","v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com;\n\ts=mail; t=1679924565;\n\tbh=SRByFKr2tKjCr4cvCm7giyiIHKIPusEWv9BZCbOBfxM=;\n\th=Subject:From:To:Date:In-Reply-To:References:From;\n\tb=ZJy4BNWufxO9yqYfKaBbIfhR6ypdDvxtSV7gpxGYmw9NcHQ3VQckUcdys5LXSCT+i\n\tPW9duDeBeG1ZdXXf99SDRT8/YqS8/0hV9vNg6S703XLh5YZeDl+0tV0VT5rPbG4NBZ\n\tWD8s7aFShxyrWVS/+zHX6LrYVziV7rFO97M8EAaOkwhxnOzjostHnH2D2pxlpaolxe\n\tbrNPNMTC20JBWd+bdJ3L8tVg9V5XTSjADZVSdrWNDkJn94j9vPG3ge2sx/NTRAH+br\n\try7dHBJ7A78NsHJ6xzCQ6gb4wzwQCW0uzl26DyRJHo6s/E1jmu5706cqTE6M243r0x\n\tz99HeZaXiSU0Q=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=collabora.com\n\theader.i=@collabora.com\n\theader.b=\"ZJy4BNWu\"; dkim-atps=neutral","Message-ID":"<1f3e86a624db2cf395ec0ceed7156f71ab8b03eb.camel@collabora.com>","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 27 Mar 2023 09:42:36 -0400","In-Reply-To":"<20230324181247.302586-3-nicolas@ndufresne.ca>","References":"<20230324181247.302586-1-nicolas@ndufresne.ca>\n\t<20230324181247.302586-3-nicolas@ndufresne.ca>","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","User-Agent":"Evolution 3.46.4 (3.46.4-1.fc37) ","MIME-Version":"1.0","Subject":"Re: [libcamera-devel] [PATCH v2 2/3] doc: gstreamer: Add missing\n\tqueues","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Nicolas Dufresne via libcamera-devel\n\t","Reply-To":"Nicolas Dufresne ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":26779,"web_url":"https://patchwork.libcamera.org/comment/26779/","msgid":"<20230327152701.rivu224g3g4idrc3@uno.localdomain>","date":"2023-03-27T15:27:01","subject":"Re: [libcamera-devel] [PATCH v2 2/3] doc: gstreamer: Add missing\n\tqueues","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Nicolas\n\nOn Fri, Mar 24, 2023 at 02:12:46PM -0400, Nicolas Dufresne via libcamera-devel wrote:\n> From: Nicolas Dufresne \n>\n> As libcamerasrc reports some latency, a queue is needed in order to store the\n> data in case the buffers has been produced slightly ahead of our reported\n> latency.\n>\n> Signed-off-by: Nicolas Dufresne \n\nReviewed-by: Jacopo Mondi \n\nI think we can take this is outside of the larger series in discussion\n\n> ---\n> README.rst | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n>\n> diff --git a/README.rst b/README.rst\n> index 34b6b49f..52cde91c 100644\n> --- a/README.rst\n> +++ b/README.rst\n> @@ -133,7 +133,7 @@ onto the OpenGL accelerated display element on your system.\n>\n> .. code::\n>\n> - gst-launch-1.0 libcamerasrc camera-name=\"Camera 1\" ! glimagesink\n> + gst-launch-1.0 libcamerasrc camera-name=\"Camera 1\" ! queue ! glimagesink\n>\n> To show the first camera found you can omit the camera-name property, or you\n> can list the cameras and their capabilities using:\n> @@ -164,7 +164,7 @@ the following example could be used as a starting point:\n>\n> gst-launch-1.0 libcamerasrc ! \\\n> video/x-raw,colorimetry=bt709,format=NV12,width=1280,height=720,framerate=30/1 ! \\\n> - jpegenc ! multipartmux ! \\\n> + queue ! jpegenc ! multipartmux ! \\\n> tcpserversink host=0.0.0.0 port=5000\n>\n> Which can be received on another device over the network with:\n> --\n> 2.39.2\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2DD28C0F2A\n\tfor ;\n\tMon, 27 Mar 2023 15:27:06 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5801D62720;\n\tMon, 27 Mar 2023 17:27:05 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D8BE66271C\n\tfor ;\n\tMon, 27 Mar 2023 17:27:03 +0200 (CEST)","from ideasonboard.com (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6A7C1AEC;\n\tMon, 27 Mar 2023 17:27:03 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1679930825;\n\tbh=BnCTBs482m/q/UwcPODjUi/ZRauWKme80yG6bhC6yBk=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=gqdgg9yaHXy4h0+lCvieJjOdRsZ1b4IEE+nL5OfGg70Z30WNN2fptyGe1nzat6ALt\n\thK2BeW5GAroPTqT1rT/jFcPiNDLpAuUzfmPsA4dc8TMpxIPTAz3o8ziLtEXHR19XOm\n\tJv3Gx37kXfxetajeExjzvh6nFU2UptHhss5LhNHQ032vhnnhUEaaPyog0k3fwkzhWQ\n\t9hWN4KNGX7sPI7St1UvQVShSHU6kKWIidXkOby/j/gZneK6Gu0uwfYbWXMkg9ID4Fy\n\tefMe2eJPb3laNMMJSEDt5CtMkjCDn5n82Mk85KcHX+7YblLhfpDpo7uQtas7cA0Vue\n\t8KwRblFvxETYQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1679930823;\n\tbh=BnCTBs482m/q/UwcPODjUi/ZRauWKme80yG6bhC6yBk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=YgJeOvxNkG8OKvCu90N5Qkbr2DN0nbjYVTa5e1bbm1o2KW02V12oBCV4O7bl4O19B\n\tXLRGvRdp3ZLAectnks0KoDwxOp7Y2ZpIXy1Ws1ERycWh+KhfK4GYDPBKGBFPbdvu51\n\ttNDlaQg3x7w+HHg8NoUnJO7OpCrms1nbQM9Zv1Q4="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"YgJeOvxN\"; dkim-atps=neutral","Date":"Mon, 27 Mar 2023 17:27:01 +0200","To":"Nicolas Dufresne ","Message-ID":"<20230327152701.rivu224g3g4idrc3@uno.localdomain>","References":"<20230324181247.302586-1-nicolas@ndufresne.ca>\n\t<20230324181247.302586-3-nicolas@ndufresne.ca>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20230324181247.302586-3-nicolas@ndufresne.ca>","Subject":"Re: [libcamera-devel] [PATCH v2 2/3] doc: gstreamer: Add missing\n\tqueues","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org,\n\tNicolas Dufresne ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]