[{"id":27256,"web_url":"https://patchwork.libcamera.org/comment/27256/","msgid":"<20230605142326.GB31538@pendragon.ideasonboard.com>","date":"2023-06-05T14:23:26","subject":"Re: [libcamera-devel] [PATCH v4 1/4] libcamera: rkisp1: Generate\n\tconfig using main path","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nOn Tue, Mar 21, 2023 at 06:20:01PM +0100, Jacopo Mondi wrote:\n> The generateConfiguration() implementation in the Rockchip RkISP1\n> pipeline handler uses by default the self path (if available) for\n> the Viewfinder and VideoRecording StreamRoles.\n> \n> The validate() implementation, at the contrary, prefers using the main\n> path, when available, for all streams.\n> \n> As the self-path is limited in output resolution to 1920x1920,\n> generating a configuration using the self path limits the maximum\n> stream size to 1920x1920, while higher resolutions can be obtained by\n> using the main path.\n> \n> Align the generateConfiguration() implementation to the validate() one\n> by using the main path by default if available.\n> \n> Bug: https://bugs.libcamera.org/show_bug.cgi?id=180\n> Reported-by: libcamera@luigi311.com\n> Signed-off-by: Jacopo Mondi \n> Reviewed-by: Paul Elder \n> Reviewed-by: Laurent Pinchart \n> ---\n> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 10 +---------\n> 1 file changed, 1 insertion(+), 9 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> index 8a30fe061d04..fd331168af80 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> @@ -630,23 +630,18 @@ PipelineHandlerRkISP1::generateConfiguration(Camera *camera,\n> \t * first stream and use it for all streams.\n> \t */\n> \tstd::optional colorSpace;\n> -\n> \tbool mainPathAvailable = true;\n> -\tbool selfPathAvailable = data->selfPath_;\n> \n> \tfor (const StreamRole role : roles) {\n> -\t\tbool useMainPath;\n> \n> \t\tswitch (role) {\n> \t\tcase StreamRole::StillCapture:\n> -\t\t\tuseMainPath = mainPathAvailable;\n> \t\t\t/* JPEG encoders typically expect sYCC. */\n> \t\t\tif (!colorSpace)\n> \t\t\t\tcolorSpace = ColorSpace::Sycc;\n> \t\t\tbreak;\n> \n> \t\tcase StreamRole::Viewfinder:\n> -\t\t\tuseMainPath = !selfPathAvailable;\n> \t\t\t/*\n> \t\t\t * sYCC is the YCbCr encoding of sRGB, which is commonly\n> \t\t\t * used by displays.\n> @@ -656,7 +651,6 @@ PipelineHandlerRkISP1::generateConfiguration(Camera *camera,\n> \t\t\tbreak;\n> \n> \t\tcase StreamRole::VideoRecording:\n> -\t\t\tuseMainPath = !selfPathAvailable;\n> \t\t\t/* Rec. 709 is a good default for HD video recording. */\n> \t\t\tif (!colorSpace)\n> \t\t\t\tcolorSpace = ColorSpace::Rec709;\n> @@ -669,7 +663,6 @@ PipelineHandlerRkISP1::generateConfiguration(Camera *camera,\n> \t\t\t\treturn nullptr;\n> \t\t\t}\n> \n> -\t\t\tuseMainPath = true;\n> \t\t\tcolorSpace = ColorSpace::Raw;\n> \t\t\tbreak;\n> \n> @@ -681,12 +674,11 @@ PipelineHandlerRkISP1::generateConfiguration(Camera *camera,\n> \n> \t\tRkISP1Path *path;\n> \n\nCould you add a comment to record the problem I raised in the review of\nv3 ? Otherwise we'll forget about it.\n\n\t\t/*\n\t\t * Prefer the main path if available, as it supports higher\n\t\t * resolutions.\n\t\t *\n\t\t * \\todo Using the main path unconditionally hides support for\n\t\t * RGB (only available on the self path) in the streams formats\n\t\t * exposed to applications. This likely calls for a better API\n\t\t * to expose streams capabilities.\n\t\t */\n\n> -\t\tif (useMainPath) {\n> +\t\tif (mainPathAvailable) {\n> \t\t\tpath = data->mainPath_;\n> \t\t\tmainPathAvailable = false;\n> \t\t} else {\n> \t\t\tpath = data->selfPath_;\n> -\t\t\tselfPathAvailable = false;\n> \t\t}\n> \n> \t\tStreamConfiguration cfg =","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9028EC31E9\n\tfor ;\n\tMon, 5 Jun 2023 14:23:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E78B862886;\n\tMon, 5 Jun 2023 16:23:28 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2B2AC6287D\n\tfor ;\n\tMon, 5 Jun 2023 16:23:28 +0200 (CEST)","from pendragon.ideasonboard.com (om126156242094.26.openmobile.ne.jp\n\t[126.156.242.94])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BA53283F;\n\tMon, 5 Jun 2023 16:23:02 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1685975009;\n\tbh=tGS+q/B9ye9sd85DNy/USy1Dv+DFrn1z6Mc3lUdDMss=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=cAPspmyBQbuHmzyq7NEW8mGoRMfW+s+1VTkt5eC8SyDVNRa9Jap8buf2sGWbHLkTk\n\tDfxYCbTzFS9C1X6iR8v7pbfTghQQrHk8JdZG7SmuKdrKDrOc2rwyHjD++qKZH32AOb\n\tlaDERVCPXVmUGj6+GPmIV8jtbRqLJmvmKdPOXoShwwpkPgh/RZ03XEQcBZn0rjIQep\n\tBZK9xzBtdhDaWYZNUj72EUgUY8wJvDscxDKqHmbLszXHRLxIpobTPVe3JG3x01K9zm\n\tYXbzmvfd0296REvQErHGo940R15BamiC49QbD2xwo7x/BhUs/U4R9TY96/WGlX8blP\n\twLkJ+SX6ThZUw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1685974983;\n\tbh=tGS+q/B9ye9sd85DNy/USy1Dv+DFrn1z6Mc3lUdDMss=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=i1qjPVm0XqWegZ+tmK3YY524lqiAAk31oHwVFiNX0oj2YFEH4LTGuUf1bpHoV14y4\n\tkSayKsjoZAOaJCE0KqMkwB6HWGO6hdcL+PYzcxwb3FygIAqItm29Hq5R6ha3nnKszu\n\t/swPApKij4Bo4/yVMhMO5ZQfuO4tjvkssOQjoLB4="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"i1qjPVm0\"; dkim-atps=neutral","Date":"Mon, 5 Jun 2023 17:23:26 +0300","To":"Jacopo Mondi ","Message-ID":"<20230605142326.GB31538@pendragon.ideasonboard.com>","References":"<20230321172004.176852-1-jacopo.mondi@ideasonboard.com>\n\t<20230321172004.176852-2-jacopo.mondi@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20230321172004.176852-2-jacopo.mondi@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v4 1/4] libcamera: rkisp1: Generate\n\tconfig using main path","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org, libcamera@luigi311.com","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]