[{"id":2462,"web_url":"https://patchwork.libcamera.org/comment/2462/","msgid":"<20190818172458.jqrpz7yjqyycejyj@uno.localdomain>","date":"2019-08-18T17:24:58","subject":"Re: [libcamera-devel] [PATCH 05/14] test: event-thread: Fix\n\tcompilation on Chromium OS","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent,\n\nOn Sun, Aug 18, 2019 at 04:13:20AM +0300, Laurent Pinchart wrote:\n> Commit 92b4af98cd67 (\"test: Add EventNotifier thread move test\") causes\n> the build to fail in the Chromium OS build environment, because the\n> return values of the pipe() function marked with the\n> __warn_unused_result__ attribute is ignored. Fix this.\n>\n\nDo we want to compile tests on CrOS?\n\n> Signed-off-by: Laurent Pinchart \n> ---\n> test/event-thread.cpp | 6 +++++-\n> 1 file changed, 5 insertions(+), 1 deletion(-)\n>\n> diff --git a/test/event-thread.cpp b/test/event-thread.cpp\n> index 714bc9845820..01120733eca4 100644\n> --- a/test/event-thread.cpp\n> +++ b/test/event-thread.cpp\n> @@ -25,7 +25,11 @@ public:\n> \tEventHandler()\n> \t\t: notified_(false)\n> \t{\n> -\t\tpipe(pipefd_);\n> +\t\tint ret = pipe(pipefd_);\n> +\t\tif (ret < 0) {\n> +\t\t\tret = errno;\n> +\t\t\tcout << \"pipe() failed: \" << strerror(ret) << endl;\n> +\t\t}\n\nShouldn't we fail the test if creating the pipe fails?\nThis will require moving this out of the constructor probably...\n\n>\n> \t\tnotifier_ = new EventNotifier(pipefd_[0], EventNotifier::Read, this);\n> \t\tnotifier_->activated.connect(this, &EventHandler::readReady);\n> --\n> Regards,\n>\n> Laurent Pinchart\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net\n\t[217.70.183.201])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 92ED960E2A\n\tfor ;\n\tSun, 18 Aug 2019 19:23:30 +0200 (CEST)","from uno.localdomain (unknown [87.18.63.98])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay8-d.mail.gandi.net (Postfix) with ESMTPSA id AF4B21BF207;\n\tSun, 18 Aug 2019 17:23:29 +0000 (UTC)"],"X-Originating-IP":"87.18.63.98","Date":"Sun, 18 Aug 2019 19:24:58 +0200","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190818172458.jqrpz7yjqyycejyj@uno.localdomain>","References":"<20190818011329.14499-1-laurent.pinchart@ideasonboard.com>\n\t<20190818011329.14499-6-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"xjmpnkxygs3kug33\"","Content-Disposition":"inline","In-Reply-To":"<20190818011329.14499-6-laurent.pinchart@ideasonboard.com>","User-Agent":"NeoMutt/20180716","Subject":"Re: [libcamera-devel] [PATCH 05/14] test: event-thread: Fix\n\tcompilation on Chromium OS","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sun, 18 Aug 2019 17:23:30 -0000"}},{"id":2463,"web_url":"https://patchwork.libcamera.org/comment/2463/","msgid":"<20190818172636.GF4999@pendragon.ideasonboard.com>","date":"2019-08-18T17:26:36","subject":"Re: [libcamera-devel] [PATCH 05/14] test: event-thread: Fix\n\tcompilation on Chromium OS","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nOn Sun, Aug 18, 2019 at 07:24:58PM +0200, Jacopo Mondi wrote:\n> On Sun, Aug 18, 2019 at 04:13:20AM +0300, Laurent Pinchart wrote:\n> > Commit 92b4af98cd67 (\"test: Add EventNotifier thread move test\") causes\n> > the build to fail in the Chromium OS build environment, because the\n> > return values of the pipe() function marked with the\n> > __warn_unused_result__ attribute is ignored. Fix this.\n> >\n> \n> Do we want to compile tests on CrOS?\n\nI thought we didn't, and went investigating. Turns out there's a typo in\nthe ebuild, so tests are always compiled. I'll fix that. It's a good\ntest though :-)\n\n> > Signed-off-by: Laurent Pinchart \n> > ---\n> > test/event-thread.cpp | 6 +++++-\n> > 1 file changed, 5 insertions(+), 1 deletion(-)\n> >\n> > diff --git a/test/event-thread.cpp b/test/event-thread.cpp\n> > index 714bc9845820..01120733eca4 100644\n> > --- a/test/event-thread.cpp\n> > +++ b/test/event-thread.cpp\n> > @@ -25,7 +25,11 @@ public:\n> > \tEventHandler()\n> > \t\t: notified_(false)\n> > \t{\n> > -\t\tpipe(pipefd_);\n> > +\t\tint ret = pipe(pipefd_);\n> > +\t\tif (ret < 0) {\n> > +\t\t\tret = errno;\n> > +\t\t\tcout << \"pipe() failed: \" << strerror(ret) << endl;\n> > +\t\t}\n> \n> Shouldn't we fail the test if creating the pipe fails?\n> This will require moving this out of the constructor probably...\n\nThe test will eventually fail as the event will not be notified, so I\nthink we're good.\n\n> > \t\tnotifier_ = new EventNotifier(pipefd_[0], EventNotifier::Read, this);\n> > \t\tnotifier_->activated.connect(this, &EventHandler::readReady);","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C11C160E2A\n\tfor ;\n\tSun, 18 Aug 2019 19:26:42 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 22EB02AF;\n\tSun, 18 Aug 2019 19:26:42 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1566149202;\n\tbh=z5I6Ed4SNXzECBXmJeEJpN5Qdln4/Beq2DblWLU6m0Y=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=sJyNaBMs+gSZUC0izip1cZkE+g1yp+e/40zUeHm22CFsfZVUZmQJ4hp9CbZ+gatRo\n\tVTDtSyhrb2rEVp770Q+C5S/B+FvaK3tYtQx5q6m5qNvX2PpxD9NLeRB+kPOR1JTA5k\n\tOZ0v8xmcFVKwNPqdqLmK2imWBx3DWmILBcyHis9Y=","Date":"Sun, 18 Aug 2019 20:26:36 +0300","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190818172636.GF4999@pendragon.ideasonboard.com>","References":"<20190818011329.14499-1-laurent.pinchart@ideasonboard.com>\n\t<20190818011329.14499-6-laurent.pinchart@ideasonboard.com>\n\t<20190818172458.jqrpz7yjqyycejyj@uno.localdomain>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20190818172458.jqrpz7yjqyycejyj@uno.localdomain>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 05/14] test: event-thread: Fix\n\tcompilation on Chromium OS","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sun, 18 Aug 2019 17:26:42 -0000"}},{"id":2492,"web_url":"https://patchwork.libcamera.org/comment/2492/","msgid":"<20190819152444.GC6693@localhost.localdomain>","date":"2019-08-19T15:24:44","subject":"Re: [libcamera-devel] [PATCH 05/14] test: event-thread: Fix\n\tcompilation on Chromium OS","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"On Sun, Aug 18, 2019 at 04:13:20AM +0300, Laurent Pinchart wrote:\n> Commit 92b4af98cd67 (\"test: Add EventNotifier thread move test\") causes\n> the build to fail in the Chromium OS build environment, because the\n> return values of the pipe() function marked with the\n> __warn_unused_result__ attribute is ignored. Fix this.\n> \n> Signed-off-by: Laurent Pinchart \n\nIt fixed the compilation for me :)\n\nReviewed-by: Paul Elder \n\n> ---\n> test/event-thread.cpp | 6 +++++-\n> 1 file changed, 5 insertions(+), 1 deletion(-)\n> \n> diff --git a/test/event-thread.cpp b/test/event-thread.cpp\n> index 714bc9845820..01120733eca4 100644\n> --- a/test/event-thread.cpp\n> +++ b/test/event-thread.cpp\n> @@ -25,7 +25,11 @@ public:\n> \tEventHandler()\n> \t\t: notified_(false)\n> \t{\n> -\t\tpipe(pipefd_);\n> +\t\tint ret = pipe(pipefd_);\n> +\t\tif (ret < 0) {\n> +\t\t\tret = errno;\n> +\t\t\tcout << \"pipe() failed: \" << strerror(ret) << endl;\n> +\t\t}\n> \n> \t\tnotifier_ = new EventNotifier(pipefd_[0], EventNotifier::Read, this);\n> \t\tnotifier_->activated.connect(this, &EventHandler::readReady);\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A152560C1E\n\tfor ;\n\tMon, 19 Aug 2019 17:24:50 +0200 (CEST)","from localhost.localdomain (173-16-160-11.client.mchsi.com\n\t[173.16.160.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B0F54510;\n\tMon, 19 Aug 2019 17:24:49 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1566228290;\n\tbh=baGYdkjpEoGit3Jb0cnL39qN6Dw9PPbZ1TnOSZxaW0k=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Wux/MbotsABRUnW0yNwefpS3c6NrqB3zlD2NICoKugyp00N3AukuTVU+mbKiWvcdi\n\td5h5BHaRWg6JuyCO5rXqbnrxHptqAX8oOOHBz8q7SIhAh7fXZyit7ZfA1nDP5LxeNU\n\tcXRZK+J49e13xLecRJ6fNOdnObHBe6CjktZrw8YE=","Date":"Mon, 19 Aug 2019 10:24:44 -0500","From":"Paul Elder ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190819152444.GC6693@localhost.localdomain>","References":"<20190818011329.14499-1-laurent.pinchart@ideasonboard.com>\n\t<20190818011329.14499-6-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20190818011329.14499-6-laurent.pinchart@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 05/14] test: event-thread: Fix\n\tcompilation on Chromium OS","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 19 Aug 2019 15:24:50 -0000"}},{"id":2496,"web_url":"https://patchwork.libcamera.org/comment/2496/","msgid":"<20190819160304.2jhwa5jts7e7nuwv@uno.localdomain>","date":"2019-08-19T16:03:04","subject":"Re: [libcamera-devel] [PATCH 05/14] test: event-thread: Fix\n\tcompilation on Chromium OS","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent,\n\nOn Sun, Aug 18, 2019 at 08:26:36PM +0300, Laurent Pinchart wrote:\n> Hi Jacopo,\n>\n> On Sun, Aug 18, 2019 at 07:24:58PM +0200, Jacopo Mondi wrote:\n> > On Sun, Aug 18, 2019 at 04:13:20AM +0300, Laurent Pinchart wrote:\n> > > Commit 92b4af98cd67 (\"test: Add EventNotifier thread move test\") causes\n> > > the build to fail in the Chromium OS build environment, because the\n> > > return values of the pipe() function marked with the\n> > > __warn_unused_result__ attribute is ignored. Fix this.\n> > >\n> >\n> > Do we want to compile tests on CrOS?\n>\n> I thought we didn't, and went investigating. Turns out there's a typo in\n> the ebuild, so tests are always compiled. I'll fix that. It's a good\n> test though :-)\n>\n\nAnd do we want to keep building tests on cros ?\nI would say why not, actually... It already spotted something\n\n> > > Signed-off-by: Laurent Pinchart \n> > > ---\n> > > test/event-thread.cpp | 6 +++++-\n> > > 1 file changed, 5 insertions(+), 1 deletion(-)\n> > >\n> > > diff --git a/test/event-thread.cpp b/test/event-thread.cpp\n> > > index 714bc9845820..01120733eca4 100644\n> > > --- a/test/event-thread.cpp\n> > > +++ b/test/event-thread.cpp\n> > > @@ -25,7 +25,11 @@ public:\n> > > \tEventHandler()\n> > > \t\t: notified_(false)\n> > > \t{\n> > > -\t\tpipe(pipefd_);\n> > > +\t\tint ret = pipe(pipefd_);\n> > > +\t\tif (ret < 0) {\n> > > +\t\t\tret = errno;\n> > > +\t\t\tcout << \"pipe() failed: \" << strerror(ret) << endl;\n> > > +\t\t}\n> >\n> > Shouldn't we fail the test if creating the pipe fails?\n> > This will require moving this out of the constructor probably...\n>\n> The test will eventually fail as the event will not be notified, so I\n> think we're good.\n>\n\nThanks for the clarification.\n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> > > \t\tnotifier_ = new EventNotifier(pipefd_[0], EventNotifier::Read, this);\n> > > \t\tnotifier_->activated.connect(this, &EventHandler::readReady);\n>\n> --\n> Regards,\n>\n> Laurent Pinchart","headers":{"Return-Path":"","Received":["from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net\n\t[217.70.183.194])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D772760C1E\n\tfor ;\n\tMon, 19 Aug 2019 18:01:36 +0200 (CEST)","from uno.localdomain (unknown [87.18.63.98])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 323BA4000C;\n\tMon, 19 Aug 2019 16:01:36 +0000 (UTC)"],"X-Originating-IP":"87.18.63.98","Date":"Mon, 19 Aug 2019 18:03:04 +0200","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190819160304.2jhwa5jts7e7nuwv@uno.localdomain>","References":"<20190818011329.14499-1-laurent.pinchart@ideasonboard.com>\n\t<20190818011329.14499-6-laurent.pinchart@ideasonboard.com>\n\t<20190818172458.jqrpz7yjqyycejyj@uno.localdomain>\n\t<20190818172636.GF4999@pendragon.ideasonboard.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"6hbepy777r3bsyew\"","Content-Disposition":"inline","In-Reply-To":"<20190818172636.GF4999@pendragon.ideasonboard.com>","User-Agent":"NeoMutt/20180716","Subject":"Re: [libcamera-devel] [PATCH 05/14] test: event-thread: Fix\n\tcompilation on Chromium OS","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 19 Aug 2019 16:01:37 -0000"}},{"id":2497,"web_url":"https://patchwork.libcamera.org/comment/2497/","msgid":"<20190819160308.GQ5011@pendragon.ideasonboard.com>","date":"2019-08-19T16:03:08","subject":"Re: [libcamera-devel] [PATCH 05/14] test: event-thread: Fix\n\tcompilation on Chromium OS","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nOn Mon, Aug 19, 2019 at 06:03:04PM +0200, Jacopo Mondi wrote:\n> On Sun, Aug 18, 2019 at 08:26:36PM +0300, Laurent Pinchart wrote:\n> > On Sun, Aug 18, 2019 at 07:24:58PM +0200, Jacopo Mondi wrote:\n> >> On Sun, Aug 18, 2019 at 04:13:20AM +0300, Laurent Pinchart wrote:\n> >>> Commit 92b4af98cd67 (\"test: Add EventNotifier thread move test\") causes\n> >>> the build to fail in the Chromium OS build environment, because the\n> >>> return values of the pipe() function marked with the\n> >>> __warn_unused_result__ attribute is ignored. Fix this.\n> >>>\n> >>\n> >> Do we want to compile tests on CrOS?\n> >\n> > I thought we didn't, and went investigating. Turns out there's a typo in\n> > the ebuild, so tests are always compiled. I'll fix that. It's a good\n> > test though :-)\n> \n> And do we want to keep building tests on cros ?\n> I would say why not, actually... It already spotted something\n\nYes, they're useful for this purpose :-)\n\n> >>> Signed-off-by: Laurent Pinchart \n> >>> ---\n> >>> test/event-thread.cpp | 6 +++++-\n> >>> 1 file changed, 5 insertions(+), 1 deletion(-)\n> >>>\n> >>> diff --git a/test/event-thread.cpp b/test/event-thread.cpp\n> >>> index 714bc9845820..01120733eca4 100644\n> >>> --- a/test/event-thread.cpp\n> >>> +++ b/test/event-thread.cpp\n> >>> @@ -25,7 +25,11 @@ public:\n> >>> \tEventHandler()\n> >>> \t\t: notified_(false)\n> >>> \t{\n> >>> -\t\tpipe(pipefd_);\n> >>> +\t\tint ret = pipe(pipefd_);\n> >>> +\t\tif (ret < 0) {\n> >>> +\t\t\tret = errno;\n> >>> +\t\t\tcout << \"pipe() failed: \" << strerror(ret) << endl;\n> >>> +\t\t}\n> >>\n> >> Shouldn't we fail the test if creating the pipe fails?\n> >> This will require moving this out of the constructor probably...\n> >\n> > The test will eventually fail as the event will not be notified, so I\n> > think we're good.\n> \n> Thanks for the clarification.\n> \n> Reviewed-by: Jacopo Mondi \n> \n> >>> \t\tnotifier_ = new EventNotifier(pipefd_[0], EventNotifier::Read, this);\n> >>> \t\tnotifier_->activated.connect(this, &EventHandler::readReady);","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 25C6860C1E\n\tfor ;\n\tMon, 19 Aug 2019 18:03:14 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 96016510;\n\tMon, 19 Aug 2019 18:03:13 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1566230593;\n\tbh=JPMtO6yhEupuzCfBqX+oCqtoipcWq2JlCdgPtV/dPWU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=DTcMlL4Kw3Keu/5LsKgE4JifP/5gs3IiUcD1XZBnQ7CgwCIH7uAe/LqMSkraQdI+a\n\thehjevphADb7QHbIWHkJ8pb1hhXcnHcMhnZkQTT0D+CLfcNeXqaSy/QW1oALlERmDJ\n\tYqvzlyHVGv741oqMIMN5dEpjBQ+mt9jJQ2Nogu6Q=","Date":"Mon, 19 Aug 2019 19:03:08 +0300","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190819160308.GQ5011@pendragon.ideasonboard.com>","References":"<20190818011329.14499-1-laurent.pinchart@ideasonboard.com>\n\t<20190818011329.14499-6-laurent.pinchart@ideasonboard.com>\n\t<20190818172458.jqrpz7yjqyycejyj@uno.localdomain>\n\t<20190818172636.GF4999@pendragon.ideasonboard.com>\n\t<20190819160304.2jhwa5jts7e7nuwv@uno.localdomain>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20190819160304.2jhwa5jts7e7nuwv@uno.localdomain>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 05/14] test: event-thread: Fix\n\tcompilation on Chromium OS","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 19 Aug 2019 16:03:14 -0000"}}]