[{"id":26900,"web_url":"https://patchwork.libcamera.org/comment/26900/","msgid":"<20230419055640.GQ30837@pendragon.ideasonboard.com>","date":"2023-04-19T05:56:40","subject":"Re: [libcamera-devel] [PATCH 07/11] pipeline: ipu3: Allow raw-only\n\tstreams in IPU3 pipeline","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Dan,\n\nThank you for the patch.\n\nOn Sat, Mar 18, 2023 at 11:40:10PM +0000, Daniel Scally via libcamera-devel wrote:\n> Sensors not connected to the Imgu produce raw-only streams. Allow\n> that configuration to proceed in the IPU3 pipeline, but warn about\n> the lack of sensor controls for other sensors.\n> \n> Signed-off-by: Daniel Scally \n> ---\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 14 +++++++-------\n> 1 file changed, 7 insertions(+), 7 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index cc7da299..b9228a59 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -232,18 +232,18 @@ CameraConfiguration::Status IPU3CameraConfiguration::validate()\n> \t\treturn Invalid;\n> \t} else if (rawCount && !yuvCount) {\n> \t\t/*\n> -\t\t * Disallow raw-only camera configuration. Currently, ImgU does\n> -\t\t * not get configured for raw-only streams and has early return\n> -\t\t * in configure(). To support raw-only stream, we do need the IPA\n> -\t\t * to get configured since it will setup the sensor controls for\n> -\t\t * the capture.\n> +\t\t * Currently, ImgU does not get configured for raw-only streams\n> +\t\t * and has early return in configure(). To support raw-only stream,\n> +\t\t * we do need the IPA to get configured since it will setup the\n> +\t\t * sensor controls for the capture. As some sensors _only_ output\n> +\t\t * raw streams though we need to allow the configuration to\n> +\t\t * continue here.\n> \t\t *\n> \t\t * \\todo Configure the ImgU with internal buffers which will enable\n> \t\t * the IPA to get configured for the raw-only camera configuration.\n> \t\t */\n> \t\tLOG(IPU3, Debug)\n> -\t\t\t<< \"Camera configuration cannot support raw-only streams\";\n> -\t\treturn Invalid;\n> +\t\t\t<< \"Sensor controls not supported for raw-only stream\";\n\nDon't you need to fix this ? Otherwise the user won't be able to control\nthe sensor parameters.\n\n> \t}\n> \n> \t/*","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9B710BD1F1\n\tfor ;\n\tWed, 19 Apr 2023 05:56:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5644F627B9;\n\tWed, 19 Apr 2023 07:56:29 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CE7DB627B1\n\tfor ;\n\tWed, 19 Apr 2023 07:56:27 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(133-32-181-51.west.xps.vectant.ne.jp [133.32.181.51])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6DAEC10A;\n\tWed, 19 Apr 2023 07:56:20 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1681883789;\n\tbh=qvD58k7UaNAG2yeK3rK7RzXLBgXBvK9KBqq5K8tkjgw=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=tDJ14bCX7/fjvQtXcu//8DrT5ir1y7S2pTF6CI/X+H6TXRBbKy86Z+h+DW/9SnADX\n\tqOIA1bOfUYhPMjPjfNF8ZYigcB0CndoK+krBBvVTc+8Lh8TbJ6xbvJD1lADTvV7fiz\n\tLZjwhDCX6mc4dYeSh9IuYHPO7Ckp+Lz5uK8vY0hkw7jniRNxJZFmPHVkPdC6vIDYYy\n\tNW5/BXg7ONvMP7HrPlOQgU0jb1/WDVOb5ijvQiGVjrpkyuKNAy4NZ5oSf+whL0chE5\n\tA8Nnv/MkLkkPC8/0ZiFutXQP7xJ6Q77Qzy0DbnQZLFp9KMLcZOozy+zyqOwL+yGOm6\n\taeOhykcvrR11Q==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1681883781;\n\tbh=qvD58k7UaNAG2yeK3rK7RzXLBgXBvK9KBqq5K8tkjgw=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=PmCemTG5lvdL/Imeuu/d3ZLsNcBxQzyjLyxoga6YQ8R+NlNXmfPLTOh/Rd7WJ3UUN\n\twcODl+CsHulbXty0KiirlDk3I5Gm/TXLplxcO8LlprvPyLff++23XBFaZUUFF7HiOs\n\t3FrSWzc7uKWA7zsKqyOKuWuz/z13tjLx3p0Kn4bo="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"PmCemTG5\"; dkim-atps=neutral","Date":"Wed, 19 Apr 2023 08:56:40 +0300","To":"Daniel Scally ","Message-ID":"<20230419055640.GQ30837@pendragon.ideasonboard.com>","References":"<20230318234014.29506-1-dan.scally@ideasonboard.com>\n\t<20230318234014.29506-8-dan.scally@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20230318234014.29506-8-dan.scally@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 07/11] pipeline: ipu3: Allow raw-only\n\tstreams in IPU3 pipeline","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]