[{"id":26666,"web_url":"https://patchwork.libcamera.org/comment/26666/","msgid":"<20230319140102.GK10144@pendragon.ideasonboard.com>","date":"2023-03-19T14:01:02","subject":"Re: [libcamera-devel] [PATCH 03/11] libcamera/formats: Add IPU3_Y10\n\tformat","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Dan,\n\nThank you for the patch.\n\nOn Sat, Mar 18, 2023 at 11:40:06PM +0000, Daniel Scally via libcamera-devel wrote:\n> Add entries to libcamera's pixelFormatInfo map describing the IPU3_Y10\n> format which is exposed by the CIO2 device when connected to certain\n> camera sensors, such as the OmniVision 7251 IR Camera.\n> \n> Signed-off-by: Daniel Scally \n> ---\n> src/libcamera/formats.cpp | 10 ++++++++++\n> src/libcamera/formats.yaml | 3 +++\n> 2 files changed, 13 insertions(+)\n> \n> diff --git a/src/libcamera/formats.cpp b/src/libcamera/formats.cpp\n> index f5769c48..eda657c5 100644\n> --- a/src/libcamera/formats.cpp\n> +++ b/src/libcamera/formats.cpp\n> @@ -517,6 +517,16 @@ const std::map pixelFormatInfo{\n> \t\t.pixelsPerGroup = 4,\n> \t\t.planes = {{ { 5, 1 }, { 0, 0 }, { 0, 0 } }},\n> \t} },\n> +\t{ formats::Y10_IPU3, {\n> +\t\t.name = \"Y10_IPU3\",\n> +\t\t.format = formats::Y10_IPU3,\n> +\t\t.v4l2Formats = { V4L2PixelFormat(V4L2_PIX_FMT_IPU3_Y10), },\n> +\t\t.bitsPerPixel = 10,\n> +\t\t.colourEncoding = PixelFormatInfo::ColourEncodingRAW,\n> +\t\t.packed = true,\n> +\t\t.pixelsPerGroup = 25,\n> +\t\t.planes = {{ { 32, 1 }, { 0, 0 }, { 0, 0 } }},\n> +\t} },\n> \n> \t/* Bayer formats. */\n> \t{ formats::SBGGR8, {\n> diff --git a/src/libcamera/formats.yaml b/src/libcamera/formats.yaml\n> index e586cde1..36d3016d 100644\n> --- a/src/libcamera/formats.yaml\n> +++ b/src/libcamera/formats.yaml\n> @@ -161,4 +161,7 @@ formats:\n> - SBGGR10_IPU3:\n> fourcc: DRM_FORMAT_SBGGR10\n> mod: IPU3_FORMAT_MOD_PACKED\n> + - Y10_IPU3:\n\nThis should be named R10_IPU3. See the existing R10_CSI2P format.\n\n> + fourcc: DRM_FORMAT_Y10\n\nAnd you should use DRM_FORMAT_R10.\n\n> + mod: IPU3_FORMAT_MOD_PACKED\n> ...","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 39FC8BD80A\n\tfor ;\n\tSun, 19 Mar 2023 14:01:13 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 704B0626E2;\n\tSun, 19 Mar 2023 15:01:12 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 20F06626D4\n\tfor ;\n\tSun, 19 Mar 2023 15:01:11 +0100 (CET)","from pendragon.ideasonboard.com (85-76-162-78-nat.elisa-mobile.fi\n\t[85.76.162.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7ACE91858;\n\tSun, 19 Mar 2023 15:01:06 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1679234472;\n\tbh=r25VHaNozfvG6mdrz0QBuAV0cHFjHuLIaXQ0b9xoG3c=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=LyYk5HulzSCQZrEwGBosMotWEJfZImYREnCXCpyRsEonDXO11KDE4R4LdHF2MQ6DJ\n\t5L4M3B/9njpKumz/hDeWayIKY285ya8F/1OpDls3ywubnKmgKySQ3mik9by/6Uy1Am\n\tGi+AtswzM4sGf41R2+m6qwi5rWWelydn5eP8Ge+O6FwKZATsVkGuWyhHuIxM3d/gVs\n\tEz1BdYh3uwjXu665LhvQynx2xdvkGTksByTdRHS0hZSJ2wlpKSWgxWGryLZKIUdZwo\n\t9qUJ9IFdycIt7W81jcrPDRaF9ts3Ep4LghNbehjFYARg39PqEk8sgP4B0dy1tV8Ddx\n\tKBfhXppRyLnLQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1679234470;\n\tbh=r25VHaNozfvG6mdrz0QBuAV0cHFjHuLIaXQ0b9xoG3c=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=MbyMaAx7WJXXyjrWtrLN22pHI7WYP+VtMLQkc8uMuUA3LkrHmw5Ot9MeR4kSyoB1t\n\tOsMt2c6Ssu7at8R+g5DaJC7U7hmYRDphorT2+tx66o0HID6sLCeel+MDXSoMsjNZF5\n\tBKn9tLURG7VtuYwJur1Aa+qMx8X8kz3r55Kyn9Y8="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"MbyMaAx7\"; dkim-atps=neutral","Date":"Sun, 19 Mar 2023 16:01:02 +0200","To":"Daniel Scally ","Message-ID":"<20230319140102.GK10144@pendragon.ideasonboard.com>","References":"<20230318234014.29506-1-dan.scally@ideasonboard.com>\n\t<20230318234014.29506-4-dan.scally@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20230318234014.29506-4-dan.scally@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 03/11] libcamera/formats: Add IPU3_Y10\n\tformat","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]