[{"id":26665,"web_url":"https://patchwork.libcamera.org/comment/26665/","msgid":"<20230319135900.GJ10144@pendragon.ideasonboard.com>","date":"2023-03-19T13:59:00","subject":"Re: [libcamera-devel] [PATCH 02/11] include: drm_fourcc: Add Y10\n\tformat","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Dan,\n\nThank you for the patch.\n\nOn Sat, Mar 18, 2023 at 11:40:05PM +0000, Daniel Scally via libcamera-devel wrote:\n> Add a FourCC entry for the V4L2_PIX_FMT_Y10 image data format.\n> \n> Signed-off-by: Daniel Scally \n> ---\n> include/linux/drm_fourcc.h | 3 +++\n> 1 file changed, 3 insertions(+)\n> \n> diff --git a/include/linux/drm_fourcc.h b/include/linux/drm_fourcc.h\n> index 1496e097..b181a534 100644\n> --- a/include/linux/drm_fourcc.h\n> +++ b/include/linux/drm_fourcc.h\n> @@ -98,6 +98,9 @@ extern \"C\" {\n> /* Reserve 0 for the invalid format specifier */\n> #define DRM_FORMAT_INVALID\t0\n> \n> +/* 10 bpp greyscale */\n> +#define DRM_FORMAT_Y10\t\tfourcc_code('Y', '1', '0', ' ') /* [15:0] Y-only little endian*/\n\nFor historical reasons, greyscale formats are named \"R\" in DRM. We\nalready have DRM_FORMAT_R10 support, so you should be all set.\n\nBy the way, if you need to add a new DRM format in the future, the patch\nshould be sent to the kernel first.\n\n> /* color index */\n> #define DRM_FORMAT_C8\t\tfourcc_code('C', '8', ' ', ' ') /* [7:0] C */\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5B90EBD80A\n\tfor ;\n\tSun, 19 Mar 2023 13:59:15 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B06A1626D4;\n\tSun, 19 Mar 2023 14:59:14 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D8B0E626CA\n\tfor ;\n\tSun, 19 Mar 2023 14:59:12 +0100 (CET)","from pendragon.ideasonboard.com (85-76-162-78-nat.elisa-mobile.fi\n\t[85.76.162.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CB9201858;\n\tSun, 19 Mar 2023 14:59:07 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1679234354;\n\tbh=+lOvE/r99ODZbwuQrdqgzdEFAS3AWY49uuUDqmeJ1Zw=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=fLRjVd5jczHxZealAcG3fORwrZ4hN7gRat99qU/AaKXN82gEnf+EBgqzFFI6CSrt6\n\tRk38jm6XrEADdCfNiHLIJTXB2OMeAjmPWU/TPZ+PCwvzzi4sJirBo73m8BKGu+LGst\n\tg8hOwucOXR2VGK5ppflDFZM0yOYcN79ZCF0paEMlnExtBb4qU0M6lGV12hVQx2W9iE\n\tG2J+8jpxI13LLyGn55SkZydd/Ww28iFpdBFhBduVtO7MkPZRL4KxbGdG/sMUBctY6j\n\tFuLuY0LukIWRvvBn5FSd7L9wXn6XxCMfpqcYqfNcSPLO275FsbxyZZUkx0buwBJcfh\n\tSvfUYmFdWhYbw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1679234352;\n\tbh=+lOvE/r99ODZbwuQrdqgzdEFAS3AWY49uuUDqmeJ1Zw=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=g5MSCrMxpqp0ms59nbN196twXT3bs9dxDTJ/Szp8FAwXVA1aIFijPUqJ0uE9h/ycx\n\tFGYIm5Kg5Wwi6lOMuyAXZM3G00epcim53XvvZBW2rmolb/KXEJoBUm3PEA3+clbcTD\n\t7UiZny8PYYDQydeV0JsyL1i1ieuEzUMojQ/DmgLM="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"g5MSCrMx\"; dkim-atps=neutral","Date":"Sun, 19 Mar 2023 15:59:00 +0200","To":"Daniel Scally ","Message-ID":"<20230319135900.GJ10144@pendragon.ideasonboard.com>","References":"<20230318234014.29506-1-dan.scally@ideasonboard.com>\n\t<20230318234014.29506-3-dan.scally@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20230318234014.29506-3-dan.scally@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 02/11] include: drm_fourcc: Add Y10\n\tformat","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]