{"id":18400,"url":"https://patchwork.libcamera.org/api/patches/18400/?format=json","web_url":"https://patchwork.libcamera.org/patch/18400/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20230314144834.85193-9-dse@thaumatec.com>","date":"2023-03-14T14:48:32","name":"[libcamera-devel,v4,08/10] ipa: rkisp1: Add AF controls to the RkISP1 IPA","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"67131c39fa674e05630e892be219dc3f3375ee8e","submitter":{"id":126,"url":"https://patchwork.libcamera.org/api/people/126/?format=json","name":"Daniel Semkowicz","email":"dse@thaumatec.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/18400/mbox/","series":[{"id":3805,"url":"https://patchwork.libcamera.org/api/series/3805/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3805","date":"2023-03-14T14:48:24","name":"ipa: rkisp1: Add autofocus algorithm","version":4,"mbox":"https://patchwork.libcamera.org/series/3805/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/18400/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/18400/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CA7E3C329F\n\tfor ;\n\tTue, 14 Mar 2023 14:50:07 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5664A6273D;\n\tTue, 14 Mar 2023 15:50:07 +0100 (CET)","from mail-lj1-x230.google.com (mail-lj1-x230.google.com\n\t[IPv6:2a00:1450:4864:20::230])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AC76362717\n\tfor ;\n\tTue, 14 Mar 2023 15:49:56 +0100 (CET)","by mail-lj1-x230.google.com with SMTP id g18so16322041ljl.3\n\tfor ;\n\tTue, 14 Mar 2023 07:49:56 -0700 (PDT)","from localhost.localdomain ([91.90.166.178])\n\tby smtp.gmail.com with ESMTPSA id\n\tq25-20020a2eb4b9000000b00295a35f30e1sm470961ljm.115.2023.03.14.07.49.54\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 14 Mar 2023 07:49:55 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1678805407;\n\tbh=BjcrFEiQTZSm9P/GWdlS61dbmdphmJsI4G6x4WDNV8k=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=rZrX2t8JgCQYrq0dNud90arpH5n4O2gKnxj4IjfwXNnEA8jwgrtoAgCHULD5v+vnl\n\tzfuh9tMLzEf5saIF78lerpQaE0u55y3kQrKHvz5BXLpZZgbMMDFWhOWv7FjA+hJz04\n\tAP+SJjaZ5rp7t3OJJXLzdHR2A9e+W/DDXm2IC7ksRl3RNXoXYReS2cMkpzDUQYmHUB\n\t3Td6W2K+k/Ktdc8nt7NV065ba6FwpBY8t5VInH4slhsQyl/FG0d7E8iwz1mecpZzb8\n\tnqkBb1qVaaMT8PCw5hGUjtZDmYXF950fxCZgPRz+gFkyXCpQmC0BYvV5pN1zU3RefF\n\tbt47IQoJpwvIA==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=thaumatec-com.20210112.gappssmtp.com; s=20210112; t=1678805395;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=LRgW1NFPu4viMTf/MJ3llUErEThVQZNmL7f3XB7nmj0=;\n\tb=llo8xF8DBh4d4Nv3tE+yoEbzYTBRSdcVldWOiX7IbNrD5/GseRgbf7mc2qS2hunhdD\n\t0xY7HBgWhpIPjzTNfFQ7ccefILJWbMEb2nITkMndIpT7/zvTTGeGLlbrccr2DsTByARu\n\teXnTlZMXkeKIwP97Y0k7hmNiBy+gQzScrJyL3ifo0m9TuN7p0wQ/frkGseMldRooZaQT\n\t5yqXB6x7MNTc0lbCMHgGVtyaoA6LI+8mRPHHYOS2Ki2FrJNmUK/pC8ePagmdLoGYF1g6\n\toBC/4JRbOy+HpDaCk3XliZr5rDl/SHCib64iOE3HtbQvv+boQ0gBZRDoYJ4yCNA2yWi7\n\ttS5w=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected)\n\theader.d=thaumatec-com.20210112.gappssmtp.com\n\theader.i=@thaumatec-com.20210112.gappssmtp.com header.b=\"llo8xF8D\"; \n\tdkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112; t=1678805395;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=LRgW1NFPu4viMTf/MJ3llUErEThVQZNmL7f3XB7nmj0=;\n\tb=70nX30buugHTriL+JHM+KlKcXtJ68MY+PCBGSrqtor5ctfjvvCngtuPTraNuJBns5p\n\tlwIA8W4uXze3rF34687jiXTEcxVMWTWWEJXS3DVuItl/0cj3ljgHv4TdBw8FksHsG3Qp\n\teeRTnmoL6u+toyvvgRJdHYU/WV85B7A8P9RKsdXF6k3LiFMJTNmJqXgmspgrc+vaisnp\n\tM5Tigq7Tc2aahhyHdDZ64oQjDU+kUG2iegRKMP6jSgUUnyBoI4g6sHYNcE9VQT/JKBHq\n\tm8RayO62s/Nb6/MiM02lI1hUd61WmfSXBBZaZR/vXTz6Oza2lASV3ns7PIbXBQrVN/I6\n\tlndQ==","X-Gm-Message-State":"AO0yUKUXeodpTky9qrMb1z202He5Co7YeSVrS2MvwQ7N6Y4IYid17fZO\n\ttRxi7OJw4Ax8wUe9P+eoAMIpRn4wGKiK3CS32r0=","X-Google-Smtp-Source":"AK7set8QzPqibHMyzRPO6KSDAtwfhwxeAVGpWcNkKsN+6U/vJpFXMnqViPhh2II6D4t7RBQ3RIOp5g==","X-Received":"by 2002:a05:651c:2125:b0:293:2cec:9ebc with SMTP id\n\ta37-20020a05651c212500b002932cec9ebcmr15823042ljq.14.1678805395260; \n\tTue, 14 Mar 2023 07:49:55 -0700 (PDT)","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 14 Mar 2023 15:48:32 +0100","Message-Id":"<20230314144834.85193-9-dse@thaumatec.com>","X-Mailer":"git-send-email 2.39.2","In-Reply-To":"<20230314144834.85193-1-dse@thaumatec.com>","References":"<20230314144834.85193-1-dse@thaumatec.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v4 08/10] ipa: rkisp1: Add AF controls to\n\tthe RkISP1 IPA","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Daniel Semkowicz via libcamera-devel\n\t","Reply-To":"Daniel Semkowicz ","Cc":"jacopo.mondi@ideasonboard.com","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Add controls supported by the AF algorithm to the list of controls\nsupported by the RkISP1 IPA. This exposes the AF controls to the user\nand allows controlling the AF algorithm using the top level API.\n\nSigned-off-by: Daniel Semkowicz \n---\n src/ipa/rkisp1/rkisp1.cpp | 6 ++++++\n 1 file changed, 6 insertions(+)","diff":"diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\nindex cd1fbae3..4b30844f 100644\n--- a/src/ipa/rkisp1/rkisp1.cpp\n+++ b/src/ipa/rkisp1/rkisp1.cpp\n@@ -101,10 +101,16 @@ namespace {\n /* List of controls handled by the RkISP1 IPA */\n const ControlInfoMap::Map rkisp1Controls{\n \t{ &controls::AeEnable, ControlInfo(false, true) },\n+\t{ &controls::AfMetering, ControlInfo(controls::AfMeteringValues) },\n+\t{ &controls::AfMode, ControlInfo(controls::AfModeValues) },\n+\t{ &controls::AfPause, ControlInfo(controls::AfPauseValues) },\n+\t{ &controls::AfTrigger, ControlInfo(controls::AfTriggerValues) },\n+\t{ &controls::AfWindows, ControlInfo(Rectangle{}, Rectangle(65535, 65535, 65535, 65535), Rectangle{}) },\n \t{ &controls::AwbEnable, ControlInfo(false, true) },\n \t{ &controls::ColourGains, ControlInfo(0.0f, 3.996f, 1.0f) },\n \t{ &controls::Brightness, ControlInfo(-1.0f, 0.993f, 0.0f) },\n \t{ &controls::Contrast, ControlInfo(0.0f, 1.993f, 1.0f) },\n+\t{ &controls::LensPosition, ControlInfo(0.0f, 2147483647.0f) },\n \t{ &controls::Saturation, ControlInfo(0.0f, 1.993f, 1.0f) },\n \t{ &controls::Sharpness, ControlInfo(0.0f, 10.0f, 1.0f) },\n \t{ &controls::draft::NoiseReductionMode, ControlInfo(controls::draft::NoiseReductionModeValues) },\n","prefixes":["libcamera-devel","v4","08/10"]}