[{"id":2472,"web_url":"https://patchwork.libcamera.org/comment/2472/","msgid":"<20190819085839.eqxxxp67u2gitp3x@uno.localdomain>","date":"2019-08-19T08:58:39","subject":"Re: [libcamera-devel] [PATCH 03/14] qcam: Remove double stop of the\n\tcamera manager","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent,\n\nOn Sun, Aug 18, 2019 at 04:13:18AM +0300, Laurent Pinchart wrote:\n> The camera manager is stopped both in the destructor of the MainWindow\n> class and in the main() function. This double stop isn't needed, remove\n> the former and keep the latter as the manager is started in the main()\n> function.\n>\n\nRegardless the discussion on the CameraManager::instance() method,\nthis is a good change.\n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> Signed-off-by: Laurent Pinchart \n> ---\n> src/qcam/main_window.cpp | 2 --\n> 1 file changed, 2 deletions(-)\n>\n> diff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp\n> index dcb653e81a29..33fde8b10fd8 100644\n> --- a/src/qcam/main_window.cpp\n> +++ b/src/qcam/main_window.cpp\n> @@ -51,8 +51,6 @@ MainWindow::~MainWindow()\n> \t\tcamera_->release();\n> \t\tcamera_.reset();\n> \t}\n> -\n> -\tCameraManager::instance()->stop();\n> }\n>\n> void MainWindow::updateTitle()\n> --\n> Regards,\n>\n> Laurent Pinchart\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net\n\t[217.70.183.194])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9BDA760E38\n\tfor ;\n\tMon, 19 Aug 2019 10:57:11 +0200 (CEST)","from uno.localdomain (unknown [87.18.63.98])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay2-d.mail.gandi.net (Postfix) with ESMTPSA id EE92E40007;\n\tMon, 19 Aug 2019 08:57:10 +0000 (UTC)"],"X-Originating-IP":"87.18.63.98","Date":"Mon, 19 Aug 2019 10:58:39 +0200","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190819085839.eqxxxp67u2gitp3x@uno.localdomain>","References":"<20190818011329.14499-1-laurent.pinchart@ideasonboard.com>\n\t<20190818011329.14499-4-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"ljow2l6gwbvls5vp\"","Content-Disposition":"inline","In-Reply-To":"<20190818011329.14499-4-laurent.pinchart@ideasonboard.com>","User-Agent":"NeoMutt/20180716","Subject":"Re: [libcamera-devel] [PATCH 03/14] qcam: Remove double stop of the\n\tcamera manager","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 19 Aug 2019 08:57:11 -0000"}}]