[{"id":26924,"web_url":"https://patchwork.libcamera.org/comment/26924/","msgid":"","date":"2023-04-24T03:19:19","subject":"Re: [libcamera-devel] [PATCH v2 4/6] libcamera: camera_sensor: Add\n\ttryFormat()","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"On Mon, Mar 13, 2023 at 10:19:42AM +0100, Jacopo Mondi via libcamera-devel wrote:\n> Add a function to the CameraSensor class that allows to test a format\n> without applying it to the subdevice and without modifying any control\n> value associated with the camera sensor.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Paul Elder \n\n> ---\n> include/libcamera/internal/camera_sensor.h | 1 +\n> src/libcamera/camera_sensor.cpp | 17 +++++++++++++++++\n> 2 files changed, 18 insertions(+)\n> \n> diff --git a/include/libcamera/internal/camera_sensor.h b/include/libcamera/internal/camera_sensor.h\n> index 928c61af7f4e..02c77ab037da 100644\n> --- a/include/libcamera/internal/camera_sensor.h\n> +++ b/include/libcamera/internal/camera_sensor.h\n> @@ -56,6 +56,7 @@ public:\n> \t\t\t\t const Size &size) const;\n> \tint setFormat(V4L2SubdeviceFormat *format,\n> \t\t Transform transform = Transform::Identity);\n> +\tint tryFormat(V4L2SubdeviceFormat *format) const;\n> \n> \tconst ControlInfoMap &controls() const;\n> \tControlList getControls(const std::vector &ids);\n> diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\n> index e442b89dacd0..06f315210240 100644\n> --- a/src/libcamera/camera_sensor.cpp\n> +++ b/src/libcamera/camera_sensor.cpp\n> @@ -795,6 +795,23 @@ int CameraSensor::setFormat(V4L2SubdeviceFormat *format, Transform transform)\n> \treturn 0;\n> }\n> \n> +/**\n> + * \\brief Try the sensor output format\n> + * \\param[in] format The desired sensor output format\n> + *\n> + * The ranges of any controls associated with the sensor are not updated.\n> + *\n> + * \\todo Add support for Transform by changing the format's Bayer ordering\n> + * before calling subdev_->setFormat().\n> + *\n> + * \\return 0 on success or a negative error code otherwise\n> + */\n> +int CameraSensor::tryFormat(V4L2SubdeviceFormat *format) const\n> +{\n> +\treturn subdev_->setFormat(pad_, format,\n> +\t\t\t\t V4L2Subdevice::Whence::TryFormat);\n> +}\n> +\n> /**\n> * \\brief Retrieve the supported V4L2 controls and their information\n> *\n> -- \n> 2.39.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5440EC3272\n\tfor ;\n\tMon, 24 Apr 2023 03:19:33 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8A7B3627D5;\n\tMon, 24 Apr 2023 05:19:32 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DB47761EB1\n\tfor ;\n\tMon, 24 Apr 2023 05:19:28 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2001:f74:80a0:3200:ffb2:54d8:7f9:f3e8])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B12264AD;\n\tMon, 24 Apr 2023 05:19:17 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1682306372;\n\tbh=UBJMLnUyuTfA7lyzD9gmyXml+qzLVNirVNCxilBYuiw=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=NUfJRgQN/vqOaBXYBHBU/lDIkrjE4csFN+SJCEqeAoAEbPzFaoB2R1bbKdxZe//va\n\thvk1nDh8FN2k1xy/m0E50TjAK29c2pSm2DEkUieleTxRUtJ/CMDqKsg5N8IjIjghb5\n\tHLM6WHdq8kY+fMn0ZQNwmVYOs1dRIdRpmerzeTgtRUZeObArRI/x1bYwdliLY+AAJs\n\tErSATWu9zuA8/OswJMUNp1LcQpVuyAUvidP36o48XXz8zILVZgKdi9GXU7h0U5HAQU\n\tT/25GqZzajrFdJL2Cpblep4SAv2whkwNz5pQUrz91sJi7FfUZWtW8QIDaifigZNcis\n\t6jw0qT/AZS/Rw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1682306358;\n\tbh=UBJMLnUyuTfA7lyzD9gmyXml+qzLVNirVNCxilBYuiw=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=MetPCSftD0wSQlaDoFQ3s+N91ZY1Kbl1C/T7L9oglCixHqlsqPfqz1hI+P3pChv/i\n\tlC9lsaaaQq1MfLMJIsqdnCxiC4zBS8w8jY0YKl84LbwqMpog/uJFXaxAUx7zmqSNxZ\n\tB94YB277MqEIvSW1zvyhFJhtZNfq4joFv8qAQj2k="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"MetPCSft\"; dkim-atps=neutral","Date":"Mon, 24 Apr 2023 12:19:19 +0900","To":"Jacopo Mondi ","Message-ID":"","References":"<20230313091944.9530-1-jacopo.mondi@ideasonboard.com>\n\t<20230313091944.9530-5-jacopo.mondi@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20230313091944.9530-5-jacopo.mondi@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2 4/6] libcamera: camera_sensor: Add\n\ttryFormat()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Paul Elder via libcamera-devel ","Reply-To":"Paul Elder ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]