[{"id":2470,"web_url":"https://patchwork.libcamera.org/comment/2470/","msgid":"<20190819085701.buao6ucsyi4e7gcp@uno.localdomain>","date":"2019-08-19T08:57:01","subject":"Re: [libcamera-devel] [PATCH 01/14] libcamera: device_enumerator:\n\tPrint media device name in error message","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent,\n\nOn Sun, Aug 18, 2019 at 04:13:16AM +0300, Laurent Pinchart wrote:\n> The device enumerator logs an error message when a media device is\n> removed while still in use. Add the device name to the message to help\n> debugging.\n>\n> Signed-off-by: Laurent Pinchart \n> ---\n> src/libcamera/device_enumerator.cpp | 3 ++-\n> 1 file changed, 2 insertions(+), 1 deletion(-)\n>\n> diff --git a/src/libcamera/device_enumerator.cpp b/src/libcamera/device_enumerator.cpp\n> index 6fcbae76b64e..60c918f0e26f 100644\n> --- a/src/libcamera/device_enumerator.cpp\n> +++ b/src/libcamera/device_enumerator.cpp\n> @@ -166,7 +166,8 @@ DeviceEnumerator::~DeviceEnumerator()\n> \tfor (std::shared_ptr media : devices_) {\n> \t\tif (media->busy())\n> \t\t\tLOG(DeviceEnumerator, Error)\n> -\t\t\t\t<< \"Removing media device while still in use\";\n> +\t\t\t\t<< \"Removing media device \" << media->deviceNode()\n> +\t\t\t\t<< \" while still in use\";\n\njust wondering if we want quotes around the media device name.\n\nApart for this minor\nReviewed-by: Jacopo Mondi \n\n> \t}\n> }\n>\n> --\n> Regards,\n>\n> Laurent Pinchart\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from relay10.mail.gandi.net (relay10.mail.gandi.net\n\t[217.70.178.230])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CDD6060E38\n\tfor ;\n\tMon, 19 Aug 2019 10:55:33 +0200 (CEST)","from uno.localdomain (unknown [87.18.63.98])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay10.mail.gandi.net (Postfix) with ESMTPSA id 3E77B240003;\n\tMon, 19 Aug 2019 08:55:32 +0000 (UTC)"],"Date":"Mon, 19 Aug 2019 10:57:01 +0200","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190819085701.buao6ucsyi4e7gcp@uno.localdomain>","References":"<20190818011329.14499-1-laurent.pinchart@ideasonboard.com>\n\t<20190818011329.14499-2-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"65q4fx52biur7t4q\"","Content-Disposition":"inline","In-Reply-To":"<20190818011329.14499-2-laurent.pinchart@ideasonboard.com>","User-Agent":"NeoMutt/20180716","Subject":"Re: [libcamera-devel] [PATCH 01/14] libcamera: device_enumerator:\n\tPrint media device name in error message","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 19 Aug 2019 08:55:34 -0000"}},{"id":2488,"web_url":"https://patchwork.libcamera.org/comment/2488/","msgid":"<20190819150706.GI5011@pendragon.ideasonboard.com>","date":"2019-08-19T15:07:06","subject":"Re: [libcamera-devel] [PATCH 01/14] libcamera: device_enumerator:\n\tPrint media device name in error message","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nOn Mon, Aug 19, 2019 at 10:57:01AM +0200, Jacopo Mondi wrote:\n> On Sun, Aug 18, 2019 at 04:13:16AM +0300, Laurent Pinchart wrote:\n> > The device enumerator logs an error message when a media device is\n> > removed while still in use. Add the device name to the message to help\n> > debugging.\n> >\n> > Signed-off-by: Laurent Pinchart \n> > ---\n> > src/libcamera/device_enumerator.cpp | 3 ++-\n> > 1 file changed, 2 insertions(+), 1 deletion(-)\n> >\n> > diff --git a/src/libcamera/device_enumerator.cpp b/src/libcamera/device_enumerator.cpp\n> > index 6fcbae76b64e..60c918f0e26f 100644\n> > --- a/src/libcamera/device_enumerator.cpp\n> > +++ b/src/libcamera/device_enumerator.cpp\n> > @@ -166,7 +166,8 @@ DeviceEnumerator::~DeviceEnumerator()\n> > \tfor (std::shared_ptr media : devices_) {\n> > \t\tif (media->busy())\n> > \t\t\tLOG(DeviceEnumerator, Error)\n> > -\t\t\t\t<< \"Removing media device while still in use\";\n> > +\t\t\t\t<< \"Removing media device \" << media->deviceNode()\n> > +\t\t\t\t<< \" while still in use\";\n> \n> just wondering if we want quotes around the media device name.\n\nI tend to use quotes only when the string can be empty or can include\nspaces. In this case I think they're not needed.\n\n> Apart for this minor\n> Reviewed-by: Jacopo Mondi \n> \n> > \t}\n> > }\n> >","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id ED67360C1E\n\tfor ;\n\tMon, 19 Aug 2019 17:07:11 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5B9C0510;\n\tMon, 19 Aug 2019 17:07:11 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1566227231;\n\tbh=8JMf/Y+ciDyqFL+7WbSZJLuS/JyvBk9DcuJtkDx0xCo=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=F96o4JMQDbrx/O7P1r/iYyfBWBCZRgvEZY/aVwQNBNApobiYuzzg74Ax4xmbr9Ciq\n\t8tzHZs8l6d+UURykO0glqh7KaecUP2BzX9eDumqLuXPlN7YLDpkUfDaZ0pVi2m3ubM\n\tpbyi2YY+yt7ty8n6Kt3QuYKSKQicKc4ngWC0qAqg=","Date":"Mon, 19 Aug 2019 18:07:06 +0300","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190819150706.GI5011@pendragon.ideasonboard.com>","References":"<20190818011329.14499-1-laurent.pinchart@ideasonboard.com>\n\t<20190818011329.14499-2-laurent.pinchart@ideasonboard.com>\n\t<20190819085701.buao6ucsyi4e7gcp@uno.localdomain>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20190819085701.buao6ucsyi4e7gcp@uno.localdomain>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 01/14] libcamera: device_enumerator:\n\tPrint media device name in error message","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 19 Aug 2019 15:07:12 -0000"}}]