{"id":18375,"url":"https://patchwork.libcamera.org/api/patches/18375/?format=json","web_url":"https://patchwork.libcamera.org/patch/18375/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20230309142601.70556-15-tomi.valkeinen@ideasonboard.com>","date":"2023-03-09T14:26:00","name":"[libcamera-devel,v4,14/15] py: Improve stub type generation for PyCameraEvent","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"b42e87234410e978d962e7b23f66d5d799eabb7e","submitter":{"id":109,"url":"https://patchwork.libcamera.org/api/people/109/?format=json","name":"Tomi Valkeinen","email":"tomi.valkeinen@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/18375/mbox/","series":[{"id":3796,"url":"https://patchwork.libcamera.org/api/series/3796/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3796","date":"2023-03-09T14:25:46","name":"py: New python bindings event handling","version":4,"mbox":"https://patchwork.libcamera.org/series/3796/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/18375/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/18375/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3A1DFC32A5\n\tfor ;\n\tThu, 9 Mar 2023 14:26:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C431762715;\n\tThu, 9 Mar 2023 15:26:30 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F1949626F5\n\tfor ;\n\tThu, 9 Mar 2023 15:26:21 +0100 (CET)","from desky.lan (91-154-32-225.elisa-laajakaista.fi [91.154.32.225])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8C577589;\n\tThu, 9 Mar 2023 15:26:21 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1678371990;\n\tbh=5FwgOSzFtXbcHkPOsawNfIsu3wCs2lDtN23afzfYdJg=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=CWOpzUrgCBi43wsp2GI943e9o3jMptiOtT0E29TfYtPbw/gOJW6X5KoKmf/W/gRXN\n\tHHw9NFBeCyBEmJnws7QhRWlf0441U4Ko8qTiSBZ1YdnHZz/FelCb6VR28FLr9pWOqc\n\tW0tMvwDqowFbo+PCEu7bQ6CHqRzhdmIsWBpKKRtunb0UetB6fzQOueYewmtSqOZ+7L\n\teVQzimXE0Pwr7JBDJMiwVq4Kz+HgTpmgjhBAlQZbyY8jsDzGbOn97i7den8hMmY1Uc\n\t/gzMKMGhPOpWn3dcuCXxAHc+OGeWoMJZ7LxgCPAjRsDQKf1m9EkJVylPaG3ajdP6II\n\tT0fcvpDZaKaHA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1678371981;\n\tbh=5FwgOSzFtXbcHkPOsawNfIsu3wCs2lDtN23afzfYdJg=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=DH7UYVkUD427sYhVd0n37rhXgXGVEe5n870PsdaUccwHfeAjwqrCqOtbe6mYr+vDq\n\t3UsLscvgPf1XAlvRF541WoYBB9O+RCzBnDX0tgFvAMj/dfJ155kbb7A5tyGo16hLkR\n\tGHk7eQGciGJAI52B6NSBaPUlyEeWrM2j+hYv/x9o="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"DH7UYVkU\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 9 Mar 2023 16:26:00 +0200","Message-Id":"<20230309142601.70556-15-tomi.valkeinen@ideasonboard.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20230309142601.70556-1-tomi.valkeinen@ideasonboard.com>","References":"<20230309142601.70556-1-tomi.valkeinen@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v4 14/15] py: Improve stub type generation\n\tfor PyCameraEvent","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Tomi Valkeinen via libcamera-devel\n\t","Reply-To":"Tomi Valkeinen ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"We store the camera, request and fb fields in PyCameraEvent as\npy::objects, so that we keep the refs and keep-alives. When we\nreturn py::objects to the Python side, they, obviously, show up\nas \"objects\" when the stub generation is looking at the fields.\n\nFix this by manually casting the py::objects to the correct C++\ncounterparts, which causes pybind11 to assign the correct types for the\nproperties, helpind stubgen to generate correct types.\n\nSigned-off-by: Tomi Valkeinen \n---\n src/py/libcamera/py_main.cpp | 14 +++++++++++---\n 1 file changed, 11 insertions(+), 3 deletions(-)","diff":"diff --git a/src/py/libcamera/py_main.cpp b/src/py/libcamera/py_main.cpp\nindex 1585b14a..cb7088b1 100644\n--- a/src/py/libcamera/py_main.cpp\n+++ b/src/py/libcamera/py_main.cpp\n@@ -100,11 +100,19 @@ PYBIND11_MODULE(_libcamera, m)\n \t\t.value(\"RequestCompleted\", CameraEventType::RequestCompleted)\n \t\t.value(\"BufferCompleted\", CameraEventType::BufferCompleted);\n \n+\t/*\n+\t * For camera, request and fb fields, manually typecast to the C++ type,\n+\t * so that pybind11 assigns the actual type for the return value. This\n+\t * makes the stubs generated by pybind11-stubgen contain the correct type,\n+\t * instead of \"object\".\n+\t *\n+\t * Maybe there's a better way to do this...\n+\t */\n \tpyEvent\n \t\t.def_readonly(\"type\", &PyCameraEvent::type_)\n-\t\t.def_readonly(\"camera\", &PyCameraEvent::camera_)\n-\t\t.def_readonly(\"request\", &PyCameraEvent::request_)\n-\t\t.def_readonly(\"fb\", &PyCameraEvent::fb_);\n+\t\t.def_property_readonly(\"camera\", [](PyCameraEvent &self) { return self.camera_.cast(); })\n+\t\t.def_property_readonly(\"request\", [](PyCameraEvent &self) { return self.request_.cast(); })\n+\t\t.def_property_readonly(\"fb\", [](PyCameraEvent &self) { return self.fb_.cast(); });\n \n \tpyCameraManager\n \t\t.def_static(\"singleton\", []() {\n","prefixes":["libcamera-devel","v4","14/15"]}