[{"id":26632,"web_url":"https://patchwork.libcamera.org/comment/26632/","msgid":"<20230312150504.GR2545@pendragon.ideasonboard.com>","date":"2023-03-12T15:05:04","subject":"Re: [libcamera-devel] [PATCH v4 12/15] py: unittests.py: Fix type\n\tchecker warnings","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Tomi,\n\nThank you for the patch.\n\nOn Thu, Mar 09, 2023 at 04:25:58PM +0200, Tomi Valkeinen via libcamera-devel wrote:\n\nPlease add a commit message.\n\nReviewed-by: Laurent Pinchart \n\n> Signed-off-by: Tomi Valkeinen \n> ---\n> test/py/unittests.py | 4 +---\n> 1 file changed, 1 insertion(+), 3 deletions(-)\n> \n> diff --git a/test/py/unittests.py b/test/py/unittests.py\n> index b52b3391..9fd8730e 100755\n> --- a/test/py/unittests.py\n> +++ b/test/py/unittests.py\n> @@ -4,11 +4,9 @@\n> # Copyright (C) 2022, Tomi Valkeinen \n> \n> from collections import defaultdict\n> -import errno\n> import gc\n> import libcamera as libcam\n> import selectors\n> -import time\n> import typing\n> import unittest\n> import weakref\n> @@ -406,7 +404,7 @@ class SimpleCaptureMethods(CameraTesterBase):\n> running = True\n> while running:\n> events = sel.select()\n> - for key, _ in events:\n> + for _ in events:\n> for ev in cm.get_events():\n> self.assertEqual(ev.type, libcam.Event.Type.RequestCompleted)\n> reqs.append(ev.request)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DC972BE080\n\tfor ;\n\tSun, 12 Mar 2023 15:05:04 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 958AA6270A;\n\tSun, 12 Mar 2023 16:05:04 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 961DA62706\n\tfor ;\n\tSun, 12 Mar 2023 16:05:03 +0100 (CET)","from pendragon.ideasonboard.com (85-76-21-162-nat.elisa-mobile.fi\n\t[85.76.21.162])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id F1CA4814;\n\tSun, 12 Mar 2023 16:05:02 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1678633504;\n\tbh=h2LHWShd9W7Jw1IfpfYc1WhbR3M3e/UQdaAcdBqUGz4=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=MHpPfjmb6/FIEjbjgXd5wvZaym8AKzgAfQvq9w0Wm1Lpbj42kuTaxblgZGUCtjtd6\n\tnGVFPeO+qzZ0aaD78cNDshdZzeRwhbTU1oImqzUGgClJzZYBpsB3HVT2OoV9fc3gT9\n\trqYrOyLRchTgkCqol1eWB8KZhe0bEi4s9TGlzcCnA70PVgFGNe98bbPGePXryPU7HM\n\tiOZIxl0cZl3ZkUmrhRM8F+ari2dTlmKTLFs3nJScGZ5KKRsCg9teqsnPlgr8DEgRp+\n\tw9Vd6zYPfn2ItVGEs3kDYtUzORzRHkP5AtRDMFXxYg4/lGehASvJCaHCPAzWN5Aa0V\n\tT2lZm9Orc3DEQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1678633503;\n\tbh=h2LHWShd9W7Jw1IfpfYc1WhbR3M3e/UQdaAcdBqUGz4=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=nQ7t8ECTmVQlieGUo0s25/AXXbVtsG6r2tW7+AuwrPx0xAB6OiIm9XgCFYPcTUI+r\n\tsbKkA2wcwuE258b1aI8Jn5CGKLF1Zw3EebMnKptH6cINHUgQ75i3X/Vi09v+1aBxMz\n\tCoWjOLPnOkBrjLkf98/fmG9zOYV97RsHBtIVH21g="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"nQ7t8ECT\"; dkim-atps=neutral","Date":"Sun, 12 Mar 2023 17:05:04 +0200","To":"Tomi Valkeinen ","Message-ID":"<20230312150504.GR2545@pendragon.ideasonboard.com>","References":"<20230309142601.70556-1-tomi.valkeinen@ideasonboard.com>\n\t<20230309142601.70556-13-tomi.valkeinen@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20230309142601.70556-13-tomi.valkeinen@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v4 12/15] py: unittests.py: Fix type\n\tchecker warnings","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]