[{"id":26631,"web_url":"https://patchwork.libcamera.org/comment/26631/","msgid":"<20230312150402.GQ2545@pendragon.ideasonboard.com>","date":"2023-03-12T15:04:02","subject":"Re: [libcamera-devel] [PATCH v4 11/15] py: unittests.py: Add test\n\tfor refs & keep-alives","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Tomi,\n\nThank you for the patch.\n\nOn Thu, Mar 09, 2023 at 04:25:57PM +0200, Tomi Valkeinen via libcamera-devel wrote:\n> Add a test for references and keep-alives by doing a capture, reusing\n> the Requests once and testing that the objects are freed as soon as all\n> the refs and keep-alives are gone.\n> \n> Signed-off-by: Tomi Valkeinen \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> test/py/unittests.py | 128 +++++++++++++++++++++++++++++++++++++++++++\n> 1 file changed, 128 insertions(+)\n> \n> diff --git a/test/py/unittests.py b/test/py/unittests.py\n> index 3bd2d7fd..b52b3391 100755\n> --- a/test/py/unittests.py\n> +++ b/test/py/unittests.py\n> @@ -31,6 +31,134 @@ class BaseTestCase(unittest.TestCase):\n> self.assertTrue(all([not wr() for wr in wr_list]), msg)\n> \n> \n> +# Test references and keep-alives by doing a capture, reusing the Requests once\n> +# and testing that the objects are freed as soon as all the refs and keep-alives\n> +# are gone.\n> +class CaptureRefTestMethods(BaseTestCase):\n> + def test_ref(self):\n> + cm = libcam.CameraManager.singleton()\n> + wr_cm = weakref.ref(cm)\n> +\n> + cam = cm.get('platform/vimc.0 Sensor B')\n> + self.assertIsNotNone(cam)\n> + wr_cam = weakref.ref(cam)\n> +\n> + cam.acquire()\n> +\n> + camconfig = cam.generate_configuration([libcam.StreamRole.StillCapture])\n> + self.assertTrue(camconfig.size == 1)\n> + wr_camconfig = weakref.ref(camconfig)\n> +\n> + streamconfig = camconfig.at(0)\n> + wr_streamconfig = weakref.ref(streamconfig)\n> +\n> + cam.configure(camconfig)\n> +\n> + stream = streamconfig.stream\n> + wr_stream = weakref.ref(stream)\n> +\n> + # stream keeps streamconfig and camconfig alive\n> + del streamconfig\n> + del camconfig\n> + gc.collect()\n> + self.assertIsAlive(wr_camconfig)\n> + self.assertIsAlive(wr_streamconfig)\n> +\n> + allocator = libcam.FrameBufferAllocator(cam)\n> + num_bufs = allocator.allocate(stream)\n> + self.assertTrue(num_bufs > 0)\n> + wr_allocator = weakref.ref(allocator)\n> +\n> + buffers = allocator.buffers(stream)\n> + self.assertIsNotNone(buffers)\n> +\n> + wr_buffers = [weakref.ref(b) for b in buffers]\n> +\n> + del allocator\n> + self.assertIsAlive(wr_allocator)\n> +\n> + reqs = []\n> + wr_reqs = []\n> + for i in range(num_bufs):\n> + req = cam.create_request(i)\n> + self.assertIsNotNone(req)\n> +\n> + wr_reqs.append(weakref.ref(req))\n> +\n> + req.add_buffer(stream, buffers[i])\n> +\n> + reqs.append(req)\n> +\n> + del buffers\n> + del stream\n> +\n> + self.assertIsDead(wr_stream)\n> +\n> + cam.start()\n> +\n> + reqs_target = num_bufs * 2\n> + reqs_queued = 0\n> + reqs_captured = 0\n> +\n> + for req in reqs:\n> + cam.queue_request(req)\n> + reqs_queued += 1\n> +\n> + del req\n> + del reqs\n> +\n> + # All buffers and reqs should be alive\n> + self.assertIsAllAlive(wr_buffers)\n> + self.assertIsAllAlive(wr_reqs)\n> +\n> + sel = selectors.DefaultSelector()\n> + sel.register(cm.event_fd, selectors.EVENT_READ)\n> +\n> + while True:\n> + events = sel.select()\n> + if not events:\n> + continue\n> + del events\n> +\n> + for ev in cm.get_events():\n> + self.assertEqual(ev.type, libcam.Event.Type.RequestCompleted)\n> +\n> + reqs_captured += 1\n> + self.assertLessEqual(reqs_captured, reqs_target)\n> +\n> + if reqs_queued < reqs_target:\n> + req: libcam.Request = typing.cast(libcam.Request, ev.request)\n> + req.reuse()\n> + cam.queue_request(req)\n> + reqs_queued += 1\n> + del req\n> +\n> + del ev\n> +\n> + if reqs_captured == reqs_target:\n> + break\n> +\n> + del sel\n> +\n> + # The allocator and all buffers and reqs should be dead\n> + self.assertIsAllDead(wr_buffers)\n> + self.assertIsAllDead(wr_reqs)\n> + self.assertIsDead(wr_allocator)\n> +\n> + events = cam.stop()\n> + self.assertZero(len(events))\n> + del events\n> + cam.release()\n> +\n> + del cm\n> + self.assertIsAlive(wr_cm)\n> + self.assertIsAlive(wr_cam)\n> +\n> + del cam\n> + self.assertIsDead(wr_cam)\n> + self.assertIsDead(wr_cm)\n> +\n> +\n> class SimpleTestMethods(BaseTestCase):\n> def test_get_ref(self):\n> cm = libcam.CameraManager.singleton()","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B0701BE080\n\tfor ;\n\tSun, 12 Mar 2023 15:04:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 072A662706;\n\tSun, 12 Mar 2023 16:04:03 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A683E62705\n\tfor ;\n\tSun, 12 Mar 2023 16:04:01 +0100 (CET)","from pendragon.ideasonboard.com (85-76-21-162-nat.elisa-mobile.fi\n\t[85.76.21.162])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A6144814;\n\tSun, 12 Mar 2023 16:04:00 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1678633443;\n\tbh=oZYWb8ln8wRpubuM8O4Uokhv9EN0gLLbycrZglS82Do=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=oIzLfw2H8Bi8yYAV9ozhkUXUKFDa15gRG1xLpLZZtXgQ3/e7KnrK6G+mS9cNUJlMz\n\tws2FvI2pSFroyYXhPl6/ETFuT/WjBF96vB24hknktjbvevQ0kwosPhYlSsIBXVxKpJ\n\tP39o9ris+t3YRf4GNXlSHRaaPkA3KZh5ccFtwagjpEm+H6LEBFhXe2CnFt/XRNqseS\n\tBdk3X+A9ava53LdUa7ABwTuS33UeDRcjfXoU+tAoQYgnGUqgc+RWSea21lN+n2x+22\n\tEXO0QyhR29Wd6pCqZQqDvNiS8TbJIUKTUvXhwa8hoXYBGqkb8g5A85YLK/m1qkDsKa\n\tGB5xvKpQxTn8A==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1678633441;\n\tbh=oZYWb8ln8wRpubuM8O4Uokhv9EN0gLLbycrZglS82Do=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=AvsEBGyXlC7of3y+dybDKFu1RK/BF4QQxkzAovyLXqP0YBvITtFCwP6EPzumJAE8Y\n\tzosEd/jgDDHkpb9b9XAruofG/pGehyL8U3Vk3hBhap51qjiTAFcvphm8crOUA8Dqb7\n\tAQVksrNS1JVMLUBLgnFRsA1EBn8MIPWvbilde7NQ="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"AvsEBGyX\"; dkim-atps=neutral","Date":"Sun, 12 Mar 2023 17:04:02 +0200","To":"Tomi Valkeinen ","Message-ID":"<20230312150402.GQ2545@pendragon.ideasonboard.com>","References":"<20230309142601.70556-1-tomi.valkeinen@ideasonboard.com>\n\t<20230309142601.70556-12-tomi.valkeinen@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20230309142601.70556-12-tomi.valkeinen@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v4 11/15] py: unittests.py: Add test\n\tfor refs & keep-alives","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]