[{"id":26630,"web_url":"https://patchwork.libcamera.org/comment/26630/","msgid":"<20230312145454.GP2545@pendragon.ideasonboard.com>","date":"2023-03-12T14:54:54","subject":"Re: [libcamera-devel] [PATCH v4 10/15] py: unittests.py: Add\n\tweakref helpers and use del","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Tomi,\n\nThank you for the patch.\n\nOn Thu, Mar 09, 2023 at 04:25:56PM +0200, Tomi Valkeinen via libcamera-devel wrote:\n> Add helpers to check if a weakref or a list of weakrefs is alive or\n> dead.\n> \n> Also use 'del' for local variables instead of setting the variable to\n> None. This makes debugging the test easier as the locals will be gone\n> from locals() dict.\n> \n> Signed-off-by: Tomi Valkeinen \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> test/py/unittests.py | 60 ++++++++++++++++++++++++++------------------\n> 1 file changed, 36 insertions(+), 24 deletions(-)\n> \n> diff --git a/test/py/unittests.py b/test/py/unittests.py\n> index fab791d1..3bd2d7fd 100755\n> --- a/test/py/unittests.py\n> +++ b/test/py/unittests.py\n> @@ -18,6 +18,18 @@ class BaseTestCase(unittest.TestCase):\n> def assertZero(self, a, msg=None):\n> self.assertEqual(a, 0, msg)\n> \n> + def assertIsAlive(self, wr, msg='object not alive'):\n> + self.assertIsNotNone(wr(), msg)\n> +\n> + def assertIsDead(self, wr, msg='object not dead'):\n> + self.assertIsNone(wr(), msg)\n> +\n> + def assertIsAllAlive(self, wr_list, msg='object not alive'):\n> + self.assertTrue(all([wr() for wr in wr_list]), msg)\n> +\n> + def assertIsAllDead(self, wr_list, msg='object not dead'):\n> + self.assertTrue(all([not wr() for wr in wr_list]), msg)\n> +\n> \n> class SimpleTestMethods(BaseTestCase):\n> def test_get_ref(self):\n> @@ -28,14 +40,14 @@ class SimpleTestMethods(BaseTestCase):\n> self.assertIsNotNone(cam)\n> wr_cam = weakref.ref(cam)\n> \n> - cm = None\n> + del cm\n> gc.collect()\n> - self.assertIsNotNone(wr_cm())\n> + self.assertIsAlive(wr_cm)\n> \n> - cam = None\n> + del cam\n> gc.collect()\n> - self.assertIsNone(wr_cm())\n> - self.assertIsNone(wr_cam())\n> + self.assertIsDead(wr_cm)\n> + self.assertIsDead(wr_cam)\n> \n> def test_acquire_release(self):\n> cm = libcam.CameraManager.singleton()\n> @@ -89,8 +101,8 @@ class CameraTesterBase(BaseTestCase):\n> self.cam = None\n> self.cm = None\n> \n> - self.assertIsNone(self.wr_cm())\n> - self.assertIsNone(self.wr_cam())\n> + self.assertIsDead(self.wr_cm)\n> + self.assertIsDead(self.wr_cam)\n> \n> \n> class AllocatorTestMethods(CameraTesterBase):\n> @@ -110,11 +122,11 @@ class AllocatorTestMethods(CameraTesterBase):\n> wr_stream = weakref.ref(stream)\n> \n> # stream should keep streamconfig and camconfig alive\n> - streamconfig = None\n> - camconfig = None\n> + del streamconfig\n> + del camconfig\n> gc.collect()\n> - self.assertIsNotNone(wr_camconfig())\n> - self.assertIsNotNone(wr_streamconfig())\n> + self.assertIsAlive(wr_camconfig)\n> + self.assertIsAlive(wr_streamconfig)\n> \n> allocator = libcam.FrameBufferAllocator(cam)\n> num_bufs = allocator.allocate(stream)\n> @@ -123,29 +135,29 @@ class AllocatorTestMethods(CameraTesterBase):\n> \n> buffers = allocator.buffers(stream)\n> self.assertIsNotNone(buffers)\n> - buffers = None\n> + del buffers\n> \n> buffer = allocator.buffers(stream)[0]\n> self.assertIsNotNone(buffer)\n> wr_buffer = weakref.ref(buffer)\n> \n> - allocator = None\n> + del allocator\n> gc.collect()\n> - self.assertIsNotNone(wr_buffer())\n> - self.assertIsNotNone(wr_allocator())\n> - self.assertIsNotNone(wr_stream())\n> + self.assertIsAlive(wr_buffer)\n> + self.assertIsAlive(wr_allocator)\n> + self.assertIsAlive(wr_stream)\n> \n> - buffer = None\n> + del buffer\n> gc.collect()\n> - self.assertIsNone(wr_buffer())\n> - self.assertIsNone(wr_allocator())\n> - self.assertIsNotNone(wr_stream())\n> + self.assertIsDead(wr_buffer)\n> + self.assertIsDead(wr_allocator)\n> + self.assertIsAlive(wr_stream)\n> \n> - stream = None\n> + del stream\n> gc.collect()\n> - self.assertIsNone(wr_stream())\n> - self.assertIsNone(wr_camconfig())\n> - self.assertIsNone(wr_streamconfig())\n> + self.assertIsDead(wr_stream)\n> + self.assertIsDead(wr_camconfig)\n> + self.assertIsDead(wr_streamconfig)\n> \n> \n> class SimpleCaptureMethods(CameraTesterBase):","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 74C3EBD80A\n\tfor ;\n\tSun, 12 Mar 2023 14:54:55 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E845262709;\n\tSun, 12 Mar 2023 15:54:54 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 34B1B62705\n\tfor ;\n\tSun, 12 Mar 2023 15:54:54 +0100 (CET)","from pendragon.ideasonboard.com (85-76-21-162-nat.elisa-mobile.fi\n\t[85.76.21.162])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2D883814;\n\tSun, 12 Mar 2023 15:54:52 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1678632894;\n\tbh=mvdB7+dqh6bmoie908j8GvFT3YLzs+rH6ZUBqw9m4EQ=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=a/HQNyjhozutvXHy3rYmB2fQOFR2od9dEg6qiB1Q3bjZ5/F+Mbs2Lt1cVYkp3UVIc\n\tKgskQX7H7hUz0A6r1rOGdObFzpUy5M/nerkO3Jr2VESVgJazksOL26/MndU7xRiKz0\n\t0AKMrPt5BkhatnKGb7PqlG7Qxqe0AXwNqdFf9j0t9vwcw5maiplyHA/8Id1RuZcMJ6\n\tWY+CCiOTzxMCm8nxeNBnOAvNY2uI+RskIP1cf0ea/91kIiqoK3o+sc9uyazdfNTQk0\n\ts/4FwAR8Dg+PjTEmCqT5NgWytkB8COa8qGJI8w0BNr3IrEvfMwJ8PzeDU/NHNr95pr\n\tW4aBo3J+sY8Xw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1678632893;\n\tbh=mvdB7+dqh6bmoie908j8GvFT3YLzs+rH6ZUBqw9m4EQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=tQ+dac22hTg8y/YDOSh6FeEyr1HbKbKmjXtlWMdD57/jrPfgthKqV4GrKC95U2kzP\n\tf9O9ZMv2isQOpaXchTmokxAC0npwn7Dkl0lx7sS6CE/mCrTSV8tcF6OWKgJKz9oTAO\n\t4w4uxZlJkAZcfIRUM+NbKYy89xFAbTnMvDanUjmc="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"tQ+dac22\"; dkim-atps=neutral","Date":"Sun, 12 Mar 2023 16:54:54 +0200","To":"Tomi Valkeinen ","Message-ID":"<20230312145454.GP2545@pendragon.ideasonboard.com>","References":"<20230309142601.70556-1-tomi.valkeinen@ideasonboard.com>\n\t<20230309142601.70556-11-tomi.valkeinen@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20230309142601.70556-11-tomi.valkeinen@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v4 10/15] py: unittests.py: Add\n\tweakref helpers and use del","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]