[{"id":26614,"web_url":"https://patchwork.libcamera.org/comment/26614/","msgid":"<20230309160025.GE1088@pendragon.ideasonboard.com>","date":"2023-03-09T16:00:25","subject":"Re: [libcamera-devel] [PATCH v4 08/15] py: Drop get_ready_requests()","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Tomi,\n\nThank you for the patch.\n\nOn Thu, Mar 09, 2023 at 04:25:54PM +0200, Tomi Valkeinen via libcamera-devel wrote:\n> get_ready_requests() is deprecated, and the Python code in libcamera has\n> been converted to the new event system, so we can drop\n> get_ready_requests().\n> \n> Signed-off-by: Tomi Valkeinen \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/py/libcamera/py_camera_manager.cpp | 24 ------------------------\n> src/py/libcamera/py_camera_manager.h | 1 -\n> src/py/libcamera/py_main.cpp | 3 ---\n> 3 files changed, 28 deletions(-)\n> \n> diff --git a/src/py/libcamera/py_camera_manager.cpp b/src/py/libcamera/py_camera_manager.cpp\n> index 7d6dded4..c3b9646f 100644\n> --- a/src/py/libcamera/py_camera_manager.cpp\n> +++ b/src/py/libcamera/py_camera_manager.cpp\n> @@ -103,30 +103,6 @@ PyCameraEvent PyCameraManager::convertEvent(const CameraEvent &event)\n> \treturn pyevent;\n> }\n> \n> -/* DEPRECATED */\n> -std::vector PyCameraManager::getReadyRequests()\n> -{\n> -\tint ret = readFd();\n> -\n> -\tif (ret == -EAGAIN)\n> -\t\treturn std::vector();\n> -\n> -\tif (ret != 0)\n> -\t\tthrow std::system_error(-ret, std::generic_category());\n> -\n> -\tstd::vector py_reqs;\n> -\n> -\tfor (const auto &ev : getEvents()) {\n> -\t\tif (ev.type_ != CameraEventType::RequestCompleted)\n> -\t\t\tcontinue;\n> -\n> -\t\tPyCameraEvent pyev = convertEvent(ev);\n> -\t\tpy_reqs.push_back(pyev.request_);\n> -\t}\n> -\n> -\treturn py_reqs;\n> -}\n> -\n> std::vector PyCameraManager::getPyEvents()\n> {\n> \tint ret = readFd();\n> diff --git a/src/py/libcamera/py_camera_manager.h b/src/py/libcamera/py_camera_manager.h\n> index 757f6d8e..648d78af 100644\n> --- a/src/py/libcamera/py_camera_manager.h\n> +++ b/src/py/libcamera/py_camera_manager.h\n> @@ -68,7 +68,6 @@ public:\n> \n> \tint eventFd() const { return eventFd_.get(); }\n> \n> -\tstd::vector getReadyRequests(); /* DEPRECATED */\n> \tstd::vector getPyEvents();\n> \tstd::vector getPyCameraEvents(std::shared_ptr camera);\n> \n> diff --git a/src/py/libcamera/py_main.cpp b/src/py/libcamera/py_main.cpp\n> index 0fffc030..1069fd9c 100644\n> --- a/src/py/libcamera/py_main.cpp\n> +++ b/src/py/libcamera/py_main.cpp\n> @@ -126,9 +126,6 @@ PYBIND11_MODULE(_libcamera, m)\n> \n> \t\t.def_property_readonly(\"event_fd\", &PyCameraManager::eventFd)\n> \n> -\t\t/* DEPRECATED */\n> -\t\t.def(\"get_ready_requests\", &PyCameraManager::getReadyRequests)\n> -\n> \t\t.def(\"get_events\", &PyCameraManager::getPyEvents)\n> \n> \t\t.def_readwrite(\"buffer_completed_active\", &PyCameraManager::bufferCompletedEventActive_);","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7A847BDE17\n\tfor ;\n\tThu, 9 Mar 2023 16:00:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E34D0626B2;\n\tThu, 9 Mar 2023 17:00:23 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8489D61ED7\n\tfor ;\n\tThu, 9 Mar 2023 17:00:22 +0100 (CET)","from pendragon.ideasonboard.com\n\t(117.145-247-81.adsl-dyn.isp.belgacom.be [81.247.145.117])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0CEB8589;\n\tThu, 9 Mar 2023 17:00:22 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1678377623;\n\tbh=yQtu1TjyHgVhot684Uh+XZ6tuoYSQjq1kHvK+0jQsXc=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=37TFG6eVTxFU6Ggeu5NFot6zJ6/C/ReyrWqIUHAqnWYEHyz1AL9SpUzPiFXS6irbm\n\tssxydAvsmChTthZmOJJHAeNKG71hi2UtCFLNvTY3b1SqIuGKUqLpPTg9uV8Rl8rgbs\n\tXFiwIdhFsF+1qItXgsPWWcUG6UbMIDmOMOwBa8SObHtG5cxTtRUqREzfCD5dJ3XpYK\n\t+pBrdXx437dBKyddraMMV5Tur8SLdhzIgMEkFLgDYcuvgBBi6ZRF0mEC1v2QZ7KO3I\n\tK1Xx98LnE4VGRzl/yCTMrrAq6wMxL4vp3wpTKDIxpI26UdDKA6qF55B34BkS7iAYQP\n\tPwwYJDunB+3Uw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1678377622;\n\tbh=yQtu1TjyHgVhot684Uh+XZ6tuoYSQjq1kHvK+0jQsXc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=RiNN2HdUsXOdxspwpmbv1/LnwaqOi3LTfAZNiiewC7WvFlve2vTWAOgMHiqe6T2hx\n\t/mR50QJ0Yadzc+CfqYiToawXjgTZFPcSLusYHzgNkvdkWoBtyEurqJ0VF385z2e/JE\n\t2n8hntGl8NGIEdcwpPIKmfTcIGSBdu763DZB8SQI="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"RiNN2HdU\"; dkim-atps=neutral","Date":"Thu, 9 Mar 2023 18:00:25 +0200","To":"Tomi Valkeinen ","Message-ID":"<20230309160025.GE1088@pendragon.ideasonboard.com>","References":"<20230309142601.70556-1-tomi.valkeinen@ideasonboard.com>\n\t<20230309142601.70556-9-tomi.valkeinen@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20230309142601.70556-9-tomi.valkeinen@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v4 08/15] py: Drop get_ready_requests()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]