{"id":18365,"url":"https://patchwork.libcamera.org/api/patches/18365/?format=json","web_url":"https://patchwork.libcamera.org/patch/18365/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20230309142601.70556-5-tomi.valkeinen@ideasonboard.com>","date":"2023-03-09T14:25:50","name":"[libcamera-devel,v4,04/15] py: unittests.py: Use new events support","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"eba1527f902aa66578967593b5315f73b709d5f9","submitter":{"id":109,"url":"https://patchwork.libcamera.org/api/people/109/?format=json","name":"Tomi Valkeinen","email":"tomi.valkeinen@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/18365/mbox/","series":[{"id":3796,"url":"https://patchwork.libcamera.org/api/series/3796/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3796","date":"2023-03-09T14:25:46","name":"py: New python bindings event handling","version":4,"mbox":"https://patchwork.libcamera.org/series/3796/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/18365/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/18365/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 08ABAC329C\n\tfor ;\n\tThu, 9 Mar 2023 14:26:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 311B8626F0;\n\tThu, 9 Mar 2023 15:26:21 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 16BCE626D5\n\tfor ;\n\tThu, 9 Mar 2023 15:26:18 +0100 (CET)","from desky.lan (91-154-32-225.elisa-laajakaista.fi [91.154.32.225])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 673B9589;\n\tThu, 9 Mar 2023 15:26:17 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1678371981;\n\tbh=dISrbspAYCcz8jDXGpTgbn0J+SDAdO6eEhIAvVRnSUc=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=IDeh9dgf/RNT12Oty7jKUEFB22wUBA/oSzSQKDUGOThSirEmIkyCEBLfH0os+b7Du\n\t54PMMNDTOBVgbPcClh+inSt5HLfT6r00C4N6vmCdAjcvmX5ja9SqfZjxBbu8ACtRXC\n\t8j269X3jpTqNQW5XHNfqdieNFdZGJMuMaE4OlkFYm7s9Saqpg2d/n7yhnsVoatMRdv\n\tW+QwATofbt5Brha48o652bE35XvwvcgxCz/rC8pC2ABLF2r5TgAqmn1kgc0fT5FVvj\n\tb+PedGIPyWOYI4MN7iBJSbARMTK1ho3Zx6Fuf5+3o/T3sjR1Y2PshSNjzF+OyaFdhG\n\t9jdqw4Vgip+nw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1678371977;\n\tbh=dISrbspAYCcz8jDXGpTgbn0J+SDAdO6eEhIAvVRnSUc=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=TA4w02Fm3gzu0IhQzbW0fG1GZ8KqfIPjOI3W1ATv3ql7FcnBXKIWGOulBGSgk8gdL\n\tQlVbAn64lBmHSoRlcaO3enJNoTQiKkVXk76Efb8cDco9u7B8aVyaBD+OMfaPJ375T0\n\t6BJwM0v90HJfqTIrNOVOGCaXmgqZwGnF2ue8oFao="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"TA4w02Fm\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 9 Mar 2023 16:25:50 +0200","Message-Id":"<20230309142601.70556-5-tomi.valkeinen@ideasonboard.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20230309142601.70556-1-tomi.valkeinen@ideasonboard.com>","References":"<20230309142601.70556-1-tomi.valkeinen@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v4 04/15] py: unittests.py: Use new events\n\tsupport","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Tomi Valkeinen via libcamera-devel\n\t","Reply-To":"Tomi Valkeinen ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Update the Python unittests to use the new event model. The unittests\nexpect a controlled environment to be run on, and the tests will fail if\nwe get any other event but RequestCompleted (e.g. camera connected).\n\nSigned-off-by: Tomi Valkeinen \nReviewed-by: Laurent Pinchart \n---\n test/py/unittests.py | 12 ++++++------\n 1 file changed, 6 insertions(+), 6 deletions(-)","diff":"diff --git a/test/py/unittests.py b/test/py/unittests.py\nindex 794e46be..fab791d1 100755\n--- a/test/py/unittests.py\n+++ b/test/py/unittests.py\n@@ -201,9 +201,9 @@ class SimpleCaptureMethods(CameraTesterBase):\n if not events:\n continue\n \n- ready_reqs = cm.get_ready_requests()\n-\n- reqs += ready_reqs\n+ for ev in cm.get_events():\n+ self.assertEqual(ev.type, libcam.Event.Type.RequestCompleted)\n+ reqs.append(ev.request)\n \n if len(reqs) == num_bufs:\n break\n@@ -267,9 +267,9 @@ class SimpleCaptureMethods(CameraTesterBase):\n while running:\n events = sel.select()\n for key, _ in events:\n- ready_reqs = cm.get_ready_requests()\n-\n- reqs += ready_reqs\n+ for ev in cm.get_events():\n+ self.assertEqual(ev.type, libcam.Event.Type.RequestCompleted)\n+ reqs.append(ev.request)\n \n if len(reqs) == num_bufs:\n running = False\n","prefixes":["libcamera-devel","v4","04/15"]}