[{"id":26610,"web_url":"https://patchwork.libcamera.org/comment/26610/","msgid":"<20230309153525.GD1088@pendragon.ideasonboard.com>","date":"2023-03-09T15:35:25","subject":"Re: [libcamera-devel] [PATCH v4 01/15] py: Use exceptions instead\n\tof returning error codes","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Tomi,\n\nThank you for the patch.\n\nOn Thu, Mar 09, 2023 at 04:25:47PM +0200, Tomi Valkeinen via libcamera-devel wrote:\n> We have multiple methods which return an error code, mimicking the C++\n> API. Using exceptions is more natural in the Python API, so change all\n> those methods to raise an Exception instead.\n> \n> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>\n> Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n> ---\n>  src/py/cam/cam.py                            | 16 +----\n>  src/py/examples/simple-cam.py                | 15 +---\n>  src/py/examples/simple-capture.py            | 21 ++----\n>  src/py/examples/simple-continuous-capture.py | 21 ++----\n>  src/py/libcamera/py_main.cpp                 | 60 ++++++++++++----\n>  test/py/unittests.py                         | 76 +++++++-------------\n>  6 files changed, 91 insertions(+), 118 deletions(-)\n> \n> diff --git a/src/py/cam/cam.py b/src/py/cam/cam.py\n> index 967a72f5..a2a115c1 100755\n> --- a/src/py/cam/cam.py\n> +++ b/src/py/cam/cam.py\n> @@ -158,9 +158,7 @@ class CameraContext:\n>  \n>              print('Camera configuration adjusted')\n>  \n> -        r = self.camera.configure(camconfig)\n> -        if r != 0:\n> -            raise Exception('Configure failed')\n> +        self.camera.configure(camconfig)\n>  \n>          self.stream_names = {}\n>          self.streams = []\n> @@ -175,12 +173,7 @@ class CameraContext:\n>          allocator = libcam.FrameBufferAllocator(self.camera)\n>  \n>          for stream in self.streams:\n> -            ret = allocator.allocate(stream)\n> -            if ret < 0:\n> -                print('Cannot allocate buffers')\n> -                exit(-1)\n> -\n> -            allocated = len(allocator.buffers(stream))\n> +            allocated = allocator.allocate(stream)\n>  \n>              print('{}-{}: Allocated {} buffers'.format(self.id, self.stream_names[stream], allocated))\n>  \n> @@ -205,10 +198,7 @@ class CameraContext:\n>                  buffers = self.allocator.buffers(stream)\n>                  buffer = buffers[buf_num]\n>  \n> -                ret = request.add_buffer(stream, buffer)\n> -                if ret < 0:\n> -                    print('Can not set buffer for request')\n> -                    exit(-1)\n> +                request.add_buffer(stream, buffer)\n>  \n>              requests.append(request)\n>  \n> diff --git a/src/py/examples/simple-cam.py b/src/py/examples/simple-cam.py\n> index b3e97ca7..1cd1019d 100755\n> --- a/src/py/examples/simple-cam.py\n> +++ b/src/py/examples/simple-cam.py\n> @@ -259,12 +259,7 @@ def main():\n>      allocator = libcam.FrameBufferAllocator(camera)\n>  \n>      for cfg in config:\n> -        ret = allocator.allocate(cfg.stream)\n> -        if ret < 0:\n> -            print('Can\\'t allocate buffers')\n> -            return -1\n> -\n> -        allocated = len(allocator.buffers(cfg.stream))\n> +        allocated = allocator.allocate(cfg.stream)\n>          print(f'Allocated {allocated} buffers for stream')\n>  \n>      # --------------------------------------------------------------------\n> @@ -289,15 +284,9 @@ def main():\n>      requests = []\n>      for i in range(len(buffers)):\n>          request = camera.create_request()\n> -        if not request:\n> -            print('Can\\'t create request')\n> -            return -1\n>  \n>          buffer = buffers[i]\n> -        ret = request.add_buffer(stream, buffer)\n> -        if ret < 0:\n> -            print('Can\\'t set buffer for request')\n> -            return -1\n> +        request.add_buffer(stream, buffer)\n>  \n>          # Controls can be added to a request on a per frame basis.\n>          request.set_control(libcam.controls.Brightness, 0.5)\n> diff --git a/src/py/examples/simple-capture.py b/src/py/examples/simple-capture.py\n> index 5f93574f..4b85408f 100755\n> --- a/src/py/examples/simple-capture.py\n> +++ b/src/py/examples/simple-capture.py\n> @@ -43,8 +43,7 @@ def main():\n>  \n>      # Acquire the camera for our use\n>  \n> -    ret = cam.acquire()\n> -    assert ret == 0\n> +    cam.acquire()\n>  \n>      # Configure the camera\n>  \n> @@ -60,8 +59,7 @@ def main():\n>          w, h = [int(v) for v in args.size.split('x')]\n>          stream_config.size = libcam.Size(w, h)\n>  \n> -    ret = cam.configure(cam_config)\n> -    assert ret == 0\n> +    cam.configure(cam_config)\n>  \n>      print(f'Capturing {TOTAL_FRAMES} frames with {stream_config}')\n>  \n> @@ -83,15 +81,13 @@ def main():\n>          req = cam.create_request(i)\n>  \n>          buffer = allocator.buffers(stream)[i]\n> -        ret = req.add_buffer(stream, buffer)\n> -        assert ret == 0\n> +        req.add_buffer(stream, buffer)\n>  \n>          reqs.append(req)\n>  \n>      # Start the camera\n>  \n> -    ret = cam.start()\n> -    assert ret == 0\n> +    cam.start()\n>  \n>      # frames_queued and frames_done track the number of frames queued and done\n>  \n> @@ -101,8 +97,7 @@ def main():\n>      # Queue the requests to the camera\n>  \n>      for req in reqs:\n> -        ret = cam.queue_request(req)\n> -        assert ret == 0\n> +        cam.queue_request(req)\n>          frames_queued += 1\n>  \n>      # The main loop. Wait for the queued Requests to complete, process them,\n> @@ -155,13 +150,11 @@ def main():\n>  \n>      # Stop the camera\n>  \n> -    ret = cam.stop()\n> -    assert ret == 0\n> +    cam.stop()\n>  \n>      # Release the camera\n>  \n> -    ret = cam.release()\n> -    assert ret == 0\n> +    cam.release()\n>  \n>      return 0\n>  \n> diff --git a/src/py/examples/simple-continuous-capture.py b/src/py/examples/simple-continuous-capture.py\n> index 26a8060b..e1cb931e 100755\n> --- a/src/py/examples/simple-continuous-capture.py\n> +++ b/src/py/examples/simple-continuous-capture.py\n> @@ -28,8 +28,7 @@ class CameraCaptureContext:\n>  \n>          # Acquire the camera for our use\n>  \n> -        ret = cam.acquire()\n> -        assert ret == 0\n> +        cam.acquire()\n>  \n>          # Configure the camera\n>  \n> @@ -37,8 +36,7 @@ class CameraCaptureContext:\n>  \n>          stream_config = cam_config.at(0)\n>  \n> -        ret = cam.configure(cam_config)\n> -        assert ret == 0\n> +        cam.configure(cam_config)\n>  \n>          stream = stream_config.stream\n>  \n> @@ -62,8 +60,7 @@ class CameraCaptureContext:\n>              req = cam.create_request(idx)\n>  \n>              buffer = allocator.buffers(stream)[i]\n> -            ret = req.add_buffer(stream, buffer)\n> -            assert ret == 0\n> +            req.add_buffer(stream, buffer)\n>  \n>              self.reqs.append(req)\n>  \n> @@ -73,13 +70,11 @@ class CameraCaptureContext:\n>      def uninit_camera(self):\n>          # Stop the camera\n>  \n> -        ret = self.cam.stop()\n> -        assert ret == 0\n> +        self.cam.stop()\n>  \n>          # Release the camera\n>  \n> -        ret = self.cam.release()\n> -        assert ret == 0\n> +        self.cam.release()\n>  \n>  \n>  # A container class for our state\n> @@ -145,8 +140,7 @@ class CaptureContext:\n>  \n>          for cam_ctx in self.camera_contexts:\n>              for req in cam_ctx.reqs:\n> -                ret = cam_ctx.cam.queue_request(req)\n> -                assert ret == 0\n> +                cam_ctx.cam.queue_request(req)\n>  \n>          # Use Selector to wait for events from the camera and from the keyboard\n>  \n> @@ -177,8 +171,7 @@ def main():\n>      # Start the cameras\n>  \n>      for cam_ctx in ctx.camera_contexts:\n> -        ret = cam_ctx.cam.start()\n> -        assert ret == 0\n> +        cam_ctx.cam.start()\n>  \n>      ctx.capture()\n>  \n> diff --git a/src/py/libcamera/py_main.cpp b/src/py/libcamera/py_main.cpp\n> index d14e18e2..1d4c23b3 100644\n> --- a/src/py/libcamera/py_main.cpp\n> +++ b/src/py/libcamera/py_main.cpp\n> @@ -114,8 +114,18 @@ PYBIND11_MODULE(_libcamera, m)\n>  \n>  \tpyCamera\n>  \t\t.def_property_readonly(\"id\", &Camera::id)\n> -\t\t.def(\"acquire\", &Camera::acquire)\n> -\t\t.def(\"release\", &Camera::release)\n> +\t\t.def(\"acquire\", [](Camera &self) {\n> +\t\t\tint ret = self.acquire();\n> +\t\t\tif (ret)\n> +\t\t\t\tthrow std::system_error(-ret, std::generic_category(),\n> +\t\t\t\t\t\t\t\"Failed to acquire camera\");\n> +\t\t})\n> +\t\t.def(\"release\", [](Camera &self) {\n> +\t\t\tint ret = self.release();\n> +\t\t\tif (ret)\n> +\t\t\t\tthrow std::system_error(-ret, std::generic_category(),\n> +\t\t\t\t\t\t\t\"Failed to release camera\");\n> +\t\t})\n>  \t\t.def(\"start\", [](Camera &self,\n>  \t\t                 const std::unordered_map<const ControlId *, py::object> &controls) {\n>  \t\t\t/* \\todo What happens if someone calls start() multiple times? */\n> @@ -135,20 +145,19 @@ PYBIND11_MODULE(_libcamera, m)\n>  \t\t\tint ret = self.start(&controlList);\n>  \t\t\tif (ret) {\n>  \t\t\t\tself.requestCompleted.disconnect();\n> -\t\t\t\treturn ret;\n> +\t\t\t\tthrow std::system_error(-ret, std::generic_category(),\n> +\t\t\t\t\t\t\t\"Failed to start camera\");\n>  \t\t\t}\n> -\n> -\t\t\treturn 0;\n>  \t\t}, py::arg(\"controls\") = std::unordered_map<const ControlId *, py::object>())\n>  \n>  \t\t.def(\"stop\", [](Camera &self) {\n>  \t\t\tint ret = self.stop();\n> -\t\t\tif (ret)\n> -\t\t\t\treturn ret;\n>  \n>  \t\t\tself.requestCompleted.disconnect();\n>  \n> -\t\t\treturn 0;\n> +\t\t\tif (ret)\n> +\t\t\t\tthrow std::system_error(-ret, std::generic_category(),\n> +\t\t\t\t\t\t\t\"Failed to stop camera\");\n>  \t\t})\n>  \n>  \t\t.def(\"__str__\", [](Camera &self) {\n> @@ -157,9 +166,20 @@ PYBIND11_MODULE(_libcamera, m)\n>  \n>  \t\t/* Keep the camera alive, as StreamConfiguration contains a Stream* */\n>  \t\t.def(\"generate_configuration\", &Camera::generateConfiguration, py::keep_alive<0, 1>())\n> -\t\t.def(\"configure\", &Camera::configure)\n> +\t\t.def(\"configure\", [](Camera &self, CameraConfiguration *config) {\n> +\t\t\tint ret = self.configure(config);\n> +\t\t\tif (ret)\n> +\t\t\t\tthrow std::system_error(-ret, std::generic_category(),\n> +\t\t\t\t\t\t\t\"Failed to configure camera\");\n> +\t\t})\n>  \n> -\t\t.def(\"create_request\", &Camera::createRequest, py::arg(\"cookie\") = 0)\n> +\t\t.def(\"create_request\", [](Camera &self, uint64_t cookie) {\n> +\t\t\tstd::unique_ptr<Request> req = self.createRequest(cookie);\n> +\t\t\tif (!req)\n> +\t\t\t\tthrow std::system_error(ENOMEM, std::generic_category(),\n> +\t\t\t\t\t\t\t\"Failed to create request\");\n> +\t\t\treturn req;\n> +\t\t}, py::arg(\"cookie\") = 0)\n>  \n>  \t\t.def(\"queue_request\", [](Camera &self, Request *req) {\n>  \t\t\tpy::object py_req = py::cast(req);\n> @@ -172,10 +192,11 @@ PYBIND11_MODULE(_libcamera, m)\n>  \t\t\tpy_req.inc_ref();\n>  \n>  \t\t\tint ret = self.queueRequest(req);\n> -\t\t\tif (ret)\n> +\t\t\tif (ret) {\n>  \t\t\t\tpy_req.dec_ref();\n> -\n> -\t\t\treturn ret;\n> +\t\t\t\tthrow std::system_error(-ret, std::generic_category(),\n> +\t\t\t\t\t\t\t\"Failed to queue request\");\n> +\t\t\t}\n>  \t\t})\n>  \n>  \t\t.def_property_readonly(\"streams\", [](Camera &self) {\n> @@ -253,7 +274,13 @@ PYBIND11_MODULE(_libcamera, m)\n>  \n>  \tpyFrameBufferAllocator\n>  \t\t.def(py::init<std::shared_ptr<Camera>>(), py::keep_alive<1, 2>())\n> -\t\t.def(\"allocate\", &FrameBufferAllocator::allocate)\n> +\t\t.def(\"allocate\", [](FrameBufferAllocator &self, Stream *stream) {\n> +\t\t\tint ret = self.allocate(stream);\n> +\t\t\tif (ret < 0)\n> +\t\t\t\tthrow std::system_error(-ret, std::generic_category(),\n> +\t\t\t\t\t\t\t\"Failed to allocate buffers\");\n> +\t\t\treturn ret;\n> +\t\t})\n>  \t\t.def_property_readonly(\"allocated\", &FrameBufferAllocator::allocated)\n>  \t\t/* Create a list of FrameBuffers, where each FrameBuffer has a keep-alive to FrameBufferAllocator */\n>  \t\t.def(\"buffers\", [](FrameBufferAllocator &self, Stream *stream) {\n> @@ -330,7 +357,10 @@ PYBIND11_MODULE(_libcamera, m)\n>  \tpyRequest\n>  \t\t/* \\todo Fence is not supported, so we cannot expose addBuffer() directly */\n>  \t\t.def(\"add_buffer\", [](Request &self, const Stream *stream, FrameBuffer *buffer) {\n> -\t\t\treturn self.addBuffer(stream, buffer);\n> +\t\t\tint ret = self.addBuffer(stream, buffer);\n> +\t\t\tif (ret)\n> +\t\t\t\tthrow std::system_error(-ret, std::generic_category(),\n> +\t\t\t\t\t\t\t\"Failed to add buffer\");\n>  \t\t}, py::keep_alive<1, 3>()) /* Request keeps Framebuffer alive */\n>  \t\t.def_property_readonly(\"status\", &Request::status)\n>  \t\t.def_property_readonly(\"buffers\", &Request::buffers)\n> diff --git a/test/py/unittests.py b/test/py/unittests.py\n> index 6dea80fc..794e46be 100755\n> --- a/test/py/unittests.py\n> +++ b/test/py/unittests.py\n> @@ -42,31 +42,26 @@ class SimpleTestMethods(BaseTestCase):\n>          cam = cm.get('platform/vimc.0 Sensor B')\n>          self.assertIsNotNone(cam)\n>  \n> -        ret = cam.acquire()\n> -        self.assertZero(ret)\n> +        cam.acquire()\n>  \n> -        ret = cam.release()\n> -        self.assertZero(ret)\n> +        cam.release()\n>  \n>      def test_double_acquire(self):\n>          cm = libcam.CameraManager.singleton()\n>          cam = cm.get('platform/vimc.0 Sensor B')\n>          self.assertIsNotNone(cam)\n>  \n> -        ret = cam.acquire()\n> -        self.assertZero(ret)\n> +        cam.acquire()\n>  \n>          libcam.log_set_level('Camera', 'FATAL')\n> -        ret = cam.acquire()\n> -        self.assertEqual(ret, -errno.EBUSY)\n> +        with self.assertRaises(RuntimeError):\n> +            cam.acquire()\n>          libcam.log_set_level('Camera', 'ERROR')\n>  \n> -        ret = cam.release()\n> -        self.assertZero(ret)\n> +        cam.release()\n>  \n> -        ret = cam.release()\n> -        # I expected EBUSY, but looks like double release works fine\n> -        self.assertZero(ret)\n> +        # I expected exception here, but looks like double release works fine\n> +        cam.release()\n>  \n>  \n>  class CameraTesterBase(BaseTestCase):\n> @@ -80,11 +75,7 @@ class CameraTesterBase(BaseTestCase):\n>              self.cm = None\n>              self.skipTest('No vimc found')\n>  \n> -        ret = self.cam.acquire()\n> -        if ret != 0:\n> -            self.cam = None\n> -            self.cm = None\n> -            raise Exception('Failed to acquire camera')\n> +        self.cam.acquire()\n>  \n>          self.wr_cam = weakref.ref(self.cam)\n>          self.wr_cm = weakref.ref(self.cm)\n> @@ -93,9 +84,7 @@ class CameraTesterBase(BaseTestCase):\n>          # If a test fails, the camera may be in running state. So always stop.\n>          self.cam.stop()\n>  \n> -        ret = self.cam.release()\n> -        if ret != 0:\n> -            raise Exception('Failed to release camera')\n> +        self.cam.release()\n>  \n>          self.cam = None\n>          self.cm = None\n> @@ -115,8 +104,7 @@ class AllocatorTestMethods(CameraTesterBase):\n>          streamconfig = camconfig.at(0)\n>          wr_streamconfig = weakref.ref(streamconfig)\n>  \n> -        ret = cam.configure(camconfig)\n> -        self.assertZero(ret)\n> +        cam.configure(camconfig)\n>  \n>          stream = streamconfig.stream\n>          wr_stream = weakref.ref(stream)\n> @@ -129,8 +117,8 @@ class AllocatorTestMethods(CameraTesterBase):\n>          self.assertIsNotNone(wr_streamconfig())\n>  \n>          allocator = libcam.FrameBufferAllocator(cam)\n> -        ret = allocator.allocate(stream)\n> -        self.assertTrue(ret > 0)\n> +        num_bufs = allocator.allocate(stream)\n> +        self.assertTrue(num_bufs > 0)\n>          wr_allocator = weakref.ref(allocator)\n>  \n>          buffers = allocator.buffers(stream)\n> @@ -173,14 +161,13 @@ class SimpleCaptureMethods(CameraTesterBase):\n>          self.assertIsNotNone(fmts)\n>          fmts = None\n>  \n> -        ret = cam.configure(camconfig)\n> -        self.assertZero(ret)\n> +        cam.configure(camconfig)\n>  \n>          stream = streamconfig.stream\n>  \n>          allocator = libcam.FrameBufferAllocator(cam)\n> -        ret = allocator.allocate(stream)\n> -        self.assertTrue(ret > 0)\n> +        num_bufs = allocator.allocate(stream)\n> +        self.assertTrue(num_bufs > 0)\n>  \n>          num_bufs = len(allocator.buffers(stream))\n>  \n> @@ -190,19 +177,16 @@ class SimpleCaptureMethods(CameraTesterBase):\n>              self.assertIsNotNone(req)\n>  \n>              buffer = allocator.buffers(stream)[i]\n> -            ret = req.add_buffer(stream, buffer)\n> -            self.assertZero(ret)\n> +            req.add_buffer(stream, buffer)\n>  \n>              reqs.append(req)\n>  \n>          buffer = None\n>  \n> -        ret = cam.start()\n> -        self.assertZero(ret)\n> +        cam.start()\n>  \n>          for req in reqs:\n> -            ret = cam.queue_request(req)\n> -            self.assertZero(ret)\n> +            cam.queue_request(req)\n>  \n>          reqs = None\n>          gc.collect()\n> @@ -230,8 +214,7 @@ class SimpleCaptureMethods(CameraTesterBase):\n>          reqs = None\n>          gc.collect()\n>  \n> -        ret = cam.stop()\n> -        self.assertZero(ret)\n> +        cam.stop()\n>  \n>      def test_select(self):\n>          cm = self.cm\n> @@ -245,14 +228,13 @@ class SimpleCaptureMethods(CameraTesterBase):\n>          self.assertIsNotNone(fmts)\n>          fmts = None\n>  \n> -        ret = cam.configure(camconfig)\n> -        self.assertZero(ret)\n> +        cam.configure(camconfig)\n>  \n>          stream = streamconfig.stream\n>  \n>          allocator = libcam.FrameBufferAllocator(cam)\n> -        ret = allocator.allocate(stream)\n> -        self.assertTrue(ret > 0)\n> +        num_bufs = allocator.allocate(stream)\n> +        self.assertTrue(num_bufs > 0)\n>  \n>          num_bufs = len(allocator.buffers(stream))\n>  \n> @@ -262,19 +244,16 @@ class SimpleCaptureMethods(CameraTesterBase):\n>              self.assertIsNotNone(req)\n>  \n>              buffer = allocator.buffers(stream)[i]\n> -            ret = req.add_buffer(stream, buffer)\n> -            self.assertZero(ret)\n> +            req.add_buffer(stream, buffer)\n>  \n>              reqs.append(req)\n>  \n>          buffer = None\n>  \n> -        ret = cam.start()\n> -        self.assertZero(ret)\n> +        cam.start()\n>  \n>          for req in reqs:\n> -            ret = cam.queue_request(req)\n> -            self.assertZero(ret)\n> +            cam.queue_request(req)\n>  \n>          reqs = None\n>          gc.collect()\n> @@ -303,8 +282,7 @@ class SimpleCaptureMethods(CameraTesterBase):\n>          reqs = None\n>          gc.collect()\n>  \n> -        ret = cam.stop()\n> -        self.assertZero(ret)\n> +        cam.stop()\n>  \n>  \n>  # Recursively expand slist's objects into olist, using seen to track already","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9706EBE080\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu,  9 Mar 2023 15:35:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EB673626B2;\n\tThu,  9 Mar 2023 16:35:23 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DC28B61ED7\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu,  9 Mar 2023 16:35:22 +0100 (CET)","from pendragon.ideasonboard.com\n\t(117.145-247-81.adsl-dyn.isp.belgacom.be [81.247.145.117])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3AF97589;\n\tThu,  9 Mar 2023 16:35:22 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1678376123;\n\tbh=km7KpmXU+I3Bcd0OWrDUH9DKwCS6BWbTszDR9UA8Fjk=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=k0zI9+1w1tj3gIpi/SjHwhL4EVYEp+8M0m/Pf0ioZt6i7cEPY63mZeZmn6ikTDjLN\n\tY+FNqCcxEumoQar9m+3Tu2QAueuCDNlB/Kw3abIOobtgX6OdSgMiEOpkmwUVplLZ4d\n\tv46AqeOFvkGg9oOZsCwySwpG2ffhWi5HZchLzbqLjkd9mu6z34iTkFUTONojiP22gt\n\t2UJ4fXHKg/wuxu+4YFCzrnGBBoWChS9QNpD/Qp1EMNx107SKgd1LUGIvkyR6sf63cY\n\tCM3rDBmERWoK/L9haWIPDbrSVr6/t0lUu54vNR1ki7VoX2oWwb+utrCzfYYqsZ51iN\n\t5UifQQJMVVK+Q==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1678376122;\n\tbh=km7KpmXU+I3Bcd0OWrDUH9DKwCS6BWbTszDR9UA8Fjk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=BiW4Mt9AtJjSnp2UvhGcXD/uT2KwsxL/1YbwKLYW4KoDVwLhisizIC5vmP3gwDq2B\n\td9WHIcs01t/mg9wRSHpy9Ah4Hlh3eVT5Pq8prrXzixN/h5NqUCh3fi1/M7AZvMuO6t\n\tzAgNESMif7vhReEUcRv94RAbdLX/K7CkhOn0/73w="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"BiW4Mt9A\"; dkim-atps=neutral","Date":"Thu, 9 Mar 2023 17:35:25 +0200","To":"Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>","Message-ID":"<20230309153525.GD1088@pendragon.ideasonboard.com>","References":"<20230309142601.70556-1-tomi.valkeinen@ideasonboard.com>\n\t<20230309142601.70556-2-tomi.valkeinen@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20230309142601.70556-2-tomi.valkeinen@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v4 01/15] py: Use exceptions instead\n\tof returning error codes","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>","Reply-To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]