[{"id":26598,"web_url":"https://patchwork.libcamera.org/comment/26598/","msgid":"<20230308220205.GD31765@pendragon.ideasonboard.com>","date":"2023-03-08T22:02:05","subject":"Re: [libcamera-devel] [PATCH] ipa: libipa: Add OV5647 Camera Sensor\n\tHelper","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Wed, Mar 08, 2023 at 03:53:29PM +0000, Kieran Bingham via libcamera-devel wrote:\n> Provide a CameraSensorHelper for the OV5647 as used in the Raspberry Pi\n> Camera Module v1.\n> \n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/ipa/libipa/camera_sensor_helper.cpp | 11 +++++++++++\n> 1 file changed, 11 insertions(+)\n> \n> diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\n> index 15d92395a7ae..693b628a438a 100644\n> --- a/src/ipa/libipa/camera_sensor_helper.cpp\n> +++ b/src/ipa/libipa/camera_sensor_helper.cpp\n> @@ -498,6 +498,17 @@ public:\n> };\n> REGISTER_CAMERA_SENSOR_HELPER(\"ov5640\", CameraSensorHelperOv5640)\n> \n> +class CameraSensorHelperOv5647 : public CameraSensorHelper\n> +{\n> +public:\n> +\tCameraSensorHelperOv5647()\n> +\t{\n> +\t\tgainType_ = AnalogueGainLinear;\n> +\t\tgainConstants_.linear = { 1, 0, 0, 16 };\n> +\t}\n> +};\n> +REGISTER_CAMERA_SENSOR_HELPER(\"ov5647\", CameraSensorHelperOv5647)\n> +\n> class CameraSensorHelperOv5670 : public CameraSensorHelper\n> {\n> public:","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8DD76BE080\n\tfor ;\n\tWed, 8 Mar 2023 22:02:04 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9D650626C2;\n\tWed, 8 Mar 2023 23:02:03 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A1D7062674\n\tfor ;\n\tWed, 8 Mar 2023 23:02:01 +0100 (CET)","from pendragon.ideasonboard.com\n\t(117.145-247-81.adsl-dyn.isp.belgacom.be [81.247.145.117])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 20E7110C;\n\tWed, 8 Mar 2023 23:02:01 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1678312923;\n\tbh=pRWg6SCvW1TWXbSVke6Rk0Rk23fgW7SlQn1vdnYmkq4=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=JwuVH9cS7GApR/7kqVpsO+qisu+uX6o5nyJ8CzkmakG/a427gM+cCAUAChY0ZtD33\n\t5OTg0wS+spbKbWdiw27VKDvm4Z3GyYHybjtrVxdmk8Ah9hOAZ9y4wIxLlL1h1k7xAW\n\tfcmfRiPnj8P8kLY/e/dx3aDu+BPZNVzgWMaoUCwRJwEZlMabrYh79GFgzGZo36GPX1\n\t+coYcXxnMBCVyJW8eZaTX4dLbK0k4+2Ir6DWIi/RRBS53WSsW3OppqBXkmBhwQImXz\n\tOzzCSFoyFq5EpMDFEjVyAaeYk5Qhne19N1rjwVdKbGlOloh7Lty5MggeLpsbw0If5N\n\t5N/wzrHpq4xNQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1678312921;\n\tbh=pRWg6SCvW1TWXbSVke6Rk0Rk23fgW7SlQn1vdnYmkq4=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=T8oDQ94dsslzg0hXqbUurMZQbLBHtjxlYbd/UVpDUisSx9T6MfiCZjUC0QOb5+MNL\n\tNG8F1hDi8l7ZkuA2PE9WzRX1g47xOCxixQYuYmiqWFZzsbVvsdJIAIxuxwqYXDCkrR\n\tcY2mvO69gAo21PuBlb2mRYsPeOYHe3InYR2hCJ78="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"T8oDQ94d\"; dkim-atps=neutral","Date":"Thu, 9 Mar 2023 00:02:05 +0200","To":"Kieran Bingham ","Message-ID":"<20230308220205.GD31765@pendragon.ideasonboard.com>","References":"<20230308155329.3083814-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20230308155329.3083814-1-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] ipa: libipa: Add OV5647 Camera Sensor\n\tHelper","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":26599,"web_url":"https://patchwork.libcamera.org/comment/26599/","msgid":"<4489af8e1643f0c2765bb7fac5adc136c6c18e1c.camel@collabora.com>","date":"2023-03-08T22:44:24","subject":"Re: [libcamera-devel] [PATCH] ipa: libipa: Add OV5647 Camera Sensor\n\tHelper","submitter":{"id":157,"url":"https://patchwork.libcamera.org/api/people/157/","name":"Christopher Obbard","email":"chris.obbard@collabora.com"},"content":"Hi Kieran,\n\nOV5647 was completely broken on RK3399 before this patch, thank you for fixing it!\n\nOn Wed, 2023-03-08 at 15:53 -0000, Kieran Bingham wrote:\n> Provide a CameraSensorHelper for the OV5647 as used in the Raspberry Pi\n> Camera Module v1.\n> \n> Signed-off-by: Kieran Bingham \n\nTested-by: Christopher Obbard \n\n> ---\n> src/ipa/libipa/camera_sensor_helper.cpp | 11 +++++++++++\n> 1 file changed, 11 insertions(+)\n> \n> diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\n> index 15d92395a7ae..693b628a438a 100644\n> --- a/src/ipa/libipa/camera_sensor_helper.cpp\n> +++ b/src/ipa/libipa/camera_sensor_helper.cpp\n> @@ -498,6 +498,17 @@ public:\n> };\n> REGISTER_CAMERA_SENSOR_HELPER(\"ov5640\", CameraSensorHelperOv5640)\n> \n> +class CameraSensorHelperOv5647 : public CameraSensorHelper\n> +{\n> +public:\n> +\tCameraSensorHelperOv5647()\n> +\t{\n> +\t\tgainType_ = AnalogueGainLinear;\n> +\t\tgainConstants_.linear = { 1, 0, 0, 16 };\n> +\t}\n> +};\n> +REGISTER_CAMERA_SENSOR_HELPER(\"ov5647\", CameraSensorHelperOv5647)\n> +\n> class CameraSensorHelperOv5670 : public CameraSensorHelper\n> {\n> public:","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2E08ABDE17\n\tfor ;\n\tWed, 8 Mar 2023 22:44:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8812D626C2;\n\tWed, 8 Mar 2023 23:44:28 +0100 (CET)","from madras.collabora.co.uk (madras.collabora.co.uk\n\t[46.235.227.172])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4420C62674\n\tfor ;\n\tWed, 8 Mar 2023 23:44:27 +0100 (CET)","from [IPv6:2a00:23c7:6883:e501:dc60:8aed:a167:f558] (unknown\n\t[IPv6:2a00:23c7:6883:e501:dc60:8aed:a167:f558])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\t(Authenticated sender: obbardc)\n\tby madras.collabora.co.uk (Postfix) with ESMTPSA id E59326602FEA;\n\tWed, 8 Mar 2023 22:44:26 +0000 (GMT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1678315468;\n\tbh=qBDYbtVxgvP6Q/wTLI8TIU94iblUf4xkFH5/nB/KisU=;\n\th=To:Date:In-Reply-To:Subject:List-Id:List-Unsubscribe:List-Archive:\n\tList-Post:List-Help:List-Subscribe:From:Reply-To:Cc:From;\n\tb=Zh140+7nkFRVfFswQAdMB2cqHMCHMHm/KB7dVsBlktIs4QDphmVYmdaP2Ar4nOtEP\n\tzI3uw1IhIZEnoazwMyJenyBQwk/H48qFIRDFRIcjPYF6Lxo6VRqyc2AE3IyxWXl5bj\n\t+5vuVoQbRJvfxrAVTu1pdOQC7qwqX5m8mNNl/64EznwDe5yMDtxO4oPq0mvzNimv0x\n\tJHBkp8R9UAPJxc6zk5xtJx+FoijMKS7VIrQFHLAmBhXPCDlXF6JZO+9+Ac8wGwW7Bv\n\txi6dxz+ExO5hVj7jNozUxPIUoe7kqNn7rHokXvnUrvNuqXNPWrg7KrzRY7W0uCuJaC\n\tpf0bwmtWz3FsQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com;\n\ts=mail; t=1678315467;\n\tbh=qBDYbtVxgvP6Q/wTLI8TIU94iblUf4xkFH5/nB/KisU=;\n\th=Subject:From:To:Cc:Date:In-Reply-To:From;\n\tb=Wf5H+HkIscyaKuQNBIJhZtQUKr8ZodBHEjzDLMCD4ta8nmiFB2m7oNkglp3z44jet\n\thge6TWpuRdnbVVlY8kGqjugjBmzhLQWPhq/+rUlyV+F4l4pqOanXwAbWunfXGCejgB\n\tZr+qenvAHPJeLKV4NAOCOaTDJZaR61/1f4oHoaYon0YAjvWZDxKKR5qrlRPqZ3DQiN\n\tFYMfg9Lpk8dt6FrpJ2nmLlShXszel1M+giieDOPLufNXmWg0j4Yc1tKLonwU2ejvo8\n\tE9xKdNNDaWxElxBoMahnr1WreivexByA0FI4PmOHIdZ+oaD/jriEnZcZiXVWl76Nmw\n\t+QwEo5LhiV8BA=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=collabora.com\n\theader.i=@collabora.com\n\theader.b=\"Wf5H+HkI\"; dkim-atps=neutral","Message-ID":"<4489af8e1643f0c2765bb7fac5adc136c6c18e1c.camel@collabora.com>","To":"Kieran Bingham ","Date":"Wed, 08 Mar 2023 22:44:24 +0000","In-Reply-To":"<20230308155329.3083814-1-kieran.bingham@ideasonboard.com>","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","User-Agent":"Evolution 3.46.4-1 ","MIME-Version":"1.0","Subject":"Re: [libcamera-devel] [PATCH] ipa: libipa: Add OV5647 Camera Sensor\n\tHelper","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Christopher Obbard via libcamera-devel\n\t","Reply-To":"Christopher Obbard ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":26604,"web_url":"https://patchwork.libcamera.org/comment/26604/","msgid":"<01c129f1-79b7-826b-f974-229162114e28@ideasonboard.com>","date":"2023-03-09T09:54:11","subject":"Re: [libcamera-devel] [PATCH] ipa: libipa: Add OV5647 Camera Sensor\n\tHelper","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Kieran,\n\nOn 3/8/23 9:23 PM, Kieran Bingham via libcamera-devel wrote:\n> Provide a CameraSensorHelper for the OV5647 as used in the Raspberry Pi\n> Camera Module v1.\n>\n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Umang Jain \n\n> ---\n> src/ipa/libipa/camera_sensor_helper.cpp | 11 +++++++++++\n> 1 file changed, 11 insertions(+)\n>\n> diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\n> index 15d92395a7ae..693b628a438a 100644\n> --- a/src/ipa/libipa/camera_sensor_helper.cpp\n> +++ b/src/ipa/libipa/camera_sensor_helper.cpp\n> @@ -498,6 +498,17 @@ public:\n> };\n> REGISTER_CAMERA_SENSOR_HELPER(\"ov5640\", CameraSensorHelperOv5640)\n> \n> +class CameraSensorHelperOv5647 : public CameraSensorHelper\n> +{\n> +public:\n> +\tCameraSensorHelperOv5647()\n> +\t{\n> +\t\tgainType_ = AnalogueGainLinear;\n> +\t\tgainConstants_.linear = { 1, 0, 0, 16 };\n> +\t}\n> +};\n> +REGISTER_CAMERA_SENSOR_HELPER(\"ov5647\", CameraSensorHelperOv5647)\n> +\n> class CameraSensorHelperOv5670 : public CameraSensorHelper\n> {\n> public:","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F01AEBE080\n\tfor ;\n\tThu, 9 Mar 2023 09:54:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A9EB8626C8;\n\tThu, 9 Mar 2023 10:54:17 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C097E62664\n\tfor ;\n\tThu, 9 Mar 2023 10:54:16 +0100 (CET)","from [IPV6:2401:4900:1c80:68bc:dd3b:9765:5b92:7a2c] (unknown\n\t[IPv6:2401:4900:1c80:68bc:dd3b:9765:5b92:7a2c])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CBB71589;\n\tThu, 9 Mar 2023 10:54:15 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1678355657;\n\tbh=fBbH68k+Rz3UpolfaH5m4WAzuUajuXXs2u2hXWe/41I=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=3nZtBwLZpvyjsjxr+52W0oCOBMPLPMVWoCGoTlR57nVoyyT+ElXieluEPLLnIltIM\n\tnahr15ZpICO0uYMJfvxMRX2qrnq+a2ir1+92DK3yTdJ7qZF/bhqbpXu/ZdN+0kD6Po\n\tFDntwtGexxJ6trbVTgdXBpEONHvh9lvWh1MakoJBMtGLDN0xo9T+SIpAvjPk+bUFpA\n\tpU/0d0xLgG/2FsEvO8U6u/X00X2yWvLK3aFze+AuklW6adYb2xr10rMP9Cr0TxY4EV\n\t6oEuivrgIMUQK24GGqNS2Z+OOXl2DblmkB8knNcGuGp6bNK+jAFvL7jVM6dA/2qxOg\n\tiXV6gYqahaUNg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1678355656;\n\tbh=fBbH68k+Rz3UpolfaH5m4WAzuUajuXXs2u2hXWe/41I=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=wjRug1yZDvJf0sEDnJIxvZCTTQC3WwNU9eUw+hGLag0GoWUrXNqZVIGwgo5EUa15G\n\tnStml5AcLdBbvp80Jq/UGDGB/GkEgWgF5Hn4ezrP871PCwwNNR+OWFFaCb4q9lJsZK\n\tcDWXE0tQlbTu3PJcM80F0TkSaDRR44Q91d2XW5J8="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"wjRug1yZ\"; dkim-atps=neutral","Message-ID":"<01c129f1-79b7-826b-f974-229162114e28@ideasonboard.com>","Date":"Thu, 9 Mar 2023 15:24:11 +0530","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101\n\tThunderbird/102.7.1","To":"Kieran Bingham ,\n\tlibcamera devel ","References":"<20230308155329.3083814-1-kieran.bingham@ideasonboard.com>","Content-Language":"en-US","In-Reply-To":"<20230308155329.3083814-1-kieran.bingham@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH] ipa: libipa: Add OV5647 Camera Sensor\n\tHelper","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Umang Jain via libcamera-devel ","Reply-To":"Umang Jain ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]