[{"id":26592,"web_url":"https://patchwork.libcamera.org/comment/26592/","msgid":"<20230307171022.GA23376@pendragon.ideasonboard.com>","date":"2023-03-07T17:10:22","subject":"Re: [libcamera-devel] Pull request from\n\thttps://github.com/naushir/libcamera.git","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Naush,\n\nThanks for the pull request.\n\nIn the future, could you try to follow the kernel convention for the\nsubject line ? It should start with a [GIT PULL] tag, and then have a\nshort one-line description of the pull request. This one could be, for\ninstance\n\n[GIT PULL] Raspberry Pi timeout handling improvements & other misc changes\n\nOn Tue, Mar 07, 2023 at 03:58:20PM +0000, Naushir Patuck via libcamera-devel wrote:\n> The following changes since commit cde9293cf9899b0fc4ce9cf89dd29f26be77f35c:\n> \n>   ipa: rkisp1: lsc: Fix integer division error (2023-03-06 18:12:10 +0100)\n> \n> are available in the Git repository at:\n> \n>   https://github.com/naushir/libcamera.git\n> \n> for you to fetch changes up to f194529f9ba35421b66fee5e5bfcb2b8a148bbbf:\n> \n>   ipa: raspberrypi: imx296: Minor tuning updates (2023-03-07 15:43:08 +0000)\n> \n> ----------------------------------------------------------------\n> David Plowman (2):\n>       ipa: raspberrypi: agc: Fix overflow in Y value calculation\n>       ipa: raspberrypi: imx296: Minor tuning updates\n> \n> Naushir Patuck (4):\n>       pipeline: ipa: raspberrypi: Change Unicam timeout handling\n>       ipa: raspberrypi: Better heuristics for calculating Unicam timeout\n>       pipeline: raspberrypi: Add a Unicam timeout override config options\n>       pipeline: raspberrypi: Iterate over all Unicam instances in match()\n> \n>  include/libcamera/ipa/raspberrypi.mojom              |   2 +-\n>  src/ipa/raspberrypi/controller/rpi/agc.cpp           |   2 +-\n>  src/ipa/raspberrypi/data/imx296.json                 | 180 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++---------------------------\n>  src/ipa/raspberrypi/data/imx296_mono.json            |  12 ++++++++--\n>  src/ipa/raspberrypi/raspberrypi.cpp                  |  45 +++++++++++++++++++++++++++++++++++---\n>  src/libcamera/pipeline/raspberrypi/data/example.yaml |  11 +++++++++-\n>  src/libcamera/pipeline/raspberrypi/raspberrypi.cpp   | 105 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-----------------------------\n>  7 files changed, 282 insertions(+), 75 deletions(-)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E3D28BE080\n\tfor ;\n\tTue, 7 Mar 2023 17:10:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0BEC3626A7;\n\tTue, 7 Mar 2023 18:10:23 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8AADB603AE\n\tfor ;\n\tTue, 7 Mar 2023 18:10:21 +0100 (CET)","from pendragon.ideasonboard.com (85-76-75-44-nat.elisa-mobile.fi\n\t[85.76.75.44])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 428284AD;\n\tTue, 7 Mar 2023 18:10:20 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1678209023;\n\tbh=vlks01lEdjr1IP3QVuYpeO7XVnpsSSpidEpIQo1XOWc=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=eLDCe2ezoSKFzckiRwNZjKFbAsltPeJ+ACidIstJpAIwO2wNTNy5FWrfW365xoSv1\n\ts6qjdVl+MDajPBL52Oy5793QzAgE1K9dmv1C4FhPfWtznwJ+6AmOuo24TNGtqBq0w6\n\tiQB3htbdb57zGEcFfXjGmRg0S9ttj3/R90DaqUhmDf5H9E6jQEHOKNybcFhHkoEXCW\n\tHmYX9kNa27li0L0Px2nNw2tPnmt09NFsuU0rh1QNH0lVWVq9Q4NA8vO0qo5a4jRGAU\n\twPa5jVSCukpGYiPmUhVoo39H2rNsn7T6bSt9gi53w9cVeKUOFOg2ctb8eQfENqrWVr\n\tnuVgeHm3U3pLw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1678209021;\n\tbh=vlks01lEdjr1IP3QVuYpeO7XVnpsSSpidEpIQo1XOWc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Dz4MfkKSb5b5UgvfLvLr88+5Nz0Z3Dp4X39ZEFAQ7W10ZtLPn5K89YKeHr5gou5wp\n\t968oeoN/q9yf/MeQjLzU9oIBfgzIgd8OaWqFdzGvFb4lHgPZA73hnnPXK8lXXLImQ/\n\tXVjsYPuqs+XEOQGUCTmeofmNGAQpCElM7DDNB16E="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"Dz4MfkKS\"; dkim-atps=neutral","Date":"Tue, 7 Mar 2023 19:10:22 +0200","To":"Naushir Patuck ","Message-ID":"<20230307171022.GA23376@pendragon.ideasonboard.com>","References":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"","Subject":"Re: [libcamera-devel] Pull request from\n\thttps://github.com/naushir/libcamera.git","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":26594,"web_url":"https://patchwork.libcamera.org/comment/26594/","msgid":"<167822786880.93391.14855754073034250425@Monstersaurus>","date":"2023-03-07T22:24:28","subject":"Re: [libcamera-devel] Pull request from\n\thttps://github.com/naushir/libcamera.git","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Naush,\n\nQuoting Laurent Pinchart (2023-03-07 17:10:22)\n> Hi Naush,\n> \n> Thanks for the pull request.\n> \n> In the future, could you try to follow the kernel convention for the\n> subject line ? It should start with a [GIT PULL] tag, and then have a\n> short one-line description of the pull request. This one could be, for\n> instance\n> \n> [GIT PULL] Raspberry Pi timeout handling improvements & other misc changes\n\nThank you for trying this as new way to handle your integrations!\n\nRunning through the integration scripts on my side failed:\n\nMissing committer Signed-off-by in commit f194529f9ba35421b66fee5e5bfcb2b8a148bbbf\nMissing committer Signed-off-by in commit 95e7b5415aadccf1a8d706c3460e114553a49e06\nFound 2 errors in refs/heads/master, not pushing\n\nWhich was due to our pre-merge validation scripts noting that the\npatches you cherry-picked from David were not Signed-off by the\n'committer' (now you).\n\nTo be able to merge these, I've run git rebase --signoff, which has\nrecommitted these with my Sign-off. I figured I could have asked you to\nresubmit a new pull request with your SoB - but it didn't seem worth the\nextra cycle at this time.\n\nWith that, they passed my integration tests, and are now merged.\n\nThankyou!\n--\nKieran\n\n\n> \n> On Tue, Mar 07, 2023 at 03:58:20PM +0000, Naushir Patuck via libcamera-devel wrote:\n> > The following changes since commit cde9293cf9899b0fc4ce9cf89dd29f26be77f35c:\n> > \n> >   ipa: rkisp1: lsc: Fix integer division error (2023-03-06 18:12:10 +0100)\n> > \n> > are available in the Git repository at:\n> > \n> >   https://github.com/naushir/libcamera.git\n> > \n> > for you to fetch changes up to f194529f9ba35421b66fee5e5bfcb2b8a148bbbf:\n> > \n> >   ipa: raspberrypi: imx296: Minor tuning updates (2023-03-07 15:43:08 +0000)\n> > \n> > ----------------------------------------------------------------\n> > David Plowman (2):\n> >       ipa: raspberrypi: agc: Fix overflow in Y value calculation\n> >       ipa: raspberrypi: imx296: Minor tuning updates\n> > \n> > Naushir Patuck (4):\n> >       pipeline: ipa: raspberrypi: Change Unicam timeout handling\n> >       ipa: raspberrypi: Better heuristics for calculating Unicam timeout\n> >       pipeline: raspberrypi: Add a Unicam timeout override config options\n> >       pipeline: raspberrypi: Iterate over all Unicam instances in match()\n> > \n> >  include/libcamera/ipa/raspberrypi.mojom              |   2 +-\n> >  src/ipa/raspberrypi/controller/rpi/agc.cpp           |   2 +-\n> >  src/ipa/raspberrypi/data/imx296.json                 | 180 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++---------------------------\n> >  src/ipa/raspberrypi/data/imx296_mono.json            |  12 ++++++++--\n> >  src/ipa/raspberrypi/raspberrypi.cpp                  |  45 +++++++++++++++++++++++++++++++++++---\n> >  src/libcamera/pipeline/raspberrypi/data/example.yaml |  11 +++++++++-\n> >  src/libcamera/pipeline/raspberrypi/raspberrypi.cpp   | 105 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-----------------------------\n> >  7 files changed, 282 insertions(+), 75 deletions(-)\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 69696BE080\n\tfor ;\n\tTue, 7 Mar 2023 22:24:33 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A9D7E626A7;\n\tTue, 7 Mar 2023 23:24:32 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7314C603AE\n\tfor ;\n\tTue, 7 Mar 2023 23:24:31 +0100 (CET)","from pendragon.ideasonboard.com\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E93724AD;\n\tTue, 7 Mar 2023 23:24:30 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1678227872;\n\tbh=uUJPDRAaZaGW3NGO1waA0fS/oYEjUxzxyXP0odol5zI=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=BZaSoIZzO7dsxp0VJ/C7YU1aR7OArafcX00K3ZnVSMKhXMlsoqr4ODE+R6f4uAokn\n\tB9gW1b+cjJBp432GnCEj2uO8zX7qsvb5lRD+VnidwkVUSKhEDT53Kn766dhqM1TOQc\n\tbNzXuFYXOHqewQ24yxgs4SCw5mvm8mAQCOXEWeJqouiOlFTSakDrdqFoH1AC5wB9sB\n\tMCjYaGHIu+diJROmb6RIiXeZ+PtK7PfSdkEETnm3/LPEsBmebIJlB3TTuBUw47z2n2\n\tu+M3sr/Lk1d4zhH6yLOIyUqGbJPBPcsHYxWjBKCQiZqxo1uKwRz4n/YjhLg7FLMkHF\n\txMtt6AioDTU0Q==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1678227871;\n\tbh=uUJPDRAaZaGW3NGO1waA0fS/oYEjUxzxyXP0odol5zI=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=OdfFFrG5rqkC4YZnZw1RDQLFtHrJw/ygbi1KcMZb0Yn4tZ2YdYjvFP+w1ooIN+7cF\n\t9Z4DWAUIOrdl1W4P3S3mS2sytHaj9r9EseKmy+w501LuVTB2FDYjSMa1gRdOop7xFc\n\tkpSE3KySfJD/n2h/tLE3g97sA0WsJzbnrqqSJ2BI="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"OdfFFrG5\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20230307171022.GA23376@pendragon.ideasonboard.com>","References":"\n\t<20230307171022.GA23376@pendragon.ideasonboard.com>","To":"Laurent Pinchart ,\n\tNaushir Patuck ","Date":"Tue, 07 Mar 2023 22:24:28 +0000","Message-ID":"<167822786880.93391.14855754073034250425@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] Pull request from\n\thttps://github.com/naushir/libcamera.git","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":26596,"web_url":"https://patchwork.libcamera.org/comment/26596/","msgid":"<20230308082417.GB14298@pendragon.ideasonboard.com>","date":"2023-03-08T08:24:17","subject":"Re: [libcamera-devel] Pull request from\n\thttps://github.com/naushir/libcamera.git","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Tue, Mar 07, 2023 at 10:24:28PM +0000, Kieran Bingham wrote:\n> Hi Naush,\n> \n> Quoting Laurent Pinchart (2023-03-07 17:10:22)\n> > Hi Naush,\n> > \n> > Thanks for the pull request.\n> > \n> > In the future, could you try to follow the kernel convention for the\n> > subject line ? It should start with a [GIT PULL] tag, and then have a\n> > short one-line description of the pull request. This one could be, for\n> > instance\n> > \n> > [GIT PULL] Raspberry Pi timeout handling improvements & other misc changes\n> \n> Thank you for trying this as new way to handle your integrations!\n> \n> Running through the integration scripts on my side failed:\n> \n> Missing committer Signed-off-by in commit f194529f9ba35421b66fee5e5bfcb2b8a148bbbf\n> Missing committer Signed-off-by in commit 95e7b5415aadccf1a8d706c3460e114553a49e06\n> Found 2 errors in refs/heads/master, not pushing\n> \n> Which was due to our pre-merge validation scripts noting that the\n> patches you cherry-picked from David were not Signed-off by the\n> 'committer' (now you).\n> \n> To be able to merge these, I've run git rebase --signoff, which has\n> recommitted these with my Sign-off. I figured I could have asked you to\n> resubmit a new pull request with your SoB - but it didn't seem worth the\n> extra cycle at this time.\n\nJust to make it clear, Naush, could you make sure, in future pull\nrequest, that all commits that list you as the committer have your SoB ?\nThis includes all commits that you cherry-pick, apply from an mbox file,\nor rebase. You can see the committer with `git log --pretty=fuller`.\n\nYou can also use the pre-push hook from utils/hooks/ (just copy it to\n.git/hooks/) to perform validity checks when pushing a branch. By\ndefault the script only checks branches named `master` or\n`integration/*`, but it's easy to modify it to accommodate your\nworkflow.\n\n> With that, they passed my integration tests, and are now merged.\n> \n> > On Tue, Mar 07, 2023 at 03:58:20PM +0000, Naushir Patuck via libcamera-devel wrote:\n> > > The following changes since commit cde9293cf9899b0fc4ce9cf89dd29f26be77f35c:\n> > > \n> > >   ipa: rkisp1: lsc: Fix integer division error (2023-03-06 18:12:10 +0100)\n> > > \n> > > are available in the Git repository at:\n> > > \n> > >   https://github.com/naushir/libcamera.git\n> > > \n> > > for you to fetch changes up to f194529f9ba35421b66fee5e5bfcb2b8a148bbbf:\n> > > \n> > >   ipa: raspberrypi: imx296: Minor tuning updates (2023-03-07 15:43:08 +0000)\n> > > \n> > > ----------------------------------------------------------------\n> > > David Plowman (2):\n> > >       ipa: raspberrypi: agc: Fix overflow in Y value calculation\n> > >       ipa: raspberrypi: imx296: Minor tuning updates\n> > > \n> > > Naushir Patuck (4):\n> > >       pipeline: ipa: raspberrypi: Change Unicam timeout handling\n> > >       ipa: raspberrypi: Better heuristics for calculating Unicam timeout\n> > >       pipeline: raspberrypi: Add a Unicam timeout override config options\n> > >       pipeline: raspberrypi: Iterate over all Unicam instances in match()\n> > > \n> > >  include/libcamera/ipa/raspberrypi.mojom              |   2 +-\n> > >  src/ipa/raspberrypi/controller/rpi/agc.cpp           |   2 +-\n> > >  src/ipa/raspberrypi/data/imx296.json                 | 180 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++---------------------------\n> > >  src/ipa/raspberrypi/data/imx296_mono.json            |  12 ++++++++--\n> > >  src/ipa/raspberrypi/raspberrypi.cpp                  |  45 +++++++++++++++++++++++++++++++++++---\n> > >  src/libcamera/pipeline/raspberrypi/data/example.yaml |  11 +++++++++-\n> > >  src/libcamera/pipeline/raspberrypi/raspberrypi.cpp   | 105 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-----------------------------\n> > >  7 files changed, 282 insertions(+), 75 deletions(-)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0FC48BE080\n\tfor ;\n\tWed, 8 Mar 2023 08:24:16 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 350BC626A7;\n\tWed, 8 Mar 2023 09:24:15 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 154DE62666\n\tfor ;\n\tWed, 8 Mar 2023 09:24:14 +0100 (CET)","from pendragon.ideasonboard.com\n\t(117.145-247-81.adsl-dyn.isp.belgacom.be [81.247.145.117])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 830C427C;\n\tWed, 8 Mar 2023 09:24:13 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1678263855;\n\tbh=tC5u37pVbn0T1FIfFoJg8YAsFVFi+3I+gjqvZsYUmAw=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=3k4WeTJ/BUxnlf2VYA/6t9HtZ4H60Aj+D+5WEGrNWRNrO9H5YSvBEsT5pcM20Hk+c\n\tEgwa2jZGPJlsosUkk1zgPsEO1GzycNEA9ZoGN9l74jc84ZlRyiFgyLwY+l4v+eMDxm\n\thYFh/00uooseKFkZ6EdOrOPiHPBtb6lT9X3pSJGxlQQ3fKQKSIsO1nQQ9jce8iMLHE\n\tc1Sy7JUPrv8UyBV0saAZaCkfN0/4eyPWZllYFOO1oeS8tu8F3r7/HWbGJKWi4ahyni\n\tpb6OTJYX2USzD0xwNgrUfgNt9OAnbULohNVPSz3XcQ2YaIoOmYvdYdUDOtd1tRdlUg\n\tp7PeYndcWkyEA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1678263853;\n\tbh=tC5u37pVbn0T1FIfFoJg8YAsFVFi+3I+gjqvZsYUmAw=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=DxhcNY27SocvTZ8p8HkXs3FQtKuz1yXJTk8rV+AYt0QGaAvJlCuzo3it+A73E6J65\n\tBrjvLbgRFzSjc83/TWDV8HCVSmHSxktewN352fZ78Zds2udYnyHzwL/OmIcdpODLbO\n\t59nwL4IBn/tf1jhcG3NHXrse0AUvsUZmniK6mTCI="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"DxhcNY27\"; dkim-atps=neutral","Date":"Wed, 8 Mar 2023 10:24:17 +0200","To":"Kieran Bingham ","Message-ID":"<20230308082417.GB14298@pendragon.ideasonboard.com>","References":"\n\t<20230307171022.GA23376@pendragon.ideasonboard.com>\n\t<167822786880.93391.14855754073034250425@Monstersaurus>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<167822786880.93391.14855754073034250425@Monstersaurus>","Subject":"Re: [libcamera-devel] Pull request from\n\thttps://github.com/naushir/libcamera.git","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":26597,"web_url":"https://patchwork.libcamera.org/comment/26597/","msgid":"","date":"2023-03-08T08:37:42","subject":"Re: [libcamera-devel] Pull request from\n\thttps://github.com/naushir/libcamera.git","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi all,\n\nOn Wed, 8 Mar 2023 at 08:24, Laurent Pinchart <\nlaurent.pinchart@ideasonboard.com> wrote:\n\n> On Tue, Mar 07, 2023 at 10:24:28PM +0000, Kieran Bingham wrote:\n> > Hi Naush,\n> >\n> > Quoting Laurent Pinchart (2023-03-07 17:10:22)\n> > > Hi Naush,\n> > >\n> > > Thanks for the pull request.\n> > >\n> > > In the future, could you try to follow the kernel convention for the\n> > > subject line ? It should start with a [GIT PULL] tag, and then have a\n> > > short one-line description of the pull request. This one could be, for\n> > > instance\n> > >\n> > > [GIT PULL] Raspberry Pi timeout handling improvements & other misc\n> changes\n> >\n> > Thank you for trying this as new way to handle your integrations!\n> >\n> > Running through the integration scripts on my side failed:\n> >\n> > Missing committer Signed-off-by in commit\n> f194529f9ba35421b66fee5e5bfcb2b8a148bbbf\n> > Missing committer Signed-off-by in commit\n> 95e7b5415aadccf1a8d706c3460e114553a49e06\n> > Found 2 errors in refs/heads/master, not pushing\n> >\n> > Which was due to our pre-merge validation scripts noting that the\n> > patches you cherry-picked from David were not Signed-off by the\n> > 'committer' (now you).\n> >\n> > To be able to merge these, I've run git rebase --signoff, which has\n> > recommitted these with my Sign-off. I figured I could have asked you to\n> > resubmit a new pull request with your SoB - but it didn't seem worth the\n> > extra cycle at this time.\n>\n> Just to make it clear, Naush, could you make sure, in future pull\n> request, that all commits that list you as the committer have your SoB ?\n> This includes all commits that you cherry-pick, apply from an mbox file,\n> or rebase. You can see the committer with `git log --pretty=fuller`.\n>\n> You can also use the pre-push hook from utils/hooks/ (just copy it to\n> .git/hooks/) to perform validity checks when pushing a branch. By\n> default the script only checks branches named `master` or\n> `integration/*`, but it's easy to modify it to accommodate your\n> workflow.\n>\n\nSure, I'll make sure to do that going forward. This git request-pull stuff\nis\nall new to me.\n\n\n>\n> > With that, they passed my integration tests, and are now merged.\n>\n\nExcellent, thanks!!\n\nNaush\n\n\n> >\n> > > On Tue, Mar 07, 2023 at 03:58:20PM +0000, Naushir Patuck via\n> libcamera-devel wrote:\n> > > > The following changes since commit\n> cde9293cf9899b0fc4ce9cf89dd29f26be77f35c:\n> > > >\n> > > > ipa: rkisp1: lsc: Fix integer division error (2023-03-06 18:12:10\n> +0100)\n> > > >\n> > > > are available in the Git repository at:\n> > > >\n> > > > https://github.com/naushir/libcamera.git\n> > > >\n> > > > for you to fetch changes up to\n> f194529f9ba35421b66fee5e5bfcb2b8a148bbbf:\n> > > >\n> > > > ipa: raspberrypi: imx296: Minor tuning updates (2023-03-07\n> 15:43:08 +0000)\n> > > >\n> > > > ----------------------------------------------------------------\n> > > > David Plowman (2):\n> > > > ipa: raspberrypi: agc: Fix overflow in Y value calculation\n> > > > ipa: raspberrypi: imx296: Minor tuning updates\n> > > >\n> > > > Naushir Patuck (4):\n> > > > pipeline: ipa: raspberrypi: Change Unicam timeout handling\n> > > > ipa: raspberrypi: Better heuristics for calculating Unicam\n> timeout\n> > > > pipeline: raspberrypi: Add a Unicam timeout override config\n> options\n> > > > pipeline: raspberrypi: Iterate over all Unicam instances in\n> match()\n> > > >\n> > > > include/libcamera/ipa/raspberrypi.mojom | 2 +-\n> > > > src/ipa/raspberrypi/controller/rpi/agc.cpp | 2 +-\n> > > > src/ipa/raspberrypi/data/imx296.json | 180\n> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++---------------------------\n> > > > src/ipa/raspberrypi/data/imx296_mono.json | 12\n> ++++++++--\n> > > > src/ipa/raspberrypi/raspberrypi.cpp | 45\n> +++++++++++++++++++++++++++++++++++---\n> > > > src/libcamera/pipeline/raspberrypi/data/example.yaml | 11\n> +++++++++-\n> > > > src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 105\n> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-----------------------------\n> > > > 7 files changed, 282 insertions(+), 75 deletions(-)\n>\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 766E5BDE17\n\tfor ;\n\tWed, 8 Mar 2023 08:37:56 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C56AA62693;\n\tWed, 8 Mar 2023 09:37:55 +0100 (CET)","from mail-yb1-xb2d.google.com (mail-yb1-xb2d.google.com\n\t[IPv6:2607:f8b0:4864:20::b2d])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1165762666\n\tfor ;\n\tWed, 8 Mar 2023 09:37:53 +0100 (CET)","by mail-yb1-xb2d.google.com with SMTP id e194so13898553ybf.1\n\tfor ;\n\tWed, 08 Mar 2023 00:37:52 -0800 (PST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1678264675;\n\tbh=HpyhJdpwMY8zm1UyB/RINw+SY3f2aGM7s3nlhzjAVP0=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=mULBKo+gw85SLtY3N6bfN5j2ZTD6m5OoHD2P/XaXp6YOs7OQHewrTSIMeAH51ou9o\n\tOa3E/fPLif4JyspihjOatEXWDDY/APmnldglxgdcmkCcIlGQlVETlpWU0AqkQmUuRw\n\tgnatcOD33wDXi7QhezFUXl9RLa4wAgZUGyWp64YK4EFitCic8TMK2oozw39j0C2zIF\n\tPwR/wxg6fs1yfs7+OLEFGiC35Lka9rjVqZRXPVfGeulUWyESkEu0qEH8sw55FxMt7I\n\tLaZAWNc4Q/SoGYtujI9uxNkZSl7AytCyKThDz1IaOny+lrygkaRd6qiEhBLWK933WC\n\tBEct4pPvuwNGA==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1678264672;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=0JUwsXQRMz6DYrkFQ1hDUfNVWPZ0swL2JuXeCILPk/A=;\n\tb=GI+/6Zgl7IXBKKj/8KYnpsx4v/C69EI7/bwuJfQdnbkHGAPVc02//Xdy+aLgI4mHrz\n\tVz4rkJxnRvHBd8V9ceXmpWvWRGnQOSS3hXvGDplSCpDa/d40PaU4W8KyARPeW3JqX0pO\n\tD5W/JZoWkuU4IzASZdlYTdd8aJVRcl9FyUCBFk6yp042bvHR2GmaybYxRMHL+j3kIED5\n\t1szNYrXp2ITRXgNKq612Z6DPxc170eEm8SMiJbxzPQJ39iY5iYMCnQYW0eBL1xVkgdcb\n\tw8Au4SGg833zJ49VEmxDBI2FvDqFxl1qAuUQhPqlK5WNkp4qFgq5u5d9rqcCkvRw0ffV\n\tsoJg=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"GI+/6Zgl\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112; t=1678264672;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=0JUwsXQRMz6DYrkFQ1hDUfNVWPZ0swL2JuXeCILPk/A=;\n\tb=hqD6hc+BIsFycbdJooM+6wOjnYQk2ylQmIhBZh5z3a8//fPTAwOxznFNyZuLqxoePl\n\tVPQhYFTidm7FNJ7Yyw9ThqkbA4KT8g734DSXqu2fEQO46mQDcUzyIi6/frmGjgx0dAUj\n\taF05F3yWB1mgBAzCacIP4L+l9GuhYm/TFM0EtdjxAAQs6QOzB1MJ/9vNvuw/4Wvi8XcV\n\tRebGWiktnT4ecQoyzrPe3MCo5w/AQrM5CcJqd5GH5UWZlwTSG4ws5qxL9XQR4vGRkE40\n\tlchjAqnfGIsj0av1EnaEZaHHaJs8pYO2fw5abkk+xWMQyeiz964hoJ23pBTeu90wAqLg\n\twQtQ==","X-Gm-Message-State":"AO0yUKV9YtxheHQTTx/Un5VsmSAeub9AY0+GJVcE3lgjS3qnLe+9tE1r\n\t1d0vSoRmhQEPIFjn0wZDCsuWIszXSUlV7r/JuUa0XgclkmoE6+8CqaxP3g==","X-Google-Smtp-Source":"AK7set/KGBeCc5A4XzyOCLARAHubJHwH820kklNwM41wG8R1VTMnES20Q+ZSGk8Leiaz7vODIreZ4OelEk0bJ/MrD5E=","X-Received":"by 2002:a5b:24a:0:b0:997:c919:4484 with SMTP id\n\tg10-20020a5b024a000000b00997c9194484mr3434297ybp.6.1678264671823;\n\tWed, 08 Mar 2023 00:37:51 -0800 (PST)","MIME-Version":"1.0","References":"\n\t<20230307171022.GA23376@pendragon.ideasonboard.com>\n\t<167822786880.93391.14855754073034250425@Monstersaurus>\n\t<20230308082417.GB14298@pendragon.ideasonboard.com>","In-Reply-To":"<20230308082417.GB14298@pendragon.ideasonboard.com>","Date":"Wed, 8 Mar 2023 08:37:42 +0000","Message-ID":"","To":"Laurent Pinchart ","Content-Type":"multipart/alternative; boundary=\"0000000000009a7bf705f65f7118\"","Subject":"Re: [libcamera-devel] Pull request from\n\thttps://github.com/naushir/libcamera.git","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Naushir Patuck via libcamera-devel\n\t","Reply-To":"Naushir Patuck ","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]