[{"id":26671,"web_url":"https://patchwork.libcamera.org/comment/26671/","msgid":"<20230319200825.GH13726@pendragon.ideasonboard.com>","date":"2023-03-19T20:08:25","subject":"Re: [libcamera-devel] [PATCH v3 4/4] libcamera: rkisp1: Fix\n\tenumeration of RAW formats","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Tue, Mar 07, 2023 at 12:48:04PM +0100, Jacopo Mondi via libcamera-devel wrote:\n> The current implementation enumerates a single RAW format (the sensor's\n> resolution) and does that regardless of what role the\n> CameraConfiguration has been generated for.\n> \n> Fix this by:\n> - Enumerate RAW StreamFormats only when the requested role is\n>   StreamRole::Raw\n> - Add all the sensor's provided resolutions that fit the video device\n>   output maximum size\n> \n> Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n> Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>\n> ---\n>  src/libcamera/pipeline/rkisp1/rkisp1_path.cpp | 19 +++++++++++++++++--\n>  1 file changed, 17 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp b/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp\n> index a27ac6fc35cb..0e4d76677732 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp\n> @@ -150,18 +150,33 @@ RkISP1Path::generateConfiguration(const CameraSensor *sensor,\n>  \tfor (const auto &format : streamFormats_) {\n>  \t\tconst PixelFormatInfo &info = PixelFormatInfo::info(format);\n>  \n> +\t\t/* Populate stream formats for non-RAW configurations. */\n>  \t\tif (info.colourEncoding != PixelFormatInfo::ColourEncodingRAW) {\n> +\t\t\tif (role == StreamRole::Raw)\n> +\t\t\t\tcontinue;\n> +\n>  \t\t\tstreamFormats[format] = { { minResolution, maxResolution } };\n>  \t\t\tcontinue;\n>  \t\t}\n>  \n> -\t\t/* Skip raw formats not supported by the sensor. */\n> +\t\t/* Skip RAW formats for non-raw roles. */\n> +\t\tif (role != StreamRole::Raw)\n> +\t\t\tcontinue;\n> +\n> +\t\t/* Populate stream formats for RAW configurations. */\n>  \t\tuint32_t mbusCode = formatToMediaBus.at(format);\n>  \t\tif (std::find(mbusCodes.begin(), mbusCodes.end(), mbusCode) ==\n>  \t\t    mbusCodes.end())\n> +\t\t\t/* Skip formats not supported by sensor. */\n>  \t\t\tcontinue;\n>  \n> -\t\tstreamFormats[format] = { { resolution, resolution } };\n> +\t\t/* Add all the RAW sizes the sensor can produce for this code. */\n> +\t\tfor (const auto &rawSize : sensor->sizes(mbusCode)) {\n> +\t\t\tif (rawSize > maxResolution_)\n\nI think you need to test the width and height independently, see how\nSize::operator>() is defined.\n\nWhat will happen if the sensor supports only sizes that are larger than\nwhat the ISP can process ?\n\nAlso, I'm wondering if the same ISP size limitation applies to raw\nformats, when bypassing the ISP for raw capture we may be able to\nsupport larger sizes.\n\n> +\t\t\t\tcontinue;\n> +\n> +\t\t\tstreamFormats[format].push_back({ rawSize, rawSize });\n> +\t\t}\n>  \n>  \t\t/*\n>  \t\t * Store the raw format with the highest bits per pixel for","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9B1F4BD80A\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSun, 19 Mar 2023 20:08:26 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D4442626DA;\n\tSun, 19 Mar 2023 21:08:25 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 10592626CA\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 19 Mar 2023 21:08:25 +0100 (CET)","from pendragon.ideasonboard.com (213-209-177-213.ip.skylogicnet.com\n\t[213.209.177.213])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A5432189A;\n\tSun, 19 Mar 2023 21:08:23 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1679256505;\n\tbh=dvDLIJCUX8kIYpZRwdavLFoa4TlEcyvIc91QorCSkXA=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=ouHP4/c+usHS8kC4WPWwuR0jshMX5M0wDdqqp/LAK9VbjZ3GHzpcKtK2S1MImZ99k\n\trV0qIBguLe8SzZ0r8iLyHp4PQGs0v/+A/Z9iIu9f/aZDL4/f+I7r8x0O8voS5y6zQV\n\tzsnvC35iIXzbxdy2sgaB0J5u0ES3i3/tFrdrAJOunh1myvC45BRrwDNic/3RfK1eku\n\tFapwpiSK5t8hWlfBkP6+R5VvL4n7n+OCXjz0OEhqZZHkn8U1iCaTqNLG7ZC/XQfuME\n\tgzTYKuVpNH3Ps6W0QhFxwk3isfrQqLhPFPMLETkwGLKsF2IifsQYMHlyWlsiK8QCs9\n\thzj+HkjhUPxIA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1679256504;\n\tbh=dvDLIJCUX8kIYpZRwdavLFoa4TlEcyvIc91QorCSkXA=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=DZoMSbkRGfLEZXtd8nIfvpLSs9QdKLYcYnKNKD6M+DhNuAtG4v1aVqdQ0/uO2+Hsf\n\t6rqpChxNRgWmEYeOiZ4sk3nf8OOLlMb4XgqiKeU0/fY8qcQCO5xnOu7KjnR48EWJ4e\n\txUK7bi2cNZ+6GL6+3N3IbuDamvhdhdRt7GQO6Bpk="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"DZoMSbkR\"; dkim-atps=neutral","Date":"Sun, 19 Mar 2023 22:08:25 +0200","To":"Jacopo Mondi <jacopo.mondi@ideasonboard.com>","Message-ID":"<20230319200825.GH13726@pendragon.ideasonboard.com>","References":"<20230307114804.42291-1-jacopo.mondi@ideasonboard.com>\n\t<20230307114804.42291-5-jacopo.mondi@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20230307114804.42291-5-jacopo.mondi@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v3 4/4] libcamera: rkisp1: Fix\n\tenumeration of RAW formats","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>","Reply-To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org, libcamera@luigi311.com","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":26676,"web_url":"https://patchwork.libcamera.org/comment/26676/","msgid":"<20230320073013.q66viorzo4on6nmc@uno.localdomain>","date":"2023-03-20T07:30:13","subject":"Re: [libcamera-devel] [PATCH v3 4/4] libcamera: rkisp1: Fix\n\tenumeration of RAW formats","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Laurent\n\nOn Sun, Mar 19, 2023 at 10:08:25PM +0200, Laurent Pinchart wrote:\n> Hi Jacopo,\n>\n> Thank you for the patch.\n>\n> On Tue, Mar 07, 2023 at 12:48:04PM +0100, Jacopo Mondi via libcamera-devel wrote:\n> > The current implementation enumerates a single RAW format (the sensor's\n> > resolution) and does that regardless of what role the\n> > CameraConfiguration has been generated for.\n> >\n> > Fix this by:\n> > - Enumerate RAW StreamFormats only when the requested role is\n> >   StreamRole::Raw\n> > - Add all the sensor's provided resolutions that fit the video device\n> >   output maximum size\n> >\n> > Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n> > Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>\n> > ---\n> >  src/libcamera/pipeline/rkisp1/rkisp1_path.cpp | 19 +++++++++++++++++--\n> >  1 file changed, 17 insertions(+), 2 deletions(-)\n> >\n> > diff --git a/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp b/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp\n> > index a27ac6fc35cb..0e4d76677732 100644\n> > --- a/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp\n> > +++ b/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp\n> > @@ -150,18 +150,33 @@ RkISP1Path::generateConfiguration(const CameraSensor *sensor,\n> >  \tfor (const auto &format : streamFormats_) {\n> >  \t\tconst PixelFormatInfo &info = PixelFormatInfo::info(format);\n> >\n> > +\t\t/* Populate stream formats for non-RAW configurations. */\n> >  \t\tif (info.colourEncoding != PixelFormatInfo::ColourEncodingRAW) {\n> > +\t\t\tif (role == StreamRole::Raw)\n> > +\t\t\t\tcontinue;\n> > +\n> >  \t\t\tstreamFormats[format] = { { minResolution, maxResolution } };\n> >  \t\t\tcontinue;\n> >  \t\t}\n> >\n> > -\t\t/* Skip raw formats not supported by the sensor. */\n> > +\t\t/* Skip RAW formats for non-raw roles. */\n> > +\t\tif (role != StreamRole::Raw)\n> > +\t\t\tcontinue;\n> > +\n> > +\t\t/* Populate stream formats for RAW configurations. */\n> >  \t\tuint32_t mbusCode = formatToMediaBus.at(format);\n> >  \t\tif (std::find(mbusCodes.begin(), mbusCodes.end(), mbusCode) ==\n> >  \t\t    mbusCodes.end())\n> > +\t\t\t/* Skip formats not supported by sensor. */\n> >  \t\t\tcontinue;\n> >\n> > -\t\tstreamFormats[format] = { { resolution, resolution } };\n> > +\t\t/* Add all the RAW sizes the sensor can produce for this code. */\n> > +\t\tfor (const auto &rawSize : sensor->sizes(mbusCode)) {\n> > +\t\t\tif (rawSize > maxResolution_)\n>\n> I think you need to test the width and height independently, see how\n> Size::operator>() is defined.\n>\n\nAck\n\n> What will happen if the sensor supports only sizes that are larger than\n> what the ISP can process ?\n>\n\nHow can you capture -anything- if none of the sensor's sizes is\ncompatible with the ISP input limits ?\n\nI've also missed how is this realted to this patch\n\n> Also, I'm wondering if the same ISP size limitation applies to raw\n> formats, when bypassing the ISP for raw capture we may be able to\n> support larger sizes.\n>\n> > +\t\t\t\tcontinue;\n> > +\n> > +\t\t\tstreamFormats[format].push_back({ rawSize, rawSize });\n> > +\t\t}\n> >\n> >  \t\t/*\n> >  \t\t * Store the raw format with the highest bits per pixel for\n>\n> --\n> Regards,\n>\n> Laurent Pinchart","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5C79BC0F1B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 20 Mar 2023 07:30:19 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2A761626E2;\n\tMon, 20 Mar 2023 08:30:18 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3FE5C626D8\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 20 Mar 2023 08:30:16 +0100 (CET)","from ideasonboard.com (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A6E891373;\n\tMon, 20 Mar 2023 08:30:15 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1679297418;\n\tbh=NcLJw7ND6qXWMSaPXjGAeP9IsSLeiumXnvsqa1ycoFA=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=xVyN9SLXdEDtvbYhcMbMmrhiS4x2v6fZGzgAbuoQTatScvD6v99YwijSq3et1C9u/\n\t6Ol9bm2UEJxkq9VekOJgIqkTDwh9bRnNXDdv1Z38KXdxwHRB5PvHLrbra0vMamotco\n\tLh1fVvdDCsNC+QJW/UDkuZXOaO5SJ0ki+WdIk6ArjHs1ljrv3Mc+q8eKM3nuW6xO1W\n\tEu+pbTFBVmC6PUqRWqhXK/xPDKWo23m6wU1mKAucK2rUrs9HJ2JBnYQ0/Q5JNGMTyH\n\tv4Tu4oOW3PJeyfiZA7VeWU5VUKsUQrm3wbACODmpPRSPhqYXQ07zx+ojt8F7QMtzYh\n\tAK5WkbVhIyOfQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1679297415;\n\tbh=NcLJw7ND6qXWMSaPXjGAeP9IsSLeiumXnvsqa1ycoFA=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=lXBVlitU/KwfCYlvD7Zs9ffgEZfMFfJQJ1nzATulrT5FvbXBnOYy6LP8BP6sdANI8\n\tYSoU+Hv5+4NYDRwDIbP7FiZ2U/apTDOHTJtBsQJp3uiIAK8i54k/32oc4Bo4ENwRhY\n\tTkOXyWCRs78jwz26lo4R7rcIDo8LLIfRXyPyLh7A="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"lXBVlitU\"; dkim-atps=neutral","Date":"Mon, 20 Mar 2023 08:30:13 +0100","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Message-ID":"<20230320073013.q66viorzo4on6nmc@uno.localdomain>","References":"<20230307114804.42291-1-jacopo.mondi@ideasonboard.com>\n\t<20230307114804.42291-5-jacopo.mondi@ideasonboard.com>\n\t<20230319200825.GH13726@pendragon.ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20230319200825.GH13726@pendragon.ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v3 4/4] libcamera: rkisp1: Fix\n\tenumeration of RAW formats","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Jacopo Mondi via libcamera-devel <libcamera-devel@lists.libcamera.org>","Reply-To":"Jacopo Mondi <jacopo.mondi@ideasonboard.com>","Cc":"Jacopo Mondi <jacopo.mondi@ideasonboard.com>,\n\tlibcamera-devel@lists.libcamera.org, libcamera@luigi311.com","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":26686,"web_url":"https://patchwork.libcamera.org/comment/26686/","msgid":"<20230320233951.GV20234@pendragon.ideasonboard.com>","date":"2023-03-20T23:39:51","subject":"Re: [libcamera-devel] [PATCH v3 4/4] libcamera: rkisp1: Fix\n\tenumeration of RAW formats","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nOn Mon, Mar 20, 2023 at 08:30:13AM +0100, Jacopo Mondi wrote:\n> On Sun, Mar 19, 2023 at 10:08:25PM +0200, Laurent Pinchart wrote:\n> > On Tue, Mar 07, 2023 at 12:48:04PM +0100, Jacopo Mondi via libcamera-devel wrote:\n> > > The current implementation enumerates a single RAW format (the sensor's\n> > > resolution) and does that regardless of what role the\n> > > CameraConfiguration has been generated for.\n> > >\n> > > Fix this by:\n> > > - Enumerate RAW StreamFormats only when the requested role is\n> > >   StreamRole::Raw\n> > > - Add all the sensor's provided resolutions that fit the video device\n> > >   output maximum size\n> > >\n> > > Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n> > > Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>\n> > > ---\n> > >  src/libcamera/pipeline/rkisp1/rkisp1_path.cpp | 19 +++++++++++++++++--\n> > >  1 file changed, 17 insertions(+), 2 deletions(-)\n> > >\n> > > diff --git a/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp b/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp\n> > > index a27ac6fc35cb..0e4d76677732 100644\n> > > --- a/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp\n> > > +++ b/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp\n> > > @@ -150,18 +150,33 @@ RkISP1Path::generateConfiguration(const CameraSensor *sensor,\n> > >  \tfor (const auto &format : streamFormats_) {\n> > >  \t\tconst PixelFormatInfo &info = PixelFormatInfo::info(format);\n> > >\n> > > +\t\t/* Populate stream formats for non-RAW configurations. */\n> > >  \t\tif (info.colourEncoding != PixelFormatInfo::ColourEncodingRAW) {\n> > > +\t\t\tif (role == StreamRole::Raw)\n> > > +\t\t\t\tcontinue;\n> > > +\n> > >  \t\t\tstreamFormats[format] = { { minResolution, maxResolution } };\n> > >  \t\t\tcontinue;\n> > >  \t\t}\n> > >\n> > > -\t\t/* Skip raw formats not supported by the sensor. */\n> > > +\t\t/* Skip RAW formats for non-raw roles. */\n> > > +\t\tif (role != StreamRole::Raw)\n> > > +\t\t\tcontinue;\n> > > +\n> > > +\t\t/* Populate stream formats for RAW configurations. */\n> > >  \t\tuint32_t mbusCode = formatToMediaBus.at(format);\n> > >  \t\tif (std::find(mbusCodes.begin(), mbusCodes.end(), mbusCode) ==\n> > >  \t\t    mbusCodes.end())\n> > > +\t\t\t/* Skip formats not supported by sensor. */\n> > >  \t\t\tcontinue;\n> > >\n> > > -\t\tstreamFormats[format] = { { resolution, resolution } };\n> > > +\t\t/* Add all the RAW sizes the sensor can produce for this code. */\n> > > +\t\tfor (const auto &rawSize : sensor->sizes(mbusCode)) {\n> > > +\t\t\tif (rawSize > maxResolution_)\n> >\n> > I think you need to test the width and height independently, see how\n> > Size::operator>() is defined.\n> >\n> \n> Ack\n> \n> > What will happen if the sensor supports only sizes that are larger than\n> > what the ISP can process ?\n> \n> How can you capture -anything- if none of the sensor's sizes is\n> compatible with the ISP input limits ?\n\nYou can't, but I was wondering if we would error out when creating the\ncamera, fail in other ways, or crash.\n\n> I've also missed how is this realted to this patch\n\nThis patch adds new checks on the size, so I was wondering if it changes\nthe behaviour (for instance from a failure to a crash).\n\n> > Also, I'm wondering if the same ISP size limitation applies to raw\n> > formats, when bypassing the ISP for raw capture we may be able to\n> > support larger sizes.\n> >\n> > > +\t\t\t\tcontinue;\n> > > +\n> > > +\t\t\tstreamFormats[format].push_back({ rawSize, rawSize });\n> > > +\t\t}\n> > >\n> > >  \t\t/*\n> > >  \t\t * Store the raw format with the highest bits per pixel for","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A7083C0F2A\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 20 Mar 2023 23:39:48 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C4A17626E5;\n\tTue, 21 Mar 2023 00:39:47 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5B6C6626DA\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 21 Mar 2023 00:39:46 +0100 (CET)","from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi\n\t[213.243.189.158])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AC588496;\n\tTue, 21 Mar 2023 00:39:45 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1679355587;\n\tbh=or4jfi0NB+G1T6SpQZqL9ICuUfvy9a5FCXhtnI0JObs=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=Mu/AzrH7EM+/etmnSoxdbGnRBUDlHtTgv3EYWG8GQuNN8fqAtUWSC1Ixb/ufzqNgj\n\tq6CPuQHr6ySCh5sQNhbYVSYtalEKEWC6nYVe9dcYSKbeNmABLumzWAhTwLrs29qCXf\n\tV18Btvsjp9dolocMg6UADD9bX8JtLENw3jkE2md10gJB3L8yzlZa1C+6hUqZ2fHpFr\n\tpQRqnaLnumzWhdFtSskeST3Qmyk8uRryuynVvUSn+PABkI70EwyihcixhcuxlFi9x9\n\tsUdvRMEtEQg55v04Q07xGJOYxPKnolLmw/xRzSHzbXAmumk84fmuokSQx6SnjAjHsM\n\tJtv1ZMQCcsbdg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1679355585;\n\tbh=or4jfi0NB+G1T6SpQZqL9ICuUfvy9a5FCXhtnI0JObs=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=cQtEMQneXtXjEpoQP6Tpr2CH0sZgXk1zQZs7onBFbBWaZGsbdfS9vHeig3pL4Migq\n\tqjmzsgKLeh7/zTFgOcDMw3xvJCKgHMLsf0F3Bk04eLUM3kgcDylIu7cKPnF4xlnGnj\n\tNbi2GIOlTlLHcNjjiehiU4bNvsf8/y66IMbUEOZg="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"cQtEMQne\"; dkim-atps=neutral","Date":"Tue, 21 Mar 2023 01:39:51 +0200","To":"Jacopo Mondi <jacopo.mondi@ideasonboard.com>","Message-ID":"<20230320233951.GV20234@pendragon.ideasonboard.com>","References":"<20230307114804.42291-1-jacopo.mondi@ideasonboard.com>\n\t<20230307114804.42291-5-jacopo.mondi@ideasonboard.com>\n\t<20230319200825.GH13726@pendragon.ideasonboard.com>\n\t<20230320073013.q66viorzo4on6nmc@uno.localdomain>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20230320073013.q66viorzo4on6nmc@uno.localdomain>","Subject":"Re: [libcamera-devel] [PATCH v3 4/4] libcamera: rkisp1: Fix\n\tenumeration of RAW formats","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>","Reply-To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org, libcamera@luigi311.com","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]