[{"id":26553,"web_url":"https://patchwork.libcamera.org/comment/26553/","msgid":"","date":"2023-03-06T05:09:59","subject":"Re: [libcamera-devel] [PATCH 1/1] fix: pipeline handlers: Stop\n\texponential explosive calls to createPipelineHandlers","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"HI Sophie,\n\nThank you for the patch\n\nOn 3/6/23 4:36 AM, Sophie Friedrich via libcamera-devel wrote:\n> Currently the method `createPipelineHandlers` registered itself to the\n> `devicesAdded` signal at the end of each call. As the Signal object\n> supports multiple non-unique listeners connected to it, the former\ns/listeners/slots maybe ?\n> method would be called exponentially often with each new emitted event\n> on `devicesAdded` (i.e. with udev plugging in a new camera)\n\nindeed, quite a bug!\n>\n> By attaching the `createPipelineHandlers` function to `devicesAdded` during\n> the first call to it / init of the `CameraManager::Private` this effect\n> is prevented.\n\nWould repharase a bit to :\n\nFix it by registering the createPipelineHandlers() slot to \n`devicesAdded` signal in\nCameraManager::Private::init() instead. This will prevent the slot \ngetting registered\nmultiple times to the `devicesAdded` signal.\n>\n> Signed-off-by: Sophie Friedrich \n\nLGTM\n\nReviewed-by: Umang Jain \n\n> ---\n> src/libcamera/camera_manager.cpp | 3 +--\n> 1 file changed, 1 insertion(+), 2 deletions(-)\n>\n> diff --git a/src/libcamera/camera_manager.cpp b/src/libcamera/camera_manager.cpp\n> index b1785f75..c1edefda 100644\n> --- a/src/libcamera/camera_manager.cpp\n> +++ b/src/libcamera/camera_manager.cpp\n> @@ -131,6 +131,7 @@ int CameraManager::Private::init()\n> \t\treturn -ENODEV;\n> \n> \tcreatePipelineHandlers();\n> +\tenumerator_->devicesAdded.connect(this, &Private::createPipelineHandlers);\n> \n> \treturn 0;\n> }\n> @@ -165,8 +166,6 @@ void CameraManager::Private::createPipelineHandlers()\n> \t\t\t\t<< \"\\\" matched\";\n> \t\t}\n> \t}\n> -\n> -\tenumerator_->devicesAdded.connect(this, &Private::createPipelineHandlers);\n> }\n> \n> void CameraManager::Private::cleanup()","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AFC56BDE17\n\tfor ;\n\tMon, 6 Mar 2023 05:10:07 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EB57B62666;\n\tMon, 6 Mar 2023 06:10:06 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8445E61EDA\n\tfor ;\n\tMon, 6 Mar 2023 06:10:04 +0100 (CET)","from [IPV6:2401:4900:1c80:1499:efd8:a543:13d1:6b56] (unknown\n\t[IPv6:2401:4900:1c80:1499:efd8:a543:13d1:6b56])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 78AC310C;\n\tMon, 6 Mar 2023 06:10:03 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1678079406;\n\tbh=XmDZlrpCOrHyPdsqS/4N/+V83k5TPzASSZd/AIWM360=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=qsfF5yL9vAB+YASRk3XL8XawvWz26x/coJ4X8vJFwlfnIJBv3GrjfeikUx47hgjjl\n\tKG6tvA8wnlY9uxI8oizk9/0dH5Al8Jav9ATIlGCmHXQ3eedkfxsOHP/PVbRukcFMMc\n\tHyFa+HsByp3kKudFPK3u8izQ7rqY3vUobUJrJ2bBeAazR4GwUdg57uSvzeQQ82AQeb\n\t8uhhmhmAa+KHCgmufcYRwfY1IkDD4V0gSEzb940o54SoCYPFcnl910zyQGrD/H/w+B\n\t0cHpuD+a63D6KNyD4/pEWxOi71yMfP+vZE6eZldGs0vYgUHven3OHjFIioHz2MCeos\n\t8aScTb4jve31w==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1678079404;\n\tbh=XmDZlrpCOrHyPdsqS/4N/+V83k5TPzASSZd/AIWM360=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=n/hdKMpSZWR3agNRmfo1BYhhirJbqiWBYcpxqJGRQ8cVbNCWNq1kOLjUqDJJBaw58\n\tkxdRAl0EAaBapaNyhpPGL3kMUhe/MR85JFmNmVf8Ss/T6UI3hYnA+aAECKP1EVLXjc\n\tFJrgYiWLo10RxK/HZUmYCyvMQLpFGbgZV4AxS6qw="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"n/hdKMpS\"; dkim-atps=neutral","Message-ID":"","Date":"Mon, 6 Mar 2023 10:39:59 +0530","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101\n\tThunderbird/102.7.1","Content-Language":"en-US","To":"Sophie Friedrich , libcamera-devel@lists.libcamera.org","References":"<20230305230603.3697024-1-dev@flowerpot.me>\n\t<20230305230603.3697024-2-dev@flowerpot.me>","In-Reply-To":"<20230305230603.3697024-2-dev@flowerpot.me>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH 1/1] fix: pipeline handlers: Stop\n\texponential explosive calls to createPipelineHandlers","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Umang Jain via libcamera-devel ","Reply-To":"Umang Jain ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":26557,"web_url":"https://patchwork.libcamera.org/comment/26557/","msgid":"<20230306104513.GD20909@pendragon.ideasonboard.com>","date":"2023-03-06T10:45:13","subject":"Re: [libcamera-devel] [PATCH 1/1] fix: pipeline handlers: Stop\n\texponential explosive calls to createPipelineHandlers","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hello,\n\nOn Mon, Mar 06, 2023 at 10:39:59AM +0530, Umang Jain via libcamera-devel wrote:\n> HI Sophie,\n> \n> Thank you for the patch\n> \n> On 3/6/23 4:36 AM, Sophie Friedrich via libcamera-devel wrote:\n> > Currently the method `createPipelineHandlers` registered itself to the\n\nWe use \"function\" instead of \"method\" in libcamera, as the term \"method\"\ncomes from Java, and the C++ standard uses \"function\".\n\n> > `devicesAdded` signal at the end of each call. As the Signal object\n> > supports multiple non-unique listeners connected to it, the former\n>\n> s/listeners/slots maybe ?\n>\n> > method would be called exponentially often with each new emitted event\n> > on `devicesAdded` (i.e. with udev plugging in a new camera)\n> \n> indeed, quite a bug!\n\nOops, indeed.\n\n> > By attaching the `createPipelineHandlers` function to `devicesAdded` during\n> > the first call to it / init of the `CameraManager::Private` this effect\n> > is prevented.\n> \n> Would repharase a bit to :\n> \n> Fix it by registering the createPipelineHandlers() slot to \n\ns/registering/connecting/\n\n> `devicesAdded` signal in\n> CameraManager::Private::init() instead. This will prevent the slot \n> getting registered\n\ns/registered/connected/\n\n> multiple times to the `devicesAdded` signal.\n>\n> > Signed-off-by: Sophie Friedrich \n> \n> LGTM\n> \n> Reviewed-by: Umang Jain \n\nReviewed-by: Laurent Pinchart \n\nI'll apply the minor changes mentioned above locally, no need to submit\na v2.\n\n> > ---\n> > src/libcamera/camera_manager.cpp | 3 +--\n> > 1 file changed, 1 insertion(+), 2 deletions(-)\n> >\n> > diff --git a/src/libcamera/camera_manager.cpp b/src/libcamera/camera_manager.cpp\n> > index b1785f75..c1edefda 100644\n> > --- a/src/libcamera/camera_manager.cpp\n> > +++ b/src/libcamera/camera_manager.cpp\n> > @@ -131,6 +131,7 @@ int CameraManager::Private::init()\n> > \t\treturn -ENODEV;\n> > \n> > \tcreatePipelineHandlers();\n> > +\tenumerator_->devicesAdded.connect(this, &Private::createPipelineHandlers);\n> > \n> > \treturn 0;\n> > }\n> > @@ -165,8 +166,6 @@ void CameraManager::Private::createPipelineHandlers()\n> > \t\t\t\t<< \"\\\" matched\";\n> > \t\t}\n> > \t}\n> > -\n> > -\tenumerator_->devicesAdded.connect(this, &Private::createPipelineHandlers);\n> > }\n> > \n> > void CameraManager::Private::cleanup()","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id ECFA2BDE17\n\tfor ;\n\tMon, 6 Mar 2023 10:45:12 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 56F2F62673;\n\tMon, 6 Mar 2023 11:45:12 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 691FA62665\n\tfor ;\n\tMon, 6 Mar 2023 11:45:10 +0100 (CET)","from pendragon.ideasonboard.com\n\t(153.162-64-87.adsl-dyn.isp.belgacom.be [87.64.162.153])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B1FE7EF;\n\tMon, 6 Mar 2023 11:45:09 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1678099512;\n\tbh=MNMd/f69dsxkdZ/ThWXTGppJ7VfTJ+EniYL7/sRRM/I=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=r10yD25LTK35M+XOw0LtNV29STNVWcXSaJewdRcA8nHTT6POZMNeF+EhWDl3sinVt\n\tQA7zNuvASIR9MOmRYSb2qMYp4hDKcZ7SCS9XVFbEGsXwo2sPHxNE8CvZbSN+8hF2Mx\n\thf+u3S6CnZOkbVYAELm8D/PfHp7BKaUEL8XlOfsb7iybw0dVcAewvAl0cWU1J08wSh\n\tdUnbDILK6cp2aanxBl40Vrc3YLTSH/7VTVH68vwJUIjzP5yiS0gi5i57xoQbBeAWlE\n\tZ3fO0EzCS3HejQUVdMBo95qDmYzVswJCE5rdK1KLD8FKLIgv310Vp6CCiOZRBlgbUv\n\tMut90q/slVT2g==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1678099509;\n\tbh=MNMd/f69dsxkdZ/ThWXTGppJ7VfTJ+EniYL7/sRRM/I=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=SDnUNuVs40aHHG06fc7MinrvqnRj6OYPGvHV5WdlTF3oxwXtLi6QCnJJe7PmhnOKt\n\tLYaqSzLCjLBC8H656kteuIcIcAvGezLZIkcgMt9FzZlrV1tTqN+WfdHKVRxYm9WX+X\n\tGI/PXOIQbTJ2pPJFBhMO3b+iWmUIL9YziCa7oPfY="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"SDnUNuVs\"; dkim-atps=neutral","Date":"Mon, 6 Mar 2023 12:45:13 +0200","To":"Umang Jain ","Message-ID":"<20230306104513.GD20909@pendragon.ideasonboard.com>","References":"<20230305230603.3697024-1-dev@flowerpot.me>\n\t<20230305230603.3697024-2-dev@flowerpot.me>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH 1/1] fix: pipeline handlers: Stop\n\texponential explosive calls to createPipelineHandlers","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org, Sophie Friedrich ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":26558,"web_url":"https://patchwork.libcamera.org/comment/26558/","msgid":"<20230306105841.GE20909@pendragon.ideasonboard.com>","date":"2023-03-06T10:58:41","subject":"Re: [libcamera-devel] [PATCH 1/1] fix: pipeline handlers: Stop\n\texponential explosive calls to createPipelineHandlers","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Also, the commit title should be start with the \"libcamera:\ncamera_manager:\" prefix:\n\nlibcamera: camera_manager: Stop exponential explosive calls to createPipelineHandlers\n\nWe also try to keep the title within a (soft) limit of 72 characters.\nThe following could work:\n\nlibcamera: camera_manager: Connect deviceAdded signal once only\n\nWould that be OK with you ?\n\nOn Mon, Mar 06, 2023 at 12:45:14PM +0200, Laurent Pinchart wrote:\n> Hello,\n> \n> On Mon, Mar 06, 2023 at 10:39:59AM +0530, Umang Jain via libcamera-devel wrote:\n> > HI Sophie,\n> > \n> > Thank you for the patch\n> > \n> > On 3/6/23 4:36 AM, Sophie Friedrich via libcamera-devel wrote:\n> > > Currently the method `createPipelineHandlers` registered itself to the\n> \n> We use \"function\" instead of \"method\" in libcamera, as the term \"method\"\n> comes from Java, and the C++ standard uses \"function\".\n> \n> > > `devicesAdded` signal at the end of each call. As the Signal object\n> > > supports multiple non-unique listeners connected to it, the former\n> >\n> > s/listeners/slots maybe ?\n> >\n> > > method would be called exponentially often with each new emitted event\n> > > on `devicesAdded` (i.e. with udev plugging in a new camera)\n> > \n> > indeed, quite a bug!\n> \n> Oops, indeed.\n> \n> > > By attaching the `createPipelineHandlers` function to `devicesAdded` during\n> > > the first call to it / init of the `CameraManager::Private` this effect\n> > > is prevented.\n> > \n> > Would repharase a bit to :\n> > \n> > Fix it by registering the createPipelineHandlers() slot to \n> \n> s/registering/connecting/\n> \n> > `devicesAdded` signal in\n> > CameraManager::Private::init() instead. This will prevent the slot \n> > getting registered\n> \n> s/registered/connected/\n> \n> > multiple times to the `devicesAdded` signal.\n> >\n> > > Signed-off-by: Sophie Friedrich \n> > \n> > LGTM\n> > \n> > Reviewed-by: Umang Jain \n> \n> Reviewed-by: Laurent Pinchart \n> \n> I'll apply the minor changes mentioned above locally, no need to submit\n> a v2.\n> \n> > > ---\n> > > src/libcamera/camera_manager.cpp | 3 +--\n> > > 1 file changed, 1 insertion(+), 2 deletions(-)\n> > >\n> > > diff --git a/src/libcamera/camera_manager.cpp b/src/libcamera/camera_manager.cpp\n> > > index b1785f75..c1edefda 100644\n> > > --- a/src/libcamera/camera_manager.cpp\n> > > +++ b/src/libcamera/camera_manager.cpp\n> > > @@ -131,6 +131,7 @@ int CameraManager::Private::init()\n> > > \t\treturn -ENODEV;\n> > > \n> > > \tcreatePipelineHandlers();\n> > > +\tenumerator_->devicesAdded.connect(this, &Private::createPipelineHandlers);\n> > > \n> > > \treturn 0;\n> > > }\n> > > @@ -165,8 +166,6 @@ void CameraManager::Private::createPipelineHandlers()\n> > > \t\t\t\t<< \"\\\" matched\";\n> > > \t\t}\n> > > \t}\n> > > -\n> > > -\tenumerator_->devicesAdded.connect(this, &Private::createPipelineHandlers);\n> > > }\n> > > \n> > > void CameraManager::Private::cleanup()","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D7C13BE080\n\tfor ;\n\tMon, 6 Mar 2023 10:58:39 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F330162676;\n\tMon, 6 Mar 2023 11:58:38 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CBC2C603B3\n\tfor ;\n\tMon, 6 Mar 2023 11:58:37 +0100 (CET)","from pendragon.ideasonboard.com\n\t(153.162-64-87.adsl-dyn.isp.belgacom.be [87.64.162.153])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 352ECEF;\n\tMon, 6 Mar 2023 11:58:37 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1678100319;\n\tbh=e64iBDZG/iZgOeqc4XnAtzOWjA2iIt4sg6bb37QoqK4=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=1XZmHoAq6D7SjMkdcZFw8ktLCNKihV7+1vbSR4yLX2ivWWE+t1KZrvEZtz7xDLpS9\n\tRC3EoMdpANUadEpEcFw74PpSZYHdbFfphanxh6G+Ke2YqhH90l6VWFK32QpP8vGIJf\n\tQvmxn0mvl3xKlLJIKAOg4lTvM0RQ8mICsiX+W1I90OcXH/yfi3jyROxGUHQd/4Mfvm\n\tmYPTrXviC/3kcQk8j8tkso9U/MV1eGetgvKGEWR/YuRG2aRJwmJsAWTtk3vXzDQjCY\n\tiqQ6s7S6kw0QuF83j/8mi8z046DSoeR5HFIVZcgSj9XuGYAJRltMUANBalUXx00umY\n\tWSpk2uu7aOFvw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1678100317;\n\tbh=e64iBDZG/iZgOeqc4XnAtzOWjA2iIt4sg6bb37QoqK4=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=cIhSot5iUEBFjt3mDD6DkHan6B6WHsMEi9BmqLtJeEUZaXQ6D4F2iJ84Xq6rCEPrU\n\tagpcIfaPvH4DtqrekiV1CyM8BWyo5BN8FeV6o6v4o7ALYZCzLw2GypcLrp+x3t5GQT\n\tXebzIgHoojeNFFu4Pym3+p6Pq9nBl6/mYJRrNI1k="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"cIhSot5i\"; dkim-atps=neutral","Date":"Mon, 6 Mar 2023 12:58:41 +0200","To":"Sophie Friedrich ","Message-ID":"<20230306105841.GE20909@pendragon.ideasonboard.com>","References":"<20230305230603.3697024-1-dev@flowerpot.me>\n\t<20230305230603.3697024-2-dev@flowerpot.me>\n\t\n\t<20230306104513.GD20909@pendragon.ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20230306104513.GD20909@pendragon.ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 1/1] fix: pipeline handlers: Stop\n\texponential explosive calls to createPipelineHandlers","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]