[{"id":26559,"web_url":"https://patchwork.libcamera.org/comment/26559/","msgid":"<20230306110945.GF20909@pendragon.ideasonboard.com>","date":"2023-03-06T11:09:45","subject":"Re: [libcamera-devel] [PATCH v4] documentation: guides:\n\tpipeline-handler: Fix spelling error","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Advait,\n\nThank you for the patch.\n\nOn Sat, Mar 04, 2023 at 04:07:58PM +0530, Advait Dhamorikar via libcamera-devel wrote:\n> The pipeline handler writers guide incorrectly references the\n> VividCameradata::init() impelementation with a spelling error\n\nSentences should end with a period.\n\n> \n> Fix spelling of \"impelementation\" in the pipeline handler development guide\n\nAnd lines in the commit message should be wrapped at 72 columns.\n\n> \n> Reviewed-by: Kieran Bingham \n> \n\nTags should be grouped together, this blank line can be dropped. I'll\nfix this locally, no need to send a new version.\n\n> Signed-off-by: Advait Dhamorikar \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> Hello Kieran,\n> Thanks for the review, here's another version with the mentioned changes,\n> I'm currently studying how simple-cam works, looking forward to contribute more.\n> \n> Regards,\n> Advait\n> \n> Documentation/guides/pipeline-handler.rst | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/Documentation/guides/pipeline-handler.rst b/Documentation/guides/pipeline-handler.rst\n> index e1930fdf..4d38fa23 100644\n> --- a/Documentation/guides/pipeline-handler.rst\n> +++ b/Documentation/guides/pipeline-handler.rst\n> @@ -1409,7 +1409,7 @@ function to the V4L2 device buffer signal.\n> video_->bufferReady.connect(this, &VividCameraData::bufferReady);\n> \n> Create the matching ``VividCameraData::bufferReady`` function after your\n> -VividCameradata::init() impelementation.\n> +VividCameradata::init() implementation.\n> \n> The ``bufferReady`` function obtains the request from the buffer using the\n> ``request`` function, and notifies the ``Camera`` that the buffer and","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AAB70BDE17\n\tfor ;\n\tMon, 6 Mar 2023 11:09:44 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E99136269B;\n\tMon, 6 Mar 2023 12:09:43 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2045E62665\n\tfor ;\n\tMon, 6 Mar 2023 12:09:42 +0100 (CET)","from pendragon.ideasonboard.com\n\t(153.162-64-87.adsl-dyn.isp.belgacom.be [87.64.162.153])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E45D210C;\n\tMon, 6 Mar 2023 12:09:40 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1678100984;\n\tbh=MgB0sxONLqg5+1Wc5YGDGlUAJPcexw8ccgbZbh1y8Ng=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=pgql4SVpDK7Cq9SZyfVAHlwgrEe4e1wCH9XtO0i+pGmiVTss2gdPoRRrC+8O0Xn/g\n\toBcrCc7xFv5b4XNz3urTur8oZhyH6U3ef2Xb9qStoR50I8UIL1yHz13UjucTNvPzMA\n\tyHvBHP3mI5h73UK/G3b5k5x/cJb9utdazcd4JLumt29FZrxZTPe2Z+ADRIfa1zxhkG\n\te6YHBP+rdBc3US+RY/qZGNg5TmQjKNoIf/AcFN4WOGxdo0Oa3o2ugxZ3eS/C467ct3\n\t0WiHWCqr187BmmQj+zF9AdxCT31mSLpKfEdSNmzJqb+6/iI3mh+fBir87O+VsBn+c7\n\tyqCP+6j2XJLIA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1678100981;\n\tbh=MgB0sxONLqg5+1Wc5YGDGlUAJPcexw8ccgbZbh1y8Ng=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=I2cS9rS95fT2hVr/Q37o0HlHscxKfD2gzW0vwmcPXbBLRCGjMbVP8U2tjALdCLkAM\n\ttydh6YXHLDTmUyso3+53sVgnYsOLyx89pfp9vzBFMLmqV1j0woCZtitdM25zB8gXmj\n\tYZfQYBIgLUfAln1gLJL/owj+D1qQ1S53Rh/Ea+54="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"I2cS9rS9\"; dkim-atps=neutral","Date":"Mon, 6 Mar 2023 13:09:45 +0200","To":"Advait Dhamorikar ","Message-ID":"<20230306110945.GF20909@pendragon.ideasonboard.com>","References":"<20230304103758.9154-1-advaitdhamorikar@gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20230304103758.9154-1-advaitdhamorikar@gmail.com>","Subject":"Re: [libcamera-devel] [PATCH v4] documentation: guides:\n\tpipeline-handler: Fix spelling error","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]