{"id":18337,"url":"https://patchwork.libcamera.org/api/patches/18337/?format=json","web_url":"https://patchwork.libcamera.org/patch/18337/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20230302190629.12506-2-suhrid.subramaniam@mediatek.com>","date":"2023-03-02T19:06:29","name":"[libcamera-devel,libcamera-devel,v3,1/1] libcamera: converter: Check converter validity","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"4291b314c883e1f1b73bcb7425cf8ebf9f589f64","submitter":{"id":151,"url":"https://patchwork.libcamera.org/api/people/151/?format=json","name":"Suhrid Subramaniam","email":"suhridsubramaniam@gmail.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/18337/mbox/","series":[{"id":3786,"url":"https://patchwork.libcamera.org/api/series/3786/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3786","date":"2023-03-02T19:06:28","name":"libcamera: converter: Check converter validity","version":3,"mbox":"https://patchwork.libcamera.org/series/3786/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/18337/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/18337/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3E698BF415\n\tfor ;\n\tThu, 2 Mar 2023 19:06:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F3BAD626E7;\n\tThu, 2 Mar 2023 20:06:48 +0100 (CET)","from mail-pg1-x52a.google.com (mail-pg1-x52a.google.com\n\t[IPv6:2607:f8b0:4864:20::52a])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4AB60626C0\n\tfor ;\n\tThu, 2 Mar 2023 20:06:47 +0100 (CET)","by mail-pg1-x52a.google.com with SMTP id bn17so67353pgb.10\n\tfor ;\n\tThu, 02 Mar 2023 11:06:47 -0800 (PST)","from localhost.localdomain (sfosm0151r356001-v22.wiline.com.\n\t[67.207.106.98]) by smtp.gmail.com with ESMTPSA id\n\tx26-20020aa784da000000b005d92c9afbd4sm63678pfn.33.2023.03.02.11.06.44\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 02 Mar 2023 11:06:45 -0800 (PST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1677784009;\n\tbh=XOz1FrvY7SWwVe4qXQvCadGwaGheac2+Ec6GZJPJxcY=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=f+lUaBXxeK/cryYLeuV1xtHB96HKrXYpd0+DF24m1jDmrz7ahLzluWdDhDSoiz6GK\n\t5388FAPkrxmN+ZTRxb0NkTxYV1cdFEiU1rkLx6Igk6xxGq7CVo536a/ODQQPCouzOA\n\t8ZRGZETpaIVBhBtF1+4g8SUBHDC0WcThXHeC1WYg/VAAsgUGjw2dHBhLS/FL68Q6JJ\n\tdC+6rQRHiWzSQRoEuOuLfqQWK7HGU44B6nxekFQhNsfs66+k6n6VvEdsloisg13UAl\n\tf6+wjhUw5wiApdtfRQ7HLTLYlBf94P12lEgMJb5et3o1RK7nJJjg8mKvPiHXHgl/yD\n\t0cIQ4d16Nu0Qg==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=TyOC1x3ApcC5bBRg9wLAKO3a40hcsJotiPl1gabBuHM=;\n\tb=IVHXMSbiMADINKJAvJO5PBCsOhsWqZRbOYSSJ1hMeqVlXVEJB1MexrDKGYglzsKmF0\n\tGPLHuW06dMqTHFcikZ4+hjCesDrKhvj8tWx3+Rn9IXX1512ZDGV5eyWzifzDyAWYUODg\n\trc1iq5JzYMS+yRPdz4pcGKHWWNt5mZ96J6eztkZ5UsQL9RhE61YCtPqPR66UjvQzP4Zg\n\t4fFjzumuiaxRTgSIIdyuJgkiyFw+SkZlIJiN4D67nFA+Yx1CiB2Vujnk0/J/3p+Us/zA\n\tyZKfVVNx+F77Q9gkhtHLZQXyHuNdN4zXNSNNkbUikvDg3yxdSP9vk1svcLs6QX5aAFNR\n\tUrMg=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"IVHXMSbi\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=TyOC1x3ApcC5bBRg9wLAKO3a40hcsJotiPl1gabBuHM=;\n\tb=DVQg4Le57EiqEkolnEQDZ2CzGDvDN+ubMMHm2dZYfzHrexHa920Xz+eJWtbsE92+1v\n\tDVEFmfY/IZf96QPCXjgyQOi9FrPP2t6boJz/TFSQyGzJLJm1Bf4zBT/sbXNut7KFIXHB\n\tmDH6xCX9+DINxnwErBQkYSiVqfWkzMAx1OlfcwBQ14OGPtVIl5B7O0zpKAT/gFcC5bMh\n\tnVYBOpk8hujJmjbbmz/Iz/O7pRCM3fqvSBX/73m+pylNVRpWRyKORHWK0rQ5uzzI6r7U\n\topITqgckYa9jVlP5WU2jQ4hIam2dOF3pTN53WK3U0HwKXvA3t25d39m95Cxd6MDQST2v\n\tETLg==","X-Gm-Message-State":"AO0yUKUhPhXG0BJRgjtUYew7eOXSTt3OKmdEzLWUwL3d7N3Oj+7ZtH/s\n\tKrzoQXFGXoPWuUnZlFu3fFV+GfFh6DMi3A==","X-Google-Smtp-Source":"AK7set/uQOQYncbZ0ofHBSHum/WNzX/drvPx/F50Fh1tI3TwHhSxQZf8ipHwYDibY2Dn0I4S1M24Kw==","X-Received":"by 2002:a05:6a00:1502:b0:5fc:cd83:92f1 with SMTP id\n\tq2-20020a056a00150200b005fccd8392f1mr10140333pfu.1.1677784005644; \n\tThu, 02 Mar 2023 11:06:45 -0800 (PST)","X-Google-Original-From":"Suhrid Subramaniam ","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 2 Mar 2023 11:06:29 -0800","Message-Id":"<20230302190629.12506-2-suhrid.subramaniam@mediatek.com>","X-Mailer":"git-send-email 2.39.0","In-Reply-To":"<20230302190629.12506-1-suhrid.subramaniam@mediatek.com>","References":"<20230302190629.12506-1-suhrid.subramaniam@mediatek.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [libcamera-devel, v3,\n\t1/1] libcamera: converter: Check converter validity","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Suhrid Subramaniam via libcamera-devel\n\t","Reply-To":"Suhrid Subramaniam ","Cc":"Suhrid Subramaniam ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"- In cases where ConverterFactoryBase::create returns a nullptr,\n converter_->isValid() causes a segmentation fault.\n\n- Solve this by checking if converter_ is a nullptr.\n\n- Additionally, check for converter validity in the create function itself\n and return a nullptr if the converter is invalid.\n\nSigned-off-by: Suhrid Subramaniam \n---\n src/libcamera/converter.cpp | 3 ++-\n src/libcamera/pipeline/simple/simple.cpp | 2 +-\n 2 files changed, 3 insertions(+), 2 deletions(-)","diff":"diff --git a/src/libcamera/converter.cpp b/src/libcamera/converter.cpp\nindex 3de39cff..38141da6 100644\n--- a/src/libcamera/converter.cpp\n+++ b/src/libcamera/converter.cpp\n@@ -226,8 +226,9 @@ std::unique_ptr ConverterFactoryBase::create(MediaDevice *media)\n \t\t\t<< \"Creating converter from \"\n \t\t\t<< factory->name_ << \" factory with \"\n \t\t\t<< (it == compatibles.end() ? \"no\" : media->driver()) << \" alias.\";\n+\t\tstd::unique_ptr converter_ = factory->createInstance(media);\n \n-\t\treturn factory->createInstance(media);\n+\t\treturn converter_->isValid() ? std::move(converter_) : nullptr;\n \t}\n \n \treturn nullptr;\ndiff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\nindex 24ded4db..2423ec10 100644\n--- a/src/libcamera/pipeline/simple/simple.cpp\n+++ b/src/libcamera/pipeline/simple/simple.cpp\n@@ -493,7 +493,7 @@ int SimpleCameraData::init()\n \tMediaDevice *converter = pipe->converter();\n \tif (converter) {\n \t\tconverter_ = ConverterFactoryBase::create(converter);\n-\t\tif (!converter_->isValid()) {\n+\t\tif (!converter_) {\n \t\t\tLOG(SimplePipeline, Warning)\n \t\t\t\t<< \"Failed to create converter, disabling format conversion\";\n \t\t\tconverter_.reset();\n","prefixes":["libcamera-devel","libcamera-devel","v3","1/1"]}