[{"id":26510,"web_url":"https://patchwork.libcamera.org/comment/26510/","msgid":"","date":"2023-03-01T10:40:34","subject":"Re: [libcamera-devel] [PATCH v2] ipa: raspberrypi: imx296: Minor\n\ttuning updates","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi David,\n\nThanks for the update!\n\nOn Wed, 1 Mar 2023 at 10:28, David Plowman via libcamera-devel\n wrote:\n>\n> Some updates to the tuning for the imx296 sensors.\n>\n> For the colour variant:\n>\n> * Minor change to the AWB curve, making things a little less green.\n> * Updated CCMs that reduce colour saturation to a more accurate level.\n> Thanks to Dr. Rolf Henkel for these measurements and calculations.\n> * Sharpening has been toned down quite a lot.\n> * rpi.focus algorithm added so that the focus measure can be accessed.\n>\n> The sharpening and focus changes are applied to the mono version of\n> the sensor too as we expect similar characteristics.\n>\n> Signed-off-by: David Plowman \n\nReviewed-by: Naushir Patuck \n\n> ---\n> src/ipa/raspberrypi/data/imx296.json | 180 ++++++++++++++++++----\n> src/ipa/raspberrypi/data/imx296_mono.json | 12 +-\n> 2 files changed, 158 insertions(+), 34 deletions(-)\n>\n> diff --git a/src/ipa/raspberrypi/data/imx296.json b/src/ipa/raspberrypi/data/imx296.json\n> index 4e830517..346f5b65 100644\n> --- a/src/ipa/raspberrypi/data/imx296.json\n> +++ b/src/ipa/raspberrypi/data/imx296.json\n> @@ -78,7 +78,7 @@\n> \"auto\":\n> {\n> \"lo\": 2500,\n> - \"hi\": 8000\n> + \"hi\": 7600\n> },\n> \"incandescent\":\n> {\n> @@ -108,7 +108,7 @@\n> \"cloudy\":\n> {\n> \"lo\": 7000,\n> - \"hi\": 8600\n> + \"hi\": 7600\n> }\n> },\n> \"bayes\": 1,\n> @@ -122,8 +122,8 @@\n> 5600.0, 0.2948, 0.6124,\n> 7400.0, 0.2336, 0.6894\n> ],\n> - \"sensitivity_r\": 1.0,\n> - \"sensitivity_b\": 1.0,\n> + \"sensitivity_r\": 1.05,\n> + \"sensitivity_b\": 1.05,\n> \"transverse_pos\": 0.03093,\n> \"transverse_neg\": 0.02374\n> }\n> @@ -352,73 +352,189 @@\n> {\n> \"ccms\": [\n> {\n> - \"ct\": 2500,\n> + \"ct\": 2000,\n> \"ccm\":\n> [\n> - 1.73697, -0.36758, -0.36939,\n> - -0.46469, 1.75868, -0.29399,\n> - 0.14353, -1.26221, 2.11867\n> + 1.48716, -0.1877, -0.35079,\n> + -0.48577, 1.55088, -0.03387,\n> + 0.24919, -1.4583, 2.12083\n> + ]\n> + },\n> + {\n> + \"ct\": 2200,\n> + \"ccm\":\n> + [\n> + 1.53439, -0.28852, -0.29392,\n> + -0.44748, 1.56295, -0.08907,\n> + 0.23529, -1.30488, 1.99784\n> + ]\n> + },\n> + {\n> + \"ct\": 2400,\n> + \"ccm\":\n> + [\n> + 1.57619, -0.36904, -0.25181,\n> + -0.41654, 1.57046, -0.13192,\n> + 0.21678, -1.18352, 1.90786\n> + ]\n> + },\n> + {\n> + \"ct\": 2600,\n> + \"ccm\":\n> + [\n> + 1.61348, -0.43497, -0.2198,\n> + -0.39075, 1.5753, -0.1665,\n> + 0.19789, -1.08592, 1.83942\n> ]\n> },\n> {\n> \"ct\": 2800,\n> \"ccm\":\n> [\n> - 1.77684, -0.48089, -0.29595,\n> - -0.41669, 1.74344, -0.32675,\n> - 0.11995, -1.10172, 1.98177\n> + 1.64717, -0.49009, -0.1951,\n> + -0.36881, 1.57852, -0.1952,\n> + 0.18016, -1.00609, 1.78575\n> + ]\n> + },\n> + {\n> + \"ct\": 3000,\n> + \"ccm\":\n> + [\n> + 1.67798, -0.53693, -0.17591,\n> + -0.34986, 1.58074, -0.21955,\n> + 0.16406, -0.9398, 1.74261\n> + ]\n> + },\n> + {\n> + \"ct\": 3200,\n> + \"ccm\":\n> + [\n> + 1.70647, -0.5773, -0.161,\n> + -0.33332, 1.58235, -0.24056,\n> + 0.14961, -0.88398, 1.70721\n> + ]\n> + },\n> + {\n> + \"ct\": 3400,\n> + \"ccm\":\n> + [\n> + 1.73305, -0.61248, -0.14951,\n> + -0.31875, 1.58355, -0.25894,\n> + 0.13671, -0.83642, 1.67769\n> + ]\n> + },\n> + {\n> + \"ct\": 3600,\n> + \"ccm\":\n> + [\n> + 1.75802, -0.64343, -0.14077,\n> + -0.30581, 1.5845, -0.27518,\n> + 0.12518, -0.79546, 1.65271\n> ]\n> },\n> {\n> - \"ct\": 2900,\n> + \"ct\": 4100,\n> \"ccm\":\n> [\n> - 1.83447, -0.50694, -0.32754,\n> - -0.44924, 1.86236, -0.41312,\n> - 0.06159, -0.91231, 1.85071\n> + 1.78116, -0.67459, -0.13048,\n> + -0.26859, 1.58692, -0.31929,\n> + 0.11915, -0.77931, 1.64012\n> ]\n> },\n> {\n> - \"ct\": 3620,\n> + \"ct\": 4600,\n> \"ccm\":\n> [\n> - 1.91315, -0.61463, -0.29852,\n> - -0.38782, 1.80483, -0.41701,\n> - 0.00632, -0.74309, 1.73678\n> + 1.83867, -0.73605, -0.12044,\n> + -0.24947, 1.58699, -0.34207,\n> + 0.09949, -0.71041, 1.59842\n> ]\n> },\n> {\n> - \"ct\": 4560,\n> + \"ct\": 5100,\n> \"ccm\":\n> [\n> - 2.13144, -0.79703, -0.33441,\n> - -0.41488, 2.10864, -0.69376,\n> - -0.03975, -0.70785, 1.74761\n> + 1.88967, -0.78455, -0.11744,\n> + -0.23398, 1.58806, -0.36172,\n> + 0.08362, -0.6574, 1.56728\n> ]\n> },\n> {\n> \"ct\": 5600,\n> \"ccm\":\n> [\n> - 1.95828, -0.76779, -0.19049,\n> - -0.26299, 1.70577, -0.44278,\n> - -0.05451, -0.51918, 1.57369\n> + 1.93485, -0.82318, -0.1191,\n> + -0.22108, 1.58973, -0.37892,\n> + 0.07074, -0.61609, 1.54362\n> + ]\n> + },\n> + {\n> + \"ct\": 6100,\n> + \"ccm\":\n> + [\n> + 1.97481, -0.85423, -0.12371,\n> + -0.21015, 1.59169, -0.39406,\n> + 0.06021, -0.58353, 1.52536\n> + ]\n> + },\n> + {\n> + \"ct\": 6600,\n> + \"ccm\":\n> + [\n> + 2.01029, -0.87946, -0.13017,\n> + -0.20074, 1.59378, -0.4075,\n> + 0.05146, -0.55732, 1.51096\n> + ]\n> + },\n> + {\n> + \"ct\": 7100,\n> + \"ccm\":\n> + [\n> + 2.04183, -0.9002, -0.13765,\n> + -0.19255, 1.59586, -0.41944,\n> + 0.04414, -0.53603, 1.49947\n> + ]\n> + },\n> + {\n> + \"ct\": 7600,\n> + \"ccm\":\n> + [\n> + 2.07001, -0.91744, -0.14566,\n> + -0.18534, 1.59788, -0.43013,\n> + 0.03791, -0.51841, 1.49013\n> + ]\n> + },\n> + {\n> + \"ct\": 8100,\n> + \"ccm\":\n> + [\n> + 2.09534, -0.93195, -0.15388,\n> + -0.17893, 1.59981, -0.43974,\n> + 0.03256, -0.50364, 1.48243\n> ]\n> },\n> {\n> - \"ct\": 7400,\n> + \"ct\": 8600,\n> \"ccm\":\n> [\n> - 2.14829, -0.65425, -0.49405,\n> - -0.46729, 2.66571, -1.19841,\n> - -0.28128, -0.56248, 1.84377\n> + 2.11799, -0.94416, -0.16203,\n> + -0.17324, 1.60161, -0.44836,\n> + 0.02795, -0.4912, 1.47604\n> ]\n> }\n> ]\n> }\n> },\n> {\n> - \"rpi.sharpen\": { }\n> + \"rpi.sharpen\":\n> + {\n> + \"threshold\": 0.1,\n> + \"strength\": 1.0,\n> + \"limit\": 0.18\n> + }\n> + },\n> + {\n> + \"rpi.focus\": { }\n> }\n> ]\n> -}\n> \\ No newline at end of file\n> +}\n> diff --git a/src/ipa/raspberrypi/data/imx296_mono.json b/src/ipa/raspberrypi/data/imx296_mono.json\n> index b68b11db..e9fa30c6 100644\n> --- a/src/ipa/raspberrypi/data/imx296_mono.json\n> +++ b/src/ipa/raspberrypi/data/imx296_mono.json\n> @@ -222,7 +222,15 @@\n> }\n> },\n> {\n> - \"rpi.sharpen\": { }\n> + \"rpi.sharpen\":\n> + {\n> + \"threshold\": 0.1,\n> + \"strength\": 1.0,\n> + \"limit\": 0.18\n> + }\n> + },\n> + {\n> + \"rpi.focus\": { }\n> }\n> ]\n> -}\n> \\ No newline at end of file\n> +}\n> --\n> 2.30.2\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7F9C6BF415\n\tfor ;\n\tWed, 1 Mar 2023 10:40:48 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C66626267E;\n\tWed, 1 Mar 2023 11:40:47 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1677667247;\n\tbh=ezy30mtb+cm+ek10vzkmvuJmUuw21DLiu4KmPqE35TI=;\n\th=References:In-Reply-To:Date:To:List-Id:List-Post:From:Cc:\n\tList-Subscribe:List-Unsubscribe:List-Archive:Reply-To:List-Help:\n\tSubject:From;\n\tb=o8IdPlv4F9qNTFc7adiTKuJ+WYaUyY66oibb6yFr6xlP8yvyo19I048EhJLgAwsaB\n\tusKUREy6guhqYqPunvHc0zkOZWw+81fBiO7PoFCdO2hcx8jhMg8ry9hhQPq++dSD2x\n\ti8huB0zIZwiL9Sh/IMAaExCHsvsQY6aD4nSQtsaPBWzhr7pQU5HSRQ8MogYoUj5Y+E\n\tTeVENVYIjKdPHDiUcUY5ecKw8yjjhcUcJGqrfXV9BaRQIElauKGjA/Bm+4JQvOR+Tg\n\tpVxB72VXBRWrOKlglzm/MgB7iK2HxHRtnApm+1BOr3fbXivi+155WwMGXy1oycoFwQ\n\t/pVfE25+keHOA==","References":"","In-Reply-To":"","Date":"Wed, 1 Mar 2023 10:40:34 +0000","To":"David Plowman ","MIME-Version":"1.0","Message-ID":"","List-Id":"","List-Post":"","From":"Naushir Patuck via libcamera-devel\n\t","Precedence":"list","Cc":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","X-BeenThere":"libcamera-devel@lists.libcamera.org","List-Subscribe":",\n\t","List-Unsubscribe":",\n\t","List-Archive":"","Reply-To":"Naushir Patuck ","List-Help":"","Subject":"Re: [libcamera-devel] [PATCH v2] ipa: raspberrypi: imx296: Minor\n\ttuning updates","Content-Type":"message/rfc822","Content-Disposition":"inline","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]