{"id":18314,"url":"https://patchwork.libcamera.org/api/patches/18314/?format=json","web_url":"https://patchwork.libcamera.org/patch/18314/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20230227204254.3965883-3-kieran.bingham@ideasonboard.com>","date":"2023-02-27T20:42:54","name":"[libcamera-devel,2/2] ipa: libipa: Add OV5695 Camera Sensor Helper","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"61bdfe6921ba9e5380bd7cebef502b013f0a145f","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/18314/mbox/","series":[{"id":3773,"url":"https://patchwork.libcamera.org/api/series/3773/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3773","date":"2023-02-27T20:42:52","name":"ipa: libipa: Add sensor helpers for the Acer Chrometab 10","version":1,"mbox":"https://patchwork.libcamera.org/series/3773/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/18314/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/18314/checks/","tags":{},"headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8CC5DC329C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 27 Feb 2023 20:43:02 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4480362692;\n\tMon, 27 Feb 2023 21:43:02 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 94F0362682\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 27 Feb 2023 21:42:58 +0100 (CET)","from Monstersaurus.tail69b4.ts.net\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 366601288;\n\tMon, 27 Feb 2023 21:42:58 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1677530582;\n\tbh=UZbDX1UgcqC90UJdAetxSyPDDwamFJvbrf32tOcTvSo=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=sUw/2iZQ3lQjj2j97yLPqafF8Xnq7z9bix4W720htJRXVTdfaRy0U41Q9u+8Q48LV\n\tvVq+hbaZd7f3eDHn4zkP0R02YD2orQJtd8L/72YjgFkVnaHtnO9Y+TxFc+NQhYyT4H\n\tkBqleGypPgyI8uy9wUAXoqaDDFyiVS1PgPAm00IdLBsB2e2uUF6+XiBj7Lopbs8Co3\n\t9EDAp1r2MYUQ/BtUbzX3DDd7Ov7JCmO3brfHWGZvrkrpSLv5K47LyesnGpM+m1gLEX\n\tXnmPWeDv+ER0GlnVZC5XCJOEEpE7fh3EHuYJA5J/W7wBxCkAcVdfhz8AtKTV0GEq0S\n\tVVLkkR3WgWP7Q==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1677530578;\n\tbh=UZbDX1UgcqC90UJdAetxSyPDDwamFJvbrf32tOcTvSo=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=QHVDSRTnMrgHKJXT3Ovl9ILqhT+nv9t2n98kj2SvgEF+Zbb3d+rLUncZTrYoQg7m4\n\tiUkNMnxLU0J/rvVobnmCOZIkjDNZdQd8DeXZFOckt7CS72RBOmLeU8oP2JX2iz2m6Y\n\tbSOg0xZkJQm2/svvcutwnas8s2iJN2odgvVm81Oc="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"QHVDSRTn\"; dkim-atps=neutral","To":"libcamera devel <libcamera-devel@lists.libcamera.org>","Date":"Mon, 27 Feb 2023 20:42:54 +0000","Message-Id":"<20230227204254.3965883-3-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20230227204254.3965883-1-kieran.bingham@ideasonboard.com>","References":"<20230227204254.3965883-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 2/2] ipa: libipa: Add OV5695 Camera Sensor\n\tHelper","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Kieran Bingham via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>","Reply-To":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"Provide a CameraSensorHelper for the OV5695, along with the\ncorresponding camera sensor properties.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/ipa/libipa/camera_sensor_helper.cpp    | 11 +++++++++++\n src/libcamera/camera_sensor_properties.cpp |  8 ++++++++\n 2 files changed, 19 insertions(+)","diff":"diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\nindex d1051cc25656..a38fefc75372 100644\n--- a/src/ipa/libipa/camera_sensor_helper.cpp\n+++ b/src/ipa/libipa/camera_sensor_helper.cpp\n@@ -527,6 +527,17 @@ public:\n };\n REGISTER_CAMERA_SENSOR_HELPER(\"ov5693\", CameraSensorHelperOv5693)\n \n+class CameraSensorHelperOv5695 : public CameraSensorHelper\n+{\n+public:\n+\tCameraSensorHelperOv5695()\n+\t{\n+\t\tgainType_ = AnalogueGainLinear;\n+\t\tgainConstants_.linear = { 1, 0, 0, 128 };\n+\t}\n+};\n+REGISTER_CAMERA_SENSOR_HELPER(\"ov5695\", CameraSensorHelperOv5695)\n+\n class CameraSensorHelperOv8858 : public CameraSensorHelper\n {\n public:\ndiff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/camera_sensor_properties.cpp\nindex 7652c5f3e24c..a92c13b87b7f 100644\n--- a/src/libcamera/camera_sensor_properties.cpp\n+++ b/src/libcamera/camera_sensor_properties.cpp\n@@ -204,6 +204,14 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n \t\t\t\t */\n \t\t\t},\n \t\t} },\n+\t\t{ \"ov5695\", {\n+\t\t\t.unitCellSize = { 1400, 1400 },\n+\t\t\t.testPatternModes = {\n+\t\t\t\t{ controls::draft::TestPatternModeOff, 0 },\n+\t\t\t\t{ controls::draft::TestPatternModeColorBars, 2 },\n+\t\t\t\t{ controls::draft::TestPatternModeColorBarsFadeToGray, 4},\n+\t\t\t},\n+\t\t} },\n \t\t{ \"ov8858\", {\n \t\t\t.unitCellSize = { 1120, 1120 },\n \t\t\t.testPatternModes = {\n","prefixes":["libcamera-devel","2/2"]}