[{"id":26470,"web_url":"https://patchwork.libcamera.org/comment/26470/","msgid":"","date":"2023-02-23T09:37:20","subject":"Re: [libcamera-devel] [PATCH] ipa: raspberrypi: imx296: Minor\n\ttuning updates","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi David,\n\nThank you for the fixes.\n\nOn Wed, 22 Feb 2023 at 16:24, David Plowman via libcamera-devel\n wrote:\n>\n> Some small updates to the tuning for the imx296 colour sensor:\n>\n> * Minor colour changes, generally makes things a little less green\n> * Sharpening toned down\n> * rpi.focus algorithm added so that focus measure can be accessed.\n>\n> The sharpening and focus changes are also made for the mono version of\n> the sensor. The sharpness characteristics should be very similar so\n> the change should beneficial, and the addition of the focus measure\n> may be useful, and is at worst harmless.\n>\n> Signed-off-by: David Plowman \n\nReviewed-by: Naushir Patuck \nTested-by: Naushir Patuck \n\n> ---\n> src/ipa/raspberrypi/data/imx296.json | 20 ++++++++++++++------\n> src/ipa/raspberrypi/data/imx296_mono.json | 12 ++++++++++--\n> 2 files changed, 24 insertions(+), 8 deletions(-)\n>\n> diff --git a/src/ipa/raspberrypi/data/imx296.json b/src/ipa/raspberrypi/data/imx296.json\n> index 4e830517..2ced95e2 100644\n> --- a/src/ipa/raspberrypi/data/imx296.json\n> +++ b/src/ipa/raspberrypi/data/imx296.json\n> @@ -78,7 +78,7 @@\n> \"auto\":\n> {\n> \"lo\": 2500,\n> - \"hi\": 8000\n> + \"hi\": 7600\n> },\n> \"incandescent\":\n> {\n> @@ -108,7 +108,7 @@\n> \"cloudy\":\n> {\n> \"lo\": 7000,\n> - \"hi\": 8600\n> + \"hi\": 7600\n> }\n> },\n> \"bayes\": 1,\n> @@ -122,8 +122,8 @@\n> 5600.0, 0.2948, 0.6124,\n> 7400.0, 0.2336, 0.6894\n> ],\n> - \"sensitivity_r\": 1.0,\n> - \"sensitivity_b\": 1.0,\n> + \"sensitivity_r\": 1.05,\n> + \"sensitivity_b\": 1.05,\n> \"transverse_pos\": 0.03093,\n> \"transverse_neg\": 0.02374\n> }\n> @@ -418,7 +418,15 @@\n> }\n> },\n> {\n> - \"rpi.sharpen\": { }\n> + \"rpi.sharpen\":\n> + {\n> + \"threshold\": 0.1,\n> + \"strength\": 1.0,\n> + \"limit\": 0.18\n> + }\n> + },\n> + {\n> + \"rpi.focus\": { }\n> }\n> ]\n> -}\n> \\ No newline at end of file\n> +}\n> diff --git a/src/ipa/raspberrypi/data/imx296_mono.json b/src/ipa/raspberrypi/data/imx296_mono.json\n> index b68b11db..d937bb30 100644\n> --- a/src/ipa/raspberrypi/data/imx296_mono.json\n> +++ b/src/ipa/raspberrypi/data/imx296_mono.json\n> @@ -222,7 +222,15 @@\n> }\n> },\n> {\n> - \"rpi.sharpen\": { }\n> + \"rpi.sharpen\":\n> + {\n> + \"threshold\": 0.1,\n> + \"strength\": 1.0,\n> + \"limit\": 0.18\n> + }\n> + },\n> + {\n> + \"rpi.focus\": { }\n> }\n> ]\n> -}\n> \\ No newline at end of file\n> +}\n> --\n> 2.30.2\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AA6B1BE080\n\tfor ;\n\tThu, 23 Feb 2023 09:37:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DAA4C61EE4;\n\tThu, 23 Feb 2023 10:37:30 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1677145050;\n\tbh=aGoXUnU3otv6ow7AGN/p4n+DYc0MICRcuYzcgKG6FGM=;\n\th=References:In-Reply-To:Date:To:List-Id:List-Post:From:Cc:\n\tList-Subscribe:List-Unsubscribe:List-Archive:Reply-To:List-Help:\n\tSubject:From;\n\tb=EsrBXFtMyQeeJaRD4Hgy5c0auIZlUuqSAYZoDhzDOWnoWEBjlsd0oF+ZqcBuWJMXA\n\tSVFg5RZVoRu7ogYF0vCKmd0fjd76hrtC7vY96+oL36osmuYJx/aOE5B10rYzIPTxtE\n\twwuMWogJATiw6w4P9sglpySlR4kZQ6Ii8pUHk34r0I7PHrRLVGZvYFPt0xZ+WE0v4T\n\twyDiFuCkuX1tS7eygsClTXWuIPTorBeiblPGGR2Y+UGHLm/X+SzjtSR80B1j9lxXm/\n\tSfU6XJz+YUhPoK1MECH/eD2i6Kb4Is+IQC2hLcA75+zo19/WzLYETdvQpJfRi5XbYu\n\tpIO9dHUUj9lrA==","References":"","In-Reply-To":"","Date":"Thu, 23 Feb 2023 09:37:20 +0000","To":"David Plowman ","MIME-Version":"1.0","Message-ID":"","List-Id":"","List-Post":"","From":"Naushir Patuck via libcamera-devel\n\t","Precedence":"list","Cc":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","X-BeenThere":"libcamera-devel@lists.libcamera.org","List-Subscribe":",\n\t","List-Unsubscribe":",\n\t","List-Archive":"","Reply-To":"Naushir Patuck ","List-Help":"","Subject":"Re: [libcamera-devel] [PATCH] ipa: raspberrypi: imx296: Minor\n\ttuning updates","Content-Type":"message/rfc822","Content-Disposition":"inline","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":26493,"web_url":"https://patchwork.libcamera.org/comment/26493/","msgid":"","date":"2023-02-28T09:58:06","subject":"Re: [libcamera-devel] [PATCH] ipa: raspberrypi: imx296: Minor\n\ttuning updates","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"On Wed, Feb 22, 2023 at 04:23:55PM +0000, David Plowman via libcamera-devel wrote:\n> Date: Wed, 22 Feb 2023 16:23:55 +0000\n> From: David Plowman \n> To: libcamera-devel@lists.libcamera.org\n> Subject: [PATCH] ipa: raspberrypi: imx296: Minor tuning updates\n> X-Mailer: git-send-email 2.30.2\n> \n> Some small updates to the tuning for the imx296 colour sensor:\n> \n> * Minor colour changes, generally makes things a little less green\n> * Sharpening toned down\n> * rpi.focus algorithm added so that focus measure can be accessed.\n> \n> The sharpening and focus changes are also made for the mono version of\n> the sensor. The sharpness characteristics should be very similar so\n> the change should beneficial, and the addition of the focus measure\n> may be useful, and is at worst harmless.\n> \n> Signed-off-by: David Plowman \n> ---\n> src/ipa/raspberrypi/data/imx296.json | 20 ++++++++++++++------\n> src/ipa/raspberrypi/data/imx296_mono.json | 12 ++++++++++--\n> 2 files changed, 24 insertions(+), 8 deletions(-)\n> \n> diff --git a/src/ipa/raspberrypi/data/imx296.json b/src/ipa/raspberrypi/data/imx296.json\n> index 4e830517..2ced95e2 100644\n> --- a/src/ipa/raspberrypi/data/imx296.json\n> +++ b/src/ipa/raspberrypi/data/imx296.json\n> @@ -78,7 +78,7 @@\n> \"auto\":\n> {\n> \"lo\": 2500,\n> - \"hi\": 8000\n> + \"hi\": 7600\n> },\n> \"incandescent\":\n> {\n> @@ -108,7 +108,7 @@\n> \"cloudy\":\n> {\n> \"lo\": 7000,\n> - \"hi\": 8600\n> + \"hi\": 7600\n> }\n> },\n> \"bayes\": 1,\n> @@ -122,8 +122,8 @@\n> 5600.0, 0.2948, 0.6124,\n> 7400.0, 0.2336, 0.6894\n> ],\n> - \"sensitivity_r\": 1.0,\n> - \"sensitivity_b\": 1.0,\n> + \"sensitivity_r\": 1.05,\n> + \"sensitivity_b\": 1.05,\n> \"transverse_pos\": 0.03093,\n> \"transverse_neg\": 0.02374\n> }\n> @@ -418,7 +418,15 @@\n> }\n> },\n> {\n> - \"rpi.sharpen\": { }\n> + \"rpi.sharpen\":\n> +\t {\n> +\t\t\"threshold\": 0.1,\n> +\t\t\"strength\": 1.0,\n> +\t\t\"limit\": 0.18\n> +\t }\n\nI think you're mixing tabs and spaces here.\n\n> + },\n> + {\n> + \"rpi.focus\": { }\n> }\n> ]\n> -}\n> \\ No newline at end of file\n> +}\n> diff --git a/src/ipa/raspberrypi/data/imx296_mono.json b/src/ipa/raspberrypi/data/imx296_mono.json\n> index b68b11db..d937bb30 100644\n> --- a/src/ipa/raspberrypi/data/imx296_mono.json\n> +++ b/src/ipa/raspberrypi/data/imx296_mono.json\n> @@ -222,7 +222,15 @@\n> }\n> },\n> {\n> - \"rpi.sharpen\": { }\n> + \"rpi.sharpen\":\n> +\t {\n> +\t\t\"threshold\": 0.1,\n> +\t\t\"strength\": 1.0,\n> +\t\t\"limit\": 0.18\n> +\t }\n\nAlso here.\n\nOtherwise, looks good to me.\n\nAcked-by: Paul Elder \n\n> + },\n> + {\n> + \"rpi.focus\": { }\n> }\n> ]\n> -}\n> \\ No newline at end of file\n> +}\n> -- \n> 2.30.2\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0F8ADBE08A\n\tfor ;\n\tTue, 28 Feb 2023 09:58:16 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 719D06269D;\n\tTue, 28 Feb 2023 10:58:15 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1009962698\n\tfor ;\n\tTue, 28 Feb 2023 10:58:14 +0100 (CET)","from pyrite.rasen.tech (h175-177-042-159.catv02.itscom.jp\n\t[175.177.42.159])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8689056A;\n\tTue, 28 Feb 2023 10:58:12 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1677578295;\n\tbh=+Y/GgaBnVBXo4FMjzZxJBMAMiO0mNCZEA8xyzGZFIxs=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=tOfm6FnyieCdyt+JQgIoR794ohIFU6HsmR7N2jhxEDQKI0EjXXuEpn+uzN8GNN5Kt\n\te71wCf5pKSdDC+eyVGRi4rF2U0ek6NdCeUsD0SQeEghxdymPX3nQOWG+poeUGxwB9V\n\tTJTZa4CMgvtSDz14BVw0ni3SiLsSakMZiLcej56OG80CzUHyFiMUkfTjNxpOeIcb5n\n\tfQFeOqYsonmmU3MoyIjQQUAvJModEw0Lfl5ENHQF4Rwk4vUuM2BFXFm3CKABBh/FTz\n\t5+uKZgMxE0Z3N1SdaFxSbse+pal4yXfs+xaA8x68au7ZyMLK0WD1GRmx14Q6y6rtt/\n\tqUVJnq3p+FeNw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1677578293;\n\tbh=+Y/GgaBnVBXo4FMjzZxJBMAMiO0mNCZEA8xyzGZFIxs=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Qlt3pyGaMyVYgLpJmkt7VlNPRNaBv4EPcdc1Qir1Sn62NBGLNP/KJ/qrzHPtfB6fO\n\tts0eEnK/ElS52J7yRKxFQPEw5g+Ses9F4mEItxy4hJHYy8CxC2L8hhf9cYJuVAlkIf\n\tSv04Nj2mrESim1HOl6fSKL4XYaCQD5YVAvUxJkgE="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"Qlt3pyGa\"; dkim-atps=neutral","Date":"Tue, 28 Feb 2023 18:58:06 +0900","To":"David Plowman ","Message-ID":"","References":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH] ipa: raspberrypi: imx296: Minor\n\ttuning updates","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Paul Elder via libcamera-devel ","Reply-To":"Paul Elder ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":26494,"web_url":"https://patchwork.libcamera.org/comment/26494/","msgid":"","date":"2023-02-28T10:56:57","subject":"Re: [libcamera-devel] [PATCH] ipa: raspberrypi: imx296: Minor\n\ttuning updates","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi Paul,\n\nOn Tue, 28 Feb 2023 at 09:58, Paul Elder via libcamera-devel\n wrote:\n>\n> On Wed, Feb 22, 2023 at 04:23:55PM +0000, David Plowman via libcamera-devel wrote:\n> > Date: Wed, 22 Feb 2023 16:23:55 +0000\n> > From: David Plowman \n> > To: libcamera-devel@lists.libcamera.org\n> > Subject: [PATCH] ipa: raspberrypi: imx296: Minor tuning updates\n> > X-Mailer: git-send-email 2.30.2\n> >\n> > Some small updates to the tuning for the imx296 colour sensor:\n> >\n> > * Minor colour changes, generally makes things a little less green\n> > * Sharpening toned down\n> > * rpi.focus algorithm added so that focus measure can be accessed.\n> >\n> > The sharpening and focus changes are also made for the mono version of\n> > the sensor. The sharpness characteristics should be very similar so\n> > the change should beneficial, and the addition of the focus measure\n> > may be useful, and is at worst harmless.\n> >\n> > Signed-off-by: David Plowman \n> > ---\n> > src/ipa/raspberrypi/data/imx296.json | 20 ++++++++++++++------\n> > src/ipa/raspberrypi/data/imx296_mono.json | 12 ++++++++++--\n> > 2 files changed, 24 insertions(+), 8 deletions(-)\n> >\n> > diff --git a/src/ipa/raspberrypi/data/imx296.json b/src/ipa/raspberrypi/data/imx296.json\n> > index 4e830517..2ced95e2 100644\n> > --- a/src/ipa/raspberrypi/data/imx296.json\n> > +++ b/src/ipa/raspberrypi/data/imx296.json\n> > @@ -78,7 +78,7 @@\n> > \"auto\":\n> > {\n> > \"lo\": 2500,\n> > - \"hi\": 8000\n> > + \"hi\": 7600\n> > },\n> > \"incandescent\":\n> > {\n> > @@ -108,7 +108,7 @@\n> > \"cloudy\":\n> > {\n> > \"lo\": 7000,\n> > - \"hi\": 8600\n> > + \"hi\": 7600\n> > }\n> > },\n> > \"bayes\": 1,\n> > @@ -122,8 +122,8 @@\n> > 5600.0, 0.2948, 0.6124,\n> > 7400.0, 0.2336, 0.6894\n> > ],\n> > - \"sensitivity_r\": 1.0,\n> > - \"sensitivity_b\": 1.0,\n> > + \"sensitivity_r\": 1.05,\n> > + \"sensitivity_b\": 1.05,\n> > \"transverse_pos\": 0.03093,\n> > \"transverse_neg\": 0.02374\n> > }\n> > @@ -418,7 +418,15 @@\n> > }\n> > },\n> > {\n> > - \"rpi.sharpen\": { }\n> > + \"rpi.sharpen\":\n> > + {\n> > + \"threshold\": 0.1,\n> > + \"strength\": 1.0,\n> > + \"limit\": 0.18\n> > + }\n>\n> I think you're mixing tabs and spaces here.\n>\n> > + },\n> > + {\n> > + \"rpi.focus\": { }\n> > }\n> > ]\n> > -}\n> > \\ No newline at end of file\n> > +}\n> > diff --git a/src/ipa/raspberrypi/data/imx296_mono.json b/src/ipa/raspberrypi/data/imx296_mono.json\n> > index b68b11db..d937bb30 100644\n> > --- a/src/ipa/raspberrypi/data/imx296_mono.json\n> > +++ b/src/ipa/raspberrypi/data/imx296_mono.json\n> > @@ -222,7 +222,15 @@\n> > }\n> > },\n> > {\n> > - \"rpi.sharpen\": { }\n> > + \"rpi.sharpen\":\n> > + {\n> > + \"threshold\": 0.1,\n> > + \"strength\": 1.0,\n> > + \"limit\": 0.18\n> > + }\n>\n> Also here.\n>\n> Otherwise, looks good to me.\n>\n> Acked-by: Paul Elder \n\nThanks for spotting that!\n\nWe might also want to do one or two more shoots before finalising the numbers.\nWe will fix this as well and submit the final version shortly.\n\nRegards,\nNaush\n\n\n\n>\n> > + },\n> > + {\n> > + \"rpi.focus\": { }\n> > }\n> > ]\n> > -}\n> > \\ No newline at end of file\n> > +}\n> > --\n> > 2.30.2\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E2F49BE080\n\tfor ;\n\tTue, 28 Feb 2023 10:57:04 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 739246269D;\n\tTue, 28 Feb 2023 11:57:04 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1677581824;\n\tbh=6KjA4/uWwT2A5xxc1RVolO4OF35z1Y1fo9DIxCnYYWs=;\n\th=References:In-Reply-To:Date:To:List-Id:List-Post:From:Cc:\n\tList-Subscribe:List-Unsubscribe:List-Archive:Reply-To:List-Help:\n\tSubject:From;\n\tb=0FJv6TWN+hzFFWnkCUt7pkUwhTzZXqpIlje6EbrBimVMlE6JXYj7RW6Yn0881w2DF\n\tXefnxwiyAsc0U01r7dYp4UmWYNQo6+2kcBcrWv+2WzRp/XJ1vClqt1SVoAMYWwPVOz\n\tKDa8Xnd1QmygP8krVH8WdrhMTZAshyoLFcJOiN2JqUbph1jFeFatxQZMPFSSGCFxMU\n\thbzCTl945Igxpp2QwnS82lK4Q3nK3t8S9sUapQ8e1GA2R8vwCYHtoFZzfRl8KFuA+G\n\tsQxBVADHH7DcO66ZNAjiiGNJRwXxdjeabDKBENTOWbxaKSCr9E0QVJrz6BKvJwfs2Y\n\tExCGVUaDD1w9g==","References":"\n\t","In-Reply-To":"","Date":"Tue, 28 Feb 2023 10:56:57 +0000","To":"Paul Elder ","MIME-Version":"1.0","Message-ID":"","List-Id":"","List-Post":"","From":"Naushir Patuck via libcamera-devel\n\t","Precedence":"list","Cc":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","X-BeenThere":"libcamera-devel@lists.libcamera.org","List-Subscribe":",\n\t","List-Unsubscribe":",\n\t","List-Archive":"","Reply-To":"Naushir Patuck ","List-Help":"","Subject":"Re: [libcamera-devel] [PATCH] ipa: raspberrypi: imx296: Minor\n\ttuning updates","Content-Type":"message/rfc822","Content-Disposition":"inline","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]