{"id":18299,"url":"https://patchwork.libcamera.org/api/patches/18299/?format=json","web_url":"https://patchwork.libcamera.org/patch/18299/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<mailman.10.1677083040.25031.libcamera-devel@lists.libcamera.org>","date":"2023-02-22T16:23:55","name":"[libcamera-devel] ipa: raspberrypi: imx296: Minor tuning updates","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"4642d6347ab4bf4e5bfea17bb972e786b9a40ad5","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/?format=json","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/18299/mbox/","series":[{"id":3763,"url":"https://patchwork.libcamera.org/api/series/3763/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3763","date":"2023-02-22T16:23:55","name":"[libcamera-devel] ipa: raspberrypi: imx296: Minor tuning updates","version":1,"mbox":"https://patchwork.libcamera.org/series/3763/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/18299/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/18299/checks/","tags":{},"headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3CECCBDCBF\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 22 Feb 2023 16:24:02 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 71A7262605;\n\tWed, 22 Feb 2023 17:24:01 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1677083041;\n\tbh=n3GpSrDoJAaKAoY3HtqbN+sNj+BKgmAcYYJdLqndKr0=;\n\th=To:Date:List-Id:List-Post:From:List-Subscribe:List-Unsubscribe:\n\tList-Archive:Reply-To:List-Help:Subject:From;\n\tb=qy5cgo+LYZoiwvN3Udie+MqUndBisyFmecy2pTB0XREcaC5mnhw+d3NuCOeVJLmad\n\tEQDHL2HscKrYcmnPN0EX0XxKRYapKzlaqro42IGeCd7PCktVTquFtvczE28Swy3UaV\n\tvKWOYLHXFDMwdSDpbB8dZTEi8PBFiCIOQLqgeCLSsngYgeoIe4+lYYzK8UWmbQcs+e\n\tth0wZnCzOs2NQpVjlJiOuChBpwXwaFzIeMMs/EBxRC6SG6tWRBiJqNTsa72EuLvfF3\n\tUi/E3BLtPUaSsHCXNEAh5+qm87PF9TR5Do9zSTxdadku/IC+iXDdK2qnLJ0YHD8dYZ\n\tyuooXt0kpyJDA==","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 22 Feb 2023 16:23:55 +0000","MIME-Version":"1.0","Message-ID":"<mailman.10.1677083040.25031.libcamera-devel@lists.libcamera.org>","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","From":"David Plowman via libcamera-devel <libcamera-devel@lists.libcamera.org>","Precedence":"list","X-Mailman-Version":"2.1.29","X-BeenThere":"libcamera-devel@lists.libcamera.org","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","Reply-To":"David Plowman <david.plowman@raspberrypi.com>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","Subject":"[libcamera-devel] [PATCH] ipa: raspberrypi: imx296: Minor tuning\n\tupdates","Content-Type":"message/rfc822","Content-Disposition":"inline","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"Some small updates to the tuning for the imx296 colour sensor:\n\n* Minor colour changes, generally makes things a little less green\n* Sharpening toned down\n* rpi.focus algorithm added so that focus measure can be accessed.\n\nThe sharpening and focus changes are also made for the mono version of\nthe sensor. The sharpness characteristics should be very similar so\nthe change should beneficial, and the addition of the focus measure\nmay be useful, and is at worst harmless.\n\nSigned-off-by: David Plowman <david.plowman@raspberrypi.com>\n---\n src/ipa/raspberrypi/data/imx296.json      | 20 ++++++++++++++------\n src/ipa/raspberrypi/data/imx296_mono.json | 12 ++++++++++--\n 2 files changed, 24 insertions(+), 8 deletions(-)","diff":"diff --git a/src/ipa/raspberrypi/data/imx296.json b/src/ipa/raspberrypi/data/imx296.json\nindex 4e830517..2ced95e2 100644\n--- a/src/ipa/raspberrypi/data/imx296.json\n+++ b/src/ipa/raspberrypi/data/imx296.json\n@@ -78,7 +78,7 @@\n                     \"auto\":\n                     {\n                         \"lo\": 2500,\n-                        \"hi\": 8000\n+                        \"hi\": 7600\n                     },\n                     \"incandescent\":\n                     {\n@@ -108,7 +108,7 @@\n                     \"cloudy\":\n                     {\n                         \"lo\": 7000,\n-                        \"hi\": 8600\n+                        \"hi\": 7600\n                     }\n                 },\n                 \"bayes\": 1,\n@@ -122,8 +122,8 @@\n                     5600.0, 0.2948, 0.6124,\n                     7400.0, 0.2336, 0.6894\n                 ],\n-                \"sensitivity_r\": 1.0,\n-                \"sensitivity_b\": 1.0,\n+                \"sensitivity_r\": 1.05,\n+                \"sensitivity_b\": 1.05,\n                 \"transverse_pos\": 0.03093,\n                 \"transverse_neg\": 0.02374\n             }\n@@ -418,7 +418,15 @@\n             }\n         },\n         {\n-            \"rpi.sharpen\": { }\n+            \"rpi.sharpen\":\n+\t    {\n+\t\t\"threshold\": 0.1,\n+\t\t\"strength\": 1.0,\n+\t\t\"limit\": 0.18\n+\t    }\n+        },\n+        {\n+            \"rpi.focus\": { }\n         }\n     ]\n-}\n\\ No newline at end of file\n+}\ndiff --git a/src/ipa/raspberrypi/data/imx296_mono.json b/src/ipa/raspberrypi/data/imx296_mono.json\nindex b68b11db..d937bb30 100644\n--- a/src/ipa/raspberrypi/data/imx296_mono.json\n+++ b/src/ipa/raspberrypi/data/imx296_mono.json\n@@ -222,7 +222,15 @@\n             }\n         },\n         {\n-            \"rpi.sharpen\": { }\n+            \"rpi.sharpen\":\n+\t    {\n+\t\t\"threshold\": 0.1,\n+\t\t\"strength\": 1.0,\n+\t\t\"limit\": 0.18\n+\t    }\n+        },\n+        {\n+            \"rpi.focus\": { }\n         }\n     ]\n-}\n\\ No newline at end of file\n+}\n","prefixes":["libcamera-devel"]}