{"id":18297,"url":"https://patchwork.libcamera.org/api/patches/18297/?format=json","web_url":"https://patchwork.libcamera.org/patch/18297/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20230222151917.669526-4-jacopo.mondi@ideasonboard.com>","date":"2023-02-22T15:19:16","name":"[libcamera-devel,v2,3/4] libcamera: rkisp1: Reserve main path for StillCapture","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"93c9cbbf5eeda2270670d7254a9149c643a3d159","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/?format=json","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/18297/mbox/","series":[{"id":3762,"url":"https://patchwork.libcamera.org/api/series/3762/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3762","date":"2023-02-22T15:19:13","name":"libcamera: rkisp1: Fix generateConfiguration","version":2,"mbox":"https://patchwork.libcamera.org/series/3762/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/18297/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/18297/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 37CE4C329C\n\tfor ;\n\tWed, 22 Feb 2023 15:19:34 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5E64E62606;\n\tWed, 22 Feb 2023 16:19:33 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E65D862606\n\tfor ;\n\tWed, 22 Feb 2023 16:19:30 +0100 (CET)","from uno.homenet.telecomitalia.it\n\t(host-87-16-53-160.retail.telecomitalia.it [87.16.53.160])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 230831E7C;\n\tWed, 22 Feb 2023 16:19:30 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1677079173;\n\tbh=xMSBikLF+V4AF0eVUPM2TQhcjRD1TgaaxnkoKUwYyNw=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=EpPWu4q9xDOABzwTfz/SYSePHL76KkXqdUntrzeVkKe2n+0d/Z/AtaHDeto21csRc\n\tTubbomCXAaaO/fhlhGFkcXs8sw15BW2JtFd4oH7UIxn5lTsM8trPIYpND8ijcKD5CH\n\tbtuF+nl1eF/ThIaOoQJwpXexlt1jYVgs8znpaESj8Eef1Wy6H67FVmJQGexkdJbkDA\n\tqINvjqmRyX0H6e/WOX01UXJ98Iov+/v2UE6IvhrJCSnGvP2b3GSP5nzqolaSb+rdSe\n\t6eDGYWZy0h0et8EPhUAgw5z4WimP/fJWs+CvrX9Pg98ccV9GJzMUveK/Y92L/mBRKI\n\tpazZCHjCmERIw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1677079170;\n\tbh=xMSBikLF+V4AF0eVUPM2TQhcjRD1TgaaxnkoKUwYyNw=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=Mmc+lX4r1+a5vn5lv8mxhIlFAVW8MvxzUEZb6gneS9YDmQ7b0pMIEpex3c5caN8Ez\n\tzDJBKOLVyoiXbsATaW2zxtI0W81cXJPrxqpF0JN/0vlOqnH8vakwrvDKh2AqdKwGyt\n\tjIvs1CbIt2GKbfNa1OPiafDahkivY+RLxPQuaK6M="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"Mmc+lX4r\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 22 Feb 2023 16:19:16 +0100","Message-Id":"<20230222151917.669526-4-jacopo.mondi@ideasonboard.com>","X-Mailer":"git-send-email 2.39.0","In-Reply-To":"<20230222151917.669526-1-jacopo.mondi@ideasonboard.com>","References":"<20230222151917.669526-1-jacopo.mondi@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 3/4] libcamera: rkisp1: Reserve main\n\tpath for StillCapture","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"Jacopo Mondi , libcamera@luigi311.com","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The main output path can produce images in higher resolution and\nshould be reserved for the StillCapture role when a configuration\nis generated.\n\nBefore this change if StillCapture was not requested first it got\nassigned to the self-path and thus down-scaled to 1920x1920.\n\nWith this change, StillCapture can be asked last and it would take\nprecedence over other streams for the usage of the main path.\n\n$ cam -c1 --stream role=viewfinder --stream role=still\nCamera camera.cpp:969 streams configuration: (0) 1920x1080-NV12 (1) 4208x3120-NV12\n\nSigned-off-by: Jacopo Mondi \n---\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 15 ++++++++++++++-\n 1 file changed, 14 insertions(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex 05a7ba03b2d2..23ff859e3835 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -626,6 +626,16 @@ PipelineHandlerRkISP1::generateConfiguration(Camera *camera,\n \tif (roles.empty())\n \t\treturn config;\n \n+\t/* If still capture is requested, reserve the main path for it. */\n+\tbool reserveMainPath = false;\n+\tfor (const StreamRole role : roles) {\n+\t\tif (role != StreamRole::StillCapture)\n+\t\t\tcontinue;\n+\n+\t\treserveMainPath = true;\n+\t\tbreak;\n+\t}\n+\n \t/*\n \t * As the ISP can't output different color spaces for the main and self\n \t * path, pick a sensible default color space based on the role of the\n@@ -644,6 +654,9 @@ PipelineHandlerRkISP1::generateConfiguration(Camera *camera,\n \t\t\tif (!colorSpace)\n \t\t\t\tcolorSpace = ColorSpace::Sycc;\n \n+\t\t\t/* Unlock usage of main path which was reserved. */\n+\t\t\treserveMainPath = false;\n+\n \t\t\tsize = data->sensor_->resolution();\n \t\t\tbreak;\n \n@@ -685,7 +698,7 @@ PipelineHandlerRkISP1::generateConfiguration(Camera *camera,\n \n \t\tRkISP1Path *path;\n \n-\t\tif (useMainPath) {\n+\t\tif (useMainPath && !reserveMainPath) {\n \t\t\tpath = data->mainPath_;\n \t\t\tmainPathAvailable = false;\n \t\t} else {\n","prefixes":["libcamera-devel","v2","3/4"]}