[{"id":26457,"web_url":"https://patchwork.libcamera.org/comment/26457/","msgid":"","date":"2023-02-14T17:04:34","subject":"Re: [libcamera-devel] [PATCH v2] pipeline: raspberrypi: Fix error\n\tin validateColorSpaces","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi David,\n\nThank you for the patch.\n\nOn Mon, Feb 13, 2023 at 10:18:08AM +0000, David Plowman via libcamera-devel wrote:\n> This fixes a small error in the validateColorSpaces method where the\n> colour space was not being set to Raw if it had an \"unset\" (null\n> option) value.\n> \n> Fixes: 613d5402673e (\"pipeline: raspberrypi: Fix handling of colour spaces\")\n> Signed-off-by: David Plowman \n> Reviewed-by: Umang Jain \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 5 ++---\n> 1 file changed, 2 insertions(+), 3 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> index c0dd9551..84120954 100644\n> --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> @@ -449,10 +449,9 @@ CameraConfiguration::Status RPiCameraConfiguration::validateColorSpaces([[maybe_\n> \t\t/* First fix up raw streams to have the \"raw\" colour space. */\n> \t\tif (isRaw(cfg.pixelFormat)) {\n> \t\t\t/* If there was no value here, that doesn't count as \"adjusted\". */\n> -\t\t\tif (cfg.colorSpace && cfg.colorSpace != ColorSpace::Raw) {\n> +\t\t\tif (cfg.colorSpace && cfg.colorSpace != ColorSpace::Raw)\n> \t\t\t\tstatus = Adjusted;\n> -\t\t\t\tcfg.colorSpace = ColorSpace::Raw;\n> -\t\t\t}\n> +\t\t\tcfg.colorSpace = ColorSpace::Raw;\n> \t\t\tcontinue;\n> \t\t}\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C76BEBDB13\n\tfor ;\n\tTue, 14 Feb 2023 17:04:35 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 80D12625F4;\n\tTue, 14 Feb 2023 18:04:35 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9E824625DF\n\tfor ;\n\tTue, 14 Feb 2023 18:04:34 +0100 (CET)","from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi\n\t[213.243.189.158])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2BDFC3D7;\n\tTue, 14 Feb 2023 18:04:34 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1676394275;\n\tbh=0ky69zude3hFQkgAki9cBRDY6wwJpJ0zL12m61QVCjs=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=q5vut4PJY7ZE5Jz1HK1xL0TQO+i42vGQdMeE9WPf16cZWtGXmR/7W1uDSiMJjk47s\n\t3eawprAwC/jqksNIk7B62o42CbLz1YL5Cp1XUYDG7hEIKTHY59ESI95a/tlapXH1DV\n\tlrPQa8TKfI/maBxrg0HZGo4b1SqIpPnDNEFirTlNXnyeW1JQZZ2pftzC2YB2KzsaUS\n\t44lYA2kr/faaWkWeRd0100iFcE7VQy47wbRDBtM2oBAvggrmYSMKsJjeDLQboTbHma\n\tFY44ClaQau3dtc+X04mnoGngp+AcsYheKA8CDgFq5HyA/OpsG/cWd1QQtJ7cnRluNi\n\txvIrmmWyB1QbA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1676394274;\n\tbh=0ky69zude3hFQkgAki9cBRDY6wwJpJ0zL12m61QVCjs=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=BFUT52CLOgpQndMwy6y8DojcIzpAvMO6KU40lOBtOJByB9m6OBASrR1HfbmB/3jyU\n\tvUbB45Sh4BYP+pRGOnm84ikcui9AFSyZqLX1/SYLCCVhFCV3pdSih9Eu6z+RcadPMv\n\teQEFq6mCnm3HJrerw9N3U4HaHYFqRZB+Q0MOBaY4="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"BFUT52CL\"; dkim-atps=neutral","Date":"Tue, 14 Feb 2023 19:04:34 +0200","To":"David Plowman ","Message-ID":"","References":"<20230213101808.4985-1-david.plowman@raspberrypi.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20230213101808.4985-1-david.plowman@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH v2] pipeline: raspberrypi: Fix error\n\tin validateColorSpaces","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]