[{"id":26449,"web_url":"https://patchwork.libcamera.org/comment/26449/","msgid":"","date":"2023-02-13T09:40:40","subject":"Re: [libcamera-devel] [PATCH] pipeline: raspberrypi: Fix error in\n\tvalidateColorSpaces","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi David,\n\nThank you for the patch\n\nOn 2/13/23 2:49 PM, David Plowman via libcamera-devel wrote:\n> This fixes a small error in the validateColorSpaces method where the\n> colour space was not being set to Raw if it had an \"unset\" (null\n> option) value.\n>\n> Signed-off-by: David Plowman \n\nLGTM,\n\nReviewed-by: Umang Jain \n\n> ---\n> src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 5 ++---\n> 1 file changed, 2 insertions(+), 3 deletions(-)\n>\n> diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> index c0dd9551..84120954 100644\n> --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> @@ -449,10 +449,9 @@ CameraConfiguration::Status RPiCameraConfiguration::validateColorSpaces([[maybe_\n> \t\t/* First fix up raw streams to have the \"raw\" colour space. */\n> \t\tif (isRaw(cfg.pixelFormat)) {\n> \t\t\t/* If there was no value here, that doesn't count as \"adjusted\". */\n> -\t\t\tif (cfg.colorSpace && cfg.colorSpace != ColorSpace::Raw) {\n> +\t\t\tif (cfg.colorSpace && cfg.colorSpace != ColorSpace::Raw)\n> \t\t\t\tstatus = Adjusted;\n> -\t\t\t\tcfg.colorSpace = ColorSpace::Raw;\n> -\t\t\t}\n> +\t\t\tcfg.colorSpace = ColorSpace::Raw;\n> \t\t\tcontinue;\n> \t\t}\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DA702BDB1C\n\tfor ;\n\tMon, 13 Feb 2023 09:40:48 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 28949625F4;\n\tMon, 13 Feb 2023 10:40:48 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 854A961EED\n\tfor ;\n\tMon, 13 Feb 2023 10:40:46 +0100 (CET)","from [IPV6:2401:4900:1f3e:54db:f072:a64a:6d2e:66a9] (unknown\n\t[IPv6:2401:4900:1f3e:54db:f072:a64a:6d2e:66a9])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9D1FA501;\n\tMon, 13 Feb 2023 10:40:45 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1676281248;\n\tbh=Fin20iD7fnCxfER1KIUETta8fjawTb5Pv2zGJaNysAg=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=RSIq+5m1WI2phLkX505RxfAcXHdjTCy+y43/GKh54IvgoAavCLFBaXDfa6pg1d9tG\n\t3BRjdxxwv7GZX064YNdDlbnrs+zn0dc/797Im2KeRRzDtoWhQfjZt3jxaYZOgQWoBd\n\tGCYSze+B8+JrUgI/ESYkAoXKVqY4Jav3Va0UcsfBszvykcvRPLAUcBWQSN6kOU/Jbm\n\tFWziEHFou3br7qfHY7Dboj3o9ky2Vbj8BWM4EUax3OioywTYXYAFUXPsu3P6FuxK4V\n\tskQiYnL07j7tlr2AsTzc3V0h5qxFkL5NlCKnGKO8/25HI8J76/06uPRjsVqTHqgYgB\n\tdg9l1pFpTk0jg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1676281246;\n\tbh=Fin20iD7fnCxfER1KIUETta8fjawTb5Pv2zGJaNysAg=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=hy/bdvumzkZM5gU/ceQc7zLNMqEpYKkftq5X+1Q9sU6FumZ7lFLAKDt/xDJwiKj78\n\tN/pu3qG7WMR61x+pQZXA/o12nb5VIrac9D1BvyvZDWq7xM7SRqVhYxWhXdS5jrs2fw\n\tRJAt0Wzsi9K9r6SHaMQCiV0TCbZeI9Y1enc6OgV8="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"hy/bdvum\"; dkim-atps=neutral","Message-ID":"","Date":"Mon, 13 Feb 2023 15:10:40 +0530","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101\n\tThunderbird/102.6.0","To":"David Plowman ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20230213091934.2356-1-david.plowman@raspberrypi.com>","Content-Language":"en-US","In-Reply-To":"<20230213091934.2356-1-david.plowman@raspberrypi.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH] pipeline: raspberrypi: Fix error in\n\tvalidateColorSpaces","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Umang Jain via libcamera-devel ","Reply-To":"Umang Jain ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":26450,"web_url":"https://patchwork.libcamera.org/comment/26450/","msgid":"","date":"2023-02-13T10:12:38","subject":"Re: [libcamera-devel] [PATCH] pipeline: raspberrypi: Fix error in\n\tvalidateColorSpaces","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi David,\n\nThank you for the patch.\n\nOn Mon, Feb 13, 2023 at 09:19:34AM +0000, David Plowman via libcamera-devel wrote:\n> This fixes a small error in the validateColorSpaces method where the\n> colour space was not being set to Raw if it had an \"unset\" (null\n> option) value.\n\nShould this have a Fixes: tag ?\n\n> Signed-off-by: David Plowman \n> ---\n> src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 5 ++---\n> 1 file changed, 2 insertions(+), 3 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> index c0dd9551..84120954 100644\n> --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> @@ -449,10 +449,9 @@ CameraConfiguration::Status RPiCameraConfiguration::validateColorSpaces([[maybe_\n> \t\t/* First fix up raw streams to have the \"raw\" colour space. */\n> \t\tif (isRaw(cfg.pixelFormat)) {\n> \t\t\t/* If there was no value here, that doesn't count as \"adjusted\". */\n> -\t\t\tif (cfg.colorSpace && cfg.colorSpace != ColorSpace::Raw) {\n> +\t\t\tif (cfg.colorSpace && cfg.colorSpace != ColorSpace::Raw)\n> \t\t\t\tstatus = Adjusted;\n> -\t\t\t\tcfg.colorSpace = ColorSpace::Raw;\n> -\t\t\t}\n> +\t\t\tcfg.colorSpace = ColorSpace::Raw;\n> \t\t\tcontinue;\n> \t\t}\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B63BEBDB13\n\tfor ;\n\tMon, 13 Feb 2023 10:12:40 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2F305625F4;\n\tMon, 13 Feb 2023 11:12:40 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1D6E361EED\n\tfor ;\n\tMon, 13 Feb 2023 11:12:39 +0100 (CET)","from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi\n\t[213.243.189.158])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 83FA3501;\n\tMon, 13 Feb 2023 11:12:38 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1676283160;\n\tbh=qEAjWdTCangLQrv1gSuGiBg+aMFHGQVXq3yyd1uUB+8=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=wUGGAepFbN1hQjRkicXU6w5voR5h28g19qTKH/yuvtlF5SbIB3j/A4PY+9obBUpxJ\n\tDw2EbaQX73jPMW0GfJ+jzqF83uoeJeMbhtd4lk6fqEtKzbotqkzdoEJawJqYw7XEF/\n\t7GK2JcO1M51bkKjai5Ls6H3tQdZ9rseqCrs8hwpJNNIoyVwy521xZFo+x1PzuqWVWs\n\tbuY5DGRiIP194dP6cBqObgPQxOYaKNG+Fk7tb5km0E77C3EnS/TJtbGVkJPcA6mLV4\n\tXkeD13bePs4mLwBwxot62SpFZV1Ow0CRuKBMmExBV2Ut4BdoJ9910L7o2eF0o+6jeh\n\tBBGx458T4BGnw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1676283158;\n\tbh=qEAjWdTCangLQrv1gSuGiBg+aMFHGQVXq3yyd1uUB+8=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=oOpu2T3139obvCdOveOH82Xce4wnYN02XU6523W9ERS+76wgW9BONjYJpGs58FLlN\n\t9m4xIKrMsooe6F6heiegLDJT1PWBrDL7Kpzlqj5HkcvHRQLMo1EX2eOjCZRyxHx4vs\n\teTzFCX226lqKqMEJPEtLC/sQYnY3RGTk29/Kyva8="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"oOpu2T31\"; dkim-atps=neutral","Date":"Mon, 13 Feb 2023 12:12:38 +0200","To":"David Plowman ","Message-ID":"","References":"<20230213091934.2356-1-david.plowman@raspberrypi.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20230213091934.2356-1-david.plowman@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH] pipeline: raspberrypi: Fix error in\n\tvalidateColorSpaces","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":26451,"web_url":"https://patchwork.libcamera.org/comment/26451/","msgid":"","date":"2023-02-13T10:13:31","subject":"Re: [libcamera-devel] [PATCH] pipeline: raspberrypi: Fix error in\n\tvalidateColorSpaces","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"content":"Hi Laurent\n\nAh yes, forgot about \"fixes\" tags. Let me try again...!\n\nThanks\nDavid\n\nOn Mon, 13 Feb 2023 at 10:12, Laurent Pinchart <\nlaurent.pinchart@ideasonboard.com> wrote:\n\n> Hi David,\n>\n> Thank you for the patch.\n>\n> On Mon, Feb 13, 2023 at 09:19:34AM +0000, David Plowman via\n> libcamera-devel wrote:\n> > This fixes a small error in the validateColorSpaces method where the\n> > colour space was not being set to Raw if it had an \"unset\" (null\n> > option) value.\n>\n> Should this have a Fixes: tag ?\n>\n> > Signed-off-by: David Plowman \n> > ---\n> > src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 5 ++---\n> > 1 file changed, 2 insertions(+), 3 deletions(-)\n> >\n> > diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> > index c0dd9551..84120954 100644\n> > --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> > +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> > @@ -449,10 +449,9 @@ CameraConfiguration::Status\n> RPiCameraConfiguration::validateColorSpaces([[maybe_\n> > /* First fix up raw streams to have the \"raw\" colour\n> space. */\n> > if (isRaw(cfg.pixelFormat)) {\n> > /* If there was no value here, that doesn't count\n> as \"adjusted\". */\n> > - if (cfg.colorSpace && cfg.colorSpace !=\n> ColorSpace::Raw) {\n> > + if (cfg.colorSpace && cfg.colorSpace !=\n> ColorSpace::Raw)\n> > status = Adjusted;\n> > - cfg.colorSpace = ColorSpace::Raw;\n> > - }\n> > + cfg.colorSpace = ColorSpace::Raw;\n> > continue;\n> > }\n> >\n>\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1F89EBDB13\n\tfor ;\n\tMon, 13 Feb 2023 10:13:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CB810625E3;\n\tMon, 13 Feb 2023 11:13:44 +0100 (CET)","from mail-ot1-x331.google.com (mail-ot1-x331.google.com\n\t[IPv6:2607:f8b0:4864:20::331])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7245961EED\n\tfor ;\n\tMon, 13 Feb 2023 11:13:43 +0100 (CET)","by mail-ot1-x331.google.com with SMTP id\n\t14-20020a9d010e000000b0068bdddfa263so3549725otu.2\n\tfor ;\n\tMon, 13 Feb 2023 02:13:43 -0800 (PST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1676283224;\n\tbh=WQxIy9Lhw+RzW5PormxGOExzpmmR/3zSPB7+2M+77BA=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=o558doWAOJHi71yDU78iDbBMf0taak7xBsNQTfij+tcJl/RYzG5uWuCHHpsRwUAS0\n\tnArBcBTjfiH0lnlksGXtmrEqXATzr9QcTtwLv/7bSLVxHgZr2FO+7rb2RQvc9Ij7S8\n\tFF4KJhJnZmbbv0fISE5haDbuIvSPsfR0AP3Fsk4GiRZFpo5WJsENLL3ok8JlR6MKFM\n\tDXZTisgfMKdf3J8EDpnbceL8AyODa0eeRMSwWmg1j94QmybUDzDxMgwLnJkvEzC6Nr\n\taRhxkrkyxOXLnoQ8K63eKQOy1gRgy740EfUKmLBNcqtV4JTiCSoThgutdIsyPhcOni\n\tra6LddjeOl5sg==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=4NgkEZ9kLULRrNOM9N6Zwuouzq9fMXa5uphAwBeXNic=;\n\tb=LLVJv/87qpJVyiQG7X0FDeO+EN4E168DV2YJxdzyn6v000eUzzmgoGS07ycw1nZvEV\n\thHsbxL1qn0Di3WOfxvdZHC+p4B0lyr+MsjMOZkVfPmXUy3xmruJkSGuvz16rr9XZbqZY\n\tn97E8mtNc9g7DDp+oo7tNoJzxfkxmtdC/vOkAundUuct8VgbxZuc/xc/LQ4xCQtIpatM\n\t4Ib10faVeG6IX/dv0kPvtKwrDqAnQ3q/T/h0jU2/XzSzqSIqnhkCYC6DjneXZoqYoTVK\n\typcgcM790JpBm11GMboZo38X17DjWshwpuUunlHLkpmDDH0iJKvETVDcSxTYkuoYMdIB\n\tH1Gg=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"LLVJv/87\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=4NgkEZ9kLULRrNOM9N6Zwuouzq9fMXa5uphAwBeXNic=;\n\tb=UyBD1C+FPDYJP23uLfigAC3oY5R1q2SXUrC1//n1KbmZe60mcLWjwowshIy6i0gbv/\n\tzdQAAf6Mj+aqk9wksAkB0moyyyAKTf6f1gjlOcSHCMtnzLlgBr8OPN9e4VOxf5/Hee3t\n\tkOZbqbgoRJ7tC+9PZUfKGNj7xCqcjkC8eB08A769H2BJuifAN71yK9TgpCjHN+MtCVfo\n\tP4xyXk4qPV7PFqHoZbl9oQyg4h3lDrKGROsa0fHSp8MaGY7PkQiI+DBizwLKw/3aozgq\n\tv6rORWbpqa4v6V8H75o4KrwBWil5YzETgujp26rY3YnOREafMwjDjJYPLK3Gy/TgvI7t\n\tFycQ==","X-Gm-Message-State":"AO0yUKUqgTK4f3oLOr9QVRGVLbcDVRarIMEgSH/bTNXpoQsPze6aQr4J\n\tIRTdiHLVQj2FXbwYazhIdjWNTLBDKlkbndu+oDvgekyXKvj9Kw==","X-Google-Smtp-Source":"AK7set9uz5UyQ62xkz/aaTESDb/mjW5mag3HZiaSgJ/U0WnZc1onUOvGqQcvliHrrjVvHJbc5qKME0Hxb6EwCbq2zqY=","X-Received":"by 2002:a05:6830:6117:b0:684:a0bb:75e0 with SMTP id\n\tca23-20020a056830611700b00684a0bb75e0mr2017492otb.82.1676283222168;\n\tMon, 13 Feb 2023 02:13:42 -0800 (PST)","MIME-Version":"1.0","References":"<20230213091934.2356-1-david.plowman@raspberrypi.com>\n\t","In-Reply-To":"","Date":"Mon, 13 Feb 2023 10:13:31 +0000","Message-ID":"","To":"Laurent Pinchart ","Content-Type":"multipart/alternative; boundary=\"000000000000002de605f4921ad6\"","Subject":"Re: [libcamera-devel] [PATCH] pipeline: raspberrypi: Fix error in\n\tvalidateColorSpaces","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"David Plowman via libcamera-devel ","Reply-To":"David Plowman ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]