[{"id":26445,"web_url":"https://patchwork.libcamera.org/comment/26445/","msgid":"","date":"2023-02-11T22:07:14","subject":"Re: [libcamera-devel] [PATCH] documentation: small fixes","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Pavel,\n\nThank you for the patch.\n\nOn Sat, Feb 11, 2023 at 10:59:14PM +0100, Pavel Machek via libcamera-devel wrote:\n> Out should really be output, and document dependency on pkg-config.\n> \n> Signed-off-by: Pavel Machek \n> \n> diff --git a/Documentation/guides/application-developer.rst b/Documentation/guides/application-developer.rst\n> index 1b2d7727..c46d3362 100644\n> --- a/Documentation/guides/application-developer.rst\n> +++ b/Documentation/guides/application-developer.rst\n> @@ -5,7 +5,7 @@ Using libcamera in a C++ application\n> \n> This tutorial shows how to create a C++ application that uses libcamera to\n> interface with a camera on a system, capture frames from it for 3 seconds, and\n> -write metadata about the frames to standard out.\n> +write metadata about the frames to standard output.\n\nGood fix.\n\n> \n> Application skeleton\n> --------------------\n> diff --git a/README.rst b/README.rst\n> index 34b6b49f..f94c0880 100644\n> --- a/README.rst\n> +++ b/README.rst\n> @@ -84,7 +84,7 @@ for gstreamer: [optional]\n> libgstreamer1.0-dev libgstreamer-plugins-base1.0-dev\n> \n> for cam: [optional]\n> - libevent-dev is required to support cam, however the following\n> + libevent-dev + pkg-config is required to support cam, however the following\n\npkg-config is documented as required by meson a few lines above:\n\nMeson Build system: [required]\n meson (>= 0.56) ninja-build pkg-config\n\n> optional dependencies bring more functionality to the cam test\n> tool:\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DB929BDB13\n\tfor ;\n\tSat, 11 Feb 2023 22:07:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3F669625F4;\n\tSat, 11 Feb 2023 23:07:18 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F044361EF1\n\tfor ;\n\tSat, 11 Feb 2023 23:07:16 +0100 (CET)","from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi\n\t[213.243.189.158])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 616044B0;\n\tSat, 11 Feb 2023 23:07:16 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1676153238;\n\tbh=x8Gnb/93QhDCRtfcQD4Tw4eFeUDLyyG6LWmM6ZRvO5c=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=sH6NUA9pSv5Qhm/ZVrcdgdRXp+XsRYVB0Hw9Fc///Q1pp75Vb2Ie5M8Yluw5y+B+T\n\tPRdNvlSDW3CTyCFnCETqieJkv74xv9sNmW1jhRHhAUTyK0CDK4JplSZbOz3UBdKV14\n\tVGDfHEv38pKx4ZXdLtLj7M8A9qKqnnKDAT0lPRkp9sqERnW61pzA26k+47EITl/mek\n\taTZXP6AXOLwoHI1C5sVSv2GrqI0C7+EQBUtu45VU/MWriMPuI+B0vcO7fhEFtI9ieb\n\twhGNezx6Ucb9GGc30ISVghYR7oZ54ZKykJiBwVFbkd9Wosbbk81zV1hEoluvqfsjHt\n\t+YHWSOAM0VjZA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1676153236;\n\tbh=x8Gnb/93QhDCRtfcQD4Tw4eFeUDLyyG6LWmM6ZRvO5c=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=GpZQWeDlF1RtITLM+YScsVjLwR6nRczqO4N3jcAhumFZcl4dcZlDPyNsBm0gkTZPI\n\tMvd2qSsYcdGOsrq4DjrgehwIgtyhXjXReOFZxDkVdgE+wTB7uEcKf+9yaa5bw8W0i8\n\t+HbI5V20l+YI8DCYfi1OPLX84ht6iIaUQiOdgMqo="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"GpZQWeDl\"; dkim-atps=neutral","Date":"Sun, 12 Feb 2023 00:07:14 +0200","To":"Pavel Machek ","Message-ID":"","References":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH] documentation: small fixes","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":26446,"web_url":"https://patchwork.libcamera.org/comment/26446/","msgid":"","date":"2023-02-12T17:19:19","subject":"Re: [libcamera-devel] [PATCH] documentation: small fixes","submitter":{"id":49,"url":"https://patchwork.libcamera.org/api/people/49/","name":"Pavel Machek","email":"pavel@ucw.cz"},"content":"Hi!\n\n> Thank you for the patch.\n\nThanks for review.\n\n> On Sat, Feb 11, 2023 at 10:59:14PM +0100, Pavel Machek via libcamera-devel wrote:\n> > Out should really be output, and document dependency on pkg-config.\n> > \n> > Signed-off-by: Pavel Machek \n> > \n> > diff --git a/Documentation/guides/application-developer.rst b/Documentation/guides/application-developer.rst\n> > index 1b2d7727..c46d3362 100644\n> > --- a/Documentation/guides/application-developer.rst\n> > +++ b/Documentation/guides/application-developer.rst\n> > @@ -5,7 +5,7 @@ Using libcamera in a C++ application\n> > \n> > This tutorial shows how to create a C++ application that uses libcamera to\n> > interface with a camera on a system, capture frames from it for 3 seconds, and\n> > -write metadata about the frames to standard out.\n> > +write metadata about the frames to standard output.\n> \n> Good fix.\n\nOk, should I resend just the first hunk, or can you just apply the\nfirst hunk?\n\nBest regards,\n\t\t\t\t\t\t\t\tPavel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 75068BDB13\n\tfor ;\n\tSun, 12 Feb 2023 17:19:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9E664625F4;\n\tSun, 12 Feb 2023 18:19:23 +0100 (CET)","from jabberwock.ucw.cz (jabberwock.ucw.cz [46.255.230.98])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2177D60481\n\tfor ;\n\tSun, 12 Feb 2023 18:19:21 +0100 (CET)","by jabberwock.ucw.cz (Postfix, from userid 1017)\n\tid 958CD1C0AB3; Sun, 12 Feb 2023 18:19:20 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1676222363;\n\tbh=xAAIHylVCKl/KoEZ+iXHV3vTGgndSphgKIswBN4z4U0=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=v80oeOxlFG2ykuYpdStcPaGEJ4Bp+bU2YGLPy65YdH+fQyGpDIPIvJlR8SPXNgAg+\n\tKfV+NijPYuEyPthq079ytZhfwKN2y1qQSSya9guGW18DkJFgmqVGschYmQMBc+kcXD\n\tzuZ91p8bBWwtYiGOG1CZh/uaohpGN5FFEH3U0Ik6CyFUlHBG7NvRSZXwTnZmaSxHW4\n\t7puqGvA20R0WKwOWwi8Eo+zBKpmanXTMcQjVsqDd4h+IDYszfQfgT/ThKBlcYJErZZ\n\t4aWCHD1KWhFJ40uDFNdNei5/PWV5gFiSVFRzg3Tqc0ok4+kWS5L31p6xvxcQWzJAXM\n\tGel39RsD5HK4A==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=ucw.cz; s=gen1;\n\tt=1676222360;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=kFhcinlIYD9XVYWVn+T8pICbzy04qi9RS4075u1U7zw=;\n\tb=NYI8eeDboLZg7UaRHCYbJywoBc3oekEYBrmGrhfG6Jk0loW5z6fg5JN9FRlLaMWKTOw9sj\n\tXjB3TRPhTVyyU0FONjDFpFZs7sJ8oLR+nhjH1e+31Fk1kPEIsPONgYM6Xh5UmlA1Hzw2G3\n\tBU51S8jM8S0022WcyBxP/PwSEAcUJRo="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ucw.cz header.i=@ucw.cz\n\theader.b=\"NYI8eeDb\"; dkim-atps=neutral","Date":"Sun, 12 Feb 2023 18:19:19 +0100","To":"Laurent Pinchart ","Message-ID":"","References":"\n\t","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha1;\n\tprotocol=\"application/pgp-signature\"; boundary=\"bzc9aKhGpWMLvkyB\"","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH] documentation: small fixes","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Pavel Machek via libcamera-devel ","Reply-To":"Pavel Machek ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":26447,"web_url":"https://patchwork.libcamera.org/comment/26447/","msgid":"","date":"2023-02-12T18:02:12","subject":"Re: [libcamera-devel] [PATCH] documentation: small fixes","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Sun, Feb 12, 2023 at 06:19:19PM +0100, Pavel Machek wrote:\n> Hi!\n> \n> > Thank you for the patch.\n> \n> Thanks for review.\n> \n> > On Sat, Feb 11, 2023 at 10:59:14PM +0100, Pavel Machek via libcamera-devel wrote:\n> > > Out should really be output, and document dependency on pkg-config.\n> > > \n> > > Signed-off-by: Pavel Machek \n> > > \n> > > diff --git a/Documentation/guides/application-developer.rst b/Documentation/guides/application-developer.rst\n> > > index 1b2d7727..c46d3362 100644\n> > > --- a/Documentation/guides/application-developer.rst\n> > > +++ b/Documentation/guides/application-developer.rst\n> > > @@ -5,7 +5,7 @@ Using libcamera in a C++ application\n> > > \n> > > This tutorial shows how to create a C++ application that uses libcamera to\n> > > interface with a camera on a system, capture frames from it for 3 seconds, and\n> > > -write metadata about the frames to standard out.\n> > > +write metadata about the frames to standard output.\n> > \n> > Good fix.\n> \n> Ok, should I resend just the first hunk, or can you just apply the\n> first hunk?\n\nI've just pushed the first hunk.","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E8046BDB1C\n\tfor ;\n\tSun, 12 Feb 2023 18:02:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 438A5625F4;\n\tSun, 12 Feb 2023 19:02:14 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7E31460481\n\tfor ;\n\tSun, 12 Feb 2023 19:02:13 +0100 (CET)","from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi\n\t[213.243.189.158])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E01D74DD;\n\tSun, 12 Feb 2023 19:02:12 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1676224934;\n\tbh=k7BK4u8MD854EPmRRdAhQCbhALgkdvKZDkxatKj94cA=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=dFCpqBaglwRXvG33IN/kJWUXOw5pkhgdBRXJL1/kTJgx/3WhIDDadxFvr5Vexp7Hk\n\tGrTHXfZ96WEqbxJmYeqRBBKU1Ueaegkmo13431MXIaqhbWK8YBqF4J/GadO12n3HEP\n\tBxDdFx6wVtSQ+W18oyDsF0R7m06ZDLr9Q5j28OsRSaKwoPoxR/MSCpTQW8Idu6qWlJ\n\thgQY9dKQCaRIUyqFVnh5g7uWKfCCk5DoanefNSi94m8cOI7wH3TtdscmXNMYHUQJhZ\n\t1mhh2QyQGob6PeuwXyKgVxcR9Gjf3dPH2tJvUbwenjfOHbzw40C4Zio+QFgFAMTfCX\n\tPe/6862dhQS6w==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1676224933;\n\tbh=k7BK4u8MD854EPmRRdAhQCbhALgkdvKZDkxatKj94cA=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=bj9WhCOgcKLUs0IAqZyh5tREMbybGbxhsHW0NrJVAdFdMQthoH8tjWFvqTi5sWl4O\n\tnMdf3ZkOP9Cs5ylaIh6Q5YyEkWB/oqWvPY7gJrQRrR0nHpBg383HWOnOxO03AHA/Jz\n\tpgW4y7tfHguRNjuF1pZ+SB5Vvk5LF7Ac9i9HvJyM="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"bj9WhCOg\"; dkim-atps=neutral","Date":"Sun, 12 Feb 2023 20:02:12 +0200","To":"Pavel Machek ","Message-ID":"","References":"\n\t\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH] documentation: small fixes","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]