[{"id":26461,"web_url":"https://patchwork.libcamera.org/comment/26461/","msgid":"<167676200500.1885751.3886603861796036157@Monstersaurus>","date":"2023-02-18T23:13:25","subject":"Re: [libcamera-devel] [PATCH] qcam: Tell user if we have TIFF\n\tsupport","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Pavel Machek via libcamera-devel (2023-02-11 21:57:55)\n> User may wonder why he can't take images. Add line to help text\n> expaining if we have TIFF support.\n> \n> Signed-off-by: Pavel Machek \n> \n> diff --git a/src/apps/qcam/main.cpp b/src/apps/qcam/main.cpp\n> index 36cb93a5..36ee16ab 100644\n> --- a/src/apps/qcam/main.cpp\n> +++ b/src/apps/qcam/main.cpp\n> @@ -46,8 +46,14 @@ OptionsParser::Options parseOptions(int argc, char *argv[])\n> \"Print verbose log messages\", \"verbose\");\n> \n> OptionsParser::Options options = parser.parse(argc, argv);\n> - if (options.isSet(OptHelp))\n> + if (options.isSet(OptHelp)) {\n> parser.usage();\n> +#ifdef HAVE_TIFF\n> + qInfo() << \"TIFF/DNG support available.\";\n> +#else\n> + qInfo() << \"TIFF/DNG support NOT available, taking still images not possible\";\n> +#endif\n> + }\n\nThis worries me as a bit overtly verbose, and not consistent (Should we\nreport every other configuration option in this way?)\n\nI'd rather see something extended on the meson.build summary perhaps to\nsay that qcam doesn't support raw files maybe?\n\n--\nKieran\n\n> \n> return options;\n> }\n> \n> -- \n> People of Russia, stop Putin before his war on Ukraine escalates.","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5D891BDB13\n\tfor ;\n\tSat, 18 Feb 2023 23:13:30 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8EED5625F3;\n\tSun, 19 Feb 2023 00:13:29 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 227EE61EEA\n\tfor ;\n\tSun, 19 Feb 2023 00:13:28 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A9349907;\n\tSun, 19 Feb 2023 00:13:27 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1676762009;\n\tbh=j3PmuUHY2YELDPtud/isiLkVZdhPaNiKHSwwDWlfP+c=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=wgp3Vd2ncen3JIr+lC5+qEUmy+PxIL2bMNNH5s1lEZNvZOnMlYJF5v3qZ75JHu9lO\n\toGswzgElgyBFRlmjihHBUs9YFk/Ts0ffHj06CPZGJXGHqBmmSHyQ9St1b3GU4SD303\n\tMcsY2tl5JaW0pQHPCl6aeI+FA0CzUYBKmLdCLJDh7pT/Q+DVfHmR4p/k8YUWXB19bT\n\tEWPVAMdKCW67UIV4DEugZWYZumMD4x3ryTwXWyU7scpRSL/V5v43/BFL5ig12wvIZq\n\tCxCP9lknVROyIVehHMTakPTIXpbNYPq6x+Y/UJZ0TKO2Eiizgz2PihfcYQQH5G5U39\n\tjnCFs4u04/LsA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1676762007;\n\tbh=j3PmuUHY2YELDPtud/isiLkVZdhPaNiKHSwwDWlfP+c=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=r94Gil3xJ/8H2OJM1uCDJ8PKaaUTMQfqbv0bvHInHQLyUCUtmoAOQHya62r0Ybv/V\n\tEyKATutgO9fZRlybDTDX5E7Oneq4lJyJy9jcpHUxltP69AZGZe5yc73LU1bCiLJjqv\n\tw2FdlmOgCfpC3pAhOPFtWamPYmvRVym4Slc5NyhQ="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"r94Gil3x\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"","References":"","To":"Pavel Machek , libcamera-devel@lists.libcamera.org","Date":"Sat, 18 Feb 2023 23:13:25 +0000","Message-ID":"<167676200500.1885751.3886603861796036157@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH] qcam: Tell user if we have TIFF\n\tsupport","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":26462,"web_url":"https://patchwork.libcamera.org/comment/26462/","msgid":"","date":"2023-02-18T23:53:18","subject":"Re: [libcamera-devel] [PATCH] qcam: Tell user if we have TIFF\n\tsupport","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Sat, Feb 18, 2023 at 11:13:25PM +0000, Kieran Bingham via libcamera-devel wrote:\n> Quoting Pavel Machek via libcamera-devel (2023-02-11 21:57:55)\n> > User may wonder why he can't take images. Add line to help text\n> > expaining if we have TIFF support.\n> > \n> > Signed-off-by: Pavel Machek \n> > \n> > diff --git a/src/apps/qcam/main.cpp b/src/apps/qcam/main.cpp\n> > index 36cb93a5..36ee16ab 100644\n> > --- a/src/apps/qcam/main.cpp\n> > +++ b/src/apps/qcam/main.cpp\n> > @@ -46,8 +46,14 @@ OptionsParser::Options parseOptions(int argc, char *argv[])\n> > \"Print verbose log messages\", \"verbose\");\n> > \n> > OptionsParser::Options options = parser.parse(argc, argv);\n> > - if (options.isSet(OptHelp))\n> > + if (options.isSet(OptHelp)) {\n> > parser.usage();\n> > +#ifdef HAVE_TIFF\n> > + qInfo() << \"TIFF/DNG support available.\";\n> > +#else\n> > + qInfo() << \"TIFF/DNG support NOT available, taking still images not possible\";\n> > +#endif\n> > + }\n> \n> This worries me as a bit overtly verbose, and not consistent (Should we\n> report every other configuration option in this way?)\n> \n> I'd rather see something extended on the meson.build summary perhaps to\n> say that qcam doesn't support raw files maybe?\n\nFurthermore, will a user who wonders why the raw save button isn't\navailable think about running `qcam -h` ? It could be more user-friendly\nto always create the button in the toolbar, and leave it in a disabled\nstate with DNG support is unavailable, possibly with a tooltip message\nthat indicates why.\n\n> > \n> > return options;\n> > }","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7D842BDB13\n\tfor ;\n\tSat, 18 Feb 2023 23:53:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D1747625F3;\n\tSun, 19 Feb 2023 00:53:22 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 77A4061EEA\n\tfor ;\n\tSun, 19 Feb 2023 00:53:21 +0100 (CET)","from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi\n\t[213.243.189.158])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C514ABB0;\n\tSun, 19 Feb 2023 00:53:20 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1676764402;\n\tbh=ad/dNO+VTLpqiQokxnYuODrSjElPmBGl+YZG7H2v5dk=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=Y1fDjBUvMo18o9oPF/hi/cVpv4tw83hDjXQR5TaIR+kmyAuCgt7/x/hcIgYVZe9CI\n\t/cPPyBycSBWvL7PDmdj7a49uOyY94aj5kb3XxXzfWDpeeEPYexbMUxJXuJ7RTeTw+D\n\tN4IFKFyMD2kNxSrb0vEIBwmBySACSWH8hy+C4BqiFmYWVMERaLT5Un2EYCFBqUsuM6\n\tIydCtiKPAnAKrIWwA/uM1J/pBNA//kQCUIX+HhPaNKpC2/3rUnZNM8V40L4boENAn0\n\t0adBt9NPCCOCbGDhDEv92ySlDfAwPMJFhpI+LZmfvehDkM4Xjlg0/NAEUZVG5gJ9QP\n\trIh1aXMLFvAhQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1676764401;\n\tbh=ad/dNO+VTLpqiQokxnYuODrSjElPmBGl+YZG7H2v5dk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=dvwDHUT3+zUpg+TG62A+dKX9riO15fjuegAt6V+BXnm7XpN8+t7QnE4rxR8o72NhU\n\tQtyJa5/Zbt8dfPXU9KsKXQ2MdHJlBy1abi6V6frvPLakyjVS4KVEkgXPQrTa3qw0BZ\n\tj0vAG6deBGvCBEZzTRan4nCGLhLRyzDi45qokZlg="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"dvwDHUT3\"; dkim-atps=neutral","Date":"Sun, 19 Feb 2023 01:53:18 +0200","To":"Kieran Bingham ","Message-ID":"","References":"\n\t<167676200500.1885751.3886603861796036157@Monstersaurus>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<167676200500.1885751.3886603861796036157@Monstersaurus>","Subject":"Re: [libcamera-devel] [PATCH] qcam: Tell user if we have TIFF\n\tsupport","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org, Pavel Machek ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]