{"id":18275,"url":"https://patchwork.libcamera.org/api/patches/18275/?format=json","web_url":"https://patchwork.libcamera.org/patch/18275/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"","date":"2023-02-11T21:57:55","name":"[libcamera-devel] qcam: Tell user if we have TIFF support","commit_ref":null,"pull_url":null,"state":"changes-requested","archived":false,"hash":"4bf72087f2860ec0d4c2409ed3996de48e966a8d","submitter":{"id":49,"url":"https://patchwork.libcamera.org/api/people/49/?format=json","name":"Pavel Machek","email":"pavel@ucw.cz"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/18275/mbox/","series":[{"id":3749,"url":"https://patchwork.libcamera.org/api/series/3749/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3749","date":"2023-02-11T21:57:55","name":"[libcamera-devel] qcam: Tell user if we have TIFF support","version":1,"mbox":"https://patchwork.libcamera.org/series/3749/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/18275/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/18275/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 30801BDB1C\n\tfor ;\n\tSat, 11 Feb 2023 21:57:58 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7E20A625F4;\n\tSat, 11 Feb 2023 22:57:57 +0100 (CET)","from jabberwock.ucw.cz (jabberwock.ucw.cz [46.255.230.98])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6287361EF1\n\tfor ;\n\tSat, 11 Feb 2023 22:57:56 +0100 (CET)","by jabberwock.ucw.cz (Postfix, from userid 1017)\n\tid CEA8D1C0AB3; Sat, 11 Feb 2023 22:57:55 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1676152677;\n\tbh=VxqOjRpKaOUkJCiiH1i5WdeqeqMNJ9lOr1j334+LQ7Q=;\n\th=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=w1ybIfm5uphfuZwpsH7ztT0NVz+JT67KImFHiseEnY5uT4vm3EDNxe1OZyOTEReeE\n\tTs7RGDHk9L9Sk4cNvXEcJRKn+F+uclcQDfakxFZmn8QbIqy2Rrjfi65Koncb5GPMqJ\n\t1mKaooCa6SI3snw7yy3t9J9zw0ahh7g3aaQvg2FiVkbMpWeAnHRKCZGIWjT3RpMUqj\n\tqT9QV9BW/UX6j9EYJYNqfwEDj1/OqU3fA97l9N+VDAzJagU2laYLpskqBcT0lmt0d1\n\tcnMR+ATTzpC/QMjQqmt5l3FQFR2ZBfP7C1l0e/l4BfdGY7RYb+VOw5aJ/8N4ltLj8d\n\tBp/qa6UnOFIow==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=ucw.cz; s=gen1;\n\tt=1676152675;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:mime-version:mime-version:content-type:content-type;\n\tbh=nV7stEZgiwE644tVmDxPpngLDbwymYFKTOyeteIhy7k=;\n\tb=PrWVJVsuUcNHIYVDhxXbHohr2/h4hvnEmY2ywoV7s7GCUU+7mHnBsJUyxkAT92N+SKDXdr\n\tYAZXHSSbXgxr/RiLjm/3QfYMTGCCrtws+z51uUF4nXCEr9gY74RhzL3D6CLkrJcSakCUMp\n\t/Wl4fZoTh/GiNGYLTIZVxj3U9y6sLFc="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ucw.cz header.i=@ucw.cz\n\theader.b=\"PrWVJVsu\"; dkim-atps=neutral","Date":"Sat, 11 Feb 2023 22:57:55 +0100","To":"libcamera-devel@lists.libcamera.org","Message-ID":"","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha1;\n\tprotocol=\"application/pgp-signature\"; boundary=\"rnWCPwCZHLgh77de\"","Content-Disposition":"inline","Subject":"[libcamera-devel] [PATCH] qcam: Tell user if we have TIFF support","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Pavel Machek via libcamera-devel ","Reply-To":"Pavel Machek ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"User may wonder why he can't take images. Add line to help text\nexpaining if we have TIFF support.\n \nSigned-off-by: Pavel Machek ","diff":"diff --git a/src/apps/qcam/main.cpp b/src/apps/qcam/main.cpp\nindex 36cb93a5..36ee16ab 100644\n--- a/src/apps/qcam/main.cpp\n+++ b/src/apps/qcam/main.cpp\n@@ -46,8 +46,14 @@ OptionsParser::Options parseOptions(int argc, char *argv[])\n \t\t\t \"Print verbose log messages\", \"verbose\");\n \n \tOptionsParser::Options options = parser.parse(argc, argv);\n-\tif (options.isSet(OptHelp))\n+\tif (options.isSet(OptHelp)) {\n \t\tparser.usage();\n+#ifdef HAVE_TIFF\n+\t\tqInfo() << \"TIFF/DNG support available.\";\n+#else\n+\t\tqInfo() << \"TIFF/DNG support NOT available, taking still images not possible\";\n+#endif\n+\t}\n \n \treturn options;\n }\n","prefixes":["libcamera-devel"]}