[{"id":26433,"web_url":"https://patchwork.libcamera.org/comment/26433/","msgid":"","date":"2023-02-09T10:24:44","subject":"Re: [libcamera-devel] [PATCH] libcamera: internal: tracepoints: Use\n\tcorrect include directive","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Umang,\n\nThank you for the patch.\n\nOn Thu, Feb 09, 2023 at 01:01:16AM +0530, Umang Jain via libcamera-devel wrote:\n> libcamera uses double quotes \"...\" for #include directives for\n> internal headers.\n> \n> While at it, move the request internal header include to the right\n> location.\n> \n> Signed-off-by: Umang Jain \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> include/libcamera/internal/tracepoints/request.tp | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/include/libcamera/internal/tracepoints/request.tp b/include/libcamera/internal/tracepoints/request.tp\n> index f1e54497..4f367e91 100644\n> --- a/include/libcamera/internal/tracepoints/request.tp\n> +++ b/include/libcamera/internal/tracepoints/request.tp\n> @@ -5,10 +5,10 @@\n> * request.tp - Tracepoints for the request object\n> */\n> \n> -#include \n> -\n> #include \n> \n> +#include \"libcamera/internal/request.h\"\n> +\n> TRACEPOINT_EVENT_CLASS(\n> \tlibcamera,\n> \trequest,","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 17D5CBDB1C\n\tfor ;\n\tThu, 9 Feb 2023 10:24:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4F737625F4;\n\tThu, 9 Feb 2023 11:24:48 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 470AE625CE\n\tfor ;\n\tThu, 9 Feb 2023 11:24:46 +0100 (CET)","from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi\n\t[213.243.189.158])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 885D98DD;\n\tThu, 9 Feb 2023 11:24:45 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1675938288;\n\tbh=IKxTSJvf9GaLNtykPMzQIEJkTNgu46TP4UUgQ6Ie33w=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=pHBEjmt7Qp8IJDCSww/s+pyt4uwlKopZnEfCwhpxAV7Ujnc5+/fadfyb+B9uzg6C0\n\t5KbJW2QU9UikHLwjce1tED8EXsbaVWnc8Wbd7baEDkyqnSYNF+gJq54XyzmnWllD+5\n\tSExCjwx0Mlg/864BWzNVHxO/yobu0ecXzvZECoeePdX4bwEQboFPBpN2qOcmi8XPMU\n\tfRzMQbMvfpCo3CvV56vdknjrKBbCBdN9deNxMBvf1qUb+dCun/B/d/JIfY8bUnOgsW\n\tO9mUis6kZPXxTqyQA1VxYzxdANOdwLq2sAsXK/UsCfFuZb7STFAyu/iSNKblMkjYVi\n\t4kEX6zlZVs9Aw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1675938285;\n\tbh=IKxTSJvf9GaLNtykPMzQIEJkTNgu46TP4UUgQ6Ie33w=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=kJn+oG6MK0X3+OnqkWKa+cXyq8zEmqWOwU2au6G3bFeK8KpkPsrnikRtgoSooEybp\n\tb7qUIK7lJbkmWCm8MFjnjngxdcdnW2lkTud1FpzGuUx/9JFHNxwDfBlvo8voR/EltP\n\tTWKDKWSj3CKmuEaAkqTurmBk2s6kwMcaJsYO67u4="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"kJn+oG6M\"; dkim-atps=neutral","Date":"Thu, 9 Feb 2023 12:24:44 +0200","To":"Umang Jain ","Message-ID":"","References":"<20230208193116.117077-1-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20230208193116.117077-1-umang.jain@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: internal: tracepoints: Use\n\tcorrect include directive","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":26434,"web_url":"https://patchwork.libcamera.org/comment/26434/","msgid":"<167593969856.42371.9745914035383098355@Monstersaurus>","date":"2023-02-09T10:48:18","subject":"Re: [libcamera-devel] [PATCH] libcamera: internal: tracepoints: Use\n\tcorrect include directive","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart via libcamera-devel (2023-02-09 10:24:44)\n> Hi Umang,\n> \n> Thank you for the patch.\n> \n> On Thu, Feb 09, 2023 at 01:01:16AM +0530, Umang Jain via libcamera-devel wrote:\n> > libcamera uses double quotes \"...\" for #include directives for\n> > internal headers.\n> > \n> > While at it, move the request internal header include to the right\n> > location.\n> > \n> > Signed-off-by: Umang Jain \n> \n> Reviewed-by: Laurent Pinchart \n> \n> > ---\n> > include/libcamera/internal/tracepoints/request.tp | 4 ++--\n> > 1 file changed, 2 insertions(+), 2 deletions(-)\n> > \n> > diff --git a/include/libcamera/internal/tracepoints/request.tp b/include/libcamera/internal/tracepoints/request.tp\n> > index f1e54497..4f367e91 100644\n> > --- a/include/libcamera/internal/tracepoints/request.tp\n> > +++ b/include/libcamera/internal/tracepoints/request.tp\n> > @@ -5,10 +5,10 @@\n> > * request.tp - Tracepoints for the request object\n> > */\n> > \n> > -#include \n> > -\n\nHrm, the object's own header is supposed to go first in the C++ code,\nbut here we're in the .tp ... so I think it's actually correct to move\nit. the quotes are definitely a fix.\n\nReviewed-by: Kieran Bingham \n\n> > #include \n> > \n> > +#include \"libcamera/internal/request.h\"\n> > +\n> > TRACEPOINT_EVENT_CLASS(\n> > libcamera,\n> > request,\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 22F91BEFBE\n\tfor ;\n\tThu, 9 Feb 2023 10:48:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 79670625E3;\n\tThu, 9 Feb 2023 11:48:23 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id ABB18625CE\n\tfor ;\n\tThu, 9 Feb 2023 11:48:21 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3981C9CA;\n\tThu, 9 Feb 2023 11:48:21 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1675939703;\n\tbh=yTKHn44CmvE3KyZqP1PjTj6aApvfbYLb5Exk8HSE8XA=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=aPl4vaOMCTmXIPr14OepvMnBKygAd5T8cgo8lDX1hH20F1tRpdJLyDJZvVreFkzw2\n\twPg9Pzd9i3F//Zx2Svhwld5USzUEm2Ez1la5tiEtjzpFw8MRqNfXkufuWQrOIxDAZ6\n\tB+Dc4IANwlSomBcNxZRO+Q5gSZv6ozQIxLbxL6YxIsvnYwiNGDVT4zDUgRyFG2BwSe\n\tEMgtxoKeDqYOAjbuePUKLDAO0aHZKF5bBEVhTG72EN6JD6FNgn5kZ4nqoyRglr3HSl\n\t1cka8GB2UTQN3rqhZzv4yIfjHi/c30unWz+pOr0t1JwBvwZUZfncbjapBT6cwdkp8/\n\tC1+DbnHnZo+bQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1675939701;\n\tbh=yTKHn44CmvE3KyZqP1PjTj6aApvfbYLb5Exk8HSE8XA=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=fP23nJz9yNhjr3/k+7bPM8HXVEV/6u4YuJL8NHH8Nxi3Wn4PAj64BZCPFQDM/NKAR\n\tUt9C/7iUxCFbnwmNc00vMD9hsQRZKN4Q0p/o00M+bQ2zjYLfi2sQKU7Zk1xQVolEZt\n\tgWJ8wiFt74YbwH/bW76jx/pEkhC7ISZcH07bssLc="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"fP23nJz9\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"","References":"<20230208193116.117077-1-umang.jain@ideasonboard.com>\n\t","To":"Laurent Pinchart ,\n\tLaurent Pinchart via libcamera-devel\n\t, \n\tUmang Jain ","Date":"Thu, 09 Feb 2023 10:48:18 +0000","Message-ID":"<167593969856.42371.9745914035383098355@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH] libcamera: internal: tracepoints: Use\n\tcorrect include directive","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]