[{"id":26428,"web_url":"https://patchwork.libcamera.org/comment/26428/","msgid":"","date":"2023-02-08T10:28:30","subject":"Re: [libcamera-devel] [PATCH v1 3/4] pipeline: ipu3: Drop unused\n\tcode","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Laurent,\n\nThank you for the patch\n\nOn 2/6/23 10:33 PM, Laurent Pinchart via libcamera-devel wrote:\n> Commit 1a614866a29c (\"libcamera: camera_sensor: Validate Transform\") has\n> removed usage of the IPU3CameraData::rotationTransform_ but hasn't\n> removed the field itself, nor its initialization. Drop those as they're\n> unused.\n>\n> Fixes: 1a614866a29c (\"libcamera: camera_sensor: Validate Transform\")\n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Umang Jain \n\n> ---\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 8 --------\n> 1 file changed, 8 deletions(-)\n>\n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index 3a569c7e0031..355cb0cb76b8 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -73,7 +73,6 @@ public:\n> \tStream rawStream_;\n> \n> \tRectangle cropRegion_;\n> -\tTransform rotationTransform_;\n> \n> \tstd::unique_ptr delayedCtrls_;\n> \tIPU3Frames frameInfos_;\n> @@ -1101,13 +1100,6 @@ int PipelineHandlerIPU3::registerCameras()\n> \t\t\t\t\t << cio2->sensor()->id()\n> \t\t\t\t\t << \". Assume rotation 0\";\n> \n> -\t\tint32_t rotationValue = rotation.value_or(0);\n> -\t\tbool success;\n> -\t\tdata->rotationTransform_ = transformFromRotation(rotationValue, &success);\n> -\t\tif (!success)\n> -\t\t\tLOG(IPU3, Warning) << \"Invalid rotation of \" << rotationValue\n> -\t\t\t\t\t << \" degrees: ignoring\";\n> -\n> \t\t/**\n> \t\t * \\todo Dynamically assign ImgU and output devices to each\n> \t\t * stream and camera; as of now, limit support to two cameras","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 900B6BDB1C\n\tfor ;\n\tWed, 8 Feb 2023 10:28:38 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EE5A6625E3;\n\tWed, 8 Feb 2023 11:28:37 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8DAD4625DD\n\tfor ;\n\tWed, 8 Feb 2023 11:28:35 +0100 (CET)","from [IPV6:2401:4900:1f3e:54db:f072:a64a:6d2e:66a9] (unknown\n\t[IPv6:2401:4900:1f3e:54db:f072:a64a:6d2e:66a9])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9FC63496;\n\tWed, 8 Feb 2023 11:28:34 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1675852118;\n\tbh=9A7JJYnGx8OcLjVte8f1Wua5g7xL5yXlpJBHFUdCszA=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=HP/K3Q5iGg8CsGKOFnrHOyQykVmSogxyTjG0Vt8yQqMXiHYc5rLjLRaGUYl+asyZX\n\tFL19lLylSOuumKeOOJCr9MxoNb3I/lVmPRWQmptSmDJJoBoMfx6CbGbCcfcLle0z1O\n\tkLRVtpcSG+l70wVrO/ZoAKzAhsxqTfzj6gg3DVnz7QnbxDnMGM7AITJPkF8/KqFNjI\n\t0QNAEKiySC8FRuhMaizD30OkRvmSLt7CpWbPcNPFhbF0GWCcSShdwnrPEYWaA1kr5g\n\tRqGsgZrPtl/4cVLpcGAswgK2ufFNgzn2htjo4DxlfqR2cmF2T8AKpasDFA+EXyIc3i\n\tJQ1Hh2A7itzUw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1675852115;\n\tbh=9A7JJYnGx8OcLjVte8f1Wua5g7xL5yXlpJBHFUdCszA=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=iGXc/2RCzT2wcW1BXCdRl+89fd6JuXV+IQZqwoJEgIdR3jlQi1zgnR+75pxPDldGE\n\tAEJsXGmmNQaV3ZFNFR5WzCogmdnSPMWuoyzhCRrIJ7sXkLMuDgSJuSa9f6tHZ4qN5q\n\tY+Wg5+3S8pyQ8nsYBr78ZLj/d0lbKVna/Zf3M87s="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"iGXc/2RC\"; dkim-atps=neutral","Message-ID":"","Date":"Wed, 8 Feb 2023 15:58:30 +0530","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101\n\tThunderbird/102.6.0","Content-Language":"en-US","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20230206170356.20340-1-laurent.pinchart@ideasonboard.com>\n\t<20230206170356.20340-4-laurent.pinchart@ideasonboard.com>","In-Reply-To":"<20230206170356.20340-4-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH v1 3/4] pipeline: ipu3: Drop unused\n\tcode","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Umang Jain via libcamera-devel ","Reply-To":"Umang Jain ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]