[{"id":26427,"web_url":"https://patchwork.libcamera.org/comment/26427/","msgid":"<95551b5e-eea0-a63c-f7eb-09df43d5761f@ideasonboard.com>","date":"2023-02-08T10:26:18","subject":"Re: [libcamera-devel] [PATCH v1 2/4] libcamera: camera_sensor: Fix\n\ttypo in comment","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Laurent,\n\nThank you for the patch\n\nOn 2/6/23 10:33 PM, Laurent Pinchart via libcamera-devel wrote:\n> Fix a typo introduced in a comment when refactoring transformation\n> handling in the CameraSensor class.\n>\n> Fixes: 1a614866a29c (\"libcamera: camera_sensor: Validate Transform\")\n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Umang Jain \n\n> ---\n> src/libcamera/camera_sensor.cpp | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n>\n> diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\n> index 11117502d817..274ed419ddfd 100644\n> --- a/src/libcamera/camera_sensor.cpp\n> +++ b/src/libcamera/camera_sensor.cpp\n> @@ -1023,8 +1023,8 @@ Transform CameraSensor::validateTransform(Transform *transform) const\n> \n> \t/*\n> \t * We combine the platform and user transform, but must \"adjust away\"\n> -\t * any combined result that includes a transform, as we can't do those.\n> -\t * In this case, flipping only the transpose bit is helpful to\n> +\t * any combined result that includes a transposition, as we can't do\n> +\t * those. In this case, flipping only the transpose bit is helpful to\n> \t * applications - they either get the transform they requested, or have\n> \t * to do a simple transpose themselves (they don't have to worry about\n> \t * the other possible cases).","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A334ABDB1C\n\tfor ;\n\tWed, 8 Feb 2023 10:26:25 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 59C1D625E3;\n\tWed, 8 Feb 2023 11:26:25 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A9E8A625DD\n\tfor ;\n\tWed, 8 Feb 2023 11:26:23 +0100 (CET)","from [IPV6:2401:4900:1f3e:54db:f072:a64a:6d2e:66a9] (unknown\n\t[IPv6:2401:4900:1f3e:54db:f072:a64a:6d2e:66a9])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 93AAD496;\n\tWed, 8 Feb 2023 11:26:22 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1675851985;\n\tbh=AVj0484SD3TcCrR76j+INH/u7XUyq8QPNWzg9bsmLk4=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=A2Dartledsnu3TjJUZuruQx02KG0z3YVOC4iVfymniETsnGKtcRi/PsG8RCbcmnJX\n\tbgzq/d802sWVg1szUE1HtGKBfGRPLvXevKBMOzYdGTgw9h+LLcq6QfXMJZ3ekbXH52\n\tGyUa9OX5NjzOHsSBvG024IkPaDOeNUjpFXCV6t2t7TxBdiQWDmRISxLkLOfLQLOJmO\n\tarYLTyY9UMZ99cCD7xcxOxqUMew7l3cco0/HEyY8VJzVxCo8DVwFDLfe82/juE/aYk\n\taTs1U1ldsgQIcH+98Z02O0DIPoVJU/RH48fYni/iJg7xGYlRyb8dKNDhgRQpuL1nN1\n\tnTQYz0I+6ldTg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1675851983;\n\tbh=AVj0484SD3TcCrR76j+INH/u7XUyq8QPNWzg9bsmLk4=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=vdMV18owE7j3Ud7/6Xa1Vka8ZiqpzGYfTT85GF+stXCxAvrhnR7FIdpBi95WLdbHq\n\t6sY8NVdBbsMkf6kDDnlwaoETdh7YTn/CmO3JFDf2cz24hywooEGsk8WwWBYNKPmxtQ\n\tNpsw4S7fQzlnFGRej5tZsSNjCmpPEnFoNO7OTrNk="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"vdMV18ow\"; dkim-atps=neutral","Message-ID":"<95551b5e-eea0-a63c-f7eb-09df43d5761f@ideasonboard.com>","Date":"Wed, 8 Feb 2023 15:56:18 +0530","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101\n\tThunderbird/102.6.0","Content-Language":"en-US","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20230206170356.20340-1-laurent.pinchart@ideasonboard.com>\n\t<20230206170356.20340-3-laurent.pinchart@ideasonboard.com>","In-Reply-To":"<20230206170356.20340-3-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH v1 2/4] libcamera: camera_sensor: Fix\n\ttypo in comment","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Umang Jain via libcamera-devel ","Reply-To":"Umang Jain ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]