{"id":18256,"url":"https://patchwork.libcamera.org/api/patches/18256/?format=json","web_url":"https://patchwork.libcamera.org/patch/18256/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20230206170356.20340-3-laurent.pinchart@ideasonboard.com>","date":"2023-02-06T17:03:54","name":"[libcamera-devel,v1,2/4] libcamera: camera_sensor: Fix typo in comment","commit_ref":"ec392360f65639d6fbc9d2c54fe119baa49248cb","pull_url":null,"state":"accepted","archived":false,"hash":"5c3ae4a74f937324eb878ea1192a7127e0b3acae","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/18256/mbox/","series":[{"id":3740,"url":"https://patchwork.libcamera.org/api/series/3740/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3740","date":"2023-02-06T17:03:52","name":"Misc fixes for transformation handling","version":1,"mbox":"https://patchwork.libcamera.org/series/3740/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/18256/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/18256/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 223DBBEFBE\n\tfor ;\n\tMon, 6 Feb 2023 17:04:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5736D625F1;\n\tMon, 6 Feb 2023 18:04:02 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EF019625F1\n\tfor ;\n\tMon, 6 Feb 2023 18:04:00 +0100 (CET)","from pendragon.ideasonboard.com (unknown [109.136.43.56])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 94AE14DA\n\tfor ;\n\tMon, 6 Feb 2023 18:04:00 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1675703042;\n\tbh=OgQo0Z0iK/8tiIURZRhO8S9jZnoomSz+CA0NP8uYdxo=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=i/40BZyJYVN+EMWr5VYgXG3e6wQFAyj3o7myhMElCOKsLjCGVoEsEN+HOXxnJV4bD\n\tPqYtkUhr5tRMK7ucU8IhAFgDUoxUOJyRr3Hm20jaJ4HdQRKE90GY5g8PQTkNGPNOOz\n\tVNm3NrNAUsKuXYjCah3NAkKkgo9sMTiYXpsogpGP7Cw1ejRL3zPeOFSYDEmjt8nwun\n\t/KvHoh7uxCC180jN71fjRz7ElyTHy73OM6jZOI/55HWnk7O6qyabmpO8nNzCaeFP5V\n\th2KzVvzLlsxd9p0gmObNisSZ2t8qpFrvz871Z8VE+385/0rOH5o26Oi7vi09Mkpzck\n\tJmCMHFWCKhU1w==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1675703040;\n\tbh=OgQo0Z0iK/8tiIURZRhO8S9jZnoomSz+CA0NP8uYdxo=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=wOZTTPcQ2ssr4cnoKwRDCXQsU6Luj43tuZs7DozX9HA30vd/xxvVJkKAmZ4Udhz4T\n\tnxHIexiy/QJYhV2HiWuKNhyze5BJdIs//U8jY56hXhaqU1VKqp6Ey0LvqnyTNJmDWK\n\t3FOBgXHpE6ZxhR0EEeSFlus+6e1QQLJcSRhaeolM="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"wOZTTPcQ\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 6 Feb 2023 19:03:54 +0200","Message-Id":"<20230206170356.20340-3-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.39.1","In-Reply-To":"<20230206170356.20340-1-laurent.pinchart@ideasonboard.com>","References":"<20230206170356.20340-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v1 2/4] libcamera: camera_sensor: Fix typo\n\tin comment","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Fix a typo introduced in a comment when refactoring transformation\nhandling in the CameraSensor class.\n\nFixes: 1a614866a29c (\"libcamera: camera_sensor: Validate Transform\")\nSigned-off-by: Laurent Pinchart \n---\n src/libcamera/camera_sensor.cpp | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\nindex 11117502d817..274ed419ddfd 100644\n--- a/src/libcamera/camera_sensor.cpp\n+++ b/src/libcamera/camera_sensor.cpp\n@@ -1023,8 +1023,8 @@ Transform CameraSensor::validateTransform(Transform *transform) const\n \n \t/*\n \t * We combine the platform and user transform, but must \"adjust away\"\n-\t * any combined result that includes a transform, as we can't do those.\n-\t * In this case, flipping only the transpose bit is helpful to\n+\t * any combined result that includes a transposition, as we can't do\n+\t * those. In this case, flipping only the transpose bit is helpful to\n \t * applications - they either get the transform they requested, or have\n \t * to do a simple transpose themselves (they don't have to worry about\n \t * the other possible cases).\n","prefixes":["libcamera-devel","v1","2/4"]}