[{"id":26426,"web_url":"https://patchwork.libcamera.org/comment/26426/","msgid":"<1da34415-b7eb-4577-9d59-288a15b84c44@ideasonboard.com>","date":"2023-02-08T10:25:26","subject":"Re: [libcamera-devel] [PATCH v1 1/4] libcamera: camera_sensor:\n\tDemote flip support message to Debug","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Laurent,\n\nThank you for the patch\n\nOn 2/6/23 10:33 PM, Laurent Pinchart via libcamera-devel wrote:\n> The CameraSensor::validateSensorDriver() function prints a Warning\n> message when the camera sensor doesn't support flips. We don't mandate\n> flip support and can run without it without any problem, so a warning is\n> too harsh. Demote it to a Debug message.\n>\n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Umang Jain \n\n> ---\n> src/libcamera/camera_sensor.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\n> index b772337eb44a..11117502d817 100644\n> --- a/src/libcamera/camera_sensor.cpp\n> +++ b/src/libcamera/camera_sensor.cpp\n> @@ -261,7 +261,7 @@ int CameraSensor::validateSensorDriver()\n> \t\tsupportFlips_ = true;\n> \n> \tif (!supportFlips_)\n> -\t\tLOG(CameraSensor, Warning)\n> +\t\tLOG(CameraSensor, Debug)\n> \t\t\t<< \"Camera sensor does not support horizontal/vertical flip\";\n> \n> \t/*","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 68F42BDB1C\n\tfor ;\n\tWed, 8 Feb 2023 10:25:34 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C49E9625F4;\n\tWed, 8 Feb 2023 11:25:33 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B7F31625DD\n\tfor ;\n\tWed, 8 Feb 2023 11:25:32 +0100 (CET)","from [IPV6:2401:4900:1f3e:54db:f072:a64a:6d2e:66a9] (unknown\n\t[IPv6:2401:4900:1f3e:54db:f072:a64a:6d2e:66a9])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 96AE9496;\n\tWed, 8 Feb 2023 11:25:31 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1675851933;\n\tbh=jc0/4hYSSeCOLMflW9mtehJwro7LQVjSmx06eBEaZJ0=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=pmMBZBQWbck0+DLkPj3kXL7RpCQJ2tmjkWNQ+AiQJkyLga30rUhf0Fc5awM5ZklYK\n\twMMhYo9AjzapWi4acFRArugb12YQKiqfIU+m/UMhb4I2G0kQg2Gji4P4OF0GoIY1C4\n\tW0y6U71B5p/Y8U9lfPQmXFjD3lGXpW1jna5jWKpfCgY0E2HhqATHNRuD9q/7UMFNKY\n\tvh9c9H7BRsOrVaAsW5hxthOy2sGa2tczc3071iL8aIrO6inYpr5V7I6IrHFZxovPzL\n\tTLVyyVwbxNCV9ZHAxdgnpNy2hF/+MZ/t5OGO7OcqmtzSKK/QA/2r1sCyGz1guTjzo0\n\ttk/E0ZofIiE6w==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1675851932;\n\tbh=jc0/4hYSSeCOLMflW9mtehJwro7LQVjSmx06eBEaZJ0=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=dXaUiXju1kCaNi23OPlzL7q2XbyjoWBplffiagRa9IkNDsRkiLXcKZ7HAPRJB3MQ/\n\tUC48q8rhTU/qiBUmMLYEoZV2gAHGKPuo58XdRbxM0Px8tnrxQPQN3J03awpVIOH2aU\n\t1LqNT7ezbHbDPc9KMYwdlXwOmaImHz1avEcC05gc="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"dXaUiXju\"; dkim-atps=neutral","Message-ID":"<1da34415-b7eb-4577-9d59-288a15b84c44@ideasonboard.com>","Date":"Wed, 8 Feb 2023 15:55:26 +0530","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101\n\tThunderbird/102.6.0","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20230206170356.20340-1-laurent.pinchart@ideasonboard.com>\n\t<20230206170356.20340-2-laurent.pinchart@ideasonboard.com>","Content-Language":"en-US","In-Reply-To":"<20230206170356.20340-2-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH v1 1/4] libcamera: camera_sensor:\n\tDemote flip support message to Debug","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Umang Jain via libcamera-devel ","Reply-To":"Umang Jain ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]