{"id":18241,"url":"https://patchwork.libcamera.org/api/patches/18241/?format=json","web_url":"https://patchwork.libcamera.org/patch/18241/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20230203091734.22803-3-naush@raspberrypi.com>","date":"2023-02-03T09:17:31","name":"[libcamera-devel,v4,2/5] ipa: raspberrypi: histogram: Add a constructor for an empty histogram","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"27b12163633a8456e8ccb38ccf6f0a9c93f77d4f","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/?format=json","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/18241/mbox/","series":[{"id":3738,"url":"https://patchwork.libcamera.org/api/series/3738/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3738","date":"2023-02-03T09:17:29","name":"Raspberry Pi: Generalise statistics","version":4,"mbox":"https://patchwork.libcamera.org/series/3738/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/18241/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/18241/checks/","tags":{},"headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0790CC3243\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri,  3 Feb 2023 09:17:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9178761EF6;\n\tFri,  3 Feb 2023 10:17:42 +0100 (CET)","from mail-wm1-x335.google.com (mail-wm1-x335.google.com\n\t[IPv6:2a00:1450:4864:20::335])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F0DEC61EF4\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri,  3 Feb 2023 10:17:40 +0100 (CET)","by mail-wm1-x335.google.com with SMTP id\n\tj32-20020a05600c1c2000b003dc4fd6e61dso5530911wms.5\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 03 Feb 2023 01:17:40 -0800 (PST)","from localhost.localdomain ([93.93.133.154])\n\tby smtp.gmail.com with ESMTPSA id\n\taz24-20020a05600c601800b003dc4baaedd3sm7468864wmb.37.2023.02.03.01.17.39\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 03 Feb 2023 01:17:40 -0800 (PST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1675415862;\n\tbh=0DLpjcoVBgrz4VpzM1CoahUQ97CgrbpdDHhpaKpgEIo=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=0WXWLu1ZTyJmCPsYtTrRYvLgnnxe/R8vF8xN/3S6X8Or5tFXeEY3hh5HT500m5iXr\n\t2OWmE058R908ytEAsln2mF4j9//N0APOteWKx/QNQLoa5gdISaTzPYWzvnn7Ve8Bet\n\tU9lHM/qmOftu0vPHsLnnbMT2I8/h85jmYeyxFvu5TPL5jHj0BcPzPYhEo/IcOtgTBf\n\ty4aRhZYm0lAnTRQuLRZIS1jA2Etio1WwoSG9pKCcnakch4p5Fjsbas95WZ1FuevZDw\n\tWt7uznn6ZNnxzuVhInvZ3IMznFbbRU7obt50a9awoB/xPKd0mFbWTU5wW4B5I42inx\n\t4aQsNnZLBsvbA==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=M1N5dqqm7dMXcCpzYGXNUD+d9WKJ+Ysufg73/hJ/cJs=;\n\tb=UL8sAqR94giJaFAFKTHFHceEETvplOPHu+QgmikGblD1t5ANphXd/88HhTn711mNzK\n\tYxApBqd9mdH3QbdByDnCqazRJ0oSR9kHxyxY68BW7cukjxQ3zkR6uXQ3E0KDIIHW0+y+\n\tnxgi56LymLReP832Oyzj3GpL5bRuTVBBtnoFTxYFxubRrrmsUXyQzSSN8Ay6fD6bzQGq\n\tDBFzPuT+pmkEmQKFNELBbF+A0i/GCMeXIKfEbSS8Pbig6yrD3AtCOGZYjCjz9V5QGJag\n\tDK7UUrfnESXNbjyk8G0aE8MwS+ygL44hW74LrcTJF7GcYZk1j22sl7v6li6GZtQ+KS3T\n\tYufg=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"UL8sAqR9\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=M1N5dqqm7dMXcCpzYGXNUD+d9WKJ+Ysufg73/hJ/cJs=;\n\tb=6V9o6MPul3qcDvoy3fIs9t1uLI/lKKO16ttcYi8IoWY8qqqzLm6NckYFOLlCNryHcn\n\t5ZnCxe090b5D23HFlUIKP72PNWWfjQy1p5V1lFxRauTWYWK0HcPWY3T7LuQbDnkxeotF\n\tfBkWTQMH+ZF+lKfMEjdQEdifW4QgYnK/6FiAJkWHHiiJZiasuIUMb16aQWv5dc5vHWRT\n\t+SK2xw7/mkvMsyDwP2ShE2/V5UcxrFCPBwmTwSGiQ3rzmTCcdTZ2/Zpy4CnmCepPkNku\n\t4hCcDoOJMTbBQgTIkmB06YnR3mr43fHZF4mv/r+b1OXuJyk+sjEc7I+IUATdlVFqTld6\n\tddDw==","X-Gm-Message-State":"AO0yUKVR3WhFKqkTv3cd0h7O5aKlJgvZ7IYuk6zLppMC4aYM7l9TmABW\n\taUkHZjgzJIliswj3uzoz6CR1ULduCOrWJLqEjqQETg==","X-Google-Smtp-Source":"AK7set8kMGpy2oAV7CvbK2EOUukctTpU6yUdIVLhYMm6xVr5Z4YlJZlIaQ38ro42qLf/U6PTMSZL7w==","X-Received":"by 2002:a05:600c:4f93:b0:3dc:59c3:9020 with SMTP id\n\tn19-20020a05600c4f9300b003dc59c39020mr9191331wmq.8.1675415860509; \n\tFri, 03 Feb 2023 01:17:40 -0800 (PST)","To":"libcamera-devel@lists.libcamera.org","Date":"Fri,  3 Feb 2023 09:17:31 +0000","Message-Id":"<20230203091734.22803-3-naush@raspberrypi.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20230203091734.22803-1-naush@raspberrypi.com>","References":"<20230203091734.22803-1-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v4 2/5] ipa: raspberrypi: histogram: Add a\n\tconstructor for an empty histogram","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Naushir Patuck via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>","Reply-To":"Naushir Patuck <naush@raspberrypi.com>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"Add a default constructor to the RPiController::Histogram class that creates\nan empty histogram. Since this is a cumulative histogram, push a value of 0 into\nthe first (and only) bin to signify this.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\nReviewed-by: David Plowman <david.plowman@raspberrypi.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/ipa/raspberrypi/controller/histogram.h | 5 +++++\n 1 file changed, 5 insertions(+)","diff":"diff --git a/src/ipa/raspberrypi/controller/histogram.h b/src/ipa/raspberrypi/controller/histogram.h\nindex 66a68b087964..6b3e3a9e68e4 100644\n--- a/src/ipa/raspberrypi/controller/histogram.h\n+++ b/src/ipa/raspberrypi/controller/histogram.h\n@@ -20,6 +20,11 @@ namespace RPiController {\n class Histogram\n {\n public:\n+\tHistogram()\n+\t{\n+\t\tcumulative_.push_back(0);\n+\t}\n+\n \ttemplate<typename T> Histogram(T *histogram, int num)\n \t{\n \t\tassert(num);\n","prefixes":["libcamera-devel","v4","2/5"]}