[{"id":26413,"web_url":"https://patchwork.libcamera.org/comment/26413/","msgid":"","date":"2023-02-06T18:40:10","subject":"Re: [libcamera-devel] [PATCH] meson: libcamera: Report IPA\n\tsignature method","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Mon, Jan 30, 2023 at 10:54:35PM +0000, Kieran Bingham via libcamera-devel wrote:\n> Use the Configuration section to report which dependency is used to\n> handle IPA module signatures.\n> \n> In the event that it is not found, report directly in the configuration\n> that modules are Isolated.\n> \n> Signed-off-by: Kieran Bingham \n> ---\n> src/libcamera/meson.build | 3 +++\n> 1 file changed, 3 insertions(+)\n> \n> diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\n> index 9869bfe77c78..dbf7f016e1b4 100644\n> --- a/src/libcamera/meson.build\n> +++ b/src/libcamera/meson.build\n> @@ -90,6 +90,9 @@ endif\n> \n> if not libcrypto.found()\n> warning('Neither gnutls nor libcrypto found, all IPA modules will be isolated')\n> + summary({'IPA Signatures': 'Isolated'}, section: 'Configuration')\n\ns/Signatures/signatures/ to match the other summary entries.\n\n> +else\n> + summary({'IPA Signatures': libcrypto.name()}, section: 'Configuration')\n\nSame here.\n\n> endif\n\nClearly nitpicking, \"IPA Signatures: Isolated\" sounds a bit weird. How\nabout\n\n summary({'IPA modules signed with': 'None (modules will run isolated)'}, section: 'Configuration')\nelse\n summary({'IPA modules signed with': libcrypto.name()}, section: 'Configuration')\nendif\n\nFeel free to adjust or keep your original version.\n\nReviewed-by: Laurent Pinchart \n\n> \n> if liblttng.found()","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1FA45BEFBE\n\tfor ;\n\tMon, 6 Feb 2023 18:40:15 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 84BB961EF4;\n\tMon, 6 Feb 2023 19:40:14 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 40ACF603B8\n\tfor ;\n\tMon, 6 Feb 2023 19:40:13 +0100 (CET)","from pendragon.ideasonboard.com (unknown [109.136.43.56])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 97A6688E;\n\tMon, 6 Feb 2023 19:40:12 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1675708814;\n\tbh=g78WU/ZJUw1vkAxen2B0zwnhJSd3hZzJ7Bhu3ueJ/Cg=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=1ZHVciIjVwcMkpiq5VOnspSLWjQXPEtrq2s/2yUIjL9UllX/FUqBdR3lXO/Th2chn\n\t5ps6TBKTa9QPmSeW1CXAWPJjLW6A+knXGI0WNCcS4NmPFH/nKt9+FvIskTbpfzQ390\n\tttI2dnTIEyW0/e6pkam64jeTjI1r7kSwb3Pr7oJLaTtzv/GDMHe17JOgqNcS2vOv7N\n\tD+q+xDZwSDmpycOBwL0KyimlChuRMhiVXOgrbhj1f76cpUaV9/tqwOTMo9x3ssdLEg\n\tS6SWYjAgvpWODra7GfNvXjCw2DJ07bQ6+KThItFcSsMx/Q46GN1DeB/aQAiSLMxDZN\n\tJfrJINXrTd8cg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1675708812;\n\tbh=g78WU/ZJUw1vkAxen2B0zwnhJSd3hZzJ7Bhu3ueJ/Cg=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=QFdlJuh3TfgK7qDZEw0qK72zYNJn5Fps+GoZCSFBzI1i+b3ywKdk9x+OoAZOCXvtv\n\tjHmDNav4OOk9r573t8e81+WO5aWiYVW13gBeHf4g8RiR4/BUmXqQ+FRakQBaERduRd\n\tI4kd/jR/zZOC/nqmOrdkX5AzW7/V5Q2ei1gpDOBA="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"QFdlJuh3\"; dkim-atps=neutral","Date":"Mon, 6 Feb 2023 20:40:10 +0200","To":"Kieran Bingham ","Message-ID":"","References":"<20230130225435.2318236-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20230130225435.2318236-1-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] meson: libcamera: Report IPA\n\tsignature method","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":26424,"web_url":"https://patchwork.libcamera.org/comment/26424/","msgid":"","date":"2023-02-07T20:15:13","subject":"Re: [libcamera-devel] [PATCH] meson: libcamera: Report IPA\n\tsignature method","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi,\n\nOn 2/7/23 12:10 AM, Laurent Pinchart via libcamera-devel wrote:\n> Hi Kieran,\n>\n> Thank you for the patch.\n>\n> On Mon, Jan 30, 2023 at 10:54:35PM +0000, Kieran Bingham via libcamera-devel wrote:\n>> Use the Configuration section to report which dependency is used to\n>> handle IPA module signatures.\n>>\n>> In the event that it is not found, report directly in the configuration\n>> that modules are Isolated.\n>>\n>> Signed-off-by: Kieran Bingham \n>> ---\n>> src/libcamera/meson.build | 3 +++\n>> 1 file changed, 3 insertions(+)\n>>\n>> diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\n>> index 9869bfe77c78..dbf7f016e1b4 100644\n>> --- a/src/libcamera/meson.build\n>> +++ b/src/libcamera/meson.build\n>> @@ -90,6 +90,9 @@ endif\n>> \n>> if not libcrypto.found()\n>> warning('Neither gnutls nor libcrypto found, all IPA modules will be isolated')\n>> + summary({'IPA Signatures': 'Isolated'}, section: 'Configuration')\n> s/Signatures/signatures/ to match the other summary entries.\n>\n>> +else\n>> + summary({'IPA Signatures': libcrypto.name()}, section: 'Configuration')\n> Same here.\n>\n>> endif\n> Clearly nitpicking, \"IPA Signatures: Isolated\" sounds a bit weird. How\n> about\n>\n> summary({'IPA modules signed with': 'None (modules will run isolated)'}, section: 'Configuration')\n\nOne related term is 'sandbox' so few suggestions below:\n\n summary({'IPA modules signed with': 'None (modules will run in sandbox)'}, section: 'Configuration')\n summary({'IPA modules signed with': 'None (modules will be sandboxed)'}, section: 'Configuration')\n\n\n> else\n> summary({'IPA modules signed with': libcrypto.name()}, section: 'Configuration')\n> endif\n>\n> Feel free to adjust or keep your original version.\n>\n> Reviewed-by: Laurent Pinchart \n\nReviewed-by: Umang Jain \n\n>\n>> \n>> if liblttng.found()","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F0D3EBDB1C\n\tfor ;\n\tTue, 7 Feb 2023 20:15:20 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 24758625F4;\n\tTue, 7 Feb 2023 21:15:20 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CDBFD625DF\n\tfor ;\n\tTue, 7 Feb 2023 21:15:18 +0100 (CET)","from [IPV6:2401:4900:1c80:1679:28dc:3e17:d92c:a044] (unknown\n\t[IPv6:2401:4900:1c80:1679:28dc:3e17:d92c:a044])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8BD4D589;\n\tTue, 7 Feb 2023 21:15:17 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1675800920;\n\tbh=JWympkvPe5ZMI8ITmUWk67qz5ixyd7AWTd2+oUbQFjI=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=PGKMR5IQcUy2gAu0fmoKHZWGWv4+50jG6eGFMwzjBOjeewr/EskdQTZo+WhvJz2Ew\n\tpACgu2oWZ5vn+Fczc4Fh3tdCjGFLppNonyAcM8iFC7Hi3fpdDTUmUS8kRcZr3SmCBH\n\tUmYmdJZE9NfEieRGi29ezY56+4UkzABr3X6tN78j2e02nfVQXckX8JocTmvdtYZC5O\n\tmhZill+TrMUSptHTZPlj/RFqPh9YOQ29QStsKHw5Wn2IbyeJxiU/90XiLuxxf2ZFDk\n\tQHGuYf5wYIF0kZARSAuMq7Iv7/WTOiNgzyr2XtvDR1POFSwNqqaVLzETlacg27x7X+\n\tfhbp81W6dutzQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1675800918;\n\tbh=JWympkvPe5ZMI8ITmUWk67qz5ixyd7AWTd2+oUbQFjI=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=toOlUsxRFggnrNh4u8o8IU8rGj+hpFIOI2oEqG+RLxqbj98DB+hoTiHzkgvz2W7rU\n\tfijAK5GaQxoZbBLhzMHwEUzzQeIT5USHb4bVkbQjYZivT4p31y2gqYn7xbKzkW9jZA\n\tExvCAYOEz/AnL7THPLy1dAW9YM4yeGU085HNTtPk="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"toOlUsxR\"; dkim-atps=neutral","Message-ID":"","Date":"Wed, 8 Feb 2023 01:45:13 +0530","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101\n\tThunderbird/102.6.0","To":"Laurent Pinchart ,\n\tKieran Bingham ","References":"<20230130225435.2318236-1-kieran.bingham@ideasonboard.com>\n\t","Content-Language":"en-US","In-Reply-To":"","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH] meson: libcamera: Report IPA\n\tsignature method","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Umang Jain via libcamera-devel ","Reply-To":"Umang Jain ","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]