[{"id":26380,"web_url":"https://patchwork.libcamera.org/comment/26380/","msgid":"<167508787610.42371.8893121979446131180@Monstersaurus>","date":"2023-01-30T14:11:16","subject":"Re: [libcamera-devel] [PATCH] qcam: Decrease minimum width of\n\tselector dialog","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Luca Weiss via libcamera-devel (2023-01-28 16:24:03)\n> On phone screens the default width is too wide, so the OK button cannot\n> be clicked.\n> \n> Fix this by decreasing the minimum size of the dialog so it fits nicely.\n> \n> Signed-off-by: Luca Weiss \n> ---\n> src/apps/qcam/cam_select_dialog.cpp | 3 +++\n> 1 file changed, 3 insertions(+)\n> \n> diff --git a/src/apps/qcam/cam_select_dialog.cpp b/src/apps/qcam/cam_select_dialog.cpp\n> index 3c8b12a9..2a600383 100644\n> --- a/src/apps/qcam/cam_select_dialog.cpp\n> +++ b/src/apps/qcam/cam_select_dialog.cpp\n> @@ -25,6 +25,9 @@ CameraSelectorDialog::CameraSelectorDialog(libcamera::CameraManager *cameraManag\n> /* Use a QFormLayout for the dialog. */\n> QFormLayout *layout = new QFormLayout(this);\n> \n> + /* Decrease minimum width of dialog to fit on narrow screens */\n> + setMinimumSize(250, 100);\n> +\n\nThis looks reasonable, and when applying here - it doesn't break my\nview, but my screen is large.\n\nIs there any way to reproduce this issue otherwise? I suspect not easily\nwithout getting a small screen. But to me this is ok.\n\n\nReviewed-by: Kieran Bingham \n\n> /* Setup the camera id combo-box. */\n> cameraIdComboBox_ = new QComboBox;\n> for (const auto &cam : cm_->cameras())\n> -- \n> 2.39.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 14F7FBEFBE\n\tfor ;\n\tMon, 30 Jan 2023 14:11:21 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7204A625E4;\n\tMon, 30 Jan 2023 15:11:20 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 97D7A60482\n\tfor ;\n\tMon, 30 Jan 2023 15:11:18 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 248C58B8;\n\tMon, 30 Jan 2023 15:11:18 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1675087880;\n\tbh=M09MaDNkbO9FOp/WXd6tbW0VQ40PHoiP2HetHxMgWao=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=v9P5lByox+he86mXsAcKzIiuXvVKQXHicwKrz4LRgpw5wasmZ2bLexuXUwd1YurTI\n\tqAaQWiCE0DHjjGlpqvTiLx/hMonQmjMxU+PXFDsX4/B332BwzUlEzt0b4E15j1sCXS\n\txE64zDCBEH38kLLuwd2ftQTqbzPQXwyOolYO+e06t4sji2XeZLS8IMG4nToPahzGg4\n\tgMVsrSWYv6iEWcGYu9HCWKOmIQ+ykX7+wiiwCfOeByAQWwRevk1/aiqKX/MEE+1HEw\n\tliB0cp5OcKJiGGcSrCV7dbFGkZg2xUM7bApEaeb3SXxRhSzMBeqsOTRVqWOFaQgk1W\n\tvgUxU8yDQSnwA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1675087878;\n\tbh=M09MaDNkbO9FOp/WXd6tbW0VQ40PHoiP2HetHxMgWao=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=Rjyo8RAqVAO3KxfNQPAiXvz+bCpPdc7xwotSTrvrmeBHe8Sg5TAk9ALktJHsHXiWZ\n\tLJwGVCEH2Rpuz967XhjywKrIatpV53r8Ya63qnEOPO2bDNRvjzuuM0r7yMbzUq9dz0\n\tB9MFQ3c6sE5EVDIuvjaNDSf+0fdWu4KFhy8Ol9BA="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"Rjyo8RAq\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20230128162402.892389-1-luca@z3ntu.xyz>","References":"<20230128162402.892389-1-luca@z3ntu.xyz>","To":"Luca Weiss , libcamera-devel@lists.libcamera.org","Date":"Mon, 30 Jan 2023 14:11:16 +0000","Message-ID":"<167508787610.42371.8893121979446131180@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH] qcam: Decrease minimum width of\n\tselector dialog","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Cc":"Luca Weiss ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":26381,"web_url":"https://patchwork.libcamera.org/comment/26381/","msgid":"<3535927.R56niFO833@g550jk>","date":"2023-01-30T17:58:29","subject":"Re: [libcamera-devel] [PATCH] qcam: Decrease minimum width of\n\tselector dialog","submitter":{"id":147,"url":"https://patchwork.libcamera.org/api/people/147/","name":"Luca Weiss","email":"luca@z3ntu.xyz"},"content":"On Montag, 30. Jänner 2023 15:11:16 CET Kieran Bingham wrote:\n> Quoting Luca Weiss via libcamera-devel (2023-01-28 16:24:03)\n> \n> > On phone screens the default width is too wide, so the OK button cannot\n> > be clicked.\n> > \n> > Fix this by decreasing the minimum size of the dialog so it fits nicely.\n> > \n> > Signed-off-by: Luca Weiss \n> > ---\n> > \n> > src/apps/qcam/cam_select_dialog.cpp | 3 +++\n> > 1 file changed, 3 insertions(+)\n> > \n> > diff --git a/src/apps/qcam/cam_select_dialog.cpp\n> > b/src/apps/qcam/cam_select_dialog.cpp index 3c8b12a9..2a600383 100644\n> > --- a/src/apps/qcam/cam_select_dialog.cpp\n> > +++ b/src/apps/qcam/cam_select_dialog.cpp\n> > @@ -25,6 +25,9 @@\n> > CameraSelectorDialog::CameraSelectorDialog(libcamera::CameraManager\n> > *cameraManag> \n> > /* Use a QFormLayout for the dialog. */\n> > QFormLayout *layout = new QFormLayout(this);\n> > \n> > + /* Decrease minimum width of dialog to fit on narrow screens */\n> > + setMinimumSize(250, 100);\n> > +\n> \n> This looks reasonable, and when applying here - it doesn't break my\n> view, but my screen is large.\n> \n> Is there any way to reproduce this issue otherwise? I suspect not easily\n> without getting a small screen. But to me this is ok.\n\nNot really I think because the window manager prohibits resizing the window \nbelow the minimum size. Perhaps setting some insane scaling (if the window \nmanager allows this) so everything's just super big.\n\nFrom what I could tell the minimum size gets set as the size the combobox \ntakes up which can be quite a big with a long identification string as happens \non ARM which includes the path to the dt node.\n\nBut if you want I can also send you screenshots from the phone where I tested \nthis.\n\nRegards\nLuca\n\n> \n> \n> Reviewed-by: Kieran Bingham \n> \n> > /* Setup the camera id combo-box. */\n> > cameraIdComboBox_ = new QComboBox;\n> > for (const auto &cam : cm_->cameras())","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 67182BEFBE\n\tfor ;\n\tMon, 30 Jan 2023 17:58:34 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id ACB14625D8;\n\tMon, 30 Jan 2023 18:58:33 +0100 (CET)","from mail.z3ntu.xyz (mail.z3ntu.xyz [128.199.32.197])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1EEE760482\n\tfor ;\n\tMon, 30 Jan 2023 18:58:31 +0100 (CET)","from g550jk.localnet (unknown [62.108.10.64])\n\tby mail.z3ntu.xyz (Postfix) with ESMTPSA id 30D17CD4FB;\n\tMon, 30 Jan 2023 17:58:30 +0000 (UTC)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1675101513;\n\tbh=LIDy+QdkJMyzgBCHS2YqJi/vZ0rZRSB4dxXu8NZ6Ves=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=iajJhbU+Zs0xirPYKgx9iIKiCpogHXJNCq71OIYdbDvtuQ7bq+454frDOAs+DD7SR\n\tymJWwY+U+4Sjic9uOCJM0AcoIjplM2v8mes55pOuMqe0vrko/A12WqFuq7EP2dg7Yd\n\t7SGLIIIlsrSENiEH9cW647oXvylHI3zgNaF8kWROvw9fG45eWWiU+ApoF6ZzPC3r+K\n\t052SIOjYD7tix64g8LjFH/K5aPC14ITUo3GlFfkVlrWtV9IojlfRDnNfz7UqOrUzmx\n\tIJgQBuvdpM19CCNB5urJ/yicFvsvFgKRweqp7jMAq3nGm8XYz61QJ2pFTRrhj+ybwQ\n\t0F0yTlGXi45ug==","v=1; a=rsa-sha256; c=simple/simple; d=z3ntu.xyz; s=z3ntu;\n\tt=1675101510; bh=LIDy+QdkJMyzgBCHS2YqJi/vZ0rZRSB4dxXu8NZ6Ves=;\n\th=From:To:Subject:Date:In-Reply-To:References;\n\tb=gjaYNIz7Hz6cmLf+ftJh3BAMMQNxqzshHHkCWNVCY/mprj6tr9aZ5o/OHahtZWvAX\n\tk8BTEQBmWCoamWgHyBRQcmBb7bDQ9H9RNUOcm8ocHaxmr3ZQpv8JA7X5S5stOeZOat\n\tsB51u7niPXdiYrdfKzy0cGV0UrBPzNtRZZlYKDkk="],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=z3ntu.xyz header.i=@z3ntu.xyz\n\theader.b=\"gjaYNIz7\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org,\n\tKieran Bingham ","Date":"Mon, 30 Jan 2023 18:58:29 +0100","Message-ID":"<3535927.R56niFO833@g550jk>","In-Reply-To":"<167508787610.42371.8893121979446131180@Monstersaurus>","References":"<20230128162402.892389-1-luca@z3ntu.xyz>\n\t<167508787610.42371.8893121979446131180@Monstersaurus>","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","Content-Type":"text/plain; charset=\"iso-8859-1\"","Subject":"Re: [libcamera-devel] [PATCH] qcam: Decrease minimum width of\n\tselector dialog","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Luca Weiss via libcamera-devel ","Reply-To":"Luca Weiss ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":26547,"web_url":"https://patchwork.libcamera.org/comment/26547/","msgid":"<2669080.mvXUDI8C0e@z3ntu.xyz>","date":"2023-03-04T17:45:50","subject":"Re: [libcamera-devel] [PATCH] qcam: Decrease minimum width of\n\tselector dialog","submitter":{"id":147,"url":"https://patchwork.libcamera.org/api/people/147/","name":"Luca Weiss","email":"luca@z3ntu.xyz"},"content":"On Montag, 30. Jänner 2023 15:11:16 CET Kieran Bingham wrote:\n> Quoting Luca Weiss via libcamera-devel (2023-01-28 16:24:03)\n> \n> > On phone screens the default width is too wide, so the OK button cannot\n> > be clicked.\n> > \n> > Fix this by decreasing the minimum size of the dialog so it fits nicely.\n> > \n> > Signed-off-by: Luca Weiss \n> > ---\n> > \n> > src/apps/qcam/cam_select_dialog.cpp | 3 +++\n> > 1 file changed, 3 insertions(+)\n> > \n> > diff --git a/src/apps/qcam/cam_select_dialog.cpp\n> > b/src/apps/qcam/cam_select_dialog.cpp index 3c8b12a9..2a600383 100644\n> > --- a/src/apps/qcam/cam_select_dialog.cpp\n> > +++ b/src/apps/qcam/cam_select_dialog.cpp\n> > @@ -25,6 +25,9 @@\n> > CameraSelectorDialog::CameraSelectorDialog(libcamera::CameraManager\n> > *cameraManag> \n> > /* Use a QFormLayout for the dialog. */\n> > QFormLayout *layout = new QFormLayout(this);\n> > \n> > + /* Decrease minimum width of dialog to fit on narrow screens */\n> > + setMinimumSize(250, 100);\n> > +\n> \n> This looks reasonable, and when applying here - it doesn't break my\n> view, but my screen is large.\n> \n> Is there any way to reproduce this issue otherwise? I suspect not easily\n> without getting a small screen. But to me this is ok.\n> \n> \n> Reviewed-by: Kieran Bingham \n\nHi,\n\nanything missing from getting this patch applied?\n\nRegards\nLuca\n\n> \n> > /* Setup the camera id combo-box. */\n> > cameraIdComboBox_ = new QComboBox;\n> > for (const auto &cam : cm_->cameras())","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EB47EBE080\n\tfor ;\n\tSat, 4 Mar 2023 17:46:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 50DCA6267A;\n\tSat, 4 Mar 2023 18:46:24 +0100 (CET)","from mail.z3ntu.xyz (mail.z3ntu.xyz [128.199.32.197])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 410D162636\n\tfor ;\n\tSat, 4 Mar 2023 18:46:22 +0100 (CET)","from g550jk.localnet (unknown [62.108.10.64])\n\tby mail.z3ntu.xyz (Postfix) with ESMTPSA id 91B03D2440;\n\tSat, 4 Mar 2023 17:45:51 +0000 (UTC)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1677951984;\n\tbh=OeNg+jwuN+j6Rq6kLcnIVhAUxv2VurMY9LJwuUUxZGM=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=axBBBL9ZcIOSVRyjM/Mcek2+PXdBnKqD0j2oDBBmGb8I9FVUacc3jCGSpoMSvYaVD\n\toNomp8SFtNmNakR2VySl3MYliQtlnFQcx7WntsXfl2myVAJaq4H2G2KyE4z14y7Pfh\n\tVhlfQdxDaZ/ISzy6IDkj1xXsnWRugGSkyga2wUqUrXwl9zNTFiq34f87fPrlHKfOCp\n\tw06b85thyTAAKIU2xpPFH4LVTUOjhO7D6yUTmwEBv/2QmWFzVgeMExKj/3sJnrA3mq\n\tWfAejdp+PQtcb2JyBZ0f8K+CAgRBOmQRG5+5Cb2NQ99+PdbX/niPV5nglqgHJlrKeT\n\tbnM/2ln3R4ECQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=z3ntu.xyz; s=z3ntu;\n\tt=1677951951; bh=OeNg+jwuN+j6Rq6kLcnIVhAUxv2VurMY9LJwuUUxZGM=;\n\th=From:To:Subject:Date:In-Reply-To:References;\n\tb=FgkUBOB+w35FJzIYS8aomvu+L55G1kNFfOP93UKBS0DsEBeoLInvocJqjiW6miZ2n\n\tY+2rruvKu595XgWTN3rA3cF8OwpKAf5v8y5l1TBqcSpSHNpvaUUfdvEiNvpzyW6DKN\n\tXUYvg5VcUNF+o+Nh3aSTLyoXpWrTjXvVfo+u2d4A="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=z3ntu.xyz header.i=@z3ntu.xyz\n\theader.b=\"FgkUBOB+\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org,\n\tKieran Bingham ","Date":"Sat, 04 Mar 2023 18:45:50 +0100","Message-ID":"<2669080.mvXUDI8C0e@z3ntu.xyz>","In-Reply-To":"<167508787610.42371.8893121979446131180@Monstersaurus>","References":"<20230128162402.892389-1-luca@z3ntu.xyz>\n\t<167508787610.42371.8893121979446131180@Monstersaurus>","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","Content-Type":"text/plain; charset=\"iso-8859-1\"","Subject":"Re: [libcamera-devel] [PATCH] qcam: Decrease minimum width of\n\tselector dialog","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Luca Weiss via libcamera-devel ","Reply-To":"Luca Weiss ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":26554,"web_url":"https://patchwork.libcamera.org/comment/26554/","msgid":"<20230306075750.ghdciiz4uqvnak76@uno.localdomain>","date":"2023-03-06T07:57:50","subject":"Re: [libcamera-devel] [PATCH] qcam: Decrease minimum width of\n\tselector dialog","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Luca,\n\nOn Sat, Mar 04, 2023 at 06:45:50PM +0100, Luca Weiss via libcamera-devel wrote:\n> On Montag, 30. Jänner 2023 15:11:16 CET Kieran Bingham wrote:\n> > Quoting Luca Weiss via libcamera-devel (2023-01-28 16:24:03)\n> >\n> > > On phone screens the default width is too wide, so the OK button cannot\n> > > be clicked.\n> > >\n> > > Fix this by decreasing the minimum size of the dialog so it fits nicely.\n> > >\n> > > Signed-off-by: Luca Weiss \n> > > ---\n> > >\n> > > src/apps/qcam/cam_select_dialog.cpp | 3 +++\n> > > 1 file changed, 3 insertions(+)\n> > >\n> > > diff --git a/src/apps/qcam/cam_select_dialog.cpp\n> > > b/src/apps/qcam/cam_select_dialog.cpp index 3c8b12a9..2a600383 100644\n> > > --- a/src/apps/qcam/cam_select_dialog.cpp\n> > > +++ b/src/apps/qcam/cam_select_dialog.cpp\n> > > @@ -25,6 +25,9 @@\n> > > CameraSelectorDialog::CameraSelectorDialog(libcamera::CameraManager\n> > > *cameraManag>\n> > > /* Use a QFormLayout for the dialog. */\n> > > QFormLayout *layout = new QFormLayout(this);\n> > >\n> > > + /* Decrease minimum width of dialog to fit on narrow screens */\n> > > + setMinimumSize(250, 100);\n> > > +\n> >\n> > This looks reasonable, and when applying here - it doesn't break my\n> > view, but my screen is large.\n> >\n> > Is there any way to reproduce this issue otherwise? I suspect not easily\n> > without getting a small screen. But to me this is ok.\n> >\n> >\n> > Reviewed-by: Kieran Bingham \n>\n> Hi,\n>\n> anything missing from getting this patch applied?\n\nYes, one more review tag, sorry for being late.\n\nI can't say I really understand the implications on bigger screens, but it\nseems legit to me\n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n\n>\n> Regards\n> Luca\n>\n> >\n> > > /* Setup the camera id combo-box. */\n> > > cameraIdComboBox_ = new QComboBox;\n> > > for (const auto &cam : cm_->cameras())\n>\n>\n>\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 97C18BE080\n\tfor ;\n\tMon, 6 Mar 2023 07:57:57 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D5B4062666;\n\tMon, 6 Mar 2023 08:57:56 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F38E461EDA\n\tfor ;\n\tMon, 6 Mar 2023 08:57:54 +0100 (CET)","from ideasonboard.com (host-79-47-54-87.retail.telecomitalia.it\n\t[79.47.54.87])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 52FB6308;\n\tMon, 6 Mar 2023 08:57:54 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1678089476;\n\tbh=c89y5nLP0iTO4/LzUiFDqzj98VOF0AZ+qJL2bjwd848=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=uqssmqKYe1brh6tLVgy6wp+FHLbJRQcKNzgMtBVcjIzcbIUhNi08u+fzrnMbjm6rm\n\twSzpijsQsZ169WN1No6Fit/htVVJCN0vZUljli8oFywZnP1AyBSp2nvum5SfYyREOs\n\tMP7iIcLP80LqKuy4HTzOvx0Njxhp35dT4QrPDmSfcmdQLjNyhSSd70K7pp6SDA5+t4\n\tBd4aLzEaoaVf4J0HnlG6PkUSWyZc4IHlAScimS3BSynhjm+8XSywIHkB5lveiPXraB\n\t3BR8Ja1flo9b50r3D/B7FvsINc7YIgMGcjB+X9XP3CexJb8eNZBT0Yym3pPe+cIRun\n\tnCjmwfpcmCAow==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1678089474;\n\tbh=c89y5nLP0iTO4/LzUiFDqzj98VOF0AZ+qJL2bjwd848=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=dUZkIl49+SrcYCFnbC0mp1rMKtAwwZZ//o4H3D6VTA/0t2+t1YOii9TNEEJYkqfgh\n\thHujDd3HfHvZEAJlQrUp5fx6yIupUfYf5Xbhn/jUcskVQffX/SzZ6qaro8ZIDxkRVo\n\t8ch0Aj1368ka3evbRdWP89k78k1nJX35/qj0yFRA="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"dUZkIl49\"; dkim-atps=neutral","Date":"Mon, 6 Mar 2023 08:57:50 +0100","To":"Luca Weiss ","Message-ID":"<20230306075750.ghdciiz4uqvnak76@uno.localdomain>","References":"<20230128162402.892389-1-luca@z3ntu.xyz>\n\t<167508787610.42371.8893121979446131180@Monstersaurus>\n\t<2669080.mvXUDI8C0e@z3ntu.xyz>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<2669080.mvXUDI8C0e@z3ntu.xyz>","Subject":"Re: [libcamera-devel] [PATCH] qcam: Decrease minimum width of\n\tselector dialog","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":26555,"web_url":"https://patchwork.libcamera.org/comment/26555/","msgid":"<20230306100747.GB20909@pendragon.ideasonboard.com>","date":"2023-03-06T10:07:47","subject":"Re: [libcamera-devel] [PATCH] qcam: Decrease minimum width of\n\tselector dialog","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Mon, Jan 30, 2023 at 06:58:29PM +0100, Luca Weiss via libcamera-devel wrote:\n> On Montag, 30. Jänner 2023 15:11:16 CET Kieran Bingham wrote:\n> > Quoting Luca Weiss via libcamera-devel (2023-01-28 16:24:03)\n> > \n> > > On phone screens the default width is too wide, so the OK button cannot\n> > > be clicked.\n> > > \n> > > Fix this by decreasing the minimum size of the dialog so it fits nicely.\n> > > \n> > > Signed-off-by: Luca Weiss \n> > > ---\n> > > \n> > > src/apps/qcam/cam_select_dialog.cpp | 3 +++\n> > > 1 file changed, 3 insertions(+)\n> > > \n> > > diff --git a/src/apps/qcam/cam_select_dialog.cpp\n> > > b/src/apps/qcam/cam_select_dialog.cpp index 3c8b12a9..2a600383 100644\n> > > --- a/src/apps/qcam/cam_select_dialog.cpp\n> > > +++ b/src/apps/qcam/cam_select_dialog.cpp\n> > > @@ -25,6 +25,9 @@\n> > > CameraSelectorDialog::CameraSelectorDialog(libcamera::CameraManager\n> > > *cameraManag> \n> > > /* Use a QFormLayout for the dialog. */\n> > > QFormLayout *layout = new QFormLayout(this);\n> > > \n> > > + /* Decrease minimum width of dialog to fit on narrow screens */\n> > > + setMinimumSize(250, 100);\n> > > +\n> > \n> > This looks reasonable, and when applying here - it doesn't break my\n> > view, but my screen is large.\n> > \n> > Is there any way to reproduce this issue otherwise? I suspect not easily\n> > without getting a small screen. But to me this is ok.\n> \n> Not really I think because the window manager prohibits resizing the window \n> below the minimum size. Perhaps setting some insane scaling (if the window \n> manager allows this) so everything's just super big.\n> \n> From what I could tell the minimum size gets set as the size the combobox \n> takes up which can be quite a big with a long identification string as happens \n> on ARM which includes the path to the dt node.\n\nBy default the minimum size will be set by the dialog box's QLayout,\nwhich indeed should size it based on the largest element. We could\nreduce the minimum size of the combo box, but I don't think that's\nbetter than changing the dialog's minimum size.\n\nDo we need to reduce both the minimum width and height, or could we\navoid touching the height ? Also, would it make sense to only lower the\nminimum size on small screens ? You can get the desktop's geometry from\nthe QDesktopWidget class (accessible from QApplication::desktop()), see\n[1]. We could then compare it with the layout's minimum size, and only\nset a manual minimum size when the desktop's geometry is small.\n\n[1] https://doc.qt.io/qt-5/qdesktopwidget.html#availableGeometry\n\n> But if you want I can also send you screenshots from the phone where I tested \n> this.\n\nA screenshot that demonstrates the problem would be nice.\n\n> > Reviewed-by: Kieran Bingham \n> > \n> > > /* Setup the camera id combo-box. */\n> > > cameraIdComboBox_ = new QComboBox;\n> > > for (const auto &cam : cm_->cameras())","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 65242BDE17\n\tfor ;\n\tMon, 6 Mar 2023 10:07:46 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A80CA62673;\n\tMon, 6 Mar 2023 11:07:45 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CE45A62665\n\tfor ;\n\tMon, 6 Mar 2023 11:07:43 +0100 (CET)","from pendragon.ideasonboard.com\n\t(153.162-64-87.adsl-dyn.isp.belgacom.be [87.64.162.153])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 40083EF;\n\tMon, 6 Mar 2023 11:07:43 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1678097265;\n\tbh=qZJpafMGZRsBUM6gRVaaY7Yz22TsoKpRr2RT283EEo4=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=YaoDELKoslF2tO9nojwDnNpBAhJZX4EHeXvpXgqYb8S2QXRtZp7uzlAMtLmNQaSBX\n\tPfAIv6aMrQpOio7kMwAARfM7OLZICE56ps0WumTx4yYh6siNu+1pQV7nE9ZdMlN4BI\n\tiDCYPTgqjLcA92DKKo67+485D+OA4kfrCtSW56PVsOEHGVpp5pq2Lvo7tyoPExblz2\n\t24gocrBeNlZgqWwQ1qlG6tuSTbfdzQhzBa2ivxMPGkLxfTcMBHKNV7PVZvyqz0KB4Z\n\t05yPUTW7+3kBKjtYTUMccdMJYF6alNvhuPkPnu6RhmBSpZNJbZ9wwTvvlaMGbKEKtX\n\tRX0UNRPr4zMIA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1678097263;\n\tbh=qZJpafMGZRsBUM6gRVaaY7Yz22TsoKpRr2RT283EEo4=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=l7x0AHka88JcC5G+5HHrwOQnsCb+XeW+QhIBD46BScT+Ph0cqk53NI09SxSVEayJL\n\tqNgzpYjem4wbQclSfjWbeVMwc4zQG/qxuUISdHbOVYZ0YfJ4TbLjzNnS7tEx1bG2mi\n\tCi1Au/ejk+zCfgzVznnYya+PnyDwUT1FzrIr5sLQ="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"l7x0AHka\"; dkim-atps=neutral","Date":"Mon, 6 Mar 2023 12:07:47 +0200","To":"Luca Weiss ","Message-ID":"<20230306100747.GB20909@pendragon.ideasonboard.com>","References":"<20230128162402.892389-1-luca@z3ntu.xyz>\n\t<167508787610.42371.8893121979446131180@Monstersaurus>\n\t<3535927.R56niFO833@g550jk>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<3535927.R56niFO833@g550jk>","Subject":"Re: [libcamera-devel] [PATCH] qcam: Decrease minimum width of\n\tselector dialog","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":26556,"web_url":"https://patchwork.libcamera.org/comment/26556/","msgid":"<20230306102029.GC20909@pendragon.ideasonboard.com>","date":"2023-03-06T10:20:29","subject":"Re: [libcamera-devel] [PATCH] qcam: Decrease minimum width of\n\tselector dialog","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Mon, Mar 06, 2023 at 12:07:47PM +0200, Laurent Pinchart via libcamera-devel wrote:\n> On Mon, Jan 30, 2023 at 06:58:29PM +0100, Luca Weiss via libcamera-devel wrote:\n> > On Montag, 30. Jänner 2023 15:11:16 CET Kieran Bingham wrote:\n> > > Quoting Luca Weiss via libcamera-devel (2023-01-28 16:24:03)\n> > > \n> > > > On phone screens the default width is too wide, so the OK button cannot\n> > > > be clicked.\n> > > > \n> > > > Fix this by decreasing the minimum size of the dialog so it fits nicely.\n> > > > \n> > > > Signed-off-by: Luca Weiss \n> > > > ---\n> > > > \n> > > > src/apps/qcam/cam_select_dialog.cpp | 3 +++\n> > > > 1 file changed, 3 insertions(+)\n> > > > \n> > > > diff --git a/src/apps/qcam/cam_select_dialog.cpp\n> > > > b/src/apps/qcam/cam_select_dialog.cpp index 3c8b12a9..2a600383 100644\n> > > > --- a/src/apps/qcam/cam_select_dialog.cpp\n> > > > +++ b/src/apps/qcam/cam_select_dialog.cpp\n> > > > @@ -25,6 +25,9 @@\n> > > > CameraSelectorDialog::CameraSelectorDialog(libcamera::CameraManager\n> > > > *cameraManag> \n> > > > /* Use a QFormLayout for the dialog. */\n> > > > QFormLayout *layout = new QFormLayout(this);\n> > > > \n> > > > + /* Decrease minimum width of dialog to fit on narrow screens */\n> > > > + setMinimumSize(250, 100);\n> > > > +\n> > > \n> > > This looks reasonable, and when applying here - it doesn't break my\n> > > view, but my screen is large.\n> > > \n> > > Is there any way to reproduce this issue otherwise? I suspect not easily\n> > > without getting a small screen. But to me this is ok.\n> > \n> > Not really I think because the window manager prohibits resizing the window \n> > below the minimum size. Perhaps setting some insane scaling (if the window \n> > manager allows this) so everything's just super big.\n> > \n> > From what I could tell the minimum size gets set as the size the combobox \n> > takes up which can be quite a big with a long identification string as happens \n> > on ARM which includes the path to the dt node.\n> \n> By default the minimum size will be set by the dialog box's QLayout,\n> which indeed should size it based on the largest element. We could\n> reduce the minimum size of the combo box, but I don't think that's\n> better than changing the dialog's minimum size.\n> \n> Do we need to reduce both the minimum width and height, or could we\n> avoid touching the height ? Also, would it make sense to only lower the\n> minimum size on small screens ? You can get the desktop's geometry from\n> the QDesktopWidget class (accessible from QApplication::desktop()), see\n> [1]. We could then compare it with the layout's minimum size, and only\n> set a manual minimum size when the desktop's geometry is small.\n\nQApplication::desktop() seems deprecated, and replaced with\nprimaryScreen(). The following code is what I have in mind.\n\ndiff --git a/src/apps/qcam/cam_select_dialog.cpp b/src/apps/qcam/cam_select_dialog.cpp\nindex 3c8b12a9c174..750e5f5df682 100644\n--- a/src/apps/qcam/cam_select_dialog.cpp\n+++ b/src/apps/qcam/cam_select_dialog.cpp\n@@ -15,7 +15,9 @@\n #include \n #include \n #include \n+#include \n #include \n+#include \n #include \n\n CameraSelectorDialog::CameraSelectorDialog(libcamera::CameraManager *cameraManager,\n@@ -53,6 +55,14 @@ CameraSelectorDialog::CameraSelectorDialog(libcamera::CameraManager *cameraManag\n \tlayout->addRow(\"Location:\", cameraLocation_);\n \tlayout->addRow(\"Model:\", cameraModel_);\n \tlayout->addWidget(buttonBox);\n+\n+\t/*\n+\t * Decrease the minimum width of dialog to fit on narrow screens, with a\n+\t * 20 pixels margin.\n+\t */\n+\tQRect screenGeometry = qGuiApp->primaryScreen()->availableGeometry();\n+\tif (screenGeometry.width() < minimumWidth())\n+\t\tsetMinimumWidth(screenGeometry.width() - 20);\n }\n\n CameraSelectorDialog::~CameraSelectorDialog() = default;\n\n> [1] https://doc.qt.io/qt-5/qdesktopwidget.html#availableGeometry\n> \n> > But if you want I can also send you screenshots from the phone where I tested \n> > this.\n> \n> A screenshot that demonstrates the problem would be nice.\n> \n> > > Reviewed-by: Kieran Bingham \n> > > \n> > > > /* Setup the camera id combo-box. */\n> > > > cameraIdComboBox_ = new QComboBox;\n> > > > for (const auto &cam : cm_->cameras())","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C67DABE080\n\tfor ;\n\tMon, 6 Mar 2023 10:20:28 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1D9EB62673;\n\tMon, 6 Mar 2023 11:20:28 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5408A62665\n\tfor ;\n\tMon, 6 Mar 2023 11:20:26 +0100 (CET)","from pendragon.ideasonboard.com\n\t(153.162-64-87.adsl-dyn.isp.belgacom.be [87.64.162.153])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A6719EF;\n\tMon, 6 Mar 2023 11:20:25 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1678098028;\n\tbh=lRZvDOScRrmmPk13LKtUE+Amjd9V+/Jb4XDfg0LRKbk=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=X54zt0BzQ8+xXeDwGk0vpikC4VnjWVmrfNoRFG4iF9vmFdBoiBsJUopTKUv02FrV/\n\tZ6MZHU+/BJA3fmQNoSnjg99mElYIDSvGINPJ1iLafSxWWEvDuSyZzYMtVONElIEptd\n\teTXy2YXAAqTO6diRJoFVcHKlkfanvilSJOgY4QVjoWx+LR1OSX+t/4y1y+Y4SV5J5x\n\tFa6nPienRoP3RBrNU/2tOQQEQDqHDKmvWl77zU8q01gxPS+o2exlyiqESzZaDPcMif\n\tEGRDPwaVLjiqiGf3e/2/4WQo1h4QuM/0S6hcL/VBMCX3sxda4tErfM9OFZLqe+TuLL\n\tHOmoBWyLO4aAw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1678098025;\n\tbh=lRZvDOScRrmmPk13LKtUE+Amjd9V+/Jb4XDfg0LRKbk=;\n\th=Date:From:To:Subject:References:In-Reply-To:From;\n\tb=F0xNxt3FXjD0JOy3jPFQgxMLld7heHQMtpj1kvr8bmt1LLXQ7VjeebzvJmTVrzk16\n\t6otcaWtm3/MNsv6gpgzWYz7MXmj5rxgcHmFz2RIFjTwxhbqnviJI5klQnIqJh0gKMe\n\tnMVwMoDx4zjvHEk3867knvQwJnnLIDi2GfhsCo2w="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"F0xNxt3F\"; dkim-atps=neutral","Date":"Mon, 6 Mar 2023 12:20:29 +0200","To":"Luca Weiss , libcamera-devel@lists.libcamera.org","Message-ID":"<20230306102029.GC20909@pendragon.ideasonboard.com>","References":"<20230128162402.892389-1-luca@z3ntu.xyz>\n\t<167508787610.42371.8893121979446131180@Monstersaurus>\n\t<3535927.R56niFO833@g550jk>\n\t<20230306100747.GB20909@pendragon.ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20230306100747.GB20909@pendragon.ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] qcam: Decrease minimum width of\n\tselector dialog","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]