[{"id":26347,"web_url":"https://patchwork.libcamera.org/comment/26347/","msgid":"<167464406645.826354.16319254453643320395@Monstersaurus>","date":"2023-01-25T10:54:26","subject":"Re: [libcamera-devel] [PATCH v2] libcamera: Add support for\n\tOmniVision OV8858","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Jacopo Mondi via libcamera-devel (2023-01-25 09:05:28)\n> From: Nicholas Roth \n> \n> Support for the OmniVision OV8858 sensor is scheduled for inclusion in\n> the Linux kernel in version v6.3.\n> \n> Add support for the sensor in libcamera by providing static properties\n> and a camera sensor helper in libipa.\n> \n> The camera sensor helper expresses analogue gain increments in 1/128\n> step which differs from what is reported in the sensor documentation in\n> section \"5.8 manual exposure compensation/ manual gain compensation\" [0]\n> \n> A more detailed analysis of the sensor gain model is reported at:\n> https://patchwork.linuxtv.org/project/linux-media/patch/20221106171129.166892-2-nicholas@rothemail.net/#142267\n> \n> Record with a \\todo note a reference to discussion on the gain model\n> implementation.\n> \n> Signed-off-by: Nicholas Roth \n> Signed-off-by: Jacopo Mondi \n> ---\n> \n> Compared to initial Nicholas' submission:\n> - Change gain step to 128 (link to the driver discussion)\n> - Add fadeToGray test patter and adjust comment\n> \n> ---\n> src/ipa/libipa/camera_sensor_helper.cpp | 18 ++++++++++++++++++\n> src/libcamera/camera_sensor_properties.cpp | 13 +++++++++++++\n> 2 files changed, 31 insertions(+)\n> \n> diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\n> index 3d8a2835fa28..52e11dfb8ca2 100644\n> --- a/src/ipa/libipa/camera_sensor_helper.cpp\n> +++ b/src/ipa/libipa/camera_sensor_helper.cpp\n> @@ -505,6 +505,24 @@ public:\n> };\n> REGISTER_CAMERA_SENSOR_HELPER(\"ov5693\", CameraSensorHelperOv5693)\n> \n> +class CameraSensorHelperOv8858 : public CameraSensorHelper\n> +{\n> +public:\n> + CameraSensorHelperOv8858()\n> + {\n> + gainType_ = AnalogueGainLinear;\n> +\n> + /*\n> + * \\todo Use an increment step of 1/128 which differs from\n> + * what the sensor manual describes.\n\nThis sounds like the todo is to *use* a step of 128, but isn't that what\nit's already doing? \n\n> + *\n> + * See: https://patchwork.linuxtv.org/project/linux-media/patch/20221106171129.166892-2-nicholas@rothemail.net/#142267\n> + */\n> + gainConstants_.linear = { 1, 0, 0, 128 };\n> + }\n> +};\n> +REGISTER_CAMERA_SENSOR_HELPER(\"ov8858\", CameraSensorHelperOv8858)\n> +\n> class CameraSensorHelperOv8865 : public CameraSensorHelper\n> {\n> public:\n> diff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/camera_sensor_properties.cpp\n> index c3c2caced906..7f6816e72773 100644\n> --- a/src/libcamera/camera_sensor_properties.cpp\n> +++ b/src/libcamera/camera_sensor_properties.cpp\n> @@ -167,6 +167,19 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n> */\n> },\n> } },\n> + { \"ov8858\", {\n> + .unitCellSize = { 1120, 1120 },\n> + .testPatternModes = {\n> + { controls::draft::TestPatternModeOff, 0 },\n> + { controls::draft::TestPatternModeColorBars, 1 },\n> + { controls::draft::TestPatternModeColorBarsFadeToGray, 2 },\n> + /*\n> + * No corresponding test patter mode\n\ns/patter/pattern/\n\n\n> + * 3: \"Vertical Color Bar Type 3\",\n> + * 4: \"Vertical Color Bar Type 4\"\n> + */\n> + },\n> + } },\n> { \"ov8865\", {\n> .unitCellSize = { 1400, 1400 },\n> .testPatternModes = {\n> --\n> 2.39.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8EDC5BDB1D\n\tfor ;\n\tWed, 25 Jan 2023 10:54:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B83D4625E4;\n\tWed, 25 Jan 2023 11:54:30 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6E45E61EFA\n\tfor ;\n\tWed, 25 Jan 2023 11:54:29 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D58126E0;\n\tWed, 25 Jan 2023 11:54:28 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1674644070;\n\tbh=MCjdC6C9AfXoTnteHjwBz9pXke+ukQzGEsxkr/FTGxE=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=FBdsP2ztXJNwhkHYoX9+wewSVaXbt4/+RWdouQHZObK5WsPU7JyegYlFH5uFVbqKB\n\tSTXCJFiQt38NwNyxNgHFqziFaTz68+HVELLtIH0v86oP7OesaaZkPnCf1V0UI5oNDT\n\tvErs+0yN7YW91HlqpJQVI0gT9XhJhqL2jkhzdbGuiW3bsjV1D0+XUYBqZiEYwSSGBA\n\tNzFXKEhy4k1dULnjVJNa/cEwmc4FiVREubysxN/uG5i1h5OnhqLVsEF/QUG6IxU9JX\n\tu21+zUZL4Lb7LXpL2qC8PE3D/C5lep8pQimn22f9pRyZyFuZGpDnhLFrc3/v1/CdLi\n\tMPbKWoUMXaaow==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1674644069;\n\tbh=MCjdC6C9AfXoTnteHjwBz9pXke+ukQzGEsxkr/FTGxE=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=MkYVjyjZGiFAYBOLHFIeXPswf3lbX2Y0d5BBOoj4QWgjdeOsGZbXDGqOjoJSwOO+A\n\tlUrwPEoUIynWhnTFv4AF709NeWs85iDeHcYYa/SXeSuTjxehRL7kFpVV+DNSqknFAI\n\tsc94Rlk1pRYBbtg8maJhC9MrXE0hPkwkb2GyN7N4="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"MkYVjyjZ\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20230125090528.46218-1-jacopo.mondi@ideasonboard.com>","References":"<20230125090528.46218-1-jacopo.mondi@ideasonboard.com>","To":"Jacopo Mondi ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Wed, 25 Jan 2023 10:54:26 +0000","Message-ID":"<167464406645.826354.16319254453643320395@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH v2] libcamera: Add support for\n\tOmniVision OV8858","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Cc":"Jacopo Mondi ,\n\tNicholas Roth ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":26361,"web_url":"https://patchwork.libcamera.org/comment/26361/","msgid":"<20230126171146.fiqh4eacvwz3y67j@uno.localdomain>","date":"2023-01-26T17:11:46","subject":"Re: [libcamera-devel] [PATCH v2] libcamera: Add support for\n\tOmniVision OV8858","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Kieran\n\nOn Wed, Jan 25, 2023 at 10:54:26AM +0000, Kieran Bingham via libcamera-devel wrote:\n> Quoting Jacopo Mondi via libcamera-devel (2023-01-25 09:05:28)\n> > From: Nicholas Roth \n> >\n> > Support for the OmniVision OV8858 sensor is scheduled for inclusion in\n> > the Linux kernel in version v6.3.\n> >\n> > Add support for the sensor in libcamera by providing static properties\n> > and a camera sensor helper in libipa.\n> >\n> > The camera sensor helper expresses analogue gain increments in 1/128\n> > step which differs from what is reported in the sensor documentation in\n> > section \"5.8 manual exposure compensation/ manual gain compensation\" [0]\n> >\n> > A more detailed analysis of the sensor gain model is reported at:\n> > https://patchwork.linuxtv.org/project/linux-media/patch/20221106171129.166892-2-nicholas@rothemail.net/#142267\n> >\n> > Record with a \\todo note a reference to discussion on the gain model\n> > implementation.\n> >\n> > Signed-off-by: Nicholas Roth \n> > Signed-off-by: Jacopo Mondi \n> > ---\n> >\n> > Compared to initial Nicholas' submission:\n> > - Change gain step to 128 (link to the driver discussion)\n> > - Add fadeToGray test patter and adjust comment\n> >\n> > ---\n> > src/ipa/libipa/camera_sensor_helper.cpp | 18 ++++++++++++++++++\n> > src/libcamera/camera_sensor_properties.cpp | 13 +++++++++++++\n> > 2 files changed, 31 insertions(+)\n> >\n> > diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\n> > index 3d8a2835fa28..52e11dfb8ca2 100644\n> > --- a/src/ipa/libipa/camera_sensor_helper.cpp\n> > +++ b/src/ipa/libipa/camera_sensor_helper.cpp\n> > @@ -505,6 +505,24 @@ public:\n> > };\n> > REGISTER_CAMERA_SENSOR_HELPER(\"ov5693\", CameraSensorHelperOv5693)\n> >\n> > +class CameraSensorHelperOv8858 : public CameraSensorHelper\n> > +{\n> > +public:\n> > + CameraSensorHelperOv8858()\n> > + {\n> > + gainType_ = AnalogueGainLinear;\n> > +\n> > + /*\n> > + * \\todo Use an increment step of 1/128 which differs from\n> > + * what the sensor manual describes.\n>\n> This sounds like the todo is to *use* a step of 128, but isn't that what\n> it's already doing?\n>\n\nRight :)\n\nI can change it to\n * \\todo Validate the selected 1/128 step value\n * as it differs from what the sensor manual\n * describes\n *\n * See: https://patchwork.linuxtv.org/project/linux-media/patch/20221106171129.166892-2-nicholas@rothemail.net/#142267\n */\n\nWhen applying\n\n\n> > + gainConstants_.linear = { 1, 0, 0, 128 };\n> > + }\n> > +};\n> > +REGISTER_CAMERA_SENSOR_HELPER(\"ov8858\", CameraSensorHelperOv8858)\n> > +\n> > class CameraSensorHelperOv8865 : public CameraSensorHelper\n> > {\n> > public:\n> > diff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/camera_sensor_properties.cpp\n> > index c3c2caced906..7f6816e72773 100644\n> > --- a/src/libcamera/camera_sensor_properties.cpp\n> > +++ b/src/libcamera/camera_sensor_properties.cpp\n> > @@ -167,6 +167,19 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n> > */\n> > },\n> > } },\n> > + { \"ov8858\", {\n> > + .unitCellSize = { 1120, 1120 },\n> > + .testPatternModes = {\n> > + { controls::draft::TestPatternModeOff, 0 },\n> > + { controls::draft::TestPatternModeColorBars, 1 },\n> > + { controls::draft::TestPatternModeColorBarsFadeToGray, 2 },\n> > + /*\n> > + * No corresponding test patter mode\n>\n> s/patter/pattern/\n>\n>\n> > + * 3: \"Vertical Color Bar Type 3\",\n> > + * 4: \"Vertical Color Bar Type 4\"\n> > + */\n> > + },\n> > + } },\n> > { \"ov8865\", {\n> > .unitCellSize = { 1400, 1400 },\n> > .testPatternModes = {\n> > --\n> > 2.39.0\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 81FC8BEFBE\n\tfor ;\n\tThu, 26 Jan 2023 17:11:53 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E0ED1625D8;\n\tThu, 26 Jan 2023 18:11:52 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B91E361EFB\n\tfor ;\n\tThu, 26 Jan 2023 18:11:50 +0100 (CET)","from ideasonboard.com (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 222642B3;\n\tThu, 26 Jan 2023 18:11:50 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1674753112;\n\tbh=7qKTcvtDpml+7oj1Hjf4RkqjaXlAowrR3oApc2vQqqQ=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=uAzlRDXTaH+AHakQjq0Vi4g4zAoj8A3y2RdF28GbVCdEaD1t7tk5mZDzYKqhlNYl4\n\tLn7ljardCcM57jaWUDnJGXRZquhVZhdZiBzmLvT/MhCLtiEn5PzoXtUmD7VA9hlGCO\n\tmHyYqIZVMcw0WsqnZi0oeHqMtNcZrjENMDCcDwVe8rOlZs0MpIa4iM4fIQ62wkW7y8\n\tiBRG50mGOfPABkN14QfBxvZ688p4B2eHzmeMOnvop5EDfyqXhFyWtKTz00GNnYOy00\n\tuLEIxMeKKKbcQC+8N4TMEGRVPMztIWRe6hxfoF+2Vqi2khR2FQ7fDACmR3VRAhTpEs\n\tkumN9yAfyLfoQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1674753110;\n\tbh=7qKTcvtDpml+7oj1Hjf4RkqjaXlAowrR3oApc2vQqqQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=smQAY0TwuHE4Szu8LguHVEx5JyLFNBtd/MZPl6dvNbZqxf8wv0hC9PR5kFFQKAhVZ\n\tqRcB9bk5nQOMtQ6rAGBFDF4UbTxjw2Bu/VHGgbIUWy5vUVkiADwg74v2JihwyRraOb\n\tMl9MRIjOQ6+nwVwoMEUuFYjKXFa9nKGgUFVEPvJA="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"smQAY0Tw\"; dkim-atps=neutral","Date":"Thu, 26 Jan 2023 18:11:46 +0100","To":"Kieran Bingham ","Message-ID":"<20230126171146.fiqh4eacvwz3y67j@uno.localdomain>","References":"<20230125090528.46218-1-jacopo.mondi@ideasonboard.com>\n\t<167464406645.826354.16319254453643320395@Monstersaurus>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<167464406645.826354.16319254453643320395@Monstersaurus>","Subject":"Re: [libcamera-devel] [PATCH v2] libcamera: Add support for\n\tOmniVision OV8858","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"Jacopo Mondi ,\n\tNicholas Roth ,\n\tlibcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":26362,"web_url":"https://patchwork.libcamera.org/comment/26362/","msgid":"<167475386545.135671.1770474101561161826@Monstersaurus>","date":"2023-01-26T17:24:25","subject":"Re: [libcamera-devel] [PATCH v2] libcamera: Add support for\n\tOmniVision OV8858","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Jacopo Mondi (2023-01-26 17:11:46)\n> Hi Kieran\n> \n> On Wed, Jan 25, 2023 at 10:54:26AM +0000, Kieran Bingham via libcamera-devel wrote:\n> > Quoting Jacopo Mondi via libcamera-devel (2023-01-25 09:05:28)\n> > > From: Nicholas Roth \n> > >\n> > > Support for the OmniVision OV8858 sensor is scheduled for inclusion in\n> > > the Linux kernel in version v6.3.\n> > >\n> > > Add support for the sensor in libcamera by providing static properties\n> > > and a camera sensor helper in libipa.\n> > >\n> > > The camera sensor helper expresses analogue gain increments in 1/128\n> > > step which differs from what is reported in the sensor documentation in\n> > > section \"5.8 manual exposure compensation/ manual gain compensation\" [0]\n> > >\n> > > A more detailed analysis of the sensor gain model is reported at:\n> > > https://patchwork.linuxtv.org/project/linux-media/patch/20221106171129.166892-2-nicholas@rothemail.net/#142267\n> > >\n> > > Record with a \\todo note a reference to discussion on the gain model\n> > > implementation.\n> > >\n> > > Signed-off-by: Nicholas Roth \n> > > Signed-off-by: Jacopo Mondi \n> > > ---\n> > >\n> > > Compared to initial Nicholas' submission:\n> > > - Change gain step to 128 (link to the driver discussion)\n> > > - Add fadeToGray test patter and adjust comment\n> > >\n> > > ---\n> > > src/ipa/libipa/camera_sensor_helper.cpp | 18 ++++++++++++++++++\n> > > src/libcamera/camera_sensor_properties.cpp | 13 +++++++++++++\n> > > 2 files changed, 31 insertions(+)\n> > >\n> > > diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\n> > > index 3d8a2835fa28..52e11dfb8ca2 100644\n> > > --- a/src/ipa/libipa/camera_sensor_helper.cpp\n> > > +++ b/src/ipa/libipa/camera_sensor_helper.cpp\n> > > @@ -505,6 +505,24 @@ public:\n> > > };\n> > > REGISTER_CAMERA_SENSOR_HELPER(\"ov5693\", CameraSensorHelperOv5693)\n> > >\n> > > +class CameraSensorHelperOv8858 : public CameraSensorHelper\n> > > +{\n> > > +public:\n> > > + CameraSensorHelperOv8858()\n> > > + {\n> > > + gainType_ = AnalogueGainLinear;\n> > > +\n> > > + /*\n> > > + * \\todo Use an increment step of 1/128 which differs from\n> > > + * what the sensor manual describes.\n> >\n> > This sounds like the todo is to *use* a step of 128, but isn't that what\n> > it's already doing?\n> >\n> \n> Right :)\n> \n> I can change it to\n> * \\todo Validate the selected 1/128 step value\n> * as it differs from what the sensor manual\n> * describes\n> *\n> * See: https://patchwork.linuxtv.org/project/linux-media/patch/20221106171129.166892-2-nicholas@rothemail.net/#142267\n> */\n> \n> When applying\n\nWorks for me ;-)\n\n\nReviewed-by: Kieran Bingham \n\n> \n> \n> > > + gainConstants_.linear = { 1, 0, 0, 128 };\n> > > + }\n> > > +};\n> > > +REGISTER_CAMERA_SENSOR_HELPER(\"ov8858\", CameraSensorHelperOv8858)\n> > > +\n> > > class CameraSensorHelperOv8865 : public CameraSensorHelper\n> > > {\n> > > public:\n> > > diff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/camera_sensor_properties.cpp\n> > > index c3c2caced906..7f6816e72773 100644\n> > > --- a/src/libcamera/camera_sensor_properties.cpp\n> > > +++ b/src/libcamera/camera_sensor_properties.cpp\n> > > @@ -167,6 +167,19 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n> > > */\n> > > },\n> > > } },\n> > > + { \"ov8858\", {\n> > > + .unitCellSize = { 1120, 1120 },\n> > > + .testPatternModes = {\n> > > + { controls::draft::TestPatternModeOff, 0 },\n> > > + { controls::draft::TestPatternModeColorBars, 1 },\n> > > + { controls::draft::TestPatternModeColorBarsFadeToGray, 2 },\n> > > + /*\n> > > + * No corresponding test patter mode\n> >\n> > s/patter/pattern/\n> >\n> >\n> > > + * 3: \"Vertical Color Bar Type 3\",\n> > > + * 4: \"Vertical Color Bar Type 4\"\n> > > + */\n> > > + },\n> > > + } },\n> > > { \"ov8865\", {\n> > > .unitCellSize = { 1400, 1400 },\n> > > .testPatternModes = {\n> > > --\n> > > 2.39.0\n> > >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E6D76BDC71\n\tfor ;\n\tThu, 26 Jan 2023 17:24:30 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3DCED625E4;\n\tThu, 26 Jan 2023 18:24:30 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9430561EFB\n\tfor ;\n\tThu, 26 Jan 2023 18:24:28 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 13E332B3;\n\tThu, 26 Jan 2023 18:24:28 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1674753870;\n\tbh=9bEQWMj6GX+jdkIm6o2B2D34HYioTEZpUfpAXSH7uGQ=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=kp6482vYTNfChADi90KKkTviRfGYZ3YiMPe7kKt1uWzVSNJQQ5x2T9K5Eeu4wTTRL\n\t49apI3I260oM4DV2Th6zNmPa6AypmzZoqjipJCNJV1HRnrOxoZivb+tI+Xb8scVXeN\n\tsmOygARZIf1UaQYu2WdFFZt6+sc5uCK2IZRli8xJdURM4WR5x9GmuakmScT1/gk0+c\n\t6EJyxlandtiu/snkfEwSENHT+v9g6cNcRGa7VNMDuVyh/b31kD44rPBqABP9J+uYAe\n\tvtG8+EWbpfpPbzec2ar1mEWgegl69EEd+3EH7vPWB/GQtlmeVSCghD079+rTtlXfLO\n\t8IWirUFLHEziA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1674753868;\n\tbh=9bEQWMj6GX+jdkIm6o2B2D34HYioTEZpUfpAXSH7uGQ=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=ITnekX+pz5q7vtAs1ZtvMlIfdygRhiunhC+QU4seIPk/sfG9hgT1jzxvUvvWyznJC\n\tR51sgiSA3bomr0IxPP4LMWdQHjgkvXiuMaHMtMJFzhLCeoliYBTwMY3sizZXz1tllO\n\tt4LBNG6vUYoiz8lA9erM/AfVxHZ1B6UYRkM/alRw="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"ITnekX+p\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20230126171146.fiqh4eacvwz3y67j@uno.localdomain>","References":"<20230125090528.46218-1-jacopo.mondi@ideasonboard.com>\n\t<167464406645.826354.16319254453643320395@Monstersaurus>\n\t<20230126171146.fiqh4eacvwz3y67j@uno.localdomain>","To":"Jacopo Mondi ","Date":"Thu, 26 Jan 2023 17:24:25 +0000","Message-ID":"<167475386545.135671.1770474101561161826@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH v2] libcamera: Add support for\n\tOmniVision OV8858","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Cc":"Jacopo Mondi ,\n\tNicholas Roth ,\n\tlibcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":26363,"web_url":"https://patchwork.libcamera.org/comment/26363/","msgid":"","date":"2023-01-26T17:53:19","subject":"Re: [libcamera-devel] [PATCH v2] libcamera: Add support for\n\tOmniVision OV8858","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Thu, Jan 26, 2023 at 05:24:25PM +0000, Kieran Bingham via libcamera-devel wrote:\n> Quoting Jacopo Mondi (2023-01-26 17:11:46)\n> > On Wed, Jan 25, 2023 at 10:54:26AM +0000, Kieran Bingham via libcamera-devel wrote:\n> > > Quoting Jacopo Mondi via libcamera-devel (2023-01-25 09:05:28)\n> > > > From: Nicholas Roth \n> > > >\n> > > > Support for the OmniVision OV8858 sensor is scheduled for inclusion in\n> > > > the Linux kernel in version v6.3.\n> > > >\n> > > > Add support for the sensor in libcamera by providing static properties\n> > > > and a camera sensor helper in libipa.\n> > > >\n> > > > The camera sensor helper expresses analogue gain increments in 1/128\n> > > > step which differs from what is reported in the sensor documentation in\n> > > > section \"5.8 manual exposure compensation/ manual gain compensation\" [0]\n> > > >\n> > > > A more detailed analysis of the sensor gain model is reported at:\n> > > > https://patchwork.linuxtv.org/project/linux-media/patch/20221106171129.166892-2-nicholas@rothemail.net/#142267\n> > > >\n> > > > Record with a \\todo note a reference to discussion on the gain model\n> > > > implementation.\n> > > >\n> > > > Signed-off-by: Nicholas Roth \n> > > > Signed-off-by: Jacopo Mondi \n> > > > ---\n> > > >\n> > > > Compared to initial Nicholas' submission:\n> > > > - Change gain step to 128 (link to the driver discussion)\n> > > > - Add fadeToGray test patter and adjust comment\n> > > >\n> > > > ---\n> > > > src/ipa/libipa/camera_sensor_helper.cpp | 18 ++++++++++++++++++\n> > > > src/libcamera/camera_sensor_properties.cpp | 13 +++++++++++++\n> > > > 2 files changed, 31 insertions(+)\n> > > >\n> > > > diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\n> > > > index 3d8a2835fa28..52e11dfb8ca2 100644\n> > > > --- a/src/ipa/libipa/camera_sensor_helper.cpp\n> > > > +++ b/src/ipa/libipa/camera_sensor_helper.cpp\n> > > > @@ -505,6 +505,24 @@ public:\n> > > > };\n> > > > REGISTER_CAMERA_SENSOR_HELPER(\"ov5693\", CameraSensorHelperOv5693)\n> > > >\n> > > > +class CameraSensorHelperOv8858 : public CameraSensorHelper\n> > > > +{\n> > > > +public:\n> > > > + CameraSensorHelperOv8858()\n> > > > + {\n> > > > + gainType_ = AnalogueGainLinear;\n> > > > +\n> > > > + /*\n> > > > + * \\todo Use an increment step of 1/128 which differs from\n> > > > + * what the sensor manual describes.\n> > >\n> > > This sounds like the todo is to *use* a step of 128, but isn't that what\n> > > it's already doing?\n> > >\n> > \n> > Right :)\n> > \n> > I can change it to\n> > * \\todo Validate the selected 1/128 step value\n> > * as it differs from what the sensor manual\n> > * describes\n> > *\n> > * See: https://patchwork.linuxtv.org/project/linux-media/patch/20221106171129.166892-2-nicholas@rothemail.net/#142267\n> > */\n> > \n> > When applying\n> \n> Works for me ;-)\n> \n> Reviewed-by: Kieran Bingham \n\nReviewed-by: Laurent Pinchart \n\n> > > > + gainConstants_.linear = { 1, 0, 0, 128 };\n> > > > + }\n> > > > +};\n> > > > +REGISTER_CAMERA_SENSOR_HELPER(\"ov8858\", CameraSensorHelperOv8858)\n> > > > +\n> > > > class CameraSensorHelperOv8865 : public CameraSensorHelper\n> > > > {\n> > > > public:\n> > > > diff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/camera_sensor_properties.cpp\n> > > > index c3c2caced906..7f6816e72773 100644\n> > > > --- a/src/libcamera/camera_sensor_properties.cpp\n> > > > +++ b/src/libcamera/camera_sensor_properties.cpp\n> > > > @@ -167,6 +167,19 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n> > > > */\n> > > > },\n> > > > } },\n> > > > + { \"ov8858\", {\n> > > > + .unitCellSize = { 1120, 1120 },\n> > > > + .testPatternModes = {\n> > > > + { controls::draft::TestPatternModeOff, 0 },\n> > > > + { controls::draft::TestPatternModeColorBars, 1 },\n> > > > + { controls::draft::TestPatternModeColorBarsFadeToGray, 2 },\n> > > > + /*\n> > > > + * No corresponding test patter mode\n> > >\n> > > s/patter/pattern/\n> > >\n> > > > + * 3: \"Vertical Color Bar Type 3\",\n> > > > + * 4: \"Vertical Color Bar Type 4\"\n> > > > + */\n> > > > + },\n> > > > + } },\n> > > > { \"ov8865\", {\n> > > > .unitCellSize = { 1400, 1400 },\n> > > > .testPatternModes = {","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C9703BEFBE\n\tfor ;\n\tThu, 26 Jan 2023 17:53:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 30C2F625E4;\n\tThu, 26 Jan 2023 18:53:27 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0854261EFB\n\tfor ;\n\tThu, 26 Jan 2023 18:53:26 +0100 (CET)","from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi\n\t[213.243.189.158])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B6B59975;\n\tThu, 26 Jan 2023 18:53:24 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1674755607;\n\tbh=VH1AkvpuLeOWNjbWB4jR9q6Y2n7HMvqoXhjXtPQMKW0=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=3hwORWc8KMn/klpRO7lS5zgB5vsbUT4DmNJNw30T4xPSgkmBYa2gRidLCwG8m06eA\n\tAm86LSVTpchCheix0ClZeU45NIFVkAb+izAYUWhGothXRmNe/6bfwB7UNRVcgqbvPq\n\tLbCDWxL1ZjEwS6MxZ3H2A9rHS3K/j9QPYzycGe3K/2T1JWs/A9XKwa81uvFwS0p88X\n\tuknpv4D9K2L1aFGVOLvTaI9qmsfzXVx6QqN/0VWtAqPt1pDf3UF+eaCm6pQ14l7Jyk\n\tUJ8b+CnfAfz71w08lTKVi0c6Jawqnf/KHrsiVmCFB7+MRi8bZa/6ZF7eTB3DZ7FnhC\n\tV2z3qUfV6Ac0Q==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1674755605;\n\tbh=VH1AkvpuLeOWNjbWB4jR9q6Y2n7HMvqoXhjXtPQMKW0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=ev1cvyrTnCL8BGdCYd9tz2I1hkg4BbXQvu0Uwf6gEHu0dQ1goMQ25KMUnGPPKEFb9\n\t08qVD8fqvuolrjtH9X0E3PNV+gTTXJ6zWdm1lRgHWN8vcvnDOHhWyYi7bmg5JiMozj\n\tfSi5JXOB7Q2eWF592KG9K3RzO55MtLbv8Zc2regw="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"ev1cvyrT\"; dkim-atps=neutral","Date":"Thu, 26 Jan 2023 19:53:19 +0200","To":"Kieran Bingham ","Message-ID":"","References":"<20230125090528.46218-1-jacopo.mondi@ideasonboard.com>\n\t<167464406645.826354.16319254453643320395@Monstersaurus>\n\t<20230126171146.fiqh4eacvwz3y67j@uno.localdomain>\n\t<167475386545.135671.1770474101561161826@Monstersaurus>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<167475386545.135671.1770474101561161826@Monstersaurus>","Subject":"Re: [libcamera-devel] [PATCH v2] libcamera: Add support for\n\tOmniVision OV8858","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"Jacopo Mondi ,\n\tNicholas Roth ,\n\tlibcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]