{"id":18194,"url":"https://patchwork.libcamera.org/api/patches/18194/?format=json","web_url":"https://patchwork.libcamera.org/patch/18194/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20230125090528.46218-1-jacopo.mondi@ideasonboard.com>","date":"2023-01-25T09:05:28","name":"[libcamera-devel,v2] libcamera: Add support for OmniVision OV8858","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"5f8b1e2c84d79777ee2502909ab804730d557557","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/?format=json","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/18194/mbox/","series":[{"id":3724,"url":"https://patchwork.libcamera.org/api/series/3724/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3724","date":"2023-01-25T09:05:28","name":"[libcamera-devel,v2] libcamera: Add support for OmniVision OV8858","version":2,"mbox":"https://patchwork.libcamera.org/series/3724/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/18194/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/18194/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8EA81BDB1D\n\tfor ;\n\tWed, 25 Jan 2023 09:06:04 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D2630625D8;\n\tWed, 25 Jan 2023 10:06:03 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7A01461EFA\n\tfor ;\n\tWed, 25 Jan 2023 10:06:02 +0100 (CET)","from uno.LocalDomain (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C0C616E0;\n\tWed, 25 Jan 2023 10:06:01 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1674637563;\n\tbh=mRDfxF0s+ZqJKV2Pxp1TteElBEVv8wN0y5rz/ueNEaM=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:Cc:From;\n\tb=outr8eUFGNDOoKwvM2rXPm5OvVNn3hOnDSbVpjt2eV3L7m2QU7N3aQOEIzbGgK6RK\n\t9x/HpJEGoitsm6NjQbkhnlJ4HHHC04XiVeql1E43mv2JfVXzy0hC0TObbkbXBBHF8Q\n\t6iKfioG/6xABg8Bk7NVHtUPMzHkOH7ayEG5TMhwssDD4oi9qWuLLY/tV4Dz3Pq8CIW\n\tnrHUjiOpUt3q9ByppvIxuGKWyAXOX9YhKpoLPkiZtebo61yqxpiQcSoeE1k6hTdi7H\n\tBsK3/c06/jD1JUOmLDPW3+48B9BR1NaVvPd7q/tEsQbVV3eq8VChe65XuWs140jO4Y\n\tSwquw49ZI4C2g==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1674637562;\n\tbh=mRDfxF0s+ZqJKV2Pxp1TteElBEVv8wN0y5rz/ueNEaM=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=m8kGm3G9HxpFj9iBAfAKkA6KcSUCv1Xpewua5u6G/lHv/zVjAl7f3sC3zCf8tHlb6\n\tqKtUaivzIe82N8g8auirD6eEme7/bJexdKTUj7dUERUQ6lNq/uQ3Ywiw0R0+bAKvyO\n\tEW1+GJ+l72qrLmmVR1lXZs8FEfxEZqi9uWK6vU4g="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"m8kGm3G9\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 25 Jan 2023 10:05:28 +0100","Message-Id":"<20230125090528.46218-1-jacopo.mondi@ideasonboard.com>","X-Mailer":"git-send-email 2.39.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2] libcamera: Add support for OmniVision\n\tOV8858","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"Jacopo Mondi ,\n\tNicholas Roth ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"From: Nicholas Roth \n\nSupport for the OmniVision OV8858 sensor is scheduled for inclusion in\nthe Linux kernel in version v6.3.\n\nAdd support for the sensor in libcamera by providing static properties\nand a camera sensor helper in libipa.\n\nThe camera sensor helper expresses analogue gain increments in 1/128\nstep which differs from what is reported in the sensor documentation in\nsection \"5.8 manual exposure compensation/ manual gain compensation\" [0]\n\nA more detailed analysis of the sensor gain model is reported at:\nhttps://patchwork.linuxtv.org/project/linux-media/patch/20221106171129.166892-2-nicholas@rothemail.net/#142267\n\nRecord with a \\todo note a reference to discussion on the gain model\nimplementation.\n\nSigned-off-by: Nicholas Roth \nSigned-off-by: Jacopo Mondi \n---\n\nCompared to initial Nicholas' submission:\n- Change gain step to 128 (link to the driver discussion)\n- Add fadeToGray test patter and adjust comment\n\n---\n src/ipa/libipa/camera_sensor_helper.cpp | 18 ++++++++++++++++++\n src/libcamera/camera_sensor_properties.cpp | 13 +++++++++++++\n 2 files changed, 31 insertions(+)\n\n--\n2.39.0","diff":"diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\nindex 3d8a2835fa28..52e11dfb8ca2 100644\n--- a/src/ipa/libipa/camera_sensor_helper.cpp\n+++ b/src/ipa/libipa/camera_sensor_helper.cpp\n@@ -505,6 +505,24 @@ public:\n };\n REGISTER_CAMERA_SENSOR_HELPER(\"ov5693\", CameraSensorHelperOv5693)\n\n+class CameraSensorHelperOv8858 : public CameraSensorHelper\n+{\n+public:\n+\tCameraSensorHelperOv8858()\n+\t{\n+\t\tgainType_ = AnalogueGainLinear;\n+\n+\t\t/*\n+\t\t * \\todo Use an increment step of 1/128 which differs from\n+\t\t * what the sensor manual describes.\n+\t\t *\n+\t\t * See: https://patchwork.linuxtv.org/project/linux-media/patch/20221106171129.166892-2-nicholas@rothemail.net/#142267\n+\t\t */\n+\t\tgainConstants_.linear = { 1, 0, 0, 128 };\n+\t}\n+};\n+REGISTER_CAMERA_SENSOR_HELPER(\"ov8858\", CameraSensorHelperOv8858)\n+\n class CameraSensorHelperOv8865 : public CameraSensorHelper\n {\n public:\ndiff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/camera_sensor_properties.cpp\nindex c3c2caced906..7f6816e72773 100644\n--- a/src/libcamera/camera_sensor_properties.cpp\n+++ b/src/libcamera/camera_sensor_properties.cpp\n@@ -167,6 +167,19 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n \t\t\t\t */\n \t\t\t},\n \t\t} },\n+\t\t{ \"ov8858\", {\n+\t\t\t.unitCellSize = { 1120, 1120 },\n+\t\t\t.testPatternModes = {\n+\t\t\t\t{ controls::draft::TestPatternModeOff, 0 },\n+\t\t\t\t{ controls::draft::TestPatternModeColorBars, 1 },\n+\t\t\t\t{ controls::draft::TestPatternModeColorBarsFadeToGray, 2 },\n+\t\t\t\t/*\n+\t\t\t\t * No corresponding test patter mode\n+\t\t\t\t * 3: \"Vertical Color Bar Type 3\",\n+\t\t\t\t * 4: \"Vertical Color Bar Type 4\"\n+\t\t\t\t */\n+\t\t\t},\n+\t\t} },\n \t\t{ \"ov8865\", {\n \t\t\t.unitCellSize = { 1400, 1400 },\n \t\t\t.testPatternModes = {\n","prefixes":["libcamera-devel","v2"]}