[{"id":26339,"web_url":"https://patchwork.libcamera.org/comment/26339/","msgid":"<167457467554.42371.12739115082101551122@Monstersaurus>","date":"2023-01-24T15:37:55","subject":"Re: [libcamera-devel] [PATCH] file_sink.cpp: Avoid\n\tdangling-reference","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Khem,\n\nQuoting Khem Raj via libcamera-devel (2023-01-24 09:22:18)\n> Fixes following errors with gcc-13\n> \n> ../git/src/cam/file_sink.cpp:92:45: error: possibly dangling reference to a temporary [-Werror=dangling-reference]\n> 92 | const FrameMetadata::Plane &meta = buffer->metadata().planes()[i];\n> | ^~~~\n> ../git/src/cam/file_sink.cpp:92:81: note: the temporary was destroyed at the end of the full expression '(& buffer->libcamera::FrameBuffer::metadata())->libcamera::FrameMetadata::planes().libcamera::Span::operator[](i)'\n> 92 | const FrameMetadata::Plane &meta = buffer->metadata().planes()[i];\n> | ^\n> cc1plus: all warnings being treated as errors\n> \n> Signed-off-by: Khem Raj \n\nThanks for identifying and fixing this issue.\n\nWim has also discovered this today. He reports that your patch does not\napply on the latest libcamera, and looking at the paths below - we moved\nsrc/cam/ into src/apps/cam a few weeks back.\n\nCould you rebase this on top of master please? If you can Cc Wim, who is\nalso affected by this, I expect he can also test it and we can get it\nmerged quickly.\n\nThanks\n--\nKieran\n\n> ---\n> src/cam/file_sink.cpp | 8 ++++----\n> 1 file changed, 4 insertions(+), 4 deletions(-)\n> \n> diff --git a/src/cam/file_sink.cpp b/src/cam/file_sink.cpp\n> index 45213d4a..897c4b37 100644\n> --- a/src/cam/file_sink.cpp\n> +++ b/src/cam/file_sink.cpp\n> @@ -89,13 +89,13 @@ void FileSink::writeBuffer(const Stream *stream, FrameBuffer *buffer)\n> Image *image = mappedBuffers_[buffer].get();\n> \n> for (unsigned int i = 0; i < buffer->planes().size(); ++i) {\n> - const FrameMetadata::Plane &meta = buffer->metadata().planes()[i];\n> + unsigned int bytesused = buffer->metadata().planes()[i].bytesused;\n> \n> Span data = image->data(i);\n> - unsigned int length = std::min(meta.bytesused, data.size());\n> + unsigned int length = std::min(bytesused, data.size());\n> \n> - if (meta.bytesused > data.size())\n> - std::cerr << \"payload size \" << meta.bytesused\n> + if (bytesused > data.size())\n> + std::cerr << \"payload size \" << bytesused\n> << \" larger than plane size \" << data.size()\n> << std::endl;\n> \n> -- \n> 2.39.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A42AFBEFBE\n\tfor ;\n\tTue, 24 Jan 2023 15:38:00 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 13D976045E;\n\tTue, 24 Jan 2023 16:38:00 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5DF35603D8\n\tfor ;\n\tTue, 24 Jan 2023 16:37:58 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B20CB8A9;\n\tTue, 24 Jan 2023 16:37:57 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1674574680;\n\tbh=V2rpxCKR3K/b99dX0Ekt5Ha+9Yhfu9t+76m3P62N7Ug=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=ISH1zElGGViWRmk9iiYy/bqUfk2baMbP0fV64w5MrA+/adGwGkZtejEt+TytkB1Xx\n\tR5WGvBelIJ7Hfc1+o0Hg3QYXypvCvh6hic4GKXyD3pV4qTvRHvx+o+nbkmjTYM9pHh\n\tGH99cVh+l3G/ZFVtEI/JNLXdAVB2xTNifR1cODuHaa1PRd0ZUZ8L9sM4OhHA06Xrmj\n\tQlQWC4xbL0G89xEYffWNdtG+fA0xmSSRU0osQvPvaOHyqptNUGbn0frmoSNTTz1GTd\n\t6+pwsLsfAz1FkcxaNAdBx/X/aDcl9WGyF0iiiXIPSxOAsh89UIkQsWspnQ+/fWeiUr\n\ty9RGs/NaQbeUw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1674574677;\n\tbh=V2rpxCKR3K/b99dX0Ekt5Ha+9Yhfu9t+76m3P62N7Ug=;\n\th=In-Reply-To:References:Subject:From:To:Cc:Date:From;\n\tb=Dh7NLnYvgDu8g+8/VM7Zd/+s5evo25DkFIQlO2DZsOrVGGt6pl1GwreDYrtSkg/Mr\n\tM+99dyKkJ30+zlWPx1O+GItCwX3cyQSjz42Q9oCpCcO7U3SuCsVmbjBycACEZJkQnA\n\tbJrXBpsLcTs4OHHCi/Lrvpp5NLcUa0bQbxwCrRYY="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"Dh7NLnYv\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20230124092218.2266563-1-raj.khem@gmail.com>","References":"<20230124092218.2266563-1-raj.khem@gmail.com>","To":"Khem Raj , libcamera-devel@lists.libcamera.org","Date":"Tue, 24 Jan 2023 15:37:55 +0000","Message-ID":"<167457467554.42371.12739115082101551122@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH] file_sink.cpp: Avoid\n\tdangling-reference","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Cc":"Khem Raj , wtaymans@redhat.com","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":26340,"web_url":"https://patchwork.libcamera.org/comment/26340/","msgid":"","date":"2023-01-24T16:29:17","subject":"Re: [libcamera-devel] [PATCH] file_sink.cpp: Avoid\n\tdangling-reference","submitter":{"id":133,"url":"https://patchwork.libcamera.org/api/people/133/","name":"Pőcze Barnabás","email":"pobrn@protonmail.com"},"content":"Hi\n\n\nOn 2023. január 24., kedd 10:22, Khem Raj via libcamera-devel wrote:\n\n> Fixes following errors with gcc-13\n> \n> ../git/src/cam/file_sink.cpp:92:45: error: possibly dangling reference to a temporary [-Werror=dangling-reference]\n> 92 | const FrameMetadata::Plane &meta = buffer->metadata().planes()[i];\n> | ^~~~\n> ../git/src/cam/file_sink.cpp:92:81: note: the temporary was destroyed at the end of the full expression '(& buffer->libcamera::FrameBuffer::metadata())->libcamera::FrameMetadata::planes().libcamera::Span::operator[](i)'\n> 92 | const FrameMetadata::Plane &meta = buffer->metadata().planes()[i];\n> | ^\n> cc1plus: all warnings being treated as errors\n\nI think this warning is a false-positive. See a similar example here: https://gcc.godbolt.org/z/rf8v4j6YG\nThis should probably be reported to the GCC bug tracker if that has not already been done.\n\n\n> \n> Signed-off-by: Khem Raj \n> ---\n> src/cam/file_sink.cpp | 8 ++++----\n> 1 file changed, 4 insertions(+), 4 deletions(-)\n> \n> diff --git a/src/cam/file_sink.cpp b/src/cam/file_sink.cpp\n> index 45213d4a..897c4b37 100644\n> --- a/src/cam/file_sink.cpp\n> +++ b/src/cam/file_sink.cpp\n> @@ -89,13 +89,13 @@ void FileSink::writeBuffer(const Stream *stream, FrameBuffer *buffer)\n> \tImage *image = mappedBuffers_[buffer].get();\n> \n> \tfor (unsigned int i = 0; i < buffer->planes().size(); ++i) {\n> -\t\tconst FrameMetadata::Plane &meta = buffer->metadata().planes()[i];\n> +\t\tunsigned int bytesused = buffer->metadata().planes()[i].bytesused;\n> \n> \t\tSpan data = image->data(i);\n> -\t\tunsigned int length = std::min(meta.bytesused, data.size());\n> +\t\tunsigned int length = std::min(bytesused, data.size());\n> \n> -\t\tif (meta.bytesused > data.size())\n> -\t\t\tstd::cerr << \"payload size \" << meta.bytesused\n> +\t\tif (bytesused > data.size())\n> +\t\t\tstd::cerr << \"payload size \" << bytesused\n> \t\t\t\t << \" larger than plane size \" << data.size()\n> \t\t\t\t << std::endl;\n> \n> --\n> 2.39.1\n> \n> \n\n\nRegards,\nBarnabás Pőcze","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 04816BEFBE\n\tfor ;\n\tTue, 24 Jan 2023 16:29:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4C372625E4;\n\tTue, 24 Jan 2023 17:29:30 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1674577770;\n\tbh=B33KQhtazX4ce2oGaEqxn5JXK6sMuEJTcgoBoNn6KbM=;\n\th=Date:To:In-Reply-To:References:List-Id:List-Post:From:Cc:\n\tList-Subscribe:List-Unsubscribe:List-Archive:Reply-To:List-Help:\n\tSubject:From;\n\tb=O0SlZyz9l8NB7g5hj4J8/qr0aUTVtwpwsdA5zNImUpk0vLRNSV4YVQnKlxuAFHi3r\n\tWOp5x48NOywDqV6PNBwbyeDS7Q3v6fc6s61Y7QSqe2E+KZaYtxsnm71Z7t+rbqkTW3\n\tKEf0kiV0MmVJvL52r7q6r7wSxLMRTNa3OYBOIBAk5B4dKXVmJ8C/EDQ3e87aOrwjfJ\n\t0ZGFkly/mjS+SwPwwimrBFf3E/EbBc1A9YBogLxQ38ETZhWAPa2XRubhbg4pvx11JA\n\tnn3SRwWRAKU8sH4ZzNaxijrAmJ1U+MPuaYIiugrGmHy+k0e183B2yzF3C0kTuul6Jh\n\tpAMeF9ziXfOQw==","Date":"Tue, 24 Jan 2023 16:29:17 +0000","To":"Khem Raj ","In-Reply-To":"<20230124092218.2266563-1-raj.khem@gmail.com>","References":"<20230124092218.2266563-1-raj.khem@gmail.com>","MIME-Version":"1.0","Message-ID":"","List-Id":"","List-Post":"","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze_via_libcamera-devel?=\n\t","Precedence":"list","Cc":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","X-BeenThere":"libcamera-devel@lists.libcamera.org","List-Subscribe":",\n\t","List-Unsubscribe":",\n\t","List-Archive":"","Reply-To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","List-Help":"","Subject":"Re: [libcamera-devel] [PATCH] file_sink.cpp: Avoid\n\tdangling-reference","Content-Type":"message/rfc822","Content-Disposition":"inline","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":26452,"web_url":"https://patchwork.libcamera.org/comment/26452/","msgid":"","date":"2023-02-14T08:12:37","subject":"Re: [libcamera-devel] [PATCH] file_sink.cpp: Avoid\n\tdangling-reference","submitter":{"id":101,"url":"https://patchwork.libcamera.org/api/people/101/","name":"Eric Curtin","email":"ecurtin@redhat.com"},"content":"On Tue, 24 Jan 2023 at 09:22, Khem Raj via libcamera-devel\n wrote:\n>\n> Fixes following errors with gcc-13\n>\n> ../git/src/cam/file_sink.cpp:92:45: error: possibly dangling reference to a temporary [-Werror=dangling-reference]\n> 92 | const FrameMetadata::Plane &meta = buffer->metadata().planes()[i];\n> | ^~~~\n> ../git/src/cam/file_sink.cpp:92:81: note: the temporary was destroyed at the end of the full expression '(& buffer->libcamera::FrameBuffer::metadata())->libcamera::FrameMetadata::planes().libcamera::Span::operator[](i)'\n> 92 | const FrameMetadata::Plane &meta = buffer->metadata().planes()[i];\n> | ^\n> cc1plus: all warnings being treated as errors\n>\n> Signed-off-by: Khem Raj \n\nI understand this is a compiler bug, but could we merge this anyway?\nHaving the same issue in Fedora 38 and this code is just as good as\nthe code that reproduces the compiler bug.\n\nReviewed-by: Eric Curtin \n\nIs mise le meas/Regards,\n\nEric Curtin\n\n> ---\n> src/cam/file_sink.cpp | 8 ++++----\n> 1 file changed, 4 insertions(+), 4 deletions(-)\n>\n> diff --git a/src/cam/file_sink.cpp b/src/cam/file_sink.cpp\n> index 45213d4a..897c4b37 100644\n> --- a/src/cam/file_sink.cpp\n> +++ b/src/cam/file_sink.cpp\n> @@ -89,13 +89,13 @@ void FileSink::writeBuffer(const Stream *stream, FrameBuffer *buffer)\n> Image *image = mappedBuffers_[buffer].get();\n>\n> for (unsigned int i = 0; i < buffer->planes().size(); ++i) {\n> - const FrameMetadata::Plane &meta = buffer->metadata().planes()[i];\n> + unsigned int bytesused = buffer->metadata().planes()[i].bytesused;\n>\n> Span data = image->data(i);\n> - unsigned int length = std::min(meta.bytesused, data.size());\n> + unsigned int length = std::min(bytesused, data.size());\n>\n> - if (meta.bytesused > data.size())\n> - std::cerr << \"payload size \" << meta.bytesused\n> + if (bytesused > data.size())\n> + std::cerr << \"payload size \" << bytesused\n> << \" larger than plane size \" << data.size()\n> << std::endl;\n>\n> --\n> 2.39.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 69647BDB13\n\tfor ;\n\tTue, 14 Feb 2023 08:13:07 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AA388625E3;\n\tTue, 14 Feb 2023 09:13:06 +0100 (CET)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7FADC61EEC\n\tfor ;\n\tTue, 14 Feb 2023 09:13:04 +0100 (CET)","from mail-vk1-f197.google.com (mail-vk1-f197.google.com\n\t[209.85.221.197]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id\n\tus-mta-260-sEoLbkchM-2zWArSoB7U8Q-1; Tue, 14 Feb 2023 03:12:54 -0500","by mail-vk1-f197.google.com with SMTP id\n\ts203-20020a1f2cd4000000b003d5b4915319so5643968vks.18\n\tfor ;\n\tTue, 14 Feb 2023 00:12:54 -0800 (PST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1676362386;\n\tbh=BXzndZ2O2FnVfyjQw9DDevwdstLIqGVPb4TIgInIno4=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=QBM+cBGXiekWQrTS/nxFbm6SBBgjcu8PS6i2cw7O+v8ZINCTTnspboXwXMQflwq2j\n\tLhjuVnU/gaOxr8BjR9y2BcNknG79Ufl/1Js9mDucuu9n5POlEJNlYmo/tgPPhq0Nba\n\taxkDVXO00Jd9XHk+F61PVzb3mEL0cTjwQMwzwCFewkCSvxP45P22WD73VA6JLULtja\n\tgC4BaC+Fk/TjwvKWsYsHN5rg41hiYqZLL0gly3eOs/0tbOT0p0nhjxnlNBF+Cqf/FB\n\tkEOpjnaBrRfgIPHuxfotMvkiDQFf/aCtYYBFXN8Cg/SnXX42XrYOnmEoQVY70AZytX\n\tA9MnYljVPh5mA==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1676362383;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=LngLUlNhl4DI/IOzX/aEFUoEHu56+noL7eTs23GpZ0U=;\n\tb=KHyiixOXaDlcPn9IptpISBeOpw4vNwe+RvTRFKc3xOjn+6J2ddvpQb0HSb/doiQSOkAmOn\n\tEZJMoOJ63afaNlajYMuVJoctzlTweKJGH+Ryo52Jm5gxbMQoN17XWb/bpNrZ0uiJRhzRjW\n\tzcFdA6yV/YSVxajOQzXQogB16JAv3TQ="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=redhat.com\n\theader.i=@redhat.com header.b=\"KHyiixOX\"; \n\tdkim-atps=neutral","X-MC-Unique":"sEoLbkchM-2zWArSoB7U8Q-1","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112; t=1676362373;\n\th=content-transfer-encoding:cc:to:subject:message-id:date:from\n\t:in-reply-to:references:mime-version:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=LngLUlNhl4DI/IOzX/aEFUoEHu56+noL7eTs23GpZ0U=;\n\tb=b0lA0XnTl5KXeKdmMhSu1jgzlRUxLd2g9fnEAnft8xVJU+w+C1hcsBsqxJffwgz4F7\n\tZIDHVHwqRoLQI+U6L6SGM++8nztUMYwztw9HQmyawQkqH/04AlmmB6E54BLkDZQiCQpQ\n\t/7HUakTPDMG3ZOydm/haZ9xZIAM6Yh61rSa55+WklCEPpU7Y794XBdcwTZnfQqzQh8Uu\n\t8qXPA+WdaioIBEGlstJr+by+RgN3Yw22ixUjzTysp8TnzPvMlc3ljGnBFdLejoWxuEr6\n\tQZWSKrbrNxdebqiaG6q70AAJUb3qRWvQq4V9AxTvvenLUBFA4AEM+eKUlInWDvmLPpuA\n\tVijQ==","X-Gm-Message-State":"AO0yUKWZ8nqE3FhjcAURNx7NveN8cX7pyQ1imsYKk0rDdYFuGh7nV0XT\n\tEnp+2468dSqFOgzYgR1uezRQuosH3msR7u2QBwW8SSgEmsPUmMra5wu4yHxoPIQGdAwJupirhK/\n\t8tFEoHdULNAZZEqHpnFCZxrMr2hgHdpqHFqrTEzoB+inOAlWXkg==","X-Received":["by 2002:a67:e092:0:b0:412:45d2:b3db with SMTP id\n\tf18-20020a67e092000000b0041245d2b3dbmr205188vsl.40.1676362373688; \n\tTue, 14 Feb 2023 00:12:53 -0800 (PST)","by 2002:a67:e092:0:b0:412:45d2:b3db with SMTP id\n\tf18-20020a67e092000000b0041245d2b3dbmr205178vsl.40.1676362373096;\n\tTue, 14 Feb 2023 00:12:53 -0800 (PST)"],"X-Google-Smtp-Source":"AK7set+sEX4oCi9LKMS2ujWjP/g0MbWWnDhc7iJmI6Bk2UImDqR2H3J7eMkM575/vkwqlhGiz8GdX1saHjmUv1tyi38=","MIME-Version":"1.0","References":"<20230124092218.2266563-1-raj.khem@gmail.com>","In-Reply-To":"<20230124092218.2266563-1-raj.khem@gmail.com>","Date":"Tue, 14 Feb 2023 08:12:37 +0000","Message-ID":"","To":"Khem Raj ","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","Subject":"Re: [libcamera-devel] [PATCH] file_sink.cpp: Avoid\n\tdangling-reference","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Eric Curtin via libcamera-devel ","Reply-To":"Eric Curtin ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]