[{"id":26337,"web_url":"https://patchwork.libcamera.org/comment/26337/","msgid":"","date":"2023-01-24T10:28:55","subject":"Re: [libcamera-devel] [PATCH] .gitignore: Add vim editor's swap\n\tfiles","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Umang,\n\nThank you for the patch.\n\nOn Tue, Jan 24, 2023 at 02:13:01PM +0530, Umang Jain via libcamera-devel wrote:\n> Add *.swp files to .gitignore to prevent committing them accidently\n> to the tree.\n\nQuoting `man gitignore`,\n\n Patterns which a user wants Git to ignore in all situations (e.g.,\n backup or temporary files generated by the user’s editor of choice)\n generally go into a file specified by core.excludesFile in the user’s\n ~/.gitconfig. Its default value is $XDG_CONFIG_HOME/git/ignore. If\n $XDG_CONFIG_HOME is either not set or empty, $HOME/.config/git/ignore\n is used instead.\n\nI think it would make sense to handle your use case through that. While\nI also use vim, I'd rather not open the door to dozens of\neditor-specific ignore patterns in the libcamera .gitignore :-)\n\n> Signed-off-by: Umang Jain \n> ---\n> .gitignore | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/.gitignore b/.gitignore\n> index f6d1d68e..809f9e45 100644\n> --- a/.gitignore\n> +++ b/.gitignore\n> @@ -5,4 +5,5 @@\n> \n> *.patch\n> *.pyc\n> +*.swp\n> __pycache__/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CF422BEFBE\n\tfor ;\n\tTue, 24 Jan 2023 10:29:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 18BED625E4;\n\tTue, 24 Jan 2023 11:29:01 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EBD6361EFB\n\tfor ;\n\tTue, 24 Jan 2023 11:28:59 +0100 (CET)","from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi\n\t[213.243.189.158])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 47DD68A9;\n\tTue, 24 Jan 2023 11:28:59 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1674556141;\n\tbh=QWS7+Gpe/YCtt/mI+HI841GGhaxSsohi4PPbff8zdIE=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=xUq8LA1tLy4DhslGfW1iyO19Q2NlASMotNomJvfgLio5nQuq6RdHOLbxVqW0Kuh+j\n\tjCqjgfsV2IwoL03bohFbiUmJjVC86kx1j26RN8BS6x2Q4SgZ1TwfHKnLBD0d4yI1qK\n\tTnk2nC+KivCG6SMB+CGGhpc0QdrcUd7XTZ0qSI6EGgoc+p1KtSadS8H37iVgrkOSjv\n\tLpFdfRXkyS+FFoY3lZQG6HxYVE4dZ3Kq6qBo7ZsUllPTrge1B1QvhIVJDBzeGkJ+es\n\te6CD4gdHApJr3zn96Bk0H8fp0Q1PgAjjFig3SvUYSzYNJVgPp8rEONHeQQ3gNBwo6H\n\tOSbbq2W9eZBIQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1674556139;\n\tbh=QWS7+Gpe/YCtt/mI+HI841GGhaxSsohi4PPbff8zdIE=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=FWOpuqyThtxQd8sSb2zYciuIpm1J+DnDDyzOOMvzzxG1h7G0keqK4smpPR4ux9i7k\n\tORG2gEecjX5kuJIwxenQwgFQ2oayqot5Flz7S9LbbbXZhlzuMmqizE1kRzJrlF6/rd\n\t2dD1Az/dLYWMNNAomVovVg1HNxRWXClbrtP4y9/M="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"FWOpuqyT\"; dkim-atps=neutral","Date":"Tue, 24 Jan 2023 12:28:55 +0200","To":"Umang Jain ","Message-ID":"","References":"<20230124084301.33320-1-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20230124084301.33320-1-umang.jain@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] .gitignore: Add vim editor's swap\n\tfiles","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":26338,"web_url":"https://patchwork.libcamera.org/comment/26338/","msgid":"<3ff15aa9-473a-00f9-d37c-67d6c9215844@ideasonboard.com>","date":"2023-01-24T10:53:22","subject":"Re: [libcamera-devel] [PATCH] .gitignore: Add vim editor's swap\n\tfiles","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 1/24/23 3:58 PM, Laurent Pinchart wrote:\n> Hi Umang,\n>\n> Thank you for the patch.\n>\n> On Tue, Jan 24, 2023 at 02:13:01PM +0530, Umang Jain via libcamera-devel wrote:\n>> Add *.swp files to .gitignore to prevent committing them accidently\n>> to the tree.\n> Quoting `man gitignore`,\n>\n> Patterns which a user wants Git to ignore in all situations (e.g.,\n> backup or temporary files generated by the user’s editor of choice)\n> generally go into a file specified by core.excludesFile in the user’s\n> ~/.gitconfig. Its default value is $XDG_CONFIG_HOME/git/ignore. If\n> $XDG_CONFIG_HOME is either not set or empty, $HOME/.config/git/ignore\n> is used instead.\n\nDidn't know this existed, that's great :-)\n>\n> I think it would make sense to handle your use case through that. While\n> I also use vim, I'd rather not open the door to dozens of\n> editor-specific ignore patterns in the libcamera .gitignore :-)\n\nOfcourse, makes sense!\n>\n>> Signed-off-by: Umang Jain \n>> ---\n>> .gitignore | 1 +\n>> 1 file changed, 1 insertion(+)\n>>\n>> diff --git a/.gitignore b/.gitignore\n>> index f6d1d68e..809f9e45 100644\n>> --- a/.gitignore\n>> +++ b/.gitignore\n>> @@ -5,4 +5,5 @@\n>> \n>> *.patch\n>> *.pyc\n>> +*.swp\n>> __pycache__/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E79BCBEFBE\n\tfor ;\n\tTue, 24 Jan 2023 10:53:32 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4F31B625DD;\n\tTue, 24 Jan 2023 11:53:32 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 602F561EFB\n\tfor ;\n\tTue, 24 Jan 2023 11:53:30 +0100 (CET)","from [192.168.1.103] (unknown [103.86.18.176])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D825B8C1;\n\tTue, 24 Jan 2023 11:53:28 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1674557612;\n\tbh=SzO35bITGfopUizwgE0jVpZ4VOPqwbcc+isH5OPK+Ok=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=m7qhw2TiOf78cjrLxY6hsmIWDd2kYCYmOfHVjKpKYGH/tl+FMhioeVX1TxDTGKZJC\n\tUr8S9Jn8iTQxiz0N7mT4HsMB0H9boOwlyf7467oEEKHIhUwVjgDW5lm9nZzo6aPQex\n\tvslGwef+zjUl3EeasfCWyXrygstFh9PFGH9L+fVbgovr2yEXXYILGNm2TkqeROB3En\n\tx/mGBdBcaZn0+I/YnYp+UuUXVHLrq3yrelocdMKbIHpNVCCnqWvCeouEAwSY5dTukU\n\tHpaZLqYpH+nX3XW/aUDm780jMn8kyFw5GpP5pE20BwRsFKn8XmMwPYs6OnXejIy6ri\n\tBf9P5CGgYDsRA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1674557610;\n\tbh=SzO35bITGfopUizwgE0jVpZ4VOPqwbcc+isH5OPK+Ok=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=qN1MdFVxxeDMm0sEd9pqC7Pyo+bUiAW4rHAbOvo3ZliDnIrhmq3TqvN25UvXdNr8U\n\tHMRkarxZKtAXtW+WjZCUyi2Za4SbuYVuHmshwsNvI4IK22K6THj3A6yyEZ14QXUthk\n\ttXAyAhe3sQb9C+qI5JhO21EKeIueltTdLz0IgOu0="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"qN1MdFVx\"; dkim-atps=neutral","Message-ID":"<3ff15aa9-473a-00f9-d37c-67d6c9215844@ideasonboard.com>","Date":"Tue, 24 Jan 2023 16:23:22 +0530","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101\n\tThunderbird/102.6.0","Content-Language":"en-US","To":"Laurent Pinchart ","References":"<20230124084301.33320-1-umang.jain@ideasonboard.com>\n\t","In-Reply-To":"","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH] .gitignore: Add vim editor's swap\n\tfiles","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Umang Jain via libcamera-devel ","Reply-To":"Umang Jain ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]