[{"id":26343,"web_url":"https://patchwork.libcamera.org/comment/26343/","msgid":"<20230124172953.3yz63jfnqpwznfkd@uno.localdomain>","date":"2023-01-24T17:29:53","subject":"Re: [libcamera-devel] [PATCH v2 4/4] ipa: rkisp1: Raise maximum\n\tanalogue gain","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Mikhail\n\nOn Mon, Jan 23, 2023 at 05:06:19PM +0300, Mikhail Rudenko wrote:\n> Omnivision OV4689 sensor driver exposes maximum analogue gain of\n> 16x. Raise kMaxAnalogueGain to 16.0, so that the full gain range can\n> be used.\n>\n\nI understand I mostly rised concerns without giving better\nalternatives, so I guess it's fine for now.\n\nMaybe I'll add a \\todo to rework this part\n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> Signed-off-by: Mikhail Rudenko \n> ---\n> src/ipa/rkisp1/algorithms/agc.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/src/ipa/rkisp1/algorithms/agc.cpp b/src/ipa/rkisp1/algorithms/agc.cpp\n> index e3470e25..e4cb2fc7 100644\n> --- a/src/ipa/rkisp1/algorithms/agc.cpp\n> +++ b/src/ipa/rkisp1/algorithms/agc.cpp\n> @@ -38,7 +38,7 @@ LOG_DEFINE_CATEGORY(RkISP1Agc)\n>\n> /* Limits for analogue gain values */\n> static constexpr double kMinAnalogueGain = 1.0;\n> -static constexpr double kMaxAnalogueGain = 8.0;\n> +static constexpr double kMaxAnalogueGain = 16.0;\n>\n> /* \\todo Honour the FrameDurationLimits control instead of hardcoding a limit */\n> static constexpr utils::Duration kMaxShutterSpeed = 60ms;\n> --\n> 2.39.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 97BE0BDB1D\n\tfor ;\n\tTue, 24 Jan 2023 17:30:00 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 55ECE6045E;\n\tTue, 24 Jan 2023 18:30:00 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EDDB6603D8\n\tfor ;\n\tTue, 24 Jan 2023 18:29:58 +0100 (CET)","from ideasonboard.com (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 930FB8A9;\n\tTue, 24 Jan 2023 18:29:58 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1674581400;\n\tbh=LthF5vdXeBb0zSWHRt2LOP12V+5PYGuT2axxP+IAEbo=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=WQ6R0KnctC7eonrsDPj9y7zs9vnY8ntYpnitb8TIc5zVkAzPeGnpQZHvRFgzkFBjU\n\tcwww+kp4Y5YskY2Z8zN1LCK7PnGivrQmR9PMkPOE2dBAD0pEDCNGaBUUUoRqcZq0zi\n\tVokMiZ3WXMnCCd5Haj8DATtwHvsjFt9kRzAVg9xVyqpY3dp8xzCIEJjB5Nmb5i63cM\n\toLN2IrLbeN5b2fwa/y0wpCG5nmyhTMcPaWYukpGhP3DozJibNF16gKQJE62vKQq6EM\n\tXtX/lS/cipLc9KzjHaJlEHGTdhpeFFJPplmn8E5bJXBDpf+vYo6fHnYxz97Pd6U41d\n\tcdOa5cFGYEl7w==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1674581398;\n\tbh=LthF5vdXeBb0zSWHRt2LOP12V+5PYGuT2axxP+IAEbo=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Uswu6/bl9UFJQg4Idh8DUVSO5VeuybPf1OUeVrgffr15ytBm19kWCfGt2dVTcvukB\n\tKqjCi5+L9g6/bg5xuYLiBFEsPSuTt7gvUFyJuavebh+hfRzyxbXWY1Ra2rccdC/RzH\n\tS46x4bNL5JHFIh2F7exh6c95xpupK1v5QcXLxOkc="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"Uswu6/bl\"; dkim-atps=neutral","Date":"Tue, 24 Jan 2023 18:29:53 +0100","To":"Mikhail Rudenko ","Message-ID":"<20230124172953.3yz63jfnqpwznfkd@uno.localdomain>","References":"<20230123140619.177878-1-mike.rudenko@gmail.com>\n\t<20230123140619.177878-5-mike.rudenko@gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20230123140619.177878-5-mike.rudenko@gmail.com>","Subject":"Re: [libcamera-devel] [PATCH v2 4/4] ipa: rkisp1: Raise maximum\n\tanalogue gain","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]